I'm somehow even more inclined to propose to base this feature on a new custom parser, like cowsay {{{ asd }}}

T15802: Regression: HTML entities rendered as plain text in config option descriptions

I've used git bisect and this regression was introuced after 4d12d014fd9ddc423ecbc6a61a92217d5aff19a4

I would probably put this check after the New username is required. and also after the username validation, but that is still OK

If you followed the test plan and if this works, thanks

Example: an organization can have 100+ hosted repositories, both Subversion and git, and the highly-trusted-staff can be allowed to push directly in these hosted repositories, for example because they just rely on heavy post-commit review with Audit. And, they can rely on Differential just to share stubs. The pre-commit review with Differential has little to do with Diffusion here.

I visually mark this as "some discussion needed" in T15780

Premising that I quite understand the difference between Differential and Diffusion, I don't get why Differential should impact Diffusion here.

I cannot reproduce the above arc unit issues, locally.

• add hardening suggested by dear avivey
• add unit test for the new low-level function and its crash

Minor clarification.

Maybe better to expand the test plan to check user creation as well

Ah, probably after WMF disabled some applications, some crawlers started crashing these. Understood.

@avivey: still red flag?

How have you discovered this problem?

Probably we need some help to understand the semantic difference between these two:

I'm on latest master, and I'm still not able to try this 🤔 No errors. Just plaintext remarkup. Test case:

I see "Unknown object" if the Diff repository is unset. Is that known?

Tested before and after, I love this! Thanks!

• Run arc liberate from my clean working copy that has not ManiphestDefaultPriorityEditCapability (?)
• Minor fix indentation of a comment in PhabricatorDashboardQueryPanelType.php:81

Can reproduce. Tested. Thanks :)

You are now in the family of Trusted Contributors :) Patch welcome.

(From Task description)

In diffusion repositories, Description and tags are hard to find or never shown (only show in Manage page).

In T15526#16806, @aklapper wrote:

Which exact page(s) is this ticket about?

Probably something here should be expanded to check if the form contains at least a visible input without read-only

You are now in the family of Trusted Contributors 🎇

Thanks again avivey. I liked the idea of using applyExternalEffects(). I have not found a way to do it efficiently, without introducing another static method.

(Credit to bekay indeed)

Nice :) Thanks

Bonus point: maybe instead of "#123" we can use "#L123" since both GitLab and GitHub use that (and that's not a stupid specification). Just because we can.

If we find 10 minutes, let's test this on every provider, as last time it gave us a little surprise on one of them

Thanks! It worked now! As mentioned in the chat, I'm quite sure that point n.3 and n.4 should be swapped in the README

Premising I've already seen this syntax in Java but not in PHP, I'm happy that now your IDE says something useful. Maybe a better title is "Improve PHPDoc of id()".

I think the purpose is to tell the IDE that the function receives a type and returns that exact type.

(Stupid question :D sorry - clear now)

In D25080#16549, @aklapper wrote:

I still think that the two Subscriber Rule value should be a list strings should for consistency be Add subscriber rule value should be a list respectively Remove subscriber rule value should be a list.

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

fix red color for removal (like in PhabricatorProjectTriggerRemoveProjectsRule)

follow code review - thanks

Ouch I see that receiving the engine was very complicated.

A weird but... expandable, fast, easy possibility is introducing this syntax:

Thanks. Tested this in a correct situation and also causing a crash putting an unset($nodes[$current_node]) in ../arcanist/src/utils/AbstractDirectedGraph.php to see the nice exception message

...or Pharkdown :D

I do not understand why it does not work to me.

Go MoreMimeMailParserPeouw

Ah, also adding a smalll meta "noindex" HTML tag on legacy file.php$123 pages and similar ones, would maybe help a little bit.

Agree with last comment

add minor comment - ready again - tested

introduce a nice applyExternalEffect() to change external things (the orginal file)