Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:41.
Tags
None
Referenced Files
F3319316: D25584.1743304350.diff
Sat, Mar 29, 03:12
F3310778: D25584.1743197530.diff
Thu, Mar 27, 21:32
F3304690: D25584.1743103310.diff
Wed, Mar 26, 19:21
F3298441: D25584.1743001999.diff
Tue, Mar 25, 15:13
F3289637: D25584.1742850293.diff
Sun, Mar 23, 21:04
F3284398: D25584.1742774440.diff
Sun, Mar 23, 00:00
F3252020: D25584.1742387276.diff
Tue, Mar 18, 12:27
F3249439: D25584.1742286117.diff
Mon, Mar 17, 08:21

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This patch also fixes two similar strlen() occurrences in the same source file.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conduit/management/PhabricatorConduitCallManagementWorkflow.php:44]
Test Plan

Run ../phorge/bin/conduit call: Get no strlen() error anymore but only expected output Usage Exception: Specify a method to call with "--method".

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable