Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:57.
Tags
None
Referenced Files
F2970343: D25589.1739527397.diff
Thu, Feb 13, 10:03
F2962033: D25589.1739170884.diff
Sun, Feb 9, 07:01
F2944594: D25589.1738273118.diff
Wed, Jan 29, 21:38
F2938381: D25589.1737994390.diff
Sun, Jan 26, 16:13
F2937023: D25589.1737945277.diff
Sun, Jan 26, 02:34
F2936364: D25589.1737915932.diff
Sat, Jan 25, 18:25
F2936363: D25589.1737915928.diff
Sat, Jan 25, 18:25
F2904824: D25589.1737334398.diff
Jan 19 2025, 00:53

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/search/management/PhabricatorSearchManagementQueryWorkflow.php:24]
Test Plan

Run ../phorge/bin/search query: Get no strlen() error anymore but only expected output Usage Exception: Specify a query with --query.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable