Paths

Table of Contentst

Differential D25589

Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter
ClosedPublic
Actions

Authored by aklapper on Tue, Apr 16, 08:57.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 28, 02:00

	Unknown Object (File)
	Sat, Apr 27, 19:53

	Unknown Object (File)
	Sat, Apr 27, 10:13

	Unknown Object (File)
	Sat, Apr 27, 07:36

	Unknown Object (File)
	Fri, Apr 26, 20:12

	Unknown Object (File)
	Thu, Apr 25, 04:46

	Unknown Object (File)
	Thu, Apr 25, 00:09

	Unknown Object (File)
	Tue, Apr 23, 11:00

View All 18 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPb29e5aa7ca22: Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/search/management/PhabricatorSearchManagementQueryWorkflow.php:24]

Test Plan

Run ../phorge/bin/search query: Get no strlen() error anymore but only expected output Usage Exception: Specify a query with --query.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Tue, Apr 16, 08:57

Owners added a reviewer: O1: Blessed Committers.Tue, Apr 16, 08:57

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Apr 16, 08:57

aklapper requested review of this revision.Tue, Apr 16, 08:57

Harbormaster completed remote builds in B1181: Diff 1861.Tue, Apr 16, 08:57

yesyes

This revision is now accepted and ready to land.Tue, Apr 16, 09:25

Closed by commit rPb29e5aa7ca22: Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter. · Explain WhyTue, Apr 16, 22:40

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPb29e5aa7ca22: Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

search/

management/

PhabricatorSearchManagementQueryWorkflow.php

2 lines

O1: Blessed Committers

Diff 1871

src/applications/search/management/PhabricatorSearchManagementQueryWorkflow.php

Loading...