Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:57.
Tags
None
Referenced Files
F3850640: D25589.1746115665.diff
Wed, Apr 30, 16:07
F3835418: D25589.1746085925.diff
Wed, Apr 30, 07:52
F3835417: D25589.1746085924.diff
Wed, Apr 30, 07:52
F3835416: D25589.1746085923.diff
Wed, Apr 30, 07:52
F3763017: D25589.1745838600.diff
Sun, Apr 27, 11:10
F3749096: D25589.1745790616.diff
Sat, Apr 26, 21:50
F3749095: D25589.1745790615.diff
Sat, Apr 26, 21:50
F3749094: D25589.1745790613.diff
Sat, Apr 26, 21:50

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/search/management/PhabricatorSearchManagementQueryWorkflow.php:24]
Test Plan

Run ../phorge/bin/search query: Get no strlen() error anymore but only expected output Usage Exception: Specify a query with --query.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable