Paths

Table of Contentst

Differential D25580

Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter
ClosedPublic
Actions

Authored by aklapper on Tue, Apr 16, 08:23.

Tags

None

Referenced Files

	F2170285: D25580.id.diff
	Tue, Apr 30, 01:41

	F2170178: D25580.id1867.diff
	Mon, Apr 29, 22:43

	Unknown Object (File)
	Mon, Apr 29, 01:35

	Unknown Object (File)
	Sun, Apr 28, 23:45

	Unknown Object (File)
	Sat, Apr 27, 13:55

	Unknown Object (File)
	Thu, Apr 25, 16:22

	Unknown Object (File)
	Tue, Apr 23, 00:00

	Unknown Object (File)
	Mon, Apr 22, 23:59

View All 16 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP6a2f2a589a0f: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/nuance/management/NuanceManagementWorkflow.php:8]

Test Plan

Run ../phorge/bin/nuance import: Get no strlen() error anymore but only expected output Usage Exception: Specify a source with --source.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Tue, Apr 16, 08:23

Owners added a reviewer: O1: Blessed Committers.Tue, Apr 16, 08:23

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Apr 16, 08:23

aklapper requested review of this revision.Tue, Apr 16, 08:23

Harbormaster completed remote builds in B1172: Diff 1852.Tue, Apr 16, 08:23

yesyes

This revision is now accepted and ready to land.Tue, Apr 16, 13:05

Closed by commit rP6a2f2a589a0f: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter. · Explain WhyTue, Apr 16, 22:35

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP6a2f2a589a0f: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

nuance/

management/

NuanceManagementWorkflow.php

2 lines

O1: Blessed Committers

Diff 1867

src/applications/nuance/management/NuanceManagementWorkflow.php

Loading...