Page MenuHomePhorge

Trusted ContributorsGroup
ActivePublic

Details

Description

This project is a self-organizing group. If you trust someone to not completely break this Phorge install, add them here.
Membership grants:

  • Access to create tasks.
  • Access to create projects.
  • Write access to wiki documents.
  • Access to bulk edit Maniphest tasks.
  • Write access to projects (apart ACLs and Security)
  • Write access to most tasks.

Recent Activity

Sat, Jan 7

Cigaryno edited Description on Trusted Contributors.
Sat, Jan 7, 08:37
Cigaryno edited Description on Trusted Contributors.
Sat, Jan 7, 08:34

Mon, Jan 2

Matthew added members for Trusted Contributors: dbcrwk, shimms.
Mon, Jan 2, 18:05

Nov 28 2022

Dylsss added a member for Trusted Contributors: valerio.bozzolan.
Nov 28 2022, 15:24

Nov 12 2022

Cigaryno edited Description on Trusted Contributors.
Nov 12 2022, 07:57

Nov 8 2022

Matthew added a member for Trusted Contributors: Higgs.
Nov 8 2022, 18:24

Oct 28 2022

avivey added a member for Trusted Contributors: cristian64.
Oct 28 2022, 07:49

Oct 13 2022

Cigaryno added a member for Trusted Contributors: Dylsss.
Oct 13 2022, 16:03

Sep 24 2022

0 added a member for Trusted Contributors: k__nard.
Sep 24 2022, 18:13

Sep 16 2022

Cigaryno added a member for Trusted Contributors: 20after4.
Sep 16 2022, 18:30
Matthew added a member for Trusted Contributors: Cigaryno.
Sep 16 2022, 18:00

Sep 7 2022

20after4 removed a member for Trusted Contributors: 20after4.
Sep 7 2022, 16:48

Aug 31 2022

avivey closed T15094: Catch up the master branch to upstream as Resolved.

I've cowboy-merged this last week. Not sure why all these commits decided they are part of this task though?

Aug 31 2022, 19:39 · Trusted Contributors, Phorge

Aug 30 2022

Cigaryno added a watcher for Trusted Contributors: Cigaryno.
Aug 30 2022, 17:54

Aug 26 2022

luca.itro added a member for Trusted Contributors: roberto.urbani.
Aug 26 2022, 08:49

May 28 2022

golyalpha added a comment to T15094: Catch up the master branch to upstream.

To be fair, I wouldn't discount already needing access as a viable attack vector, even on private installations.

May 28 2022, 06:38 · Trusted Contributors, Phorge
dcog added a comment to T15094: Catch up the master branch to upstream.

It sounds specific to people who already have access, thank you -- do very much need to pull in latest

May 28 2022, 06:32 · Trusted Contributors, Phorge
golyalpha added a comment to T15094: Catch up the master branch to upstream.

The disclosed issue is that someone can gain access to Files objects they don't have access to by, for example, getting someone with permissions to edit a task they wrote (by including a reference to that file which gets "activated" when the person with permissions to view it saves the edit), which makes the file accessible via the task description.

May 28 2022, 06:19 · Trusted Contributors, Phorge
dcog added a comment to T15094: Catch up the master branch to upstream.

Thanks -- Offhand do you know if this is related to login in that a malicious actor can gain access to source code when unpatched?

May 28 2022, 06:11 · Trusted Contributors, Phorge
golyalpha added a comment to T15094: Catch up the master branch to upstream.

Upstream-T13683

IMPORTANT: This release mitigates a severe security issue which allows attackers with few permission to gain access to files they can not otherwise see. All installs are strongly advised to upgrade.
May 28 2022, 05:10 · Trusted Contributors, Phorge
roguelazer added a comment to T15094: Catch up the master branch to upstream.

FYI today's release (2022 week 21 stable) has a some pretty serious security content

May 28 2022, 00:12 · Trusted Contributors, Phorge

May 21 2022

speck added a comment to T15094: Catch up the master branch to upstream.

@dcog I think the differences with the Harbormaster changes are due to the different approach taken. We planned to do the approach which you took in D25036 which re-played the Phorge diffs on top of phabricator, however in D25040 I just did a merge of the phab/master branch into phorge/master where the Harbormaster changes already existed. Since upstream didn't modify the same Harbormaster files there were no conflicts and things merged appropriately. I did a sanity check of files changed on D25005 with the files changed on D25040.

May 21 2022, 17:06 · Trusted Contributors, Phorge
speck added a comment to T15094: Catch up the master branch to upstream.

Do we even have servers to run the tests on?

May 21 2022, 16:56 · Trusted Contributors, Phorge
speck added a revision to T15094: Catch up the master branch to upstream: D25039: merge phab/master -> phorge/master.
May 21 2022, 16:43 · Trusted Contributors, Phorge
speck added a revision to T15094: Catch up the master branch to upstream: D25040: merge phab/master -> phorge/master.
May 21 2022, 16:43 · Trusted Contributors, Phorge
golyalpha added a comment to T15094: Catch up the master branch to upstream.
In T15094#2292, @speck wrote:

I did not think we had Harbormaster set up to run unit tests - I think that involves configuring both Harbormaster and Drydock, and possibly Almanac which I don't think anyone has done.

I'll go back and review those Harbormaster file changes. Thanks for pointing that out!

May 21 2022, 16:40 · Trusted Contributors, Phorge
golyalpha added a comment to T15094: Catch up the master branch to upstream.
In T15094#2281, @dcog wrote:

This would be a legitimately good exercise to try and do "properly"... although, the thought of not doing it optimally can be a bit of a barrier to starting..

Given the edge cases outlined in T15094#2279, would there be cases in step 2 (or 1?) from T15094#2259 that might benefit from Git cherry-picking? @golyalpha, any thoughts on that? I nearly never have to use cherry-picking, or maybe I should, but either way I'm not very familiar with it other than I'm wondering if it may be relevant

After some reading I'm finding that, as far as I can tell, it's not designed to pick/integrate *specific lines* from a diff, but rather a specific whole commit (from any local or remote branch most likely).. if I'm understanding it correctly

But, perhaps, it could still have the same effect as removing lines from one, and keeping lines from the other when grabbing specific whole commits

The more I think about this the more I'm confusing myself, but hopefully some fraction of this makes sense

May 21 2022, 16:37 · Trusted Contributors, Phorge
speck added a comment to T15094: Catch up the master branch to upstream.

I did not think we had Harbormaster set up to run unit tests - I think that involves configuring both Harbormaster and Drydock, and possibly Almanac which I don't think anyone has done.

May 21 2022, 16:24 · Trusted Contributors, Phorge
dcog added a comment to T15094: Catch up the master branch to upstream.

I would think that your method produced the results we want... though I was noticing this:

May 21 2022, 15:34 · Trusted Contributors, Phorge
dcog added a comment to T15094: Catch up the master branch to upstream.

I see it looks Harbormaster itself does the testing?

May 21 2022, 15:21 · Trusted Contributors, Phorge
dcog added a comment to T15094: Catch up the master branch to upstream.

My vote is that if tests pass we go ahead and do the thing.... More changes in upstream seems fine, and moving forward if we keep up it should get easier and easier hopefully

May 21 2022, 15:18 · Trusted Contributors, Phorge
dcog added a comment to T15094: Catch up the master branch to upstream.

Oh nice!!

May 21 2022, 15:17 · Trusted Contributors, Phorge
dcog added a comment to T15094: Catch up the master branch to upstream.
May 21 2022, 15:15 · Trusted Contributors, Phorge
speck added a comment to T15094: Catch up the master branch to upstream.

Though it does appear additional work has been landing upstream today

May 21 2022, 00:52 · Trusted Contributors, Phorge
speck added a comment to T15094: Catch up the master branch to upstream.

Any concerns about landing those changes? Once I land I'll see about updating this instance which should make accessing the repositories possible again.

May 21 2022, 00:45 · Trusted Contributors, Phorge

May 20 2022

speck added a comment to T15094: Catch up the master branch to upstream.

Merged the arcanist repository in D25039

May 20 2022, 03:06 · Trusted Contributors, Phorge

May 17 2022

dcog added a comment to T15094: Catch up the master branch to upstream.

This would be a legitimately good exercise to try and do "properly"... although, the thought of not doing it optimally can be a bit of a barrier to starting..

May 17 2022, 19:51 · Trusted Contributors, Phorge
dcog added a comment to T15094: Catch up the master branch to upstream.

Here is one thing I noticed... In at least a couple of the files, there may be changes that:

May 17 2022, 19:21 · Trusted Contributors, Phorge

May 12 2022

golyalpha added a comment to T15094: Catch up the master branch to upstream.

If we merge, a force-push should not be required - unless you mean something other than standard git merge here. (Force-push is required when rewriting already pushed history - git merge simply adds a new commit that applies the changes on top of the branch)

May 12 2022, 06:19 · Trusted Contributors, Phorge

May 3 2022

speck added a comment to T15094: Catch up the master branch to upstream.

It looks like upstream has issued a number of updates which we'll want to pull in. From {E4} we discussed doing the following:

May 3 2022, 19:20 · Trusted Contributors, Phorge

Apr 20 2022

dcog added a comment to T15094: Catch up the master branch to upstream.

Created {D25036}

Apr 20 2022, 02:04 · Trusted Contributors, Phorge
dcog created T15094: Catch up the master branch to upstream.
Apr 20 2022, 01:41 · Trusted Contributors, Phorge

Apr 19 2022

Matthew added a member for Trusted Contributors: luca.itro.
Apr 19 2022, 21:03
Matthew added a member for Trusted Contributors: dtf.
Apr 19 2022, 20:57

Apr 5 2022

avivey changed the join policy for Trusted Contributors.
Apr 5 2022, 19:45

Mar 16 2022

Matthew added a member for Trusted Contributors: golyalpha.
Mar 16 2022, 21:33

Feb 25 2022

MacFan4000 added a member for Trusted Contributors: bd808.
Feb 25 2022, 19:22

Feb 7 2022

MacFan4000 added members for Trusted Contributors: Nikerabbit, brennen.
Feb 7 2022, 00:40

Sep 22 2021

speck added a member for Trusted Contributors: MikeCripps.
Sep 22 2021, 00:50

Sep 4 2021

MacFan4000 changed the visibility for Trusted Contributors.
Sep 4 2021, 21:21