Page MenuHomePhorge
Feed All Stories

Today

valerio.bozzolan added a comment to D25578: Fix PHP 8.1 "strlen(null)" exceptions adding an OAuth provider.

If we find 10 minutes, let's test this on every provider, as last time it gave us a little surprise on one of them

Wed, Apr 17, 06:59
valerio.bozzolan accepted D25595: Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as parameter.

yesyes

Wed, Apr 17, 06:57
valerio.bozzolan accepted D25594: Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter.

yesyes

Wed, Apr 17, 06:57

Yesterday

aklapper requested review of D25595: Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as parameter.
Tue, Apr 16, 23:05
aklapper requested review of D25594: Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter.
Tue, Apr 16, 22:58
aklapper closed D25585: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter.
Tue, Apr 16, 22:41
aklapper committed rPc59a883e9de7: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter
Tue, Apr 16, 22:41
aklapper closed D25589: Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter.
Tue, Apr 16, 22:40
aklapper committed rPb29e5aa7ca22: Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter
Tue, Apr 16, 22:40
aklapper closed D25583: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter.
Tue, Apr 16, 22:38
aklapper committed rP102c43fb6a87: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter
Tue, Apr 16, 22:38
aklapper closed D25582: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter.
Tue, Apr 16, 22:37
aklapper committed rP2c7be156a8c3: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter
Tue, Apr 16, 22:37
aklapper closed D25581: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter.
Tue, Apr 16, 22:35
aklapper committed rP9101c0b63df4: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter
Tue, Apr 16, 22:35
aklapper closed D25580: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter.
Tue, Apr 16, 22:35
aklapper committed rP6a2f2a589a0f: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter
Tue, Apr 16, 22:35
aklapper closed D25579: Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without parameter.
Tue, Apr 16, 22:29
aklapper committed rP05798a630120: Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without….
Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without…
Tue, Apr 16, 22:29
bekay accepted D25593: README: run upgrade after installation.

You are right of course!

Tue, Apr 16, 20:47
bekay added a comment to T15787: Diagrams: avoid double slash in the URL after Saving.

Yeah, there are some malformed URLs we should tackle for sure.

Tue, Apr 16, 20:45 · Diagrams (Extension)
valerio.bozzolan triaged T15787: Diagrams: avoid double slash in the URL after Saving as Low priority.
Tue, Apr 16, 20:21 · Diagrams (Extension)
valerio.bozzolan added a revision to T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType"): D25593: README: run upgrade after installation.
Tue, Apr 16, 20:19 · Diagrams (Extension)
valerio.bozzolan retitled D25593: README: run upgrade after installation from README: run upgrade after installation Ref T15745
Tue, Apr 16, 20:19
valerio.bozzolan added a reviewer for D25593: README: run upgrade after installation: bekay.
Tue, Apr 16, 20:19
valerio.bozzolan added a comment to T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType").

Thanks! It worked now! As mentioned in the chat, I'm quite sure that point n.3 and n.4 should be swapped in the README

Tue, Apr 16, 20:19 · Diagrams (Extension)
valerio.bozzolan requested review of D25593: README: run upgrade after installation.
Tue, Apr 16, 20:19
bekay added a comment to Q108: Phorge and Mermaid Js (Answer 139).

I have edited the answer. Because with draw.io you can integrate Mermaid out of the box. With R5 you can start using the syntax like instantly.

Tue, Apr 16, 18:30
bekay updated the answer details for Q108: Phorge and Mermaid Js (Answer 139).
Tue, Apr 16, 18:28
valerio.bozzolan accepted D25581: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter.

yesyes

Tue, Apr 16, 16:55
valerio.bozzolan accepted D25582: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter.

yesyes

Tue, Apr 16, 16:55
valerio.bozzolan accepted D25584: Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter.

yesyes

Tue, Apr 16, 16:55
valerio.bozzolan accepted D25585: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter.

yesyes

Tue, Apr 16, 16:54
valerio.bozzolan accepted D25579: Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without parameter.

yesyes

Tue, Apr 16, 13:05
valerio.bozzolan accepted D25580: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter.

yesyes

Tue, Apr 16, 13:05
valerio.bozzolan accepted D25583: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter.

yesyes

Tue, Apr 16, 13:02
aklapper added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

Maybe put the warning above the box, so it catches all actions, not just comments?

Tue, Apr 16, 10:44 · Feature Requests
aklapper merged T15785: Showolder page: "Undefined index: " into T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php.
Tue, Apr 16, 09:28
aklapper merged task T15785: Showolder page: "Undefined index: " into T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php.
Tue, Apr 16, 09:28 · phorge.it install, Phorge
aklapper updated the task description for T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php.
Tue, Apr 16, 09:27
valerio.bozzolan accepted D25586: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter.

yesyes

Tue, Apr 16, 09:27
aklapper reopened T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php as "Open".

Seems to happen in upstream per duplicate, thus reopening

Tue, Apr 16, 09:26
valerio.bozzolan accepted D25587: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth cache-pkcs8" without parameter.

yesyes

Tue, Apr 16, 09:26
valerio.bozzolan accepted D25588: Fix PHP 8.1 "strlen(null)" exception for "/bin/bulk export --query --format" without parameter.

yesyes

Tue, Apr 16, 09:26
valerio.bozzolan accepted D25589: Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter.

yesyes

Tue, Apr 16, 09:25
valerio.bozzolan accepted D25590: Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter.

yesyes

Tue, Apr 16, 09:24
valerio.bozzolan accepted D25591: Fix PHP 8.1 "strlen(null)" exception for "/bin/almanac register" without parameter.

sgtm

Tue, Apr 16, 09:23
valerio.bozzolan accepted D25592: Fix PHP 8.1 "strlen(null)" exception for "/bin/storage renamespace" without parameter.

lgtm

Tue, Apr 16, 09:22
zhe added a comment to Q123: [Feature] Phorge integrates with Keycloak.

:p

Tue, Apr 16, 09:11 · Phorge, Feature Requests
revi added a comment to Q123: [Feature] Phorge integrates with Keycloak.

I was responding to the previous comment which...

Tue, Apr 16, 09:09 · Phorge, Feature Requests
zhe added a comment to Q123: [Feature] Phorge integrates with Keycloak.

Our company uses the Phorge, and we use Keycloak as IAM. Keycloak is a very popular OAuth2/SAML provider now.

Tue, Apr 16, 09:06 · Phorge, Feature Requests
aklapper requested review of D25592: Fix PHP 8.1 "strlen(null)" exception for "/bin/storage renamespace" without parameter.
Tue, Apr 16, 09:05
aklapper requested review of D25591: Fix PHP 8.1 "strlen(null)" exception for "/bin/almanac register" without parameter.
Tue, Apr 16, 09:03
aklapper requested review of D25590: Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter.
Tue, Apr 16, 08:59
aklapper requested review of D25589: Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter.
Tue, Apr 16, 08:57
aklapper requested review of D25588: Fix PHP 8.1 "strlen(null)" exception for "/bin/bulk export --query --format" without parameter.
Tue, Apr 16, 08:55
aklapper requested review of D25587: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth cache-pkcs8" without parameter.
Tue, Apr 16, 08:50
aklapper requested review of D25586: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter.
Tue, Apr 16, 08:48
aklapper requested review of D25585: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter.
Tue, Apr 16, 08:45
aklapper requested review of D25584: Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter.
Tue, Apr 16, 08:41
aklapper requested review of D25583: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter.
Tue, Apr 16, 08:36
aklapper updated the test plan for D25582: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter.
Tue, Apr 16, 08:31
aklapper requested review of D25582: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter.
Tue, Apr 16, 08:29
aklapper requested review of D25581: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter.
Tue, Apr 16, 08:25
aklapper requested review of D25580: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter.
Tue, Apr 16, 08:23
aklapper requested review of D25579: Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without parameter.
Tue, Apr 16, 08:15
bekay added a comment to T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType").

@valerio.bozzolan Could you try again to install it? There is a readme with new instructions.

Tue, Apr 16, 07:16 · Diagrams (Extension)
bekay closed T15782: Diagrams Extension is not installable/usable in its current form as Resolved by committing R5:6fa25e4097aa: Makes extension usable with configured alternative file domain.
Tue, Apr 16, 07:14 · Diagrams (Extension)
bekay closed D25577: Makes extension usable with configured alternative file domain.
Tue, Apr 16, 07:14 · Diagrams (Extension)
bekay committed R5:6fa25e4097aa: Makes extension usable with configured alternative file domain.
Makes extension usable with configured alternative file domain
Tue, Apr 16, 07:14
bekay added a revision to T15782: Diagrams Extension is not installable/usable in its current form: D25577: Makes extension usable with configured alternative file domain.
Tue, Apr 16, 07:11 · Diagrams (Extension)
bekay updated the summary of D25577: Makes extension usable with configured alternative file domain.
Tue, Apr 16, 07:11 · Diagrams (Extension)
avivey retitled D25577: Makes extension usable with configured alternative file domain from [WIP] Makes extension usable with configured alternative file domain
Tue, Apr 16, 06:28 · Diagrams (Extension)

Mon, Apr 15

mturdus accepted D25577: Makes extension usable with configured alternative file domain.
Mon, Apr 15, 20:41 · Diagrams (Extension)
bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

Now it's working!

Mon, Apr 15, 19:13 · Diagrams (Extension)
revi awarded rPd519f75dfdee: (stable) Fix config transaction rendering error on auth page by allowing… a Love token.
Mon, Apr 15, 17:42
mturdus added a comment to D25577: Makes extension usable with configured alternative file domain.

Now it's working!

Mon, Apr 15, 16:58 · Diagrams (Extension)
avivey added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

done...

Mon, Apr 15, 16:36 · Auth, Bug Reports
avivey committed rPd519f75dfdee: (stable) Fix config transaction rendering error on auth page by allowing… (authored by doommius).
(stable) Fix config transaction rendering error on auth page by allowing…
Mon, Apr 15, 16:36
aklapper updated the test plan for D25578: Fix PHP 8.1 "strlen(null)" exceptions adding an OAuth provider.
Mon, Apr 15, 15:02
aklapper requested review of D25578: Fix PHP 8.1 "strlen(null)" exceptions adding an OAuth provider.
Mon, Apr 15, 15:00
aklapper added a revision to T15786: PHP 8.1 "strlen(null)" exceptions adding an OAuth provider: D25578: Fix PHP 8.1 "strlen(null)" exceptions adding an OAuth provider.
Mon, Apr 15, 15:00 · PHP 8 support
aklapper created T15786: PHP 8.1 "strlen(null)" exceptions adding an OAuth provider.
Mon, Apr 15, 14:58 · PHP 8 support
aklapper closed D25568: Fix PHP 8.1 "addcslashes(null)" exception exporting task list to tab-separated text.
Mon, Apr 15, 14:42
aklapper closed T15771: PHP 8.1 "addcslashes(null)" exception exporting task list to tab-separated text as Resolved by committing rP79464882da14: Fix PHP 8.1 "addcslashes(null)" exception exporting task list to tab-separated….
Mon, Apr 15, 14:42
aklapper committed rP79464882da14: Fix PHP 8.1 "addcslashes(null)" exception exporting task list to tab-separated….
Fix PHP 8.1 "addcslashes(null)" exception exporting task list to tab-separated…
Mon, Apr 15, 14:42
valerio.bozzolan created T15785: Showolder page: "Undefined index: ".
Mon, Apr 15, 14:42 · phorge.it install, Phorge
tsc closed D25576: Improve PHPDoc of id().
Mon, Apr 15, 14:39
tsc committed rARC6718b32a64f2: Improve PHPDoc of id().
Improve PHPDoc of id()
Mon, Apr 15, 14:39
tsc retitled D25576: Improve PHPDoc of id() from provide proper typings for `id` function
Mon, Apr 15, 14:12
valerio.bozzolan accepted D25576: Improve PHPDoc of id().

Premising I've already seen this syntax in Java but not in PHP, I'm happy that now your IDE says something useful. Maybe a better title is "Improve PHPDoc of id()".

Mon, Apr 15, 13:09
avivey added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

Yeah, probably. I'll try to do it tonight.

Mon, Apr 15, 08:31 · Auth, Bug Reports

Sun, Apr 14

bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

@mturdus right, I don't have the whole picture of the little bit wild codebase 😁 Thanks for the pointer. As far as I can see, this image and the DOMContentLoaded event handler serves no purpose anymore. All is working without. I have renamed the main js and some functions in it for clarity. Would love if you could give it a try.

Sun, Apr 14, 19:00 · Diagrams (Extension)
bekay updated the diff for D25577: Makes extension usable with configured alternative file domain.
  • Renames behavior and some functions and gets rid of unnecessary image proxy
Sun, Apr 14, 18:56 · Diagrams (Extension)
mturdus added a comment to D25577: Makes extension usable with configured alternative file domain.

This is the console log I got when running in Firefox:

Navigated to http://phorge.blackbird.turdus.local/diagram/
diagram-extension behavior called with config: 
Object { loadJsExtensionArgs: (4) […], toolbarCss: "http://phorge.blackbird.turdus.local/res/diagram-resources/35ad6f49/iframe-toolbtn.css", toolbarJs: "http://phorge.blackbird.turdus.local/res/diagram-resources/26d75a35/iframe-toolbtn.js" }
​
loadJsExtensionArgs: Array(4) [ "", "", "", … ]
​​
0: ""
​​
1: ""
​​
2: ""
​​
3: ""
​​
length: 4
​​
<prototype>: Array []
​
toolbarCss: "http://phorge.blackbird.turdus.local/res/diagram-resources/35ad6f49/iframe-toolbtn.css"
​
toolbarJs: "http://phorge.blackbird.turdus.local/res/diagram-resources/26d75a35/iframe-toolbtn.js"
​
<prototype>: Object { … }
phorge_extension.js:8:11
loadJsExtension called with args: <empty string> <empty string> <empty string> <empty string> phorge_extension.js:95:13
Sun, Apr 14, 18:24 · Diagrams (Extension)
revi added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

Can this (I mean rPb445e1d80df9 )be backported into stable?

Sun, Apr 14, 12:24 · Auth, Bug Reports
revi updated revi.
Sun, Apr 14, 11:34
bekay updated the question details for Q126: 5 Deprecation Notices in PhabricatorStandardPageView.php.
Sun, Apr 14, 09:34 · Deprecation Notice
bekay updated Q126: 5 Deprecation Notices in PhabricatorStandardPageView.php from 5 Deprecation Notices PhabricatorStandardPageView to 5 Deprecation Notices in PhabricatorStandardPageView.php.
Sun, Apr 14, 09:03 · Deprecation Notice
bekay closed T15781: arc liberate throws exception as Resolved.

Fixed by R5:91dd43de7dee: T15781: arc liberate throws exception

Sun, Apr 14, 08:59 · Diagrams (Extension)