Page MenuHomePhorge
Feed All Stories

Today

aklapper closed D26007: Remove unused CSS file aphront/panel-view.css.
Sat, May 24, 07:28
aklapper committed rPd784533cf71d: Remove unused CSS file aphront/panel-view.css.
Sat, May 24, 07:28
pppery added a comment to Q177: Should it be easier for non-community-members to submit security reports? (Answer 219).

Agreed.

Sat, May 24, 01:30
pppery added a comment to Q181: "Auth" - Multiple LDAP Servers (Answer 223).

Now you do.

Sat, May 24, 01:29
pppery added a member for Trusted Contributors: jgrammen-agilitypr.
Sat, May 24, 01:29
l2dy created T16083: Replace remaining MyISAM tables with InnoDB.
Sat, May 24, 01:10

Yesterday

aklapper updated the diff for D26007: Remove unused CSS file aphront/panel-view.css.

git rebase master

Fri, May 23, 21:44
aklapper added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

no no I rock like a grapstar

Fri, May 23, 17:32
valerio.bozzolan accepted D26007: Remove unused CSS file aphront/panel-view.css.

You grep like a rockstar

Fri, May 23, 17:29
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

Uh right, thanks! Let's do as mainframe98 says

Fri, May 23, 17:28
valerio.bozzolan removed a reviewer for D26007: Remove unused CSS file aphront/panel-view.css: valerio.bozzolan.
Fri, May 23, 17:26
valerio.bozzolan resigned from D26007: Remove unused CSS file aphront/panel-view.css.

Unlocking patch

Fri, May 23, 17:26
aklapper requested review of D26007: Remove unused CSS file aphront/panel-view.css.
Fri, May 23, 17:21
aklapper added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.

Fri, May 23, 17:21
valerio.bozzolan added a subtask for T15018: Make Harbormaster more generally usable and extendable: T16041: Harbormaster Build Plan: improve input "Depends On".
Fri, May 23, 06:53 · Connor Gurney, Almanac/Drydock/Harbormaster
valerio.bozzolan added a parent task for T16041: Harbormaster Build Plan: improve input "Depends On": T15018: Make Harbormaster more generally usable and extendable.
Fri, May 23, 06:53 · User-valerio.bozzolan, UX, Feature Requests, Almanac/Drydock/Harbormaster
valerio.bozzolan added a project to T16041: Harbormaster Build Plan: improve input "Depends On": User-valerio.bozzolan.
Fri, May 23, 06:53 · User-valerio.bozzolan, UX, Feature Requests, Almanac/Drydock/Harbormaster
aklapper closed D25995: Remove orphan CSS selectors in PHUIFormView.
Fri, May 23, 00:08
aklapper committed rP5e64a0a81903: Remove orphan CSS selectors in PHUIFormView.
Fri, May 23, 00:08

Thu, May 22

aklapper added a comment to D26030: Fix project typeahead query with columns when string is not name prefix.

You're right, thank you (as usual)!

Thu, May 22, 17:13
aklapper updated the test plan for D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 17:13
aklapper updated the diff for D25995: Remove orphan CSS selectors in PHUIFormView.

git rebase master

Thu, May 22, 16:35
aklapper closed D25978: Fix wrong argument count in numerous calls' signatures.
Thu, May 22, 16:28
aklapper committed rPb174cce279aa: Fix wrong argument count in numerous calls' signatures.
Thu, May 22, 16:28
valerio.bozzolan requested changes to D26007: Remove unused CSS file aphront/panel-view.css.

Flagging as "andre is merging stuff https://we.phorge.it/D26007#26996"

Thu, May 22, 12:49
valerio.bozzolan updated the summary of D25995: Remove orphan CSS selectors in PHUIFormView.
Thu, May 22, 12:47
valerio.bozzolan accepted D25995: Remove orphan CSS selectors in PHUIFormView.

Very good job as usual 👍

Thu, May 22, 12:47
valerio.bozzolan accepted D26030: Fix project typeahead query with columns when string is not name prefix.

Nice. I'm 99% sure about the test plan, please see https://we.phorge.it/T16068#22703 before landing to adjust it, eventually.

Thu, May 22, 12:38
valerio.bozzolan added a comment to T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)".

Questions about the steps:

Thu, May 22, 12:24 · Bug Reports
aklapper updated the summary of D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 10:13
aklapper requested review of D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 10:10
aklapper added a revision to T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)": D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 10:10 · Bug Reports
aklapper closed D26006: Remove unused FatCow icon files.
Thu, May 22, 06:53
aklapper committed rP947b70441184: Remove unused FatCow icon files.
Thu, May 22, 06:53

Wed, May 21

jgrammen-agilitypr closed Q180: "Auth" - it is possible to have a provider (LDAP) configured via conf/custom as resolved.
Wed, May 21, 14:51 · Auth
valerio.bozzolan updated the diff for D26026: Add a Before-Destruction Engine.
  • fix last typo
Wed, May 21, 13:39
valerio.bozzolan updated the diff for D26026: Add a Before-Destruction Engine.
  • @return list<PhabricatorDestructionEngineExtension>
Wed, May 21, 13:33
aklapper added inline comments to D26026: Add a Before-Destruction Engine.
Wed, May 21, 12:59
valerio.bozzolan closed T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time), a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Wed, May 21, 09:59 · PHP 8 support
valerio.bozzolan closed D26029: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72.
Wed, May 21, 09:59
valerio.bozzolan closed T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time) as Resolved by committing rPaf4ac8bd9567: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from….
Wed, May 21, 09:59 · Calendar, PHP 8 support
valerio.bozzolan committed rPaf4ac8bd9567: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from….
Wed, May 21, 09:59
valerio.bozzolan added inline comments to D26026: Add a Before-Destruction Engine.
Wed, May 21, 09:51
valerio.bozzolan updated the diff for D26026: Add a Before-Destruction Engine.
  • fix typos
  • add PHPDoc @return
Wed, May 21, 09:50
valerio.bozzolan accepted D26006: Remove unused FatCow icon files.

Thanks! Additionally, it seems it's not possible to use these through {icon NAME} since it only supports font awesome AFAIK

Wed, May 21, 08:49
valerio.bozzolan added a comment to D26024: Make long phui-tag-view object titles wrap in Remarkup context.

Seems very useful thanks, I would like to find small extra time to expand the test plan a bit more and run these extra tests, since this sounds very "core"

Wed, May 21, 07:37

Tue, May 20

aklapper accepted D26029: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72.

Thanks! Confirming; tested, also works as expected with other epoch values.

Tue, May 20, 16:21
mainframe98 accepted D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Tue, May 20, 15:57
valerio.bozzolan updated subscribers of D26026: Add a Before-Destruction Engine.
Tue, May 20, 15:57
mainframe98 added inline comments to D26026: Add a Before-Destruction Engine.
Tue, May 20, 15:51
mainframe98 accepted D26029: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72.
Tue, May 20, 15:50
mainframe98 added inline comments to D26028: Explain consequences when adding second Multi-Factor Auth.
Tue, May 20, 15:47
valerio.bozzolan added a comment to D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.

Is getDisplayIconColor() related to these? (spoiler: probably it's not)

Tue, May 20, 13:45
valerio.bozzolan claimed T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time).

Yet another one strlen(null)...

Tue, May 20, 13:40 · Calendar, PHP 8 support
valerio.bozzolan added a revision to T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time): D26029: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72.
Tue, May 20, 13:39 · Calendar, PHP 8 support
valerio.bozzolan requested review of D26029: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72.
Tue, May 20, 13:39
valerio.bozzolan created T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time).
Tue, May 20, 13:35 · Calendar, PHP 8 support
aklapper added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

I'm too stuck in Serious Business Mode to introduce another string to translate, I'm afraid :-/

Tue, May 20, 13:13
aklapper added a comment to D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.

Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?

Tue, May 20, 13:02
valerio.bozzolan accepted D26028: Explain consequences when adding second Multi-Factor Auth.

Love this. Feel free to evaluate the addition of thus, dramatically increasing your corporate security (at the price of slowing you down even more). as stated here lol https://we.phorge.it/D26028#27452 or whatever small thing could help to better visualize this alien behavior that is very peculiar of Phorge (that is, as already said, not intuitive).

Tue, May 20, 12:48
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

indentation is arrsome

Tue, May 20, 12:44
valerio.bozzolan added a comment to D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.

Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?

Tue, May 20, 12:43
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

oh true

Tue, May 20, 12:42
valerio.bozzolan awarded D26000: Remove orphan CSS selectors in calendar/phui-calendar.css a Yellow Medal token.
Tue, May 20, 12:38
valerio.bozzolan added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

Maybe better to just expand dialog, so, less code to maintain (?)

Tue, May 20, 12:36
valerio.bozzolan added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

(I just mean the feature comes from Phabricator, not from Phorge; sorry I always pick random words to express myself)

Tue, May 20, 12:33
aklapper added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

Hmm could you share why it's a "legacy feature"? I guess I'm clueless

Tue, May 20, 12:31
valerio.bozzolan added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

Awesome. Optional bonus point, since this legacy feature thing is indeed veeeery confusing and very-Phorgi, maybe we may want to add a "Why" Phorge decided this, and highlight potential pitfalls.

Tue, May 20, 12:30
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

Rephrase to not mentioned "second MFA"; Avoid empty HTML paragraph

Tue, May 20, 12:21
aklapper added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

good points <3

Tue, May 20, 12:20
valerio.bozzolan added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

Seems nice. Maybe we can generalize the text a bit to avoid "both" (since you can have multiple of them).

Tue, May 20, 12:12
aklapper added a revision to T16081: Warn users that adding a second Multi-Factor Auth will require both instead of choosing one of them: D26028: Explain consequences when adding second Multi-Factor Auth.
Tue, May 20, 12:10
aklapper requested review of D26028: Explain consequences when adding second Multi-Factor Auth.
Tue, May 20, 12:10
aklapper added a comment to T16081: Warn users that adding a second Multi-Factor Auth will require both instead of choosing one of them.

Proposed behavior: Add additional text when setting up a second MFA.

Tue, May 20, 12:05
aklapper created T16081: Warn users that adding a second Multi-Factor Auth will require both instead of choosing one of them.
Tue, May 20, 12:01
valerio.bozzolan added a subtask for T16060: arc diff: it could auto-claim the Task, if unclaimed: T15153: Document the special syntax you can use in commit messages to cause effects.
Tue, May 20, 11:46 · Discussion Needed, User-valerio.bozzolan, Feature Requests, Arcanist
valerio.bozzolan added a parent task for T15153: Document the special syntax you can use in commit messages to cause effects: T16060: arc diff: it could auto-claim the Task, if unclaimed.
Tue, May 20, 11:46 · Documentation, Diffusion, User-valerio.bozzolan
valerio.bozzolan updated the diff for D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.

fix PHPDoc - thanks andre

Tue, May 20, 10:22
aklapper added inline comments to D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Tue, May 20, 10:14
valerio.bozzolan archived Wikimedia Hackathon 2025.
Tue, May 20, 09:35
valerio.bozzolan edited Description on Wikimedia Hackathon 2025.
Tue, May 20, 09:35
valerio.bozzolan moved T16060: arc diff: it could auto-claim the Task, if unclaimed from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.
Tue, May 20, 09:32 · Discussion Needed, User-valerio.bozzolan, Feature Requests, Arcanist
valerio.bozzolan moved T15973: Fix unit test PhutilRemarkupEngineTestCase from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:31 · Wikimedia Hackathon 2025, Bug Reports, User-valerio.bozzolan, Remarkup
valerio.bozzolan moved T15967: Fix unit test PhutilPygmentizeParserTestCase from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:31 · Wikimedia Hackathon 2025, Bug Reports, User-valerio.bozzolan, Remarkup
valerio.bozzolan moved T16061: PhabricatorEnv isSelfURI(): add small cache of these self-URIs from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:31 · User-valerio.bozzolan, Feature Requests
valerio.bozzolan moved T16079: Allow extensions to define "Before Destruction" engines from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:31 · Extension Development, Feature Requests, User-valerio.bozzolan
valerio.bozzolan moved T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one") from Code Sprint Candidate to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:30 · Feature Requests, Policy, User-valerio.bozzolan, People
valerio.bozzolan moved T16043: Create Unit Tests to cover Project Destroy from Code Sprint Candidate to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:30 · Wikimedia Hackathon 2025, User-valerio.bozzolan, Feature Requests, Projects
valerio.bozzolan moved T15160: The Feed should not display the old content of an edited Comment as default from Code Sprint Candidate to 🔥 Trap on the User-valerio.bozzolan board.
Tue, May 20, 09:29 · Feed, Comments, User-valerio.bozzolan
valerio.bozzolan closed T16080: Evaluate a new database index to cover user.profileImagePHID as Wontfix.

The scenario in which this index would be needed is far from being normal. The patch D26027 that would benefit for it, is able to avoid that query in 99% of cases (it only needs such query when you want to destroy a profile picture, AND that picture was manually un-attached... why was it manually un-attached? by a spam click? by a faulty mouse?). So, the normal scenario is too small and unclear to justify a new index.

Tue, May 20, 08:16 · User-valerio.bozzolan, People
valerio.bozzolan closed T16080: Evaluate a new database index to cover user.profileImagePHID, a subtask of T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image), as Wontfix.
Tue, May 20, 08:16 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan updated the diff for D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.

add extra inline comments about T16080

Tue, May 20, 08:04
valerio.bozzolan added a revision to T16080: Evaluate a new database index to cover user.profileImagePHID: D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Tue, May 20, 07:57 · User-valerio.bozzolan, People
valerio.bozzolan updated the summary of D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Tue, May 20, 07:57
valerio.bozzolan added inline comments to D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Tue, May 20, 07:49
valerio.bozzolan updated the diff for D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
  • implement review tips from @mainframe98 - thanks
  • cover the edge case of a profile picture without attachments
Tue, May 20, 07:49
valerio.bozzolan created T16080: Evaluate a new database index to cover user.profileImagePHID.
Tue, May 20, 07:35 · User-valerio.bozzolan, People
aklapper edited the content of Next Up.
Tue, May 20, 06:36
aklapper edited the content of Next Up.
Tue, May 20, 06:35
aklapper closed D26021: Make User-Agent regex detect Firefox on Android.
Tue, May 20, 06:33