Agreed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Today
Now you do.
Yesterday
git rebase master
no no I rock like a grapstar
You grep like a rockstar
Uh right, thanks! Let's do as mainframe98 says
Unlocking patch
In D26007#26996, @aklapper wrote:@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.
Thu, May 22
You're right, thank you (as usual)!
git rebase master
Flagging as "andre is merging stuff https://we.phorge.it/D26007#26996"
Very good job as usual 👍
Nice. I'm 99% sure about the test plan, please see https://we.phorge.it/T16068#22703 before landing to adjust it, eventually.
Questions about the steps:
Wed, May 21
- fix last typo
- @return list<PhabricatorDestructionEngineExtension>
- fix typos
- add PHPDoc @return
Thanks! Additionally, it seems it's not possible to use these through {icon NAME} since it only supports font awesome AFAIK
Seems very useful thanks, I would like to find small extra time to expand the test plan a bit more and run these extra tests, since this sounds very "core"
Tue, May 20
Thanks! Confirming; tested, also works as expected with other epoch values.
Is getDisplayIconColor() related to these? (spoiler: probably it's not)
Yet another one strlen(null)...
I'm too stuck in Serious Business Mode to introduce another string to translate, I'm afraid :-/
In D26000#27460, @valerio.bozzolan wrote:Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?
Love this. Feel free to evaluate the addition of thus, dramatically increasing your corporate security (at the price of slowing you down even more). as stated here lol https://we.phorge.it/D26028#27452 or whatever small thing could help to better visualize this alien behavior that is very peculiar of Phorge (that is, as already said, not intuitive).
indentation is arrsome
Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?
oh true
Maybe better to just expand dialog, so, less code to maintain (?)
(I just mean the feature comes from Phabricator, not from Phorge; sorry I always pick random words to express myself)
Hmm could you share why it's a "legacy feature"? I guess I'm clueless
Awesome. Optional bonus point, since this legacy feature thing is indeed veeeery confusing and very-Phorgi, maybe we may want to add a "Why" Phorge decided this, and highlight potential pitfalls.
Rephrase to not mentioned "second MFA"; Avoid empty HTML paragraph
good points <3
Seems nice. Maybe we can generalize the text a bit to avoid "both" (since you can have multiple of them).
Proposed behavior: Add additional text when setting up a second MFA.
fix PHPDoc - thanks andre
The scenario in which this index would be needed is far from being normal. The patch D26027 that would benefit for it, is able to avoid that query in 99% of cases (it only needs such query when you want to destroy a profile picture, AND that picture was manually un-attached... why was it manually un-attached? by a spam click? by a faulty mouse?). So, the normal scenario is too small and unclear to justify a new index.
add extra inline comments about T16080
- implement review tips from @mainframe98 - thanks
- cover the edge case of a profile picture without attachments