Page MenuHomePhorge
Feed All Stories

Today

mturdus committed R5:f1a92c669931: Remarkup documentation added.
Remarkup documentation added
Sat, Jul 13, 07:15
mturdus committed R5:41270a2e9664: Remarkup documentation added.
Remarkup documentation added
Sat, Jul 13, 07:08

Yesterday

valerio.bozzolan closed T15883: Column "Move to Project": make it working for Milestones (instead of "You must choose a project with a workboard") as Invalid.

OK I'm stupid. I just need to visit the Milestone and create a Workboard.

Fri, Jul 12, 13:15 · User-valerio.bozzolan, Projects
valerio.bozzolan updated the task description for T15883: Column "Move to Project": make it working for Milestones (instead of "You must choose a project with a workboard").
Fri, Jul 12, 13:13 · User-valerio.bozzolan, Projects
valerio.bozzolan created T15883: Column "Move to Project": make it working for Milestones (instead of "You must choose a project with a workboard").
Fri, Jul 12, 13:10 · User-valerio.bozzolan, Projects
aklapper closed D25715: Fix property name typo in PhabricatorPDFIterator.
Fri, Jul 12, 10:20
aklapper committed rP877ac8a873f9: Fix property name typo in PhabricatorPDFIterator.
Fix property name typo in PhabricatorPDFIterator
Fri, Jul 12, 10:20
valerio.bozzolan added inline comments to D25502: Make PhabricatorSearchIntField validate its input.
Fri, Jul 12, 10:10
valerio.bozzolan added inline comments to D25502: Make PhabricatorSearchIntField validate its input.
Fri, Jul 12, 10:07
valerio.bozzolan accepted D25715: Fix property name typo in PhabricatorPDFIterator.

Seems that nothing internally accessed that method, and probably nothing externally. But we should probably keep that method since it's public. Thanks.

Fri, Jul 12, 09:50
valerio.bozzolan accepted D25725: Update phpqrcode from version 1.1.4 to 1.9.9.

I was still able to generate QR codes, and I verified with alternative application "Barcode Scanner" that the desired URL is read.

Fri, Jul 12, 09:46
valerio.bozzolan edited the content of Next Up.
Fri, Jul 12, 07:02
valerio.bozzolan added a comment to T15882: When archiving a project, reset its default menu item to Profile.

Premising that the root problem is that it's difficult to understand if a project is archived just looking at other parts.

Fri, Jul 12, 06:52 · Feature Requests, Projects
valerio.bozzolan triaged T15882: When archiving a project, reset its default menu item to Profile as Wishlist priority.
Fri, Jul 12, 06:51 · Feature Requests, Projects
valerio.bozzolan accepted D25731: Set default menu item to Project Details when archiving a project.

Thanks. Feature make sense and implementation seems good (but I have untested).

Fri, Jul 12, 06:48

Thu, Jul 11

aklapper updated the task description for T15882: When archiving a project, reset its default menu item to Profile.
Thu, Jul 11, 23:12 · Feature Requests, Projects
aklapper requested review of D25731: Set default menu item to Project Details when archiving a project.
Thu, Jul 11, 23:07
aklapper added a revision to T15882: When archiving a project, reset its default menu item to Profile: D25731: Set default menu item to Project Details when archiving a project.
Thu, Jul 11, 23:07 · Feature Requests, Projects
aklapper created T15882: When archiving a project, reset its default menu item to Profile.
Thu, Jul 11, 22:49 · Feature Requests, Projects
aklapper requested review of D25730: Avoid PhabricatorApplicationTransactionStructureException on editors not supporting Mute Notifications.
Thu, Jul 11, 10:08
aklapper added a revision to T15378: PhabricatorApplicationTransactionStructureException trying to mute File notifications: "Attempting to apply a transaction which has not been constructed correctly": D25730: Avoid PhabricatorApplicationTransactionStructureException on editors not supporting Mute Notifications.
Thu, Jul 11, 10:08
s.quinn closed Q143: Upgrading from Phabricator as resolved.
Thu, Jul 11, 08:14
avivey removed a project from T15705: Lower the search ranking of disabled user accounts: Discussion Needed.

I think we're all aligned here...

Thu, Jul 11, 07:35 · UX
aklapper closed T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Thu, Jul 11, 05:25 · PHP 8 support
aklapper closed T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView as Resolved by committing rP59428f64ca2c: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Thu, Jul 11, 05:25 · PHP 8 support
aklapper closed D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Thu, Jul 11, 05:25
aklapper committed rP59428f64ca2c: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView
Thu, Jul 11, 05:25
aklapper retitled D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView from Fix PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView
Thu, Jul 11, 05:21

Wed, Jul 10

speck accepted D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.

😆

Wed, Jul 10, 21:54
aklapper updated the diff for D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.

Eh, the PHP pitfalls that I'll never learn by heart... Thanks! :)
Let's try if ($file !== null && $file !== '') instead of if ($file) then?

Wed, Jul 10, 19:53
avivey added a comment to Q143: Upgrading from Phabricator (Answer 179).

The best way is probably to make an Extension:

Wed, Jul 10, 14:01
aklapper closed D25729: Remove unreachable return statement in AphrontFormDateControlValue.
Wed, Jul 10, 13:56
aklapper committed rPc4246cf871a7: Remove unreachable return statement in AphrontFormDateControlValue.
Remove unreachable return statement in AphrontFormDateControlValue
Wed, Jul 10, 13:56
avivey accepted D25729: Remove unreachable return statement in AphrontFormDateControlValue.
Wed, Jul 10, 13:53
aklapper requested review of D25729: Remove unreachable return statement in AphrontFormDateControlValue.
Wed, Jul 10, 13:25
aklapper closed D25716: Declare missing class property in PhabricatorTimelineEngine.
Wed, Jul 10, 12:54
aklapper committed rP941b769abae6: Declare missing class property in PhabricatorTimelineEngine.
Declare missing class property in PhabricatorTimelineEngine
Wed, Jul 10, 12:54
valerio.bozzolan accepted D25716: Declare missing class property in PhabricatorTimelineEngine.

sgtm

Wed, Jul 10, 12:20
aklapper edited the content of Next Up.
Wed, Jul 10, 11:34
aklapper closed T15876: Update external timezone information file to 2024a as Resolved by committing rP3fbb0309b53f: Update external timezone information to IANA TZDB 2024a.
Wed, Jul 10, 11:33
aklapper closed D25722: Update external timezone information to IANA TZDB 2024a.
Wed, Jul 10, 11:33
aklapper committed rP3fbb0309b53f: Update external timezone information to IANA TZDB 2024a.
Update external timezone information to IANA TZDB 2024a
Wed, Jul 10, 11:33
aklapper closed D25719: Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine.
Wed, Jul 10, 11:32
aklapper committed rPd9592e034812: Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine.
Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine
Wed, Jul 10, 11:32
valerio.bozzolan updated the summary of D25719: Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine.
Wed, Jul 10, 11:27
valerio.bozzolan accepted D25719: Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine.

sgtm

Wed, Jul 10, 11:26
valerio.bozzolan accepted D25722: Update external timezone information to IANA TZDB 2024a.

sgtm

Wed, Jul 10, 11:23
valerio.bozzolan retitled D25722: Update external timezone information to IANA TZDB 2024a from Update external timezone information to 2024a
Wed, Jul 10, 11:22
s.quinn added a comment to Q143: Upgrading from Phabricator (Answer 179).

Thanks for the confirmation!

Wed, Jul 10, 09:15
valerio.bozzolan updated the diff for D25305: Workboard: have thin scrollbars.

git rebase master (again)

Wed, Jul 10, 09:03
valerio.bozzolan attached a referenced file: F312320: Screenshot 2023-06-20 at 07-26-08 Maniphest · Workboard.png.
Wed, Jul 10, 08:34 · Maniphest, UX
valerio.bozzolan attached a referenced file: F312321: Screenshot 2023-06-20 at 07-27-41 Editing-team (Kanban Board) · Workboard.png.
Wed, Jul 10, 08:33 · Maniphest, UX
valerio.bozzolan attached a referenced file: F312322: Screenshot 2023-06-20 at 07-31-57 Maniphest · Workboard.png.
Wed, Jul 10, 08:33 · Maniphest, UX
valerio.bozzolan attached a referenced file: F312323: Screenshot 2023-06-20 at 07-32-20 Editing-team (Kanban Board) · Workboard.png.
Wed, Jul 10, 08:33 · Maniphest, UX
valerio.bozzolan accepted D25305: Workboard: have thin scrollbars.

Sorry for waiting.

Wed, Jul 10, 08:33
valerio.bozzolan updated the diff for D25305: Workboard: have thin scrollbars.

git rebase master

Wed, Jul 10, 08:21
aklapper closed D25713: Declare missing class properties in ArcanistDownloadWorkflow.
Wed, Jul 10, 08:06
aklapper committed rARC84210cedc6ce: Declare missing class properties in ArcanistDownloadWorkflow.
Declare missing class properties in ArcanistDownloadWorkflow
Wed, Jul 10, 08:06
aklapper closed D25720: Correct PHPDoc of dropSymbolCache().
Wed, Jul 10, 08:06
aklapper committed rARC76d22d70e429: Correct PHPDoc of dropSymbolCache().
Correct PHPDoc of dropSymbolCache()
Wed, Jul 10, 08:06
valerio.bozzolan accepted D25713: Declare missing class properties in ArcanistDownloadWorkflow.

sgtm

Wed, Jul 10, 07:35
valerio.bozzolan accepted D25720: Correct PHPDoc of dropSymbolCache().
Wed, Jul 10, 07:34
aklapper closed T15874: Invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest() as Resolved by committing rPff7be2cf1444: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Wed, Jul 10, 06:38
aklapper closed D25727: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Wed, Jul 10, 06:38
aklapper committed rPff7be2cf1444: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest()
Wed, Jul 10, 06:38
aklapper closed T15880: Timeline title for form creation mentions generic "object" instead of "form" as Resolved by committing rP290883b2a995: Set specific timeline title for form creation.
Wed, Jul 10, 06:18
aklapper closed D25726: Set specific timeline title for form creation.
Wed, Jul 10, 06:18
aklapper committed rP290883b2a995: Set specific timeline title for form creation.
Set specific timeline title for form creation
Wed, Jul 10, 06:18
speck added a comment to D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.

This might regress the case where file is “0”

Wed, Jul 10, 00:31
speck accepted D25727: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Wed, Jul 10, 00:10
speck accepted D25726: Set specific timeline title for form creation.
Wed, Jul 10, 00:04

Tue, Jul 9

aklapper updated the summary of D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Tue, Jul 9, 22:29
aklapper requested review of D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Tue, Jul 9, 22:23
aklapper added a revision to T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView: D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Tue, Jul 9, 22:23 · PHP 8 support
aklapper created T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView.
Tue, Jul 9, 22:10 · PHP 8 support
aklapper updated the diff for D25727: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().

Restore an empty line

Tue, Jul 9, 21:30
aklapper added a revision to T15874: Invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest(): D25727: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Tue, Jul 9, 21:26
aklapper requested review of D25727: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Tue, Jul 9, 21:26
aklapper added a comment to T15874: Invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().

This broken code is intended to find MailTags (means: each entry listed under http://phorge.localhost/settings/panel/emailpreferences/ , grep for const MAILTAG_ to get a list of them) defined more than once to display them in a Common section on top:

Screenshot from 2024-07-09 23-13-28.png (438×1 px, 90 KB)

However, as currently all MailTags are prefixed with their application (examples: phame-post-content, vote:responses, maniphest-owner) there is nothing to display anyway.

Tue, Jul 9, 21:19
avivey added Q143: Upgrading from Phabricator (Answer 179).
Tue, Jul 9, 14:44
s.quinn updated the question details for Q143: Upgrading from Phabricator.
Tue, Jul 9, 12:55
s.quinn asked Q143: Upgrading from Phabricator.
Tue, Jul 9, 12:54
aklapper added a comment to D25726: Set specific timeline title for form creation.

Before:

Screenshot from 2024-07-09 11-52-39.png (312×946 px, 35 KB)

Tue, Jul 9, 09:59
aklapper added a revision to T15880: Timeline title for form creation mentions generic "object" instead of "form": D25726: Set specific timeline title for form creation.
Tue, Jul 9, 09:58
aklapper requested review of D25726: Set specific timeline title for form creation.
Tue, Jul 9, 09:58
aklapper created T15880: Timeline title for form creation mentions generic "object" instead of "form".
Tue, Jul 9, 09:55

Mon, Jul 8

avivey added a comment to T15879: Documentation: Macro image rendered instead of keyword when names match.

these pages should have Macro disabled, probably. A user on the install can add more macros that would break the page in some other ways. Probably.

Mon, Jul 8, 16:38
aklapper created T15879: Documentation: Macro image rendered instead of keyword when names match.
Mon, Jul 8, 15:36
valerio.bozzolan edited the content of Next Up.
Mon, Jul 8, 08:10
valerio.bozzolan closed T15855: Fix "arc diff" in Subversion for non-English languages as Resolved by committing rARC72e59da8047c: Fix arc diff in Subversion for non-English languages.
Mon, Jul 8, 08:06 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan closed D25691: Fix arc diff in Subversion for non-English languages.
Mon, Jul 8, 08:06
valerio.bozzolan committed rARC72e59da8047c: Fix arc diff in Subversion for non-English languages.
Fix arc diff in Subversion for non-English languages
Mon, Jul 8, 08:06
avivey accepted D25691: Fix arc diff in Subversion for non-English languages.
Mon, Jul 8, 07:45
valerio.bozzolan added a comment to D25691: Fix arc diff in Subversion for non-English languages.

(↑ isn't this lovely? lol)

Mon, Jul 8, 05:41
valerio.bozzolan added a comment to F2284839: plz make me merge.jpg.

This is a low quality image that could be used by "fair use" as meme. Source:

Mon, Jul 8, 05:36
valerio.bozzolan changed the visibility for F2284839: plz make me merge.jpg.
Mon, Jul 8, 05:35
aklapper requested review of D25725: Update phpqrcode from version 1.1.4 to 1.9.9.
Mon, Jul 8, 01:55
aklapper added a revision to T15878: Update embedded phpqrcode from version 1.1.4 to 1.9.9: D25725: Update phpqrcode from version 1.1.4 to 1.9.9.
Mon, Jul 8, 01:55
aklapper created T15878: Update embedded phpqrcode from version 1.1.4 to 1.9.9.
Mon, Jul 8, 01:52

Sun, Jul 7

saveinsta updated saveinsta.
Sun, Jul 7, 14:13