Page MenuHomePhorge
Feed All Stories

Today

valerio.bozzolan added a project to T15048: Allow awarding Tokens to individual Comments: Comments.
Wed, Feb 21, 09:29 · Comments
valerio.bozzolan added a comment to T15728: Repo home view and browse view share the same menu tab.

I tried to understand the situation. Thanks.

Wed, Feb 21, 08:03 · Discussion Needed, Diffusion

Yesterday

avivey added a comment to Q111: How to disable noreply mailbox? (Answer 143).

Ok, see here: https://we.phorge.it/book/phorge/article/configuring_outbound_email/#outbound-quot-from-quot-and-quot

Tue, Feb 20, 07:30
sicenul added a comment to Q111: How to disable noreply mailbox? (Answer 143).
  • I have setup cluster.mailers using smtp type (phorge-mailer@gmail.com (example only))
  • those messages are receive in phorge-mailer@gmail.com from google mailer, informing that noreply@phorge.domain.com is not reachable so it bounce.
  • I assume, it happened because phorge send outbound email:
    • using noreply@phorge.domain.com as "To" address
    • "cc" address to recipients
    • "From" with format "Username (Fullname) <phorge-mailer@gmail.com>"
  • Is it possible to disable or change "To" address other than noreply@phorge.domain.com, because I didn't setup phorge.domain.com to receive email.
Tue, Feb 20, 03:22

Mon, Feb 19

avivey added a comment to T15512: Reimplement "Flags" to be based on Edges.

btw, for the "search" use-case I'm describing, I'm imagining something like a Function on Users/project, so I can search, for example "Tasks that are assigned to users which I flagged with a green flag" or "Tasks that have a tag that I flagged with a blue flag".
And also, "Revisions that I flagged with any flag".

Mon, Feb 19, 21:59
avivey added a comment to T15512: Reimplement "Flags" to be based on Edges.

I looked into this again.

Mon, Feb 19, 21:54
avivey added Q111: How to disable noreply mailbox? (Answer 143).
Mon, Feb 19, 19:59
sicenul asked Q111: How to disable noreply mailbox?.
Mon, Feb 19, 11:11

Sat, Feb 17

avivey edited the content of How to Write Extensions.
Sat, Feb 17, 13:33 · Extension Development
avivey created an object: How to Install Extensions.
Sat, Feb 17, 13:32 · Extension Development
20after4 awarded R11:741e2946b93f: license a Like token.
Sat, Feb 17, 12:52
avivey committed R11:741e2946b93f: license.
license
Sat, Feb 17, 11:13
avivey committed R11:f9e20362b385: Fix nestes lists and work on Inputs too.
Fix nestes lists and work on Inputs too
Sat, Feb 17, 11:13
avivey committed R11:b77da03b97ce: Create lightweight RTL extension.
Create lightweight RTL extension
Sat, Feb 17, 11:13
Iniquity added a comment to D25491: Improve contrast of Links in Dark Mode.

Hello! Are you sure changing the link color is a good idea? Perhaps we should just make the background darker?

Sat, Feb 17, 10:46
Iniquity awarded T15056: Improve Dark Mode a Love token.
Sat, Feb 17, 10:36 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit

Fri, Feb 16

Wikivu resigned from rPaf06bfb1cc49: Make Changeset ID for render cache explicit.

Wiki volkankaos

Fri, Feb 16, 16:07 · arc-vscode
Wikivu added 1 auditor(s) for rPaf06bfb1cc49: Make Changeset ID for render cache explicit: Wikivu.
Fri, Feb 16, 16:06 · arc-vscode
bekay added a comment to T15048: Allow awarding Tokens to individual Comments.

Just asking for a friend: Is there some progress on this?

Fri, Feb 16, 12:43 · Comments
bekay updated subscribers of Q108: Phorge and Mermaid Js (Answer 139).

Maybe this could be integrated in the Diagrams extension...? I mean: the entire infrastructure is there - you just have to decide, what lib you wanne use when creating a new diagram. @mturdus What do you think about this?

Fri, Feb 16, 12:35
avivey created an object: How to Write Extensions.
Fri, Feb 16, 11:05 · Extension Development
avivey created an object: Extensions.
Fri, Feb 16, 11:05
valerio.bozzolan added a comment to Q110: Non working URL for query overheated explanation page.

It would be a pleasure to receive a patch from you :) The file should be this one:

Fri, Feb 16, 11:00
valerio.bozzolan updated the question details for Q110: Non working URL for query overheated explanation page.
Fri, Feb 16, 10:57
avivey added Q110: Non working URL for query overheated explanation page (Answer 142).
Fri, Feb 16, 10:57
sicenul changed the visibility for F1375625: image.png.
Fri, Feb 16, 10:40
sicenul changed the visibility for F1375613: image.png.
Fri, Feb 16, 10:39
sicenul asked Q110: Non working URL for query overheated explanation page.
Fri, Feb 16, 10:39
avivey edited the content of Community Resources.
Fri, Feb 16, 10:25
avivey created an object: Community Resources.
Fri, Feb 16, 10:06
avivey added a comment to D25535: T15011: Update support for XHPast on Windows.

Maybe this is wild, but: should we consider removing the compiled xhpast.exe file from the repository, and host is externally?
I think it's only used for working on PHP on Windows; The equivalent xhpast isn't included, presumably because compiling stuff on Windows is harder.
My argument for this is that the normal way to install arcanist is git clone, which downloads all the history (and 95% of users won't need this particular file).

Fri, Feb 16, 08:08

Thu, Feb 15

valerio.bozzolan added inline comments to D25535: T15011: Update support for XHPast on Windows.
Thu, Feb 15, 23:48
valerio.bozzolan added inline comments to D25535: T15011: Update support for XHPast on Windows.
Thu, Feb 15, 23:47
valerio.bozzolan accepted D25535: T15011: Update support for XHPast on Windows.

Passed a week. Nobody commented. I blindly trust you in this field :3 Approve.

Thu, Feb 15, 23:46
valerio.bozzolan accepted D25537: Update PHP versions in install guide: Remove 5, Add 8..

sgtm

Thu, Feb 15, 23:43
valerio.bozzolan edited the content of Next Up.
Thu, Feb 15, 23:15
bekay attached a referenced file: F1360344: image.png.
Thu, Feb 15, 19:01
bekay attached a referenced file: F1368592: image.png.
Thu, Feb 15, 19:01
bekay added a comment to T15673: Phorge participation at FOSDEM 2024.

TRUST ME - YOU DON'T WANT TO LISTEN MY ENGLISH :D :D

Btw now the video is here :D :D AGAIN SORRY PHORGE FOR MY MISTAKES <3 <3

https://video.fosdem.org/2024/h2215/fosdem-2024-3610-unpack-phabricator-welcome-phorge-forking-the-opinionated-open-source-project-manager.av1.webm

Thu, Feb 15, 18:59 · Blessed Communicators, Phorge
bekay closed D25536: Implements copy button in clone repo modal.
Thu, Feb 15, 18:38
bekay committed rP89a5d3132c94: Implements copy button in clone repo modal.
Implements copy button in clone repo modal
Thu, Feb 15, 18:38
bekay updated the diff for D25536: Implements copy button in clone repo modal.
Thu, Feb 15, 18:35
valerio.bozzolan added a comment to D25536: Implements copy button in clone repo modal.

Premising that I've already accepted I noticed also this minor possible thing:

Thu, Feb 15, 16:55
valerio.bozzolan accepted D25536: Implements copy button in clone repo modal.

Lovely thanks :)

Thu, Feb 15, 16:49
bekay added a comment to D25536: Implements copy button in clone repo modal.

I really have struggled to find any device in our company that can't do await/async. I strongly bevlieve it is a non issue. Let us land this thing now and see if we get any feedback of an error.

Thu, Feb 15, 16:29
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • Changes the order of the variables and function calls
Thu, Feb 15, 16:29
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • Extends select behavior and only select content on first click
Thu, Feb 15, 16:23
avivey added a comment to D25536: Implements copy button in clone repo modal.

The ".then()" part is pure hackness; The async/await is the sane way to do async programming.

Thu, Feb 15, 10:39
bekay added a comment to D25536: Implements copy button in clone repo modal.

Again, non-blocking opinion:

Are we aware that the "async" keyword (that was never used in Phorge) may just cause a crash by syntax error (almost-immediately even without clicking?) by that kind of browsers, so, breaking the page, just because we want to provide a copy function and we want to avoid .then()?

I think we can introduce breaking changes, but it's strange to do that, now, with this minor feature.

If we are aware of this minor risk, indeed let's land.

Thu, Feb 15, 10:08
valerio.bozzolan added inline comments to D25536: Implements copy button in clone repo modal.
Thu, Feb 15, 10:07
valerio.bozzolan added a comment to D25536: Implements copy button in clone repo modal.

Again, non-blocking opinion:

Thu, Feb 15, 09:43
bekay added a comment to D25536: Implements copy button in clone repo modal.

Additional non-blocking thing:

Maybe should be copy(text) with var data defined outside

Bonus point: copy() not defined during every call of JX.Stratcom.listen, but outside (?)

Thu, Feb 15, 09:23
valerio.bozzolan added a comment to D25536: Implements copy button in clone repo modal.

Additional non-blocking thing:

Thu, Feb 15, 09:13
valerio.bozzolan awarded D25536: Implements copy button in clone repo modal a Like token.
Thu, Feb 15, 09:08
bekay added a comment to D25536: Implements copy button in clone repo modal.

Yes, we can avoid async.

So, this is just a tip, to avoid async and also to have everything a little more modular for no reason:

  1. remove async from copy()
  2. rename copy() to copyWithoutFeedback() and have the function that always return a Promise
    • so copyWithoutFeedback() has return navigator.clipboard.writeText(text); to always return a Promise
    • so copyWithoutFeedback() can use copyWithFeedback() but after that it return Promise.resolve(true) to always return a Promise
    • so copyWithoutFeedback() can fail with just return Promise.reject() to always return a Promise
  3. so we can create the function with feedback, copyWithFeedback(), that just calls the previous one, so, copyWithoutFeedback().then(function() { show_success_message() } ); with also a chained .fail( function() { show_error_message(); } ) or something similar
Thu, Feb 15, 08:52
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • Updates map
Thu, Feb 15, 08:36
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • Ignores async jshint
Thu, Feb 15, 08:35
valerio.bozzolan added a comment to D25536: Implements copy button in clone repo modal.

First of all, I tested this, and this is super-lovely, really better than I thought, I love this. Thanks.

Thu, Feb 15, 08:11

Wed, Feb 14

avivey added a comment to D25536: Implements copy button in clone repo modal.

oh, for this one we can just ignore it. arc only shows these for new lines

Wed, Feb 14, 18:42
bekay edited the content of Organizations Using Phorge.
Wed, Feb 14, 17:36
bekay requested review of D25538: Seperate repository home and browse view in tab menu.
Wed, Feb 14, 17:27
bekay added a revision to T15728: Repo home view and browse view share the same menu tab: D25538: Seperate repository home and browse view in tab menu.
Wed, Feb 14, 17:27 · Discussion Needed, Diffusion
bekay added a comment to D25536: Implements copy button in clone repo modal.

I'm happy about the JS stuff, and I'm ok with any UI solution here.
I'll try to see if there's config for the jshint to allow async.

@valerio.bozzolan ?

Wed, Feb 14, 16:36
avivey accepted D25536: Implements copy button in clone repo modal.

I'm happy about the JS stuff, and I'm ok with any UI solution here.
I'll try to see if there's config for the jshint to allow async.

Wed, Feb 14, 16:32
bekay added a comment to D25536: Implements copy button in clone repo modal.

Well, now I have tried to satisfy every wish.

Wed, Feb 14, 16:05
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • use async/await for copy promise hell
  • make the io button to just a type icon
  • select entire text when clicking inside the input field
  • patch JsShrink to shrink await/async syntax
Wed, Feb 14, 16:01
bekay updated the summary of D25536: Implements copy button in clone repo modal.
Wed, Feb 14, 15:49
avivey added a comment to D25536: Implements copy button in clone repo modal.

We can probably just pull the JsShrink fix in for now, and later replace both it and jsxmin (which I'll bet nobody have) with something else that is maintained, like JShrink.

Wed, Feb 14, 12:41
bekay added a comment to D25536: Implements copy button in clone repo modal.

(This Quickfix would help: https://github.com/vrana/JsShrink/pull/6/commits/5b2dd500d25b29ace2fbd76fc95b4518ef22abfc 😆 )

Wed, Feb 14, 12:39
bekay added a comment to D25536: Implements copy button in clone repo modal.

await/async won't go through the shrink process without destroying the entire syntax. And if it will go through this jsxmin binary, who can know? Note for the future: Maybe replace the entire shrink process with a new and used php shrinker like JShrink.

Wed, Feb 14, 12:13
avivey added a comment to D25536: Implements copy button in clone repo modal.

(Just to clarify, and sorry if late comment again - I was proposing to avoid to add buttons, and simply auto-select and auto-copy the input text the first time it receives a click. Bonus: with "copied" message feedback - I have untested this sorry)

Wed, Feb 14, 11:20
bekay added a comment to D25536: Implements copy button in clone repo modal.

@avivey worst case is a syntax error because the operators are not know. Even that could be wrapped inside a try/catch.
@valerio.bozzolan could be done with the current behavior but this kind of implicit actions seems not the phorge way...?

Wed, Feb 14, 10:10
valerio.bozzolan added a comment to D25536: Implements copy button in clone repo modal.

(Just to clarify, and sorry if late comment again - I was proposing to avoid to add buttons, and simply auto-select and auto-copy the input text the first time it receives a click. Bonus: with "copied" message feedback - I have untested this sorry)

Wed, Feb 14, 09:37
avivey added a comment to D25536: Implements copy button in clone repo modal.

Our policy in general is "support things way after the go EOL", but with the cost of supporting IE 11 (this kind of hell), I think we can make an exception and throw it under the bus. Worst case, we're talking about an error in the logs and "nothing happening" from the user POV, right?

Wed, Feb 14, 09:29
sirocyl edited the content of Organizations Using Phorge.
Wed, Feb 14, 09:26
valerio.bozzolan added a comment to Organizations Using Phorge.

I've successfully updated our Phabricator instance to Phorge today. After paying very careful attention to everything it went smoothly without any issues. Glad that this project has not died. Phabricator grew on me as well.

Wed, Feb 14, 09:24
bekay added a comment to D25536: Implements copy button in clone repo modal.

Yes, I insist on using the absolute required minimum of Promise-style coding.

Wed, Feb 14, 08:56
sirocyl added a comment to Organizations Using Phorge.

Should we add FreeBSD to this list? It uses Phorge now (as of June 2023) and has many users.
(Much of their documentation still refers to it as "Phabricator", despite this.)

Wed, Feb 14, 00:52
sirocyl updated the answer details for Q18: Lowest and Highest supported PHP (Answer 141).
Wed, Feb 14, 00:10
sirocyl added Q18: Lowest and Highest supported PHP (Answer 141).
Wed, Feb 14, 00:09

Tue, Feb 13

20after4 added a comment to T15705: Lower the search ranking of disabled user accounts.

I agree, disabled users should be hidden in the global search typeahead results.

Tue, Feb 13, 23:22 · Discussion Needed, UX
20after4 added a comment to T15736: JavaScript modernization (umbrella task).
In T15736#15681, @bekay wrote:
  • Get rid of the JX namespace and the the require comments - use import and export like it is done in modern js
Tue, Feb 13, 23:21 · UX, Discussion Needed
aklapper closed T15720: Improve messages when no image formats are supported (due to GD not installed) as Resolved by committing rPe2bec4c1f58b: Improve messages when no image formats are supported (due to GD not installed).
Tue, Feb 13, 16:07
aklapper closed D25525: Improve messages when no image formats are supported (due to GD not installed).
Tue, Feb 13, 16:07
aklapper committed rPe2bec4c1f58b: Improve messages when no image formats are supported (due to GD not installed).
Improve messages when no image formats are supported (due to GD not installed)
Tue, Feb 13, 16:07
aklapper updated the diff for D25502: Make PhabricatorSearchIntField validate its input.

Remove unreached return call as pointed out by speck

Tue, Feb 13, 15:58
aklapper added a comment to D25502: Make PhabricatorSearchIntField validate its input.
In D25502#15384, @speck wrote:

Is it possible to check if anything is relying on this not working with negative numbers?

Tue, Feb 13, 15:56
valerio.bozzolan added a comment to D25536: Implements copy button in clone repo modal.

Sorry for my late comment

Tue, Feb 13, 14:28
avivey added a comment to D25536: Implements copy button in clone repo modal.

Yes, I insist on using the absolute required minimum of Promise-style coding.
I don't know if we have any other example of a Promise-based API used - there might be an example somewhere on how to break away from it and go back to sane code.

Tue, Feb 13, 09:53
bekay added a comment to D25536: Implements copy button in clone repo modal.

I have to wait for the success or failure of the copy action, so I think this ui example makes no sense for my case. The notification should not be triggered by a button click.

Tue, Feb 13, 09:42
bekay added a comment to D25536: Implements copy button in clone repo modal.
Tue, Feb 13, 09:35
avivey added a comment to D25536: Implements copy button in clone repo modal.
try {
  if (new_copy) {
    new_copy(text);
  } else {
    old_copy(text);
  } 
  show_message(good);
} catch (ex) {
  show_message(bad);
}
Tue, Feb 13, 09:34
avivey requested changes to D25536: Implements copy button in clone repo modal.

Don't do that thing to the JS file. To add a notification, use the existing notification feature we already have - see https://we.phorge.it/uiexample/view/PhabricatorNotificationUIExample/ (https://we.phorge.it/source/phorge/browse/master/src/applications/uiexample/examples/PhabricatorNotificationUIExample.php).

Tue, Feb 13, 09:21
avivey added a comment to T15739: Replace celerity postprocessors with real css variables.

I'm not against replacing the mechanism - It's just that the original task description doesn't specify why that would be good (i.e., what the benefit would be).
That's clear from the discussion now, but should generally be included in the ticket description - the "describe "what", not "how"" principle.

Tue, Feb 13, 07:57 · Discussion Needed
sirocyl added a comment to T15739: Replace celerity postprocessors with real css variables.

A big benefit of using client-side variables in CSS, is that one can use the browser's prefers-color-scheme media query to select light or dark mode based on the user's browser or system setting, automatically, and that the transition from light to dark mode, or to other accent/highlight color schemes, requires no reload.

Tue, Feb 13, 04:02 · Discussion Needed
sirocyl closed T15737: Include information for installing required PHP version in Diviner docs as Wontfix.
Tue, Feb 13, 03:34 · PHP 8 support, Good Starter Task, Documentation

Mon, Feb 12

speck added a comment to D25502: Make PhabricatorSearchIntField validate its input.

Is it possible to check if anything is relying on this not working with negative numbers?

Mon, Feb 12, 22:56
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

Well, I see a tremendous critism and scepticism concerning modern client side techniques here. The world of frontend tooling has changed tremendously in the last 5 years. And I understand concerns, but nobody has to write JavaScript for certain browsers anymore. Javelin for example tries to solve so many problems that Babel solves with one config entry. But that's okay and I like the architecture here and know we can't change everything at once.

Mon, Feb 12, 21:05 · Discussion Needed
avivey requested review of D25537: Update PHP versions in install guide: Remove 5, Add 8..
Mon, Feb 12, 20:35
avivey added a revision to T15047: Officially raise minimum required PHP version to 7.2: D25537: Update PHP versions in install guide: Remove 5, Add 8..
Mon, Feb 12, 20:35 · Phorge