Page MenuHomePhorge
Feed All Stories

Yesterday

avivey added Q77: Arcanist writes cache files to its source directory, and this prevents packaging (Answer 106).
Tue, Oct 3, 20:19
fgaz added a comment to Q77: Arcanist writes cache files to its source directory, and this prevents packaging (Answer 105).

Could libexec/arcanist/src/.phutil_module_cache just be a symlink to somewhere else?

Tue, Oct 3, 14:19
fgaz added a comment to Q77: Arcanist writes cache files to its source directory, and this prevents packaging.

Nix

Tue, Oct 3, 14:17 · Arcanist
valerio.bozzolan added a comment to Q77: Arcanist writes cache files to its source directory, and this prevents packaging.

Just for my curiosity, what lovely package are you crafting? APT? snap? Thanks :)

Tue, Oct 3, 14:15 · Arcanist
fgaz updated the question details for Q77: Arcanist writes cache files to its source directory, and this prevents packaging.
Tue, Oct 3, 14:14 · Arcanist
valerio.bozzolan added Q77: Arcanist writes cache files to its source directory, and this prevents packaging (Answer 105).
Tue, Oct 3, 14:14
fgaz asked Q77: Arcanist writes cache files to its source directory, and this prevents packaging.
Tue, Oct 3, 14:13 · Arcanist
valerio.bozzolan added a member for Trusted Contributors: fgaz.
Tue, Oct 3, 12:56
valerio.bozzolan accepted D25445: Update path in startup error.

I accept but please wait at least one day before landing :) Thanks for your code contribution!

Tue, Oct 3, 12:55
valerio.bozzolan added a comment to D25445: Update path in startup error.

I'm inclined to accept this, premising that usually we adopt PlatformSymbols::getPlatformServerPath() but in this case that will not work since this error is very low-level about the load of Arcanist itself.

Tue, Oct 3, 12:54
fgaz requested review of D25445: Update path in startup error.
Tue, Oct 3, 12:51
aklapper updated the task description for T15322: Footer: specify a default Libre license for Phorge contents.
Tue, Oct 3, 09:18 · Discussion Needed, Governance
valerio.bozzolan added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

Thanks but I don't know where that typo is, so, feel free to fix

Tue, Oct 3, 09:07 · Discussion Needed, Governance
aklapper added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

See e.g. https://www.law.cornell.edu/wex/release why to "license under" instead of "release in"

Tue, Oct 3, 08:31 · Discussion Needed, Governance
valerio.bozzolan triaged T15649: Too few arguments to function DiffusionDiffQueryConduitAPIMethod::getDefaultParser(), 0 passed in DiffusionDiffQueryConduitAPIMethod.php on line 156 and exactly 1 expected as Unbreak Now! priority.

Triaging to "Unbreak Now!" so to be kindly shown in the homepage :)

Tue, Oct 3, 07:30 · Bug Reports
valerio.bozzolan added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

I don't remember but that was an attempt to do not release Passphrase credentials as CC BY-SA 4.0 :D :D

Tue, Oct 3, 07:26 · Discussion Needed, Governance
aklapper added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

Public contents are released in Creative Commons Attribution-ShareAlike 4.0.

Tue, Oct 3, 07:18 · Discussion Needed, Governance
valerio.bozzolan added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

Updated to reflect some tips from comments. Also added some "Pro / Cons"

Tue, Oct 3, 06:10 · Discussion Needed, Governance
valerio.bozzolan updated the task description for T15322: Footer: specify a default Libre license for Phorge contents.
Tue, Oct 3, 06:09 · Discussion Needed, Governance
valerio.bozzolan moved T15515: Blur profile image when account disabled from Backlog to Feature Requests on the Affects-Wikimedia board.
Tue, Oct 3, 05:31 · Feature Requests, Affects-Wikimedia
valerio.bozzolan moved T15648: Transaction text when changing Diffusion URI I/O type is about Display type instead from Backlog to Bug Reports on the Affects-Wikimedia board.
Tue, Oct 3, 05:31 · Affects-Wikimedia, Bug Reports
valerio.bozzolan moved T15149: Fix middle-click, CTRL+click, right-click etc. on Typehead search results from Backlog to Bug Reports on the Affects-Wikimedia board.
Tue, Oct 3, 05:31 · Affects-Wikimedia, User-valerio.bozzolan, Typeahead

Mon, Oct 2

Quartz added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

+1 for CC BY-SA 4.0 International for content (text, images, etc) and Apache 2.0 for code.

Mon, Oct 2, 21:15 · Discussion Needed, Governance
valerio.bozzolan updated the test plan for D25444: Fix regression in DiffusionDiffQueryConduitAPIMethod.
Mon, Oct 2, 14:52
valerio.bozzolan requested review of D25444: Fix regression in DiffusionDiffQueryConduitAPIMethod.
Mon, Oct 2, 14:51
valerio.bozzolan added a revision to T15649: Too few arguments to function DiffusionDiffQueryConduitAPIMethod::getDefaultParser(), 0 passed in DiffusionDiffQueryConduitAPIMethod.php on line 156 and exactly 1 expected: D25444: Fix regression in DiffusionDiffQueryConduitAPIMethod.
Mon, Oct 2, 14:51 · Bug Reports
valerio.bozzolan updated the task description for T15649: Too few arguments to function DiffusionDiffQueryConduitAPIMethod::getDefaultParser(), 0 passed in DiffusionDiffQueryConduitAPIMethod.php on line 156 and exactly 1 expected.
Mon, Oct 2, 14:30 · Bug Reports
valerio.bozzolan raised a concern with rP69c64c1e83e2: Teach Commit View about Encoding.
Mon, Oct 2, 14:30
valerio.bozzolan updated the task description for T15649: Too few arguments to function DiffusionDiffQueryConduitAPIMethod::getDefaultParser(), 0 passed in DiffusionDiffQueryConduitAPIMethod.php on line 156 and exactly 1 expected.
Mon, Oct 2, 14:28 · Bug Reports
valerio.bozzolan created T15649: Too few arguments to function DiffusionDiffQueryConduitAPIMethod::getDefaultParser(), 0 passed in DiffusionDiffQueryConduitAPIMethod.php on line 156 and exactly 1 expected.
Mon, Oct 2, 14:28 · Bug Reports
valerio.bozzolan updated the diff for D25416: Replacing the deprecated -moz-outline-style with outline-style.

git rebase master

Mon, Oct 2, 11:47
fgaz updated fgaz.
Mon, Oct 2, 08:05

Sat, Sep 30

waldyrious awarded T15535: Using Differential with plain Git, without requiring Arc a Love token.
Sat, Sep 30, 14:12 · Feature Requests

Fri, Sep 29

valerio.bozzolan added a comment to D25437: Fix "Undefined index" exception setting Meme text.

There is a thing, to be honest. We are trimming the $above just in the test, but then we are not using the trimmed string in the rendering. So, the $v = coalesce($v, '') thing, and always trim() later, may still be better.

Fri, Sep 29, 07:58
valerio.bozzolan updated the test plan for D25437: Fix "Undefined index" exception setting Meme text.
Fri, Sep 29, 07:57
valerio.bozzolan accepted D25437: Fix "Undefined index" exception setting Meme text.

Maybe other people would like to propose a coalesce() and always trim() that and just have the if(phutil_nonempty...($)), but to be honest this is just correct and somehow minimal.

Fri, Sep 29, 07:54

Thu, Sep 28

valerio.bozzolan added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

I tried browsing that page without being able to trigger the issue

Thu, Sep 28, 11:31 · Affects-Wikimedia
Sten closed T15647: 'arc lint' fails for composer.json with RuntimeException: Undefined array key "hash" as Resolved by committing rARCba42b63704b2: Update ArcanistComposerLinter.php to check content-hash instead of hash.
Thu, Sep 28, 08:12
Sten closed D25442: Update ArcanistComposerLinter.php to check content-hash instead of hash.
Thu, Sep 28, 08:12
Sten committed rARCba42b63704b2: Update ArcanistComposerLinter.php to check content-hash instead of hash (authored by Sten).
Update ArcanistComposerLinter.php to check content-hash instead of hash
Thu, Sep 28, 08:12
aklapper closed D25443: Correct Transaction text when changing Diffusion URI I/O type.
Thu, Sep 28, 07:20
aklapper closed T15648: Transaction text when changing Diffusion URI I/O type is about Display type instead as Resolved by committing rP03afb97ff20b: Correct Transaction text when changing Diffusion URI I/O type.
Thu, Sep 28, 07:20 · Affects-Wikimedia, Bug Reports
aklapper committed rP03afb97ff20b: Correct Transaction text when changing Diffusion URI I/O type (authored by aklapper).
Correct Transaction text when changing Diffusion URI I/O type
Thu, Sep 28, 07:20

Wed, Sep 27

valerio.bozzolan awarded D25443: Correct Transaction text when changing Diffusion URI I/O type a Like token.
Wed, Sep 27, 20:47
valerio.bozzolan updated the summary of D25443: Correct Transaction text when changing Diffusion URI I/O type.
Wed, Sep 27, 20:46
avivey accepted D25442: Update ArcanistComposerLinter.php to check content-hash instead of hash.
Wed, Sep 27, 20:21
avivey accepted D25443: Correct Transaction text when changing Diffusion URI I/O type.
Wed, Sep 27, 20:12
aklapper requested review of D25443: Correct Transaction text when changing Diffusion URI I/O type.
Wed, Sep 27, 16:51
aklapper added a revision to T15648: Transaction text when changing Diffusion URI I/O type is about Display type instead: D25443: Correct Transaction text when changing Diffusion URI I/O type.
Wed, Sep 27, 16:51 · Affects-Wikimedia, Bug Reports
aklapper created T15648: Transaction text when changing Diffusion URI I/O type is about Display type instead.
Wed, Sep 27, 16:50 · Affects-Wikimedia, Bug Reports
aklapper updated the task description for T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.
Wed, Sep 27, 12:19 · Affects-Wikimedia
aklapper abandoned D25438: Allow branch names to be integer values to avoid an InvalidArgumentException.

Abandoning per last comment; guess we should debug a bit more first in downstream to understand the root cause better

Wed, Sep 27, 11:43
Sten added a comment to T15647: 'arc lint' fails for composer.json with RuntimeException: Undefined array key "hash".

This issue has been a pain for years. Never investigated it before...

Wed, Sep 27, 09:42
Sten updated the diff for D25442: Update ArcanistComposerLinter.php to check content-hash instead of hash.

Fix unit test

Wed, Sep 27, 09:40
Sten updated the diff for D25442: Update ArcanistComposerLinter.php to check content-hash instead of hash.

Lint & fix xml unit test

Wed, Sep 27, 09:33
Sten planned changes to D25442: Update ArcanistComposerLinter.php to check content-hash instead of hash.
Wed, Sep 27, 09:12
Sten requested review of D25442: Update ArcanistComposerLinter.php to check content-hash instead of hash.
Wed, Sep 27, 09:11
Sten added a revision to T15647: 'arc lint' fails for composer.json with RuntimeException: Undefined array key "hash": D25442: Update ArcanistComposerLinter.php to check content-hash instead of hash.
Wed, Sep 27, 09:11
Sten claimed T15647: 'arc lint' fails for composer.json with RuntimeException: Undefined array key "hash".
Wed, Sep 27, 08:52
Sten created T15647: 'arc lint' fails for composer.json with RuntimeException: Undefined array key "hash".
Wed, Sep 27, 08:52
aklapper added a project to T15646: Renaming several Pholio Mockup images creates neverending daemon task (PhutilProxyException due to Array to string conversion): Affects-Wikimedia.
Wed, Sep 27, 08:50 · Affects-Wikimedia, Bug Reports
aklapper abandoned D25239: Fix PHP 8.1 exceptions which block rendering Drydock's Create Blueprint page.

Not sure how to proceed here, this abandoning for now

Wed, Sep 27, 08:44

Tue, Sep 26

aklapper requested review of D25441: Fix array to string conversion renaming several Pholio mockup images at once.
Tue, Sep 26, 13:10
aklapper added a revision to T15646: Renaming several Pholio Mockup images creates neverending daemon task (PhutilProxyException due to Array to string conversion): D25441: Fix array to string conversion renaming several Pholio mockup images at once.
Tue, Sep 26, 13:10 · Affects-Wikimedia, Bug Reports
aklapper created T15646: Renaming several Pholio Mockup images creates neverending daemon task (PhutilProxyException due to Array to string conversion).
Tue, Sep 26, 13:05 · Affects-Wikimedia, Bug Reports
bekay created T15645: Implement "Locate File" input in Browse view.
Tue, Sep 26, 07:03 · Diffusion
valerio.bozzolan added a comment to T15256: Diffusion file: add a way to copy permalink.

Yeah feel free to review D2530

Tue, Sep 26, 06:55 · User-valerio.bozzolan, Diffusion
bekay added a comment to T15256: Diffusion file: add a way to copy permalink.

I still like this. Why is this not going forward? 😄

Tue, Sep 26, 06:52 · User-valerio.bozzolan, Diffusion

Mon, Sep 25

Dylsss added inline comments to D25051: Destroy file attachments when file is deleted.
Mon, Sep 25, 10:55 · Files
valerio.bozzolan added a comment to D25033: Packages: Load'em from .cache.

(I have not tried this patch but I checked with ls -la the mess in my .cache to understand best practices from other software)

Mon, Sep 25, 10:14 · Arcanist (archived)
valerio.bozzolan edited the content of Next Up.
Mon, Sep 25, 06:23
valerio.bozzolan edited the content of Next Up.
Mon, Sep 25, 06:20
valerio.bozzolan closed T15143: Allow to quick-edit a Milestone name from Workboard menu as Resolved by committing rP903d71e67d84: Workboard: Milestone Name easily editable (instead of surfing 3 pages).
Mon, Sep 25, 06:18 · UX, Affects-Wikimedia, User-valerio.bozzolan, Workboard
valerio.bozzolan closed D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).
Mon, Sep 25, 06:18
valerio.bozzolan committed rP903d71e67d84: Workboard: Milestone Name easily editable (instead of surfing 3 pages) (authored by valerio.bozzolan).
Workboard: Milestone Name easily editable (instead of surfing 3 pages)
Mon, Sep 25, 06:18
valerio.bozzolan added a comment to D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).
  • we have an approval from a core contributor
  • we tested by at lest 2 persons in real-world
  • we tested also in my production for 7 months, using this intensively, without any nuclear implosion
  • nobody cares, really, nobody uses Milestones, nobody knows what a Milestone is, people also don't like Workboards, Workboards are evil persons for much core contributors, so we will never receive more feedback here automagically, if we have not received these in 7 months
  • since this change is online since the 11st of February (!) :D and since I waited 2 weeks to be kind after approval, ...
Mon, Sep 25, 06:16
valerio.bozzolan updated the task description for T15535: Using Differential with plain Git, without requiring Arc.
Mon, Sep 25, 06:01 · Feature Requests

Sun, Sep 24

waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

Should I go ahead and submit a different patch? Or could I somehow contribute the edit to this patch?

Sun, Sep 24, 09:14
waldyrious updated the title for P23 xhpast error from xhpast error (two commands and their output) to xhpast error.
Sun, Sep 24, 09:11
waldyrious created P23 xhpast error.
Sun, Sep 24, 09:08

Sat, Sep 23

revi awarded D25440: Show Deprecation Warnings as Setup Warnings a Party Time token.
Sat, Sep 23, 21:03
avivey added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

So would the latter option mean doing $html_details = array($head, $more, implode(' ', $exceptions)); here? I kind of find this approach cleaner than appending a space to each item in the $exceptions array.

Sat, Sep 23, 14:55
waldyrious added inline comments to D25425: Remove mention of Phabricator in the Auth setup check.
Sat, Sep 23, 14:29
waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

The value of moreInfo here is a list (array) of 3 things, (https://we.phorge.it/source/phorge/browse/master/src/applications/policy/filter/PhabricatorPolicyFilter.php;4f845d8f8c77$702) - $head, $more and $exceptions, and I'm guessing from context that the appendList() creates one <ul> for the list and one <li> for each item in the list - so $exceptions at this point is a single thing.

Sat, Sep 23, 13:56
avivey added inline comments to D25363: Match yourself from Imported Events Invitees.
Sat, Sep 23, 09:05
avivey added a project to T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land": UX.

I don't think we have a specific task for "general UI text improvements" - there's the UX project, but "improve UX" is an ongoing process, so I don't think a single parent task is a good match.

Sat, Sep 23, 06:11 · UX, Differential
avivey updated the task description for T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".
Sat, Sep 23, 05:53 · UX, Differential
avivey added a comment to T15512: Reimplement "Flags" to be based on Edges.

Interestingly: https://secure.phabricator.com/T10574 argues for removal of the additional data from edges.

Sat, Sep 23, 05:36
avivey added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

... whereas the $html_details is constructed as merely array($head, $more, $exceptions); ...

Sat, Sep 23, 05:07

Fri, Sep 22

waldyrious added a comment to T15270: "Access Denied: Restricted File" strings concatenated without whitespace.

For others reading this thread: there's some discussion going on in the thread of the patch linked above, D25419.

Fri, Sep 22, 22:26 · Good Starter Task, Files
waldyrious updated the task description for T15644: Support backticks in inline and block code by wrapping with multiple backticks.
Fri, Sep 22, 22:22 · Feature Requests, Remarkup
waldyrious created T15644: Support backticks in inline and block code by wrapping with multiple backticks.
Fri, Sep 22, 22:17 · Feature Requests, Remarkup
waldyrious added a comment to T15643: Support marking text with <ins> in Remarkup.

Note: the <ins> tag is typically rendered as underlined text, so this would be very similar to the <u> formatting that is produced with __foobar__foobar. In fact, it might be worth repurposing that rule to produce <ins> instead, since ~~foobar~~ actually creates a semantic <del> tag rather than the presentational equivalent <s> (strikethrough) tag.

Fri, Sep 22, 21:58 · Feature Requests, Remarkup
waldyrious created T15643: Support marking text with <ins> in Remarkup.
Fri, Sep 22, 21:47 · Feature Requests, Remarkup
waldyrious added a comment to T15245: Continue bulleted/numbered list during new line.

Ugh. I added this to the UX project but forgot to remove the test content from the comment box, so my changes ended up coupled with a comment that said "- List Item". I tried to delete the comment but now it looks weird like some sort of redacted content :( anway, though I'd leave the note here in case anyone is confused with the deleted comment.

Fri, Sep 22, 21:36 · UX, Feature Requests, Remarkup
waldyrious added a project to T15245: Continue bulleted/numbered list during new line: UX.
Fri, Sep 22, 21:34 · UX, Feature Requests, Remarkup
waldyrious awarded T15245: Continue bulleted/numbered list during new line a Like token.
Fri, Sep 22, 21:33 · UX, Feature Requests, Remarkup
waldyrious added a comment to T15225: Conpherence: add a dedicated "Send" button (not just the Enter key).

It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message. I was caught off-guard by this at least once. So perhaps the text entry box should be made single-line by default (as already happens if the screen is narrow enough) and expand as needed if line breaks are added.

Fri, Sep 22, 21:29 · Conpherence, Mobile, User-valerio.bozzolan, UX
waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

@valerio.bozzolan I actually think the right place to look at the usage of getSpecialRules() might be here: https://we.phorge.it/source/phorge/browse/master/src/applications/policy/filter/PhabricatorPolicyFilter.php;4f845d8f8c77$693-719

Fri, Sep 22, 21:25
waldyrious awarded T15270: "Access Denied: Restricted File" strings concatenated without whitespace a Like token.
Fri, Sep 22, 20:38 · Good Starter Task, Files