Screenshot before (M17) and after (M18) applying D25600:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Yesterday
Thu, Apr 18
Yeah, that might help (like specifically in the case of the Clone dialog) even though it wouldn't help with dialogs containing writable inputs. (E.g. on the repository page, click Flag For Later instead and press Shift+Tab and Escape.) A better fix would lie at https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/externals/javelin/lib/Workflow.js$413 where either the getSpecialKey would need improvement itself to return true for these non-modifying keys, or it would need to be amended with a custom check in that regard. However, I don't know where that function comes from.
Probably something here should be expanded to check if the form contains at least a visible input without read-only
Thanks, created as T15788
You are now in the family of Trusted Contributors 🎇
Wed, Apr 17
Thanks again avivey. I liked the idea of using applyExternalEffects(). I have not found a way to do it efficiently, without introducing another static method.
(Credit to bekay indeed)
Nice :) Thanks
Bonus point: maybe instead of "#123" we can use "#L123" since both GitLab and GitHub uses that (and that's not a stupid specification). Just because we can.
If we find 10 minutes, let's test this on every provider, as last time it gave us a little surprise on one of them
Tue, Apr 16
You are right of course!
Yeah, there are some malformed URLs we should tackle for sure.
Thanks! It worked now! As mentioned in the chat, I'm quite sure that point n.3 and n.4 should be swapped in the README
I have edited the answer. Because with draw.io you can integrate Mermaid out of the box. With R5 you can start using the syntax like instantly.
In T15749#16629, @avivey wrote:Maybe put the warning above the box, so it catches all actions, not just comments?
Seems to happen in upstream per duplicate, thus reopening