Page MenuHomePhorge
Feed All Stories

Sun, Jun 16

mturdus closed Q139: Add remarkup syntax help for custom remarkup rule tokens as resolved.
Sun, Jun 16, 17:22 · Extension Development
mturdus added Q139: Add remarkup syntax help for custom remarkup rule tokens (Answer 172).
Sun, Jun 16, 17:22
avivey updated the question details for Q139: Add remarkup syntax help for custom remarkup rule tokens.
Sun, Jun 16, 15:49 · Extension Development
avivey added Q139: Add remarkup syntax help for custom remarkup rule tokens (Answer 171).
Sun, Jun 16, 15:44
avivey added Q138: SAML 2.0 support (Answer 170).
Sun, Jun 16, 15:33
mturdus updated the task description for T15858: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Sun, Jun 16, 15:24 · Feature Requests
mturdus updated the diff for D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.

Updating D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy

Sun, Jun 16, 15:21
avivey added a comment to D25546: Warn in comment field if task is closed as duplicate.

I still don't like the solution of using place-holder text for that; But this implementation also adds another DB access which I think is redundant.

Sun, Jun 16, 09:16
avivey added a comment to D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.

Instead of this diff, can you add a modern endpoint that uses the EditEngine/transactions? e.g. maniphest.edit, badge.edit, etc.
That will need a different name, but will allow full editing capability.

Sun, Jun 16, 07:53

Sat, Jun 15

mturdus requested review of D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Sat, Jun 15, 15:03
mturdus added a revision to T15858: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy: D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Sat, Jun 15, 15:03 · Feature Requests
mturdus created T15858: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Sat, Jun 15, 15:00 · Feature Requests
mturdus closed T15857: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email as Resolved by committing rP000bccf8e4f7: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending….
Sat, Jun 15, 13:14
mturdus closed D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.
Sat, Jun 15, 13:14
mturdus committed rP000bccf8e4f7: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending….
Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending…
Sat, Jun 15, 13:14
speck accepted D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.

Thank you!

Sat, Jun 15, 13:12
mturdus retitled D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email from Fix PHP 8.1 "strlen(null)" exception in Diviner when sending email via SMTP
Sat, Jun 15, 12:43
mturdus requested review of D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.
Sat, Jun 15, 12:40
mturdus added a revision to T15857: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email: D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.
Sat, Jun 15, 12:40
mturdus created T15857: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.
Sat, Jun 15, 12:39
Jack_who_built_the_house attached a referenced file: F2228581: image.png.
Sat, Jun 15, 01:39 · Accessibility, Phorge
Jack_who_built_the_house updated subscribers of T15856: Links cannot be navigated using keyboard.

I have this look on Windows for

a {
  outline-style: auto;
}
Last ChromeLast Firefox
image.png (486×806 px, 54 KB)
image.png (475×800 px, 44 KB)
Sat, Jun 15, 01:35 · Accessibility, Phorge
aklapper added a comment to T15856: Links cannot be navigated using keyboard.

This is the same as Q132: Why is there an `outline-style: none;` declaration for all links within Phorge/Phabricator?

Sat, Jun 15, 00:39 · Accessibility, Phorge

Fri, Jun 14

Jack_who_built_the_house created T15856: Links cannot be navigated using keyboard.
Fri, Jun 14, 19:08 · Accessibility, Phorge
aklapper added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

Cleaner attempt in D25546 Diff 2113.

Fri, Jun 14, 05:51 · Feature Requests
aklapper updated the test plan for D25546: Warn in comment field if task is closed as duplicate.
Fri, Jun 14, 05:50
aklapper updated the diff for D25546: Warn in comment field if task is closed as duplicate.

Allow to setEditEngine when constructing a PhabricatorApplicationTransactionCommentView

Fri, Jun 14, 05:49

Thu, Jun 13

mturdus asked Q139: Add remarkup syntax help for custom remarkup rule tokens.
Thu, Jun 13, 19:15 · Extension Development
aklapper added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

Thanks for the pointers, I really appreciate them.

Thu, Jun 13, 15:04 · Feature Requests
aklapper added a comment to D25676: Fix responsible authors in DifferentialRevisionQuery.

Ah, thanks, makes sense now. I'd probably rephrase "but harms the authors constraint" a little bit to explicitly cover what you explained well in D25676#18549 - an author PHID in $this->responsibles might not always be a member of a project or owner of a package, so the query results were incomplete beforehand.

Thu, Jun 13, 09:55
zhe awarded Q138: SAML 2.0 support a Orange Medal token.
Thu, Jun 13, 03:43 · Feature Requests

Wed, Jun 12

pppery claimed T15840: Don't give bad password advice when resetting password.
Wed, Jun 12, 04:01
pppery changed the status of T15840: Don't give bad password advice when resetting password from Spite to Resolved by committing rP1bb7422662ac: Reword joke password reset email message.
Wed, Jun 12, 03:59
pppery closed D25671: Reword joke password reset email message.
Wed, Jun 12, 03:59
pppery committed rP1bb7422662ac: Reword joke password reset email message.
Reword joke password reset email message
Wed, Jun 12, 03:59

Tue, Jun 11

aklapper closed T15853: PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Tue, Jun 11, 20:52 · PHP 8 support
aklapper closed T15853: PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block as Resolved by committing rP8f361810737c: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.
Tue, Jun 11, 20:52 · PHP 8 support
aklapper closed D25689: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.
Tue, Jun 11, 20:52
aklapper committed rP8f361810737c: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.
Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block
Tue, Jun 11, 20:52
aklapper updated the test plan for D25689: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.
Tue, Jun 11, 20:50
speck added inline comments to D25690: Fix "Undefined offset: 1" exception in Diviner when @task value in PHPDoc is a single word.
Tue, Jun 11, 17:17
speck accepted D25689: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.

Ah I see below it assumes string. Thanks!

Tue, Jun 11, 17:15
speck added a comment to D25689: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.

Is it possible tasks isn’t a string in this case, where non_empty_scalar might be more of a match?

Tue, Jun 11, 17:13
speck accepted D25687: Display same items in mobile menu on User Profile page as on desktop.

seems good, ty!

Tue, Jun 11, 17:11
valerio.bozzolan updated the summary of D25691: Fix arc diff in Subversion for non-English languages.
Tue, Jun 11, 16:11
valerio.bozzolan updated the summary of D25691: Fix arc diff in Subversion for non-English languages.
Tue, Jun 11, 16:10
valerio.bozzolan requested review of D25691: Fix arc diff in Subversion for non-English languages.
Tue, Jun 11, 16:09
valerio.bozzolan added a revision to T15855: Fix "arc diff" in Subversion for non-English languages: D25691: Fix arc diff in Subversion for non-English languages.
Tue, Jun 11, 16:09 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan triaged T15855: Fix "arc diff" in Subversion for non-English languages as Normal priority.
Tue, Jun 11, 16:06 · Bug Reports, User-valerio.bozzolan, Arcanist
mturdus closed D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings).
Tue, Jun 11, 15:09
mturdus committed rP214988fafd75: T15774: Celerity: javascript minification issue with template literals….
T15774: Celerity: javascript minification issue with template literals…
Tue, Jun 11, 15:09
aklapper closed D25642: Initialize $cache_key variable in CelerityResourceController.php.
Tue, Jun 11, 11:55
aklapper committed rPc1d86da5b209: Initialize $cache_key variable in CelerityResourceController.php.
Initialize $cache_key variable in CelerityResourceController.php
Tue, Jun 11, 11:55
valerio.bozzolan accepted D25642: Initialize $cache_key variable in CelerityResourceController.php.

Thanks. Moreover, looking at PhutilKeyValueCache it seems that setKey(null) has no sense. So thanks also for that extra care you already set.

Tue, Jun 11, 10:58
aklapper requested review of D25690: Fix "Undefined offset: 1" exception in Diviner when @task value in PHPDoc is a single word.
Tue, Jun 11, 09:40
aklapper added a revision to T15854: "Undefined array key 1" exception when @task in PHPDoc is a single string: D25690: Fix "Undefined offset: 1" exception in Diviner when @task value in PHPDoc is a single word.
Tue, Jun 11, 09:40
aklapper created T15854: "Undefined array key 1" exception when @task in PHPDoc is a single string.
Tue, Jun 11, 09:38
aklapper accepted D25619: Fixes overflowing of AphrontSideNavFilterView on small screens and tidies up nav bar styles.

Hi bekay, thanks for looking into this, very appreciated!

Tue, Jun 11, 08:50
aklapper retitled D25689: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block from Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has single @task block
Tue, Jun 11, 05:56
aklapper renamed T15853: PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block from PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has single @task block to PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.
Tue, Jun 11, 05:55 · PHP 8 support

Mon, Jun 10

aklapper requested review of D25689: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.
Mon, Jun 10, 23:18
aklapper added a revision to T15853: PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block: D25689: Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.
Mon, Jun 10, 23:18 · PHP 8 support
aklapper created T15853: PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block.
Mon, Jun 10, 23:17 · PHP 8 support
aklapper requested review of D25688: Fix broken URIs on "Rendering HTML" Diviner page.
Mon, Jun 10, 23:13
aklapper closed T15852: PHP 8.1 "preg_match(null)"/"strlen(null)" exceptions importing ics file with no attendee names into calendar as Resolved by committing rP10cb2521630a: Fix PHP 8.1 exceptions importing ICS file without attendee names.
Mon, Jun 10, 22:54
aklapper closed D25686: Fix PHP 8.1 exceptions importing ICS file without attendee names.
Mon, Jun 10, 22:54
aklapper committed rP10cb2521630a: Fix PHP 8.1 exceptions importing ICS file without attendee names.
Fix PHP 8.1 exceptions importing ICS file without attendee names
Mon, Jun 10, 22:54
aklapper abandoned D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

There is no reason to expose "Manage" for admins only. I'm abandoning this in favor of D25687.

Mon, Jun 10, 22:46
aklapper requested review of D25687: Display same items in mobile menu on User Profile page as on desktop.
Mon, Jun 10, 22:46
aklapper added a revision to T15224: Mobile hamburger menu in User Profile page contains only useless stuff: D25687: Display same items in mobile menu on User Profile page as on desktop.
Mon, Jun 10, 22:46 · User-valerio.bozzolan, People, User-Cigaryno, Mobile
valerio.bozzolan accepted D25686: Fix PHP 8.1 exceptions importing ICS file without attendee names.

I will then need a rebase for D25363

Mon, Jun 10, 22:20
aklapper updated the summary of D25686: Fix PHP 8.1 exceptions importing ICS file without attendee names.
Mon, Jun 10, 18:29
aklapper requested review of D25686: Fix PHP 8.1 exceptions importing ICS file without attendee names.
Mon, Jun 10, 17:13
aklapper added a revision to T15852: PHP 8.1 "preg_match(null)"/"strlen(null)" exceptions importing ics file with no attendee names into calendar: D25686: Fix PHP 8.1 exceptions importing ICS file without attendee names.
Mon, Jun 10, 17:13
aklapper created T15852: PHP 8.1 "preg_match(null)"/"strlen(null)" exceptions importing ics file with no attendee names into calendar.
Mon, Jun 10, 17:08
aklapper added a comment to D25363: Match yourself from Imported Events Invitees.

Could you clarify if this is only supposed to work for import an .ics URI and not for importing a single event via an .ics file? Maybe I'm overcomplicating things, what I tried:

Mon, Jun 10, 16:13
aklapper added a comment to D25363: Match yourself from Imported Events Invitees.

I admit I am quite interested in the changes in src/applications/people/query/PhabricatorPeopleUserEmailQuery.php adding $userPhids and $isVerified as I have a downstream use case for them.
Would be lovely to get them in, nevertheless where the actual calendar feature request is going.

Mon, Jun 10, 16:13
aklapper created P42 D25363.ics testcase.
Mon, Jun 10, 16:08
aklapper updated the diff for D25668: Add Open Graph protocol meta tags to Maniphest task pages.

Use PhabricatorMarkupEngine::summarizeSentence() instead of mb_substr().

Mon, Jun 10, 15:13
valerio.bozzolan added inline comments to D25668: Add Open Graph protocol meta tags to Maniphest task pages.
Mon, Jun 10, 14:59
Wikivu accepted D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

thanks you

Mon, Jun 10, 09:05

Sun, Jun 9

valerio.bozzolan added a comment to D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

To me it makes sense thanks. Maybe just add a comment somewhere to say that the menu should be automatically generated - T15224

Sun, Jun 9, 09:18
aklapper added a comment to D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

Sun, Jun 9, 08:57
avivey added a comment to T15724: PHP 8.3: ldap_connect() call signature deprecated.

So PHP, very wow

Sun, Jun 9, 06:54 · PHP 8 support

Sat, Jun 8

pppery added a project to T15724: PHP 8.3: ldap_connect() call signature deprecated: PHP 8 support.
Sat, Jun 8, 23:59 · PHP 8 support
pppery added a project to T15757: Arcanist Test Result Parser Updates: Arcanist.
Sat, Jun 8, 23:58 · Arcanist
pppery added a project to T15772: Task with graph issue won't show: Maniphest.
Sat, Jun 8, 23:58 · Maniphest
pppery added projects to T15790: Exception creating a "Diffusion Raw Commits" Dashboard query panel: Dashboards, Diffusion.
Sat, Jun 8, 23:58 · Diffusion, Dashboards
pppery added a project to T15811: Search exception when AM/PM string is localized in Calendar application: Calendar.
Sat, Jun 8, 23:57 · Calendar
pppery added a project to T15843: Allow collapse and expand of workboard columns in mobile view: Workboard.
Sat, Jun 8, 23:56 · Workboard
aklapper closed D25683: Only display "Calendar" entry in user profile page menu on mobile when Calendar application is installed.
Sat, Jun 8, 08:02
aklapper committed rPa83ba95445e1: Only display "Calendar" entry in user profile page menu on mobile when Calendar….
Only display "Calendar" entry in user profile page menu on mobile when Calendar…
Sat, Jun 8, 08:02

Fri, Jun 7

valerio.bozzolan added a comment to D25622: Transformed Pictures: make them non-orphan.

Test plan: I finished my ideas. It seems it just work 🤔

Fri, Jun 7, 20:34
valerio.bozzolan added a comment to D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

Fri, Jun 7, 20:13
avivey added a comment to D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

As T15224 suggest, this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

Fri, Jun 7, 19:58
valerio.bozzolan accepted D25685: Allow admins to access "Manage" page from user profile page menu on mobile.
Fri, Jun 7, 19:33
valerio.bozzolan added a comment to D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

Better than before.

Fri, Jun 7, 19:33
valerio.bozzolan accepted D25683: Only display "Calendar" entry in user profile page menu on mobile when Calendar application is installed.

all those tears shed by devastated users after clicking the Calendar menu item

Fri, Jun 7, 19:31
pppery closed D25684: Remove PhutilPhtTestCase::getDateTranslations().
Fri, Jun 7, 19:10
pppery committed rARCf7fcf31c7e23: Remove PhutilPhtTestCase::getDateTranslations().
Remove PhutilPhtTestCase::getDateTranslations()
Fri, Jun 7, 19:10