Page MenuHomePhorge
Feed All Stories

Today

valerio.bozzolan added a project to T15742: When creating a Diffusion Repo, add helpful text to each field: UX.
Mon, Dec 2, 17:37 · UX, Diffusion
l2dy added a comment to T15062: Introducing Phixator 2.

Is the extension still maintained? While there is no extension store yet, it's possible to host repositories here. https://we.phorge.it/w/docs/extensions/phactory/

Mon, Dec 2, 13:58 · Phactory: Community Projects
aklapper reopened T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Open.
Mon, Dec 2, 09:28 · PHP 8 support
aklapper reopened T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated as Open by committing rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….
Mon, Dec 2, 09:28 · PHP 8 support
aklapper closed T15963: LDAP over TLS is broken as Resolved by committing rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….
Mon, Dec 2, 09:28 · Bug Reports, Auth
aklapper closed D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".
Mon, Dec 2, 09:28
aklapper added a reverting change for D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception: rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….
Mon, Dec 2, 09:28
aklapper committed rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….
Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"…
Mon, Dec 2, 09:28
aklapper added a reverting change for rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception: rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….
Mon, Dec 2, 09:28
valerio.bozzolan added a revision to T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated: D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".
Mon, Dec 2, 06:48 · PHP 8 support
valerio.bozzolan updated the summary of D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".
Mon, Dec 2, 06:48
valerio.bozzolan accepted D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".
Mon, Dec 2, 06:47
aklapper requested review of D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".
Mon, Dec 2, 00:28
aklapper added a reverting change for rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception: D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".
Mon, Dec 2, 00:28
aklapper added a reverting change for D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception: D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".
Mon, Dec 2, 00:28
aklapper added a revision to T15963: LDAP over TLS is broken: D25842: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception".
Mon, Dec 2, 00:28 · Bug Reports, Auth

Yesterday

pppery updated the diff for D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Add the newlline

Sun, Dec 1, 20:37
taavi added a project to T15963: LDAP over TLS is broken: Bug Reports.
Sun, Dec 1, 14:11 · Bug Reports, Auth
taavi added a comment to D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.

this unfortunately caused T15963: LDAP over TLS is broken :/

Sun, Dec 1, 14:08
taavi created T15963: LDAP over TLS is broken.
Sun, Dec 1, 14:08 · Bug Reports, Auth
valerio.bozzolan added a comment to D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

(I still need to understand the old intentions on the old regex, and the new one, but it seems much magically readable, thanks)

Sun, Dec 1, 11:21

Sat, Nov 30

valerio.bozzolan accepted D25841: Account registration: Restrict Real Name length.

Double slam accept

Sat, Nov 30, 13:01
aklapper updated the diff for D25841: Account registration: Restrict Real Name length.

Simplify return of validateRealName() as proposed by Valerio

Sat, Nov 30, 12:17

Fri, Nov 29

valerio.bozzolan triaged T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php as Normal priority.
Fri, Nov 29, 18:47 · Affects-Wikimedia
valerio.bozzolan updated the task description for T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.
Fri, Nov 29, 18:47 · Affects-Wikimedia
valerio.bozzolan added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

BTW I think the page is reached by a crawler that is visiting a branch root on a specific commit:

Fri, Nov 29, 18:42 · Affects-Wikimedia
valerio.bozzolan added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

Fri, Nov 29, 18:36 · Affects-Wikimedia
valerio.bozzolan accepted D25841: Account registration: Restrict Real Name length.

sgtm. Thanks :) just that comment

Fri, Nov 29, 18:11
aklapper updated the diff for D25841: Account registration: Restrict Real Name length.

Thanks for catching that! Amend in new PhutilNumber()

Fri, Nov 29, 14:33
aklapper updated the summary of D25841: Account registration: Restrict Real Name length.
Fri, Nov 29, 14:30
l2dy added inline comments to D25841: Account registration: Restrict Real Name length.
Fri, Nov 29, 14:29
aklapper requested review of D25841: Account registration: Restrict Real Name length.
Fri, Nov 29, 14:22
aklapper added a revision to T15962: Account registration: Handle too long Real Name more gracefully: D25841: Account registration: Restrict Real Name length.
Fri, Nov 29, 14:22
aklapper created T15962: Account registration: Handle too long Real Name more gracefully.
Fri, Nov 29, 13:54
aklapper added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

Finally got a reproducer URI in downstream:

Fri, Nov 29, 12:36 · Affects-Wikimedia
Siz3r303 awarded F2660661: profile a Pirate Logo token.
Fri, Nov 29, 01:45

Thu, Nov 28

aklapper awarded T15961: Should we adopt modern PHP type hints in Phorge source code? a Like token.
Thu, Nov 28, 16:55 · Phorge Development Tools, Discussion Needed
valerio.bozzolan awarded T15961: Should we adopt modern PHP type hints in Phorge source code? a Like token.
Thu, Nov 28, 14:34 · Phorge Development Tools, Discussion Needed
aklapper closed T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)" as Resolved by committing rPa68b8daafde3: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.
Thu, Nov 28, 11:41 · Herald
aklapper closed D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.
Thu, Nov 28, 11:41
aklapper committed rPa68b8daafde3: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.
Avoid "Unknown Object (????)" for custom Select field values in Herald editor
Thu, Nov 28, 11:41
aklapper added a comment to D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.

Maybe relevant but PhabricatorObjectHandleData seems to do some magic

Thu, Nov 28, 11:40
valerio.bozzolan closed Q158: Is there a way to create a task in Maniphest via a webhook? as resolved.
Thu, Nov 28, 09:01 · Maniphest
arp awarded Q158: Is there a way to create a task in Maniphest via a webhook? a Like token.
Thu, Nov 28, 04:16 · Maniphest
20after4 added a comment to Q158: Is there a way to create a task in Maniphest via a webhook? (Answer 198).

Yes maniphest.edit is the modern way to do it.

Thu, Nov 28, 03:13
20after4 updated the task description for T15961: Should we adopt modern PHP type hints in Phorge source code?.
Thu, Nov 28, 03:10 · Phorge Development Tools, Discussion Needed
20after4 created T15961: Should we adopt modern PHP type hints in Phorge source code?.
Thu, Nov 28, 03:10 · Phorge Development Tools, Discussion Needed

Wed, Nov 27

valerio.bozzolan added a comment to D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.

Maybe relevant but PhabricatorObjectHandleData seems to do some magic about filling PhabricatorObjectHandle with stuff like the name.

Wed, Nov 27, 06:35
valerio.bozzolan accepted D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.

Thanks for the comment

Wed, Nov 27, 06:32

Tue, Nov 26

aklapper updated the task description for T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)".
Tue, Nov 26, 18:39 · Herald
taavi accepted D25839: Fix parsing of incoming mail with UTF-8 encoded headers.

Works on my machine!

Tue, Nov 26, 15:19
aklapper closed T15943: Calendar: Call to a member function format() on null at $this->getQueryDateFrom($query)->getDateTime() as Resolved by committing rP89be7a51d8c8: Validate some user provided calendar query range dates.
Tue, Nov 26, 14:12 · Calendar
aklapper committed rP89be7a51d8c8: Validate some user provided calendar query range dates.
Validate some user provided calendar query range dates
Tue, Nov 26, 14:12
aklapper closed D25825: Validate some user provided calendar query range dates.
Tue, Nov 26, 14:12
valerio.bozzolan accepted D25825: Validate some user provided calendar query range dates.

Thanks :)

Tue, Nov 26, 14:03
aklapper closed D25840: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4.
Tue, Nov 26, 14:02
aklapper committed rPb253675917c6: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4.
mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4
Tue, Nov 26, 14:02
aklapper updated the diff for D25825: Validate some user provided calendar query range dates.

Also update the PhpDoc accordingly

Tue, Nov 26, 14:01
aklapper updated the diff for D25825: Validate some user provided calendar query range dates.

Ignore PHP 8.3.0's new DateMalformedStringException and stick to generic Exception in all cases instead

Tue, Nov 26, 13:59
valerio.bozzolan accepted D25840: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4.

sgtm

Tue, Nov 26, 13:59
aklapper requested review of D25840: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4.
Tue, Nov 26, 13:53
aklapper added a comment to T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them.

@taavi: Uhm, thanks! If you have a chance to test D25839 that would be great. :)

Tue, Nov 26, 13:48 · Bug Reports
aklapper requested review of D25839: Fix parsing of incoming mail with UTF-8 encoded headers.
Tue, Nov 26, 13:47
aklapper added a revision to T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them: D25839: Fix parsing of incoming mail with UTF-8 encoded headers.
Tue, Nov 26, 13:47 · Bug Reports
aklapper edited the content of Next Up.
Tue, Nov 26, 13:12
aklapper closed T15916: Conduit maniphest.gettasktransactions: include metadata and title, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Tue, Nov 26, 13:08 · Discussion Needed, Affects-Wikimedia
aklapper closed T15916: Conduit maniphest.gettasktransactions: include metadata and title as Resolved by committing rP6ec5c88bee24: Make maniphest.gettasktransactions include metadata and title.
Tue, Nov 26, 13:08 · Maniphest, Affects-Wikimedia
aklapper committed rP6ec5c88bee24: Make maniphest.gettasktransactions include metadata and title.
Make maniphest.gettasktransactions include metadata and title
Tue, Nov 26, 13:08
aklapper closed D25777: Make maniphest.gettasktransactions include metadata and title.
Tue, Nov 26, 13:08
avivey awarded T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them a Burninate token.
Tue, Nov 26, 13:08 · Bug Reports
aklapper closed D25827: Allow zooming on pages.
Tue, Nov 26, 13:07
aklapper closed T15945: Allow zooming Phorge pages on mobile as Resolved by committing rP828ea9bca030: Allow zooming on pages.
Tue, Nov 26, 13:07 · Accessibility
aklapper committed rP828ea9bca030: Allow zooming on pages.
Allow zooming on pages
Tue, Nov 26, 13:07
aklapper closed T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Tue, Nov 26, 13:05 · PHP 8 support
aklapper closed T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated as Resolved by committing rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.
Tue, Nov 26, 13:05 · PHP 8 support
aklapper closed D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.
Tue, Nov 26, 13:05
aklapper committed rP700090917af6: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.
Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception
Tue, Nov 26, 13:05
aklapper requested review of D25835: Strip surrounding whitespace from project and task titles.
Tue, Nov 26, 13:03
aklapper updated the diff for D25835: Strip surrounding whitespace from project and task titles.

Handle whitespace-only task and project titles correctly

Tue, Nov 26, 13:02
aklapper updated the test plan for D25835: Strip surrounding whitespace from project and task titles.
Tue, Nov 26, 13:00
aklapper planned changes to D25835: Strip surrounding whitespace from project and task titles.

This needs rework as the logic currently does not properly handle entering a title consisting of whitespace only. (Outcome gets unpleasant afterwards.)

Tue, Nov 26, 12:52
aklapper closed D25837: Fix a typo in documentation.
Tue, Nov 26, 10:44
aklapper committed rPc0ebc7b405c2: Fix a typo in documentation.
Fix a typo in documentation
Tue, Nov 26, 10:44

Mon, Nov 25

BlankEclair closed T15914: Doing Ctrl+Enter on forms do not cause them to open in a new tab as Resolved by committing rP0ea95d41a67f: Fix submitting forms in a new tab using Ctrl+Return.
Mon, Nov 25, 10:09
BlankEclair closed D25773: Fix submitting forms in a new tab using Ctrl+Return.
Mon, Nov 25, 10:09
BlankEclair committed rP0ea95d41a67f: Fix submitting forms in a new tab using Ctrl+Return.
Fix submitting forms in a new tab using Ctrl+Return
Mon, Nov 25, 10:09
BlankEclair asked Q159: Is MFA requiring all factors intentional?.
Mon, Nov 25, 10:06

Sun, Nov 24

taavi added a project to T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them: Bug Reports.
Sun, Nov 24, 16:54 · Bug Reports
taavi created T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them.
Sun, Nov 24, 16:48 · Bug Reports
avivey accepted D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.

It might be slightly safer to use PhutilURI, but this is in any case a potentially-unsafe configuration.

Sun, Nov 24, 09:32
l2dy edited the content of Organizations Using Phorge.
Sun, Nov 24, 08:37

Sat, Nov 23

pppery added a comment to D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

https://devina.io/redos-checker says the new regex is still prone to polynomial backtracking, but that can happen only on extremely contrived input, whereas the old one was exponential on a common case.

Sat, Nov 23, 21:22
pppery claimed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.
Sat, Nov 23, 21:17 · Bug Reports, Remarkup, Affects-Wikimedia
pppery renamed T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing from RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing to RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.
Sat, Nov 23, 21:17 · Bug Reports, Remarkup, Affects-Wikimedia
pppery updated the test plan for D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
Sat, Nov 23, 21:16
pppery updated the diff for D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.

Fix lint

Sat, Nov 23, 21:14
pppery added a revision to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing: D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
Sat, Nov 23, 21:08 · Bug Reports, Remarkup, Affects-Wikimedia
pppery requested review of D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
Sat, Nov 23, 21:08
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Digging deeper, the problem is specific to ProjectRemarkupRule::getObjectIDPattern. That returns:

Sat, Nov 23, 20:45 · Bug Reports, Remarkup, Affects-Wikimedia
pppery added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Step 2: Remove irrelevant character class exclusions:

Sat, Nov 23, 20:33 · Bug Reports, Remarkup, Affects-Wikimedia