Don't try to steal this Task to Dylsss, who proposed a very nice patch for this.

Your customization is very good.

Green light @20after4 - you can land - thank you

I agree. Having said that I'm not bold enough to propose a "default: open in same tab" since at the moment we have the exact contrary. That is why I proposed this compromise based on the destination.

In T15178#4404, @dcog wrote:

@avivey

What is the criteria for determining the intentions of various accounts and banning?

Are there any accounts that hinder notifications and general progress intentionally or is it hard to tell?

Since the context of these changes is all localized here, I think it's reasonable to use the short names (T1234), because we expect most users will see it in the context of this site. I just find the full addresses to be harder to read (I need to stop and actually read the URI to understand if this is an "internal" or "external" link).

@dcog why do you think this is a bad question?

@dcog hmm?

I agree with this, but I think we should let this wait for broader discussion - there maybe good counter-arguments.

In D25092#2806, @valerio.bozzolan wrote:

remote: This push was rejected by Herald push rule H8.
remote:     Change: commit/
remote:       Rule: Guard Arcanist Repo with Blessed Committers
remote:     Reason: Commit is not approved by Blessed Committers
remote: Transcript: https://we.phorge.it/herald/transcript/4967/

https://we.phorge.it/herald/transcript/4967/

In T15178#4406, @dcog wrote:

$1.25USD bet says @valerio.bozzolan or @Cigaryno has some weird connection to Salesforce or Jira or Mantis

Thank you for your review

simplified inline comment

make the damn linter happy

Don't mind me, I'm terrible, but I want to keep people on their toes at the same time... Also drowning with notifications could be tactic, and it doesn't take a rocket scientist to see where drowning in notifications can be an exploit if not tended

$1.25 bet says @valerio.bozzolan has some weird connection to Salesforce

Don't you hate it when the intentions are hard to determine?

What is the criteria for determining the intentions of various accounts and banning?

@Matthew thank you in the other Diff

Sure, done.

Hi @Matthew please undo your -1 so the author can land

(I accept also as O1 since somebody from O1 tried to land)

Hi @Cigaryno - I will offer you an authentic Phorge doublon for your review here

Do you want an hand to land this nice feature?

try to make a review even more simple

Damn Arcanist.

Interestingly, this modification also brings a performance improvement on calculating the length of multiple strings.

By the way, Rector.php was able to do this replacement automatically: