Page MenuHomePhorge
Feed All Stories

Yesterday

aklapper added a comment to D25600: Mark created Pholio mockups as new objects to fix empty Feed transaction entries.

Screenshot before (M17) and after (M18) applying D25600:

Screenshot from 2024-04-19 18-20-53.png (834×1 px, 162 KB)

Fri, Apr 19, 16:31
aklapper requested review of D25600: Mark created Pholio mockups as new objects to fix empty Feed transaction entries.
Fri, Apr 19, 16:30
aklapper added a revision to T15679: Pholio image upload triggers Passing null is deprecated at PhabricatorPolicyQuery.php:314: D25600: Mark created Pholio mockups as new objects to fix empty Feed transaction entries.
Fri, Apr 19, 16:30 · PHP 8 support
aklapper requested review of D25599: Fix PHP 8.1 "strlen(null)" exception mass-editing tasks when custom Date field present.
Fri, Apr 19, 15:56
aklapper added a revision to T15794: PHP 8.1 "strlen(null)" exceptions mass-editing tasks when custom Date field present: D25599: Fix PHP 8.1 "strlen(null)" exception mass-editing tasks when custom Date field present.
Fri, Apr 19, 15:56 · PHP 8 support
aklapper created T15794: PHP 8.1 "strlen(null)" exceptions mass-editing tasks when custom Date field present.
Fri, Apr 19, 15:30 · PHP 8 support
aklapper requested review of D25598: Fix exception for anonymous viewers on dashboard query panels with user-specific data.
Fri, Apr 19, 11:52
aklapper added a revision to T15792: Dashboard query panel requiring a Current Viewer throws exception when not logged in: D25598: Fix exception for anonymous viewers on dashboard query panels with user-specific data.
Fri, Apr 19, 11:52
aklapper requested review of D25597: Fix exception accessing a non-existing EditEngine.
Fri, Apr 19, 10:58
aklapper added a revision to T15793: Exception trying to access non-existing EditEngine: D25597: Fix exception accessing a non-existing EditEngine.
Fri, Apr 19, 10:58
aklapper created T15793: Exception trying to access non-existing EditEngine.
Fri, Apr 19, 09:37
aklapper updated the task description for T15792: Dashboard query panel requiring a Current Viewer throws exception when not logged in.
Fri, Apr 19, 08:37
aklapper created T15792: Dashboard query panel requiring a Current Viewer throws exception when not logged in.
Fri, Apr 19, 08:33

Thu, Apr 18

aklapper requested review of D25596: Fix PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.
Thu, Apr 18, 17:50
aklapper added a revision to T15791: PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined: D25596: Fix PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.
Thu, Apr 18, 17:50 · PHP 8 support
aklapper renamed T15791: PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined from PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel to PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.
Thu, Apr 18, 17:47 · PHP 8 support
aklapper updated the task description for T15791: PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.
Thu, Apr 18, 17:44 · PHP 8 support
aklapper created T15791: PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.
Thu, Apr 18, 17:41 · PHP 8 support
aklapper created T15790: Exception creating a "Diffusion Raw Commits" Dashboard query panel.
Thu, Apr 18, 17:40
aklapper created T15789: Exception trying to export empty task list to CSV.
Thu, Apr 18, 17:09
Mormegil added a comment to T15788: “Form data changed” confirmation is shown after even read-only keyboard interaction.

Yeah, that might help (like specifically in the case of the Clone dialog) even though it wouldn't help with dialogs containing writable inputs. (E.g. on the repository page, click Flag For Later instead and press Shift+Tab and Escape.) A better fix would lie at https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/externals/javelin/lib/Workflow.js$413 where either the getSpecialKey would need improvement itself to return true for these non-modifying keys, or it would need to be amended with a custom check in that regard. However, I don't know where that function comes from.

Thu, Apr 18, 15:40 · Bug Reports, Phorge
valerio.bozzolan added a comment to T15788: “Form data changed” confirmation is shown after even read-only keyboard interaction.

Probably something here should be expanded to check if the form contains at least a visible input without read-only

Thu, Apr 18, 15:17 · Bug Reports, Phorge
Mormegil updated Mormegil.
Thu, Apr 18, 15:15
Mormegil set Timezone to Europe/Prague on Mormegil.
Thu, Apr 18, 15:13
Mormegil closed Q127: [bug] “Form data changed” confirmation is shown after even read-only keyboard interaction as obsolete.
Thu, Apr 18, 15:11
Mormegil added a comment to Q127: [bug] “Form data changed” confirmation is shown after even read-only keyboard interaction.

Thanks, created as T15788

Thu, Apr 18, 15:11
Mormegil created T15788: “Form data changed” confirmation is shown after even read-only keyboard interaction.
Thu, Apr 18, 15:11 · Bug Reports, Phorge
valerio.bozzolan awarded Q127: [bug] “Form data changed” confirmation is shown after even read-only keyboard interaction a Yellow Medal token.
Thu, Apr 18, 14:43
valerio.bozzolan added a comment to Q127: [bug] “Form data changed” confirmation is shown after even read-only keyboard interaction.

You are now in the family of Trusted Contributors 🎇

Thu, Apr 18, 14:42
valerio.bozzolan added a member for Trusted Contributors: Mormegil.
Thu, Apr 18, 14:40
Mormegil asked Q127: [bug] “Form data changed” confirmation is shown after even read-only keyboard interaction.
Thu, Apr 18, 08:23

Wed, Apr 17

valerio.bozzolan added a comment to D25475: Drag & Drop Task Cover Image: also attach.

Thanks again avivey. I liked the idea of using applyExternalEffects(). I have not found a way to do it efficiently, without introducing another static method.

Wed, Apr 17, 16:10
aklapper closed D25592: Fix PHP 8.1 "strlen(null)" exception for "/bin/storage renamespace" without parameter.
Wed, Apr 17, 11:12
aklapper committed rP5444e1c885c3: Fix PHP 8.1 "strlen(null)" exception for "/bin/storage renamespace" without….
Fix PHP 8.1 "strlen(null)" exception for "/bin/storage renamespace" without…
Wed, Apr 17, 11:12
aklapper closed D25591: Fix PHP 8.1 "strlen(null)" exception for "/bin/almanac register" without parameter.
Wed, Apr 17, 11:12
aklapper committed rP5fe2fc33fb1c: Fix PHP 8.1 "strlen(null)" exception for "/bin/almanac register" without….
Fix PHP 8.1 "strlen(null)" exception for "/bin/almanac register" without…
Wed, Apr 17, 11:12
aklapper closed D25590: Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter.
Wed, Apr 17, 11:11
aklapper committed rPdb3e68137dcc: Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter
Wed, Apr 17, 11:11
aklapper closed D25588: Fix PHP 8.1 "strlen(null)" exception for "/bin/bulk export --query --format" without parameter.
Wed, Apr 17, 11:10
aklapper committed rP85903f968fda: Fix PHP 8.1 "strlen(null)" exception for "/bin/bulk export --query --format"….
Fix PHP 8.1 "strlen(null)" exception for "/bin/bulk export --query --format"…
Wed, Apr 17, 11:10
aklapper closed D25587: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth cache-pkcs8" without parameter.
Wed, Apr 17, 11:08
aklapper committed rP412c01ffa6fb: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth cache-pkcs8" without….
Fix PHP 8.1 "strlen(null)" exception for "/bin/auth cache-pkcs8" without…
Wed, Apr 17, 11:08
aklapper closed D25586: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter.
Wed, Apr 17, 11:08
aklapper committed rP0e53f91c9701: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter
Wed, Apr 17, 11:08
aklapper closed D25584: Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter.
Wed, Apr 17, 11:07
aklapper committed rPd630f2281bcc: Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter
Wed, Apr 17, 11:07
valerio.bozzolan reassigned T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType") from valerio.bozzolan to bekay.

(Credit to bekay indeed)

Wed, Apr 17, 08:05 · Diagrams (Extension)
valerio.bozzolan closed T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType") as Resolved.

Nice :) Thanks

Wed, Apr 17, 08:04 · Diagrams (Extension)
valerio.bozzolan closed D25593: README: run upgrade after installation.
Wed, Apr 17, 08:01
valerio.bozzolan committed R5:ce4b81b3705c: README: run upgrade after installation.
README: run upgrade after installation
Wed, Apr 17, 08:01
valerio.bozzolan added a member for Diagrams (Extension): valerio.bozzolan.
Wed, Apr 17, 08:01
aklapper closed D25595: Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as parameter.
Wed, Apr 17, 07:17
aklapper committed rP98cbf5fa19e2: Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as….
Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as…
Wed, Apr 17, 07:17
aklapper closed D25594: Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter.
Wed, Apr 17, 07:16
aklapper committed rP0bdfcc47e7de: Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter
Wed, Apr 17, 07:16
valerio.bozzolan added a comment to D25569: Avoid separate per-line URIs in line number column.

Bonus point: maybe instead of "#123" we can use "#L123" since both GitLab and GitHub uses that (and that's not a stupid specification). Just because we can.

Wed, Apr 17, 07:09
valerio.bozzolan added a comment to D25578: Fix PHP 8.1 "strlen(null)" exceptions adding an OAuth provider.

If we find 10 minutes, let's test this on every provider, as last time it gave us a little surprise on one of them

Wed, Apr 17, 06:59
valerio.bozzolan accepted D25595: Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as parameter.

yesyes

Wed, Apr 17, 06:57
valerio.bozzolan accepted D25594: Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter.

yesyes

Wed, Apr 17, 06:57

Tue, Apr 16

aklapper requested review of D25595: Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as parameter.
Tue, Apr 16, 23:05
aklapper requested review of D25594: Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter.
Tue, Apr 16, 22:58
aklapper closed D25585: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter.
Tue, Apr 16, 22:41
aklapper committed rPc59a883e9de7: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter
Tue, Apr 16, 22:41
aklapper closed D25589: Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter.
Tue, Apr 16, 22:40
aklapper committed rPb29e5aa7ca22: Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter
Tue, Apr 16, 22:40
aklapper closed D25583: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter.
Tue, Apr 16, 22:38
aklapper committed rP102c43fb6a87: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter
Tue, Apr 16, 22:38
aklapper closed D25582: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter.
Tue, Apr 16, 22:37
aklapper committed rP2c7be156a8c3: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter
Tue, Apr 16, 22:37
aklapper closed D25581: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter.
Tue, Apr 16, 22:35
aklapper committed rP9101c0b63df4: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter
Tue, Apr 16, 22:35
aklapper closed D25580: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter.
Tue, Apr 16, 22:35
aklapper committed rP6a2f2a589a0f: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter
Tue, Apr 16, 22:35
aklapper closed D25579: Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without parameter.
Tue, Apr 16, 22:29
aklapper committed rP05798a630120: Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without….
Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without…
Tue, Apr 16, 22:29
bekay accepted D25593: README: run upgrade after installation.

You are right of course!

Tue, Apr 16, 20:47
bekay added a comment to T15787: Diagrams: avoid double slash in the URL after Saving.

Yeah, there are some malformed URLs we should tackle for sure.

Tue, Apr 16, 20:45 · Diagrams (Extension)
valerio.bozzolan triaged T15787: Diagrams: avoid double slash in the URL after Saving as Low priority.
Tue, Apr 16, 20:21 · Diagrams (Extension)
valerio.bozzolan added a revision to T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType"): D25593: README: run upgrade after installation.
Tue, Apr 16, 20:19 · Diagrams (Extension)
valerio.bozzolan retitled D25593: README: run upgrade after installation from README: run upgrade after installation Ref T15745
Tue, Apr 16, 20:19
valerio.bozzolan added a reviewer for D25593: README: run upgrade after installation: bekay.
Tue, Apr 16, 20:19
valerio.bozzolan added a comment to T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType").

Thanks! It worked now! As mentioned in the chat, I'm quite sure that point n.3 and n.4 should be swapped in the README

Tue, Apr 16, 20:19 · Diagrams (Extension)
valerio.bozzolan requested review of D25593: README: run upgrade after installation.
Tue, Apr 16, 20:19
bekay added a comment to Q108: Phorge and Mermaid Js (Answer 139).

I have edited the answer. Because with draw.io you can integrate Mermaid out of the box. With R5 you can start using the syntax like instantly.

Tue, Apr 16, 18:30
bekay updated the answer details for Q108: Phorge and Mermaid Js (Answer 139).
Tue, Apr 16, 18:28
valerio.bozzolan accepted D25581: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter.

yesyes

Tue, Apr 16, 16:55
valerio.bozzolan accepted D25582: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter.

yesyes

Tue, Apr 16, 16:55
valerio.bozzolan accepted D25584: Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter.

yesyes

Tue, Apr 16, 16:55
valerio.bozzolan accepted D25585: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter.

yesyes

Tue, Apr 16, 16:54
valerio.bozzolan accepted D25579: Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without parameter.

yesyes

Tue, Apr 16, 13:05
valerio.bozzolan accepted D25580: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter.

yesyes

Tue, Apr 16, 13:05
valerio.bozzolan accepted D25583: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter.

yesyes

Tue, Apr 16, 13:02
aklapper added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

Maybe put the warning above the box, so it catches all actions, not just comments?

Tue, Apr 16, 10:44 · Feature Requests
aklapper merged T15785: Showolder page: "Undefined index: " into T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php.
Tue, Apr 16, 09:28
aklapper merged task T15785: Showolder page: "Undefined index: " into T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php.
Tue, Apr 16, 09:28 · phorge.it install, Phorge
aklapper updated the task description for T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php.
Tue, Apr 16, 09:27
valerio.bozzolan accepted D25586: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter.

yesyes

Tue, Apr 16, 09:27
aklapper reopened T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php as "Open".

Seems to happen in upstream per duplicate, thus reopening

Tue, Apr 16, 09:26
valerio.bozzolan accepted D25587: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth cache-pkcs8" without parameter.

yesyes

Tue, Apr 16, 09:26
valerio.bozzolan accepted D25588: Fix PHP 8.1 "strlen(null)" exception for "/bin/bulk export --query --format" without parameter.

yesyes

Tue, Apr 16, 09:26