Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:45.
Tags
None
Referenced Files
F2976247: D25585.1739586789.diff
Fri, Feb 14, 02:33
F2962758: D25585.1739181896.diff
Sun, Feb 9, 10:04
F2962757: D25585.1739181892.diff
Sun, Feb 9, 10:04
F2962756: D25585.1739181889.diff
Sun, Feb 9, 10:04
F2944592: D25585.1738273116.diff
Wed, Jan 29, 21:38
F2937032: D25585.1737945449.diff
Sun, Jan 26, 02:37
F2928374: D25585.1737650399.diff
Wed, Jan 22, 16:39
F2922420: D25585.1737573652.diff
Tue, Jan 21, 19:20

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/herald/management/HeraldRuleManagementWorkflow.php:36]
Test Plan

Run ../phorge/bin/herald rule: Get no strlen() error anymore but only expected output Usage Exception: Specify a rule to edit with "--rule <id|monogram>".

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable