Interesting. What's the use case you have in mind?

Interesting, I agree. Note that also #bbb is valid but I see that 6 is minimum characters.

I went down a rabbit hole while trying to add unit tests for this. Our core remarkup unit tests are pretty thorough but they only seem to cover the "core" remarkup engine and syntax. When I added a new test case for this it would pass but always caused a different test case to fail in weird ways. I haven't yet figured out what part of the unit test or engine is stateful such that my unit test alters the state in a way that breaks a later test. If I change the order that tests run in, it just causes another different test case to fail.

About your Remarkup unit tests, try to rebase. Maybe related to D25559.

In D25540#16124, @valerio.bozzolan wrote:

About your Remarkup unit tests, try to rebase. Maybe related to D25559.

Thanks, it does seem to work now!

1. Are we interested in #fff?

2. I've updated and restarted my webserver but I cannot test this 🤔 ideas? Thanks again :)

I do not understand why it does not work to me.

• I can pass the unit test
• I have the class PhutilRemarkupHexColorCodeRule
• I have arc liberate up to date
• I have restarted my local webserver

Possible cause:

I start with this Remarkup:

some red, grey and white for you: {#ff0000} {#999999} {#ffffff} Also green: {#0F0} but not this: {#0000000} or this: {#0000} asdasdasd asdsdsssss sdss

And I see that the apply($text) function receives a PhutilSafeHTML object that, casted to string, contains this value:

some red, grey and white for you:
1Z
2Z
3Z Also green:
4Z but not this:
5Z or this:
6Z asdasdasd asdsdss

So it never matches to me.

But this is strange since, again, the unit test works 🤔

LOL I only ever tested the unit test case. I forgot to add the rule to PhabricatorMarkupEngine:

$rules[] = new PhutilRemarkupHexColorCodeRule();

In D25540#16412, @valerio.bozzolan wrote:

I do not understand why it does not work to me.

• I can pass the unit test
• I have the class PhutilRemarkupHexColorCodeRule
• I have arc liberate up to date
• I have restarted my local webserver

Possible cause:

I start with this Remarkup:

some red, grey and white for you: {#ff0000} {#999999} {#ffffff} Also green: {#0F0} but not this: {#0000000} or this: {#0000} asdasdasd asdsdsssss sdss

And I see that the apply($text) function receives a PhutilSafeHTML object that, casted to string, contains this value:

some red, grey and white for you:
1Z
2Z
3Z Also green:
4Z but not this:
5Z or this:
6Z asdasdasd asdsdss

So it never matches to me.

But this is strange since, again, the unit test works 🤔

It's kind of a shame that remarkup wasn't named Pharkup.

...or Pharkdown :D

Anyway it still does not work to me in real life. Tested on a Task description or on a comment 🧐 Any idea why?

Doesn't actually work for me either after arc patch:

The test does run and pass, so something strange is up.

It's something to do with the priority - it works if the priority is 150.
Probably one of the other similar rules is interrupting (icon? Object? Maybe it thinks this is a mention of a project?)

man I didn't even consider that you could actually have a valid project named #0dba11 ... maybe the syntax should be something different. #{00ffff} perhaps?

Also apologies for not testing this locally in the phab ui, I was far too confident in my TDD.

A weird but... expandable, fast, easy possibility is introducing this syntax:

color {{{#00ffff}}}

or something like that ↑

That uses the already existing cowsay-like syntax. THANKS FOR ASKING, it's this one (see raw remarkup asd):

cowsay {{{ asd }}}

↓

figlet {{{ asd }}}

↓

I think the current syntax should be ok because it isn't normal to use {} around a project name. And my regex only matches exactly 3 or 6 hex digits, as demonstrated in the hex-color-code.txt test file.

I'm on latest master, and I'm still not able to try this 🤔 No errors. Just plaintext remarkup. Test case:

Yeah please set {#ff0000} asdasd

Yeah yeah {#ee33ee}

{#ee33e1}

I probably missed the train, so… can you add the docs for this? :-P