Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter
ClosedPublic

Authored by aklapper on Tue, Apr 16, 08:59.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 18:34
Unknown Object (File)
Sun, Apr 28, 13:55
Unknown Object (File)
Sat, Apr 27, 16:49
Unknown Object (File)
Sat, Apr 27, 16:49
Unknown Object (File)
Sat, Apr 27, 16:48
Unknown Object (File)
Sat, Apr 27, 14:01
Unknown Object (File)
Sat, Apr 27, 03:51
Unknown Object (File)
Fri, Apr 26, 23:32

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This patch also fixes another similar strlen() occurrence in the same source file.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/aphlict/management/PhabricatorAphlictManagementNotifyWorkflow.php:29]
Test Plan

Run ../phorge/bin/aphlict notify: Get no strlen() error anymore but only expected output Usage Exception: Specify a user to notify with "--user".

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable