Page MenuHomePhorge

bekay (Benjamin Kausch)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2021, 07:59 (158 w, 4 d)
Availability
Available

Recent Activity

May 24 2024

bekay added a comment to D25612: Use more css and phorge standard elements for application view.

@mturdus Can you spare some time to review this diff?

May 24 2024, 08:13 · Diagrams (Extension)

May 23 2024

bekay added a comment to D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.

Maybe "feature" but note the left sidebar, is not anymore connected to the end of the viewport:

BeforeAfter
Maniphest list before.png (643×1 px, 78 KB)
Maniphest list after.png (643×1 px, 78 KB)
May 23 2024, 09:44
bekay updated the diff for D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.

./bin/celerity map

May 23 2024, 09:43
bekay updated the diff for D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.
  • Fixes non stretching nav bar if content is absolute or does not fill entire page height
May 23 2024, 09:40

May 4 2024

bekay added a comment to D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.
In D25619#17360, @speck wrote:

Ah, yes thank you for the video. I should have clarified but was asking for screenies of the result after this change. The changes look reasonable but I’m not a regular css user

May 4 2024, 17:27
bekay attached a referenced file: F2178277: Record_2024-05-04-19-00-08.mp4.
May 4 2024, 17:09 · UX
bekay updated subscribers of T15809: Homepage will overflow on small screens when feed content is too long.

@speck here you can see the described overflowing:

May 4 2024, 17:09 · UX
bekay added a comment to T15809: Homepage will overflow on small screens when feed content is too long.

Test for feed: https://we.phorge.it/source/phorge/browse/master/src/view/layout/AphrontSideNavFilterView.php

May 4 2024, 16:54 · UX
bekay added a comment to D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.

All described here with screenshot (and now video): T15809

May 4 2024, 16:52
bekay updated the summary of D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.
May 4 2024, 13:28
bekay added a revision to T15809: Homepage will overflow on small screens when feed content is too long: D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.
May 4 2024, 13:25 · UX
bekay updated the summary of D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.
May 4 2024, 13:25
bekay requested review of D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.
May 4 2024, 13:21

May 3 2024

bekay updated the task description for T15809: Homepage will overflow on small screens when feed content is too long.
May 3 2024, 15:27 · UX
bekay updated the task description for T15809: Homepage will overflow on small screens when feed content is too long.
May 3 2024, 12:36 · UX
bekay updated the task description for T15809: Homepage will overflow on small screens when feed content is too long.
May 3 2024, 12:34 · UX
bekay triaged T15809: Homepage will overflow on small screens when feed content is too long as Normal priority.
May 3 2024, 12:33 · UX
bekay claimed T15809: Homepage will overflow on small screens when feed content is too long.

Root problem is the https://we.phorge.it/source/phorge/browse/master/src/view/layout/AphrontSideNavFilterView.php with its styles: https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/phui/phui-basic-nav-view.css

May 3 2024, 12:33 · UX
bekay created T15809: Homepage will overflow on small screens when feed content is too long.
May 3 2024, 12:28 · UX

May 2 2024

bekay added a comment to T15806: Use drawio viewer for rendering of diagrams.

I have a nice working version here, which renders the diagram with the drawio viewer javascript component:

May 2 2024, 13:40 · Diagrams (Extension)
bekay added a project to D25612: Use more css and phorge standard elements for application view: Diagrams (Extension).
May 2 2024, 13:33 · Diagrams (Extension)
bekay updated subscribers of D25612: Use more css and phorge standard elements for application view.
May 2 2024, 13:33 · Diagrams (Extension)
bekay updated the diff for D25612: Use more css and phorge standard elements for application view.
  • Fixes regression from missing html element
May 2 2024, 13:31 · Diagrams (Extension)

May 1 2024

bekay updated the test plan for D25612: Use more css and phorge standard elements for application view.
May 1 2024, 16:12 · Diagrams (Extension)
bekay requested review of D25612: Use more css and phorge standard elements for application view.
May 1 2024, 16:10 · Diagrams (Extension)
bekay updated subscribers of T15806: Use drawio viewer for rendering of diagrams.
May 1 2024, 16:09 · Diagrams (Extension)

Apr 30 2024

bekay created T15806: Use drawio viewer for rendering of diagrams.
Apr 30 2024, 14:56 · Diagrams (Extension)

Apr 16 2024

bekay accepted D25593: README: run upgrade after installation.

You are right of course!

Apr 16 2024, 20:47
bekay added a comment to T15787: Diagrams: avoid double slash in the URL after Saving.

Yeah, there are some malformed URLs we should tackle for sure.

Apr 16 2024, 20:45 · Diagrams (Extension)
bekay added a comment to Q108: Phorge and Mermaid Js (Answer 139).

I have edited the answer. Because with draw.io you can integrate Mermaid out of the box. With R5 you can start using the syntax like instantly.

Apr 16 2024, 18:30
bekay updated the answer details for Q108: Phorge and Mermaid Js (Answer 139).
Apr 16 2024, 18:28
bekay added a comment to T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType").

@valerio.bozzolan Could you try again to install it? There is a readme with new instructions.

Apr 16 2024, 07:16 · Diagrams (Extension)
bekay closed T15782: Diagrams Extension is not installable/usable in its current form as Resolved by committing R5:6fa25e4097aa: Makes extension usable with configured alternative file domain.
Apr 16 2024, 07:14 · Diagrams (Extension)
bekay closed D25577: Makes extension usable with configured alternative file domain.
Apr 16 2024, 07:14 · Diagrams (Extension)
bekay committed R5:6fa25e4097aa: Makes extension usable with configured alternative file domain.
Makes extension usable with configured alternative file domain
Apr 16 2024, 07:14
bekay added a revision to T15782: Diagrams Extension is not installable/usable in its current form: D25577: Makes extension usable with configured alternative file domain.
Apr 16 2024, 07:11 · Diagrams (Extension)
bekay updated the summary of D25577: Makes extension usable with configured alternative file domain.
Apr 16 2024, 07:11 · Diagrams (Extension)

Apr 15 2024

bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

Now it's working!

Apr 15 2024, 19:13 · Diagrams (Extension)

Apr 14 2024

bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

@mturdus right, I don't have the whole picture of this little bit wild codebase 😁 Thanks for the pointer. As far as I can see, this image and the DOMContentLoaded event handler serves no purpose anymore. All is working without it. I have renamed the main js and some functions in it for clarity. Would love if you could give it a try.

Apr 14 2024, 19:00 · Diagrams (Extension)
bekay updated the diff for D25577: Makes extension usable with configured alternative file domain.
  • Renames behavior and some functions and gets rid of unnecessary image proxy
Apr 14 2024, 18:56 · Diagrams (Extension)
bekay updated the question details for Q126: 5 Deprecation Notices in PhabricatorStandardPageView.php.
Apr 14 2024, 09:34 · Deprecation Notice
bekay updated Q126: 5 Deprecation Notices in PhabricatorStandardPageView.php from 5 Deprecation Notices PhabricatorStandardPageView to 5 Deprecation Notices in PhabricatorStandardPageView.php.
Apr 14 2024, 09:03 · Deprecation Notice
bekay closed T15781: arc liberate throws exception as Resolved.

Fixed by R5:91dd43de7dee: T15781: arc liberate throws exception

Apr 14 2024, 08:59 · Diagrams (Extension)
bekay updated subscribers of T15782: Diagrams Extension is not installable/usable in its current form.
Apr 14 2024, 08:58 · Diagrams (Extension)
bekay updated subscribers of T15784: Add title and project tags to diagram.
Apr 14 2024, 08:57 · Diagrams (Extension)
bekay updated subscribers of T15784: Add title and project tags to diagram.
Apr 14 2024, 08:57 · Diagrams (Extension)
bekay created T15784: Add title and project tags to diagram.
Apr 14 2024, 08:54 · Diagrams (Extension)
bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

@mturdus I have added some console logs in the js code (so patch and purge the caches on <phorge-base>config/cache/!)

Apr 14 2024, 08:43 · Diagrams (Extension)
bekay updated the diff for D25577: Makes extension usable with configured alternative file domain.
  • Caches draw.io assets, uses base64 method of diagram and adds some console logs for js debugging
Apr 14 2024, 08:39 · Diagrams (Extension)
bekay added a member for Diagrams (Extension): bekay.
Apr 14 2024, 08:14
bekay asked Q126: 5 Deprecation Notices in PhabricatorStandardPageView.php.
Apr 14 2024, 08:13 · Deprecation Notice
bekay added a project to D25577: Makes extension usable with configured alternative file domain: Diagrams (Extension).
Apr 14 2024, 07:39 · Diagrams (Extension)
bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

Firefox does work for me. Does Chrome work for you?

Apr 14 2024, 07:36 · Diagrams (Extension)

Apr 13 2024

bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

@mturdus You don't have to download the diff, you can do an arc patch D25577 (and you should, because I have changed something again). Mh, but I don't know why it should not work.... 🤔

Apr 13 2024, 20:03 · Diagrams (Extension)
bekay updated the summary of D25577: Makes extension usable with configured alternative file domain.
Apr 13 2024, 19:56 · Diagrams (Extension)
bekay updated the diff for D25577: Makes extension usable with configured alternative file domain.
  • Dumps base64 image data directly while remarkup rendering and adds js/css files for remarkup object rule
Apr 13 2024, 19:54 · Diagrams (Extension)
bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

@mturdus Is the phorge_extension.js file loaded?

Apr 13 2024, 19:09 · Diagrams (Extension)
bekay added a comment to T15782: Diagrams Extension is not installable/usable in its current form.

@mturdus Just test this if you like. I think this is a first step in the right direction: D25577

Apr 13 2024, 16:16 · Diagrams (Extension)
bekay requested review of D25577: Makes extension usable with configured alternative file domain.
Apr 13 2024, 16:13 · Diagrams (Extension)
bekay added a comment to T15782: Diagrams Extension is not installable/usable in its current form.

Well I have worked the entire day on this (and I see your mentioned issues)... main problem is: extension is not working with security.alternate-file-domain. That I have fixed at least for the creation/editing of diagrams. I have changed pretty much and would love to send a diff.

Apr 13 2024, 15:49 · Diagrams (Extension)

Apr 12 2024

bekay added a comment to T15782: Diagrams Extension is not installable/usable in its current form.

(Working on fixing it...)

Apr 12 2024, 20:00 · Diagrams (Extension)

Apr 11 2024

bekay updated the task description for T15782: Diagrams Extension is not installable/usable in its current form.
Apr 11 2024, 18:13 · Diagrams (Extension)
bekay created T15782: Diagrams Extension is not installable/usable in its current form.
Apr 11 2024, 18:08 · Diagrams (Extension)
bekay assigned T15781: arc liberate throws exception to mturdus.
Apr 11 2024, 16:41 · Diagrams (Extension)
bekay created T15781: arc liberate throws exception.
Apr 11 2024, 16:40 · Diagrams (Extension)

Apr 3 2024

bekay added a comment to V5: Should we remove the code-generated documents from this instance?.

I never use them, because there is no real method search. I think, we should be considering generating a documentation with a real php documention tool. But whatever we do: I think we can remove them in their current form.

Apr 3 2024, 08:06 · Diviner

Apr 2 2024

20after4 awarded D25538: Separate repository home and browse view in tab menu a Orange Medal token.
Apr 2 2024, 19:19
bekay retitled D25538: Separate repository home and browse view in tab menu from Seperate repository home and browse view in tab menu
Apr 2 2024, 14:36
bekay closed T15728: Repo home view and browse view share the same menu tab as Resolved by committing rPba835fe0eced: Seperate repository home and browse view in tab menu.
Apr 2 2024, 13:56 · Discussion Needed, Diffusion
bekay closed D25538: Separate repository home and browse view in tab menu.
Apr 2 2024, 13:56
bekay committed rPba835fe0eced: Seperate repository home and browse view in tab menu.
Seperate repository home and browse view in tab menu
Apr 2 2024, 13:56
bekay updated the summary of D25538: Separate repository home and browse view in tab menu.
Apr 2 2024, 13:40
bekay added a comment to D25538: Separate repository home and browse view in tab menu.

I'd even suggest we can go one step further, and in the Home tab show the Readme above the files (and maybe change the order/highlight some other UI elements too).

Apr 2 2024, 10:01
bekay updated the diff for D25538: Separate repository home and browse view in tab menu.
  • Moves readme to the top in home view
Apr 2 2024, 09:58
bekay added a comment to Q108: Phorge and Mermaid Js (Answer 139).

Well, my idea was to use the already implemented logic of the diagram extension and just extend it with another diagram renderer. But @mturdus is not responding 😁

Apr 2 2024, 09:17
bekay added a comment to T15744: Render html color codes in remarkup.

Well, you know what would be next level for a dev? If (s)he clicks on it, the color is copied to the clipboard. We can't use this behavior, because behaviors loose their state in the remarkup cache...

Apr 2 2024, 09:12 · Discussion Needed, Remarkup

Mar 15 2024

bekay added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

Updated Pygments with pip to 2.17.2 und cut the time in half. So yeah, that's already an improvement.

Mar 15 2024, 09:08 · Remarkup
bekay added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

Well, good to know that it is not something in the phorge codebase. Our server has pygmentize 2.14.0 - but the server itself is really not the best, so that could be an explanation. Maybe we could make some remarks about performance and keeping the versions fresh on the diviner page...

Mar 15 2024, 08:14 · Remarkup

Mar 14 2024

avivey awarded T15756: Rendering remarkup with many embedded code blocks is very slow a Manufacturing Defect? token.
Mar 14 2024, 16:45 · Remarkup
bekay created T15756: Rendering remarkup with many embedded code blocks is very slow.
Mar 14 2024, 14:46 · Remarkup

Feb 23 2024

avivey awarded Q112: Deprecation Notice from PhrictionRemarkupRule.php:194 a Like token.
Feb 23 2024, 10:51 · Deprecation Notice
bekay asked Q112: Deprecation Notice from PhrictionRemarkupRule.php:194.
Feb 23 2024, 10:11 · Deprecation Notice

Feb 21 2024

bekay added a comment to T15741: Diffusion pattern search not working as expected.

The word solution would solve it from the expecting side, you are right. Here in my company the search is used frequently and only as a plain text search. So we have to escape the special regex signs time and again. Just would be interested if this is seen as an issue by others who uses the feature.

Feb 21 2024, 12:48 · Diffusion
bekay added a comment to T15741: Diffusion pattern search not working as expected.

Thanks for the clarification. I still think we should tackle the exception.

Feb 21 2024, 12:41 · Diffusion
bekay updated the task description for T15741: Diffusion pattern search not working as expected.
Feb 21 2024, 10:52 · Diffusion
bekay created T15741: Diffusion pattern search not working as expected.
Feb 21 2024, 10:51 · Diffusion
bekay created T15740: Crumb menu wrapping is deficient.
Feb 21 2024, 10:35 · UX
bekay added a comment to T15728: Repo home view and browse view share the same menu tab.

I tried to understand the situation. Thanks.

In your opinion: on the repo view (with clone buttons) is it really important to link to the other similar "reduced" view (without clone buttons)?

Feb 21 2024, 10:15 · Discussion Needed, Diffusion

Feb 16 2024

bekay added a comment to T15048: Allow awarding Tokens to individual Comments.

Just asking for a friend: Is there some progress on this?

Feb 16 2024, 12:43 · Comments
bekay updated subscribers of Q108: Phorge and Mermaid Js (Answer 139).

Maybe this could be integrated in the Diagrams extension...? I mean: the entire infrastructure is there - you just have to decide, what lib you wanne use when creating a new diagram. @mturdus What do you think about this?

Feb 16 2024, 12:35

Feb 15 2024

bekay attached a referenced file: F1360344: image.png.
Feb 15 2024, 19:01
bekay attached a referenced file: F1368592: image.png.
Feb 15 2024, 19:01
bekay added a comment to T15673: Phorge participation at FOSDEM 2024.

TRUST ME - YOU DON'T WANT TO LISTEN MY ENGLISH :D :D

Btw now the video is here :D :D AGAIN SORRY PHORGE FOR MY MISTAKES <3 <3

https://video.fosdem.org/2024/h2215/fosdem-2024-3610-unpack-phabricator-welcome-phorge-forking-the-opinionated-open-source-project-manager.av1.webm

Feb 15 2024, 18:59 · Blessed Communicators, Phorge
bekay closed D25536: Implements copy button in clone repo modal.
Feb 15 2024, 18:38
bekay committed rP89a5d3132c94: Implements copy button in clone repo modal.
Implements copy button in clone repo modal
Feb 15 2024, 18:38
bekay updated the diff for D25536: Implements copy button in clone repo modal.
Feb 15 2024, 18:35
bekay added a comment to D25536: Implements copy button in clone repo modal.

I really have struggled to find any device in our company that can't do await/async. I strongly bevlieve it is a non issue. Let us land this thing now and see if we get any feedback of an error.

Feb 15 2024, 16:29
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • Changes the order of the variables and function calls
Feb 15 2024, 16:29
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • Extends select behavior and only select content on first click
Feb 15 2024, 16:23
bekay added a comment to D25536: Implements copy button in clone repo modal.

Again, non-blocking opinion:

Are we aware that the "async" keyword (that was never used in Phorge) may just cause a crash by syntax error (almost-immediately even without clicking?) by that kind of browsers, so, breaking the page, just because we want to provide a copy function and we want to avoid .then()?

I think we can introduce breaking changes, but it's strange to do that, now, with this minor feature.

If we are aware of this minor risk, indeed let's land.

Feb 15 2024, 10:08