Page MenuHomePhorge

bekay (Benjamin Kausch)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2021, 07:59 (132 w, 4 d)
Availability
Available

Recent Activity

Yesterday

bekay accepted D25593: README: run upgrade after installation.

You are right of course!

Tue, Apr 16, 20:47
bekay added a comment to T15787: Diagrams: avoid double slash in the URL after Saving.

Yeah, there are some malformed URLs we should tackle for sure.

Tue, Apr 16, 20:45 · Diagrams (Extension)
bekay added a comment to Q108: Phorge and Mermaid Js (Answer 139).

I have edited the answer. Because with draw.io you can integrate Mermaid out of the box. With R5 you can start using the syntax like instantly.

Tue, Apr 16, 18:30
bekay updated the answer details for Q108: Phorge and Mermaid Js (Answer 139).
Tue, Apr 16, 18:28
bekay added a comment to T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType").

@valerio.bozzolan Could you try again to install it? There is a readme with new instructions.

Tue, Apr 16, 07:16 · Diagrams (Extension)
bekay closed T15782: Diagrams Extension is not installable/usable in its current form as Resolved by committing R5:6fa25e4097aa: Makes extension usable with configured alternative file domain.
Tue, Apr 16, 07:14 · Diagrams (Extension)
bekay closed D25577: Makes extension usable with configured alternative file domain.
Tue, Apr 16, 07:14 · Diagrams (Extension)
bekay committed R5:6fa25e4097aa: Makes extension usable with configured alternative file domain.
Makes extension usable with configured alternative file domain
Tue, Apr 16, 07:14
bekay added a revision to T15782: Diagrams Extension is not installable/usable in its current form: D25577: Makes extension usable with configured alternative file domain.
Tue, Apr 16, 07:11 · Diagrams (Extension)
bekay updated the summary of D25577: Makes extension usable with configured alternative file domain.
Tue, Apr 16, 07:11 · Diagrams (Extension)

Mon, Apr 15

bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

Now it's working!

Mon, Apr 15, 19:13 · Diagrams (Extension)

Sun, Apr 14

bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

@mturdus right, I don't have the whole picture of the little bit wild codebase 😁 Thanks for the pointer. As far as I can see, this image and the DOMContentLoaded event handler serves no purpose anymore. All is working without. I have renamed the main js and some functions in it for clarity. Would love if you could give it a try.

Sun, Apr 14, 19:00 · Diagrams (Extension)
bekay updated the diff for D25577: Makes extension usable with configured alternative file domain.
  • Renames behavior and some functions and gets rid of unnecessary image proxy
Sun, Apr 14, 18:56 · Diagrams (Extension)
bekay updated the question details for Q126: 5 Deprecation Notices in PhabricatorStandardPageView.php.
Sun, Apr 14, 09:34 · Deprecation Notice
bekay updated Q126: 5 Deprecation Notices in PhabricatorStandardPageView.php from 5 Deprecation Notices PhabricatorStandardPageView to 5 Deprecation Notices in PhabricatorStandardPageView.php.
Sun, Apr 14, 09:03 · Deprecation Notice
bekay closed T15781: arc liberate throws exception as Resolved.

Fixed by R5:91dd43de7dee: T15781: arc liberate throws exception

Sun, Apr 14, 08:59 · Diagrams (Extension)
bekay updated subscribers of T15782: Diagrams Extension is not installable/usable in its current form.
Sun, Apr 14, 08:58 · Diagrams (Extension)
bekay updated subscribers of T15784: Add title and project tags to diagram.
Sun, Apr 14, 08:57 · Diagrams (Extension)
bekay updated subscribers of T15784: Add title and project tags to diagram.
Sun, Apr 14, 08:57 · Diagrams (Extension)
bekay created T15784: Add title and project tags to diagram.
Sun, Apr 14, 08:54 · Diagrams (Extension)
bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

@mturdus I have added some console logs in the js code (so patch and purge the caches on <phorge-base>config/cache/!)

Sun, Apr 14, 08:43 · Diagrams (Extension)
bekay updated the diff for D25577: Makes extension usable with configured alternative file domain.
  • Caches draw.io assets, uses base64 method of diagram and adds some console logs for js debugging
Sun, Apr 14, 08:39 · Diagrams (Extension)
bekay added a member for Diagrams (Extension): bekay.
Sun, Apr 14, 08:14
bekay asked Q126: 5 Deprecation Notices in PhabricatorStandardPageView.php.
Sun, Apr 14, 08:13 · Deprecation Notice
bekay added a project to D25577: Makes extension usable with configured alternative file domain: Diagrams (Extension).
Sun, Apr 14, 07:39 · Diagrams (Extension)
bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

Firefox does work for me. Does Chrome work for you?

Sun, Apr 14, 07:36 · Diagrams (Extension)

Sat, Apr 13

bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

@mturdus You don't have to download the diff, you can do an arc patch D25577 (and you should, because I have changed something again). Mh, but I don't know why it should not work.... 🤔

Sat, Apr 13, 20:03 · Diagrams (Extension)
bekay updated the summary of D25577: Makes extension usable with configured alternative file domain.
Sat, Apr 13, 19:56 · Diagrams (Extension)
bekay updated the diff for D25577: Makes extension usable with configured alternative file domain.
  • Dumps base64 image data directly while remarkup rendering and adds js/css files for remarkup object rule
Sat, Apr 13, 19:54 · Diagrams (Extension)
bekay added a comment to D25577: Makes extension usable with configured alternative file domain.

@mturdus Is the phorge_extension.js file loaded?

Sat, Apr 13, 19:09 · Diagrams (Extension)
bekay added a comment to T15782: Diagrams Extension is not installable/usable in its current form.

@mturdus Just test this if you like. I think this is a first step in the right direction: D25577

Sat, Apr 13, 16:16 · Diagrams (Extension)
bekay requested review of D25577: Makes extension usable with configured alternative file domain.
Sat, Apr 13, 16:13 · Diagrams (Extension)
bekay added a comment to T15782: Diagrams Extension is not installable/usable in its current form.

Well I have worked the entire day on this (and I see your mentioned issues)... main problem is: extension is not working with security.alternate-file-domain. That I have fixed at least for the creation/editing of diagrams. I have changed pretty much and would love to send a diff.

Sat, Apr 13, 15:49 · Diagrams (Extension)

Fri, Apr 12

bekay added a comment to T15782: Diagrams Extension is not installable/usable in its current form.

(Working on fixing it...)

Fri, Apr 12, 20:00 · Diagrams (Extension)

Thu, Apr 11

bekay updated the task description for T15782: Diagrams Extension is not installable/usable in its current form.
Thu, Apr 11, 18:13 · Diagrams (Extension)
bekay created T15782: Diagrams Extension is not installable/usable in its current form.
Thu, Apr 11, 18:08 · Diagrams (Extension)
bekay assigned T15781: arc liberate throws exception to mturdus.
Thu, Apr 11, 16:41 · Diagrams (Extension)
bekay created T15781: arc liberate throws exception.
Thu, Apr 11, 16:40 · Diagrams (Extension)

Wed, Apr 3

bekay added a comment to V5: Should we remove the code-generated documents from this instance?.

I never use them, because there is no real method search. I think, we should be considering generating a documentation with a real php documention tool. But whatever we do: I think we can remove them in their current form.

Wed, Apr 3, 08:06 · Diviner

Tue, Apr 2

20after4 awarded D25538: Separate repository home and browse view in tab menu a Orange Medal token.
Tue, Apr 2, 19:19
bekay retitled D25538: Separate repository home and browse view in tab menu from Seperate repository home and browse view in tab menu
Tue, Apr 2, 14:36
bekay closed T15728: Repo home view and browse view share the same menu tab as Resolved by committing rPba835fe0eced: Seperate repository home and browse view in tab menu.
Tue, Apr 2, 13:56 · Discussion Needed, Diffusion
bekay closed D25538: Separate repository home and browse view in tab menu.
Tue, Apr 2, 13:56
bekay committed rPba835fe0eced: Seperate repository home and browse view in tab menu.
Seperate repository home and browse view in tab menu
Tue, Apr 2, 13:56
bekay updated the summary of D25538: Separate repository home and browse view in tab menu.
Tue, Apr 2, 13:40
bekay added a comment to D25538: Separate repository home and browse view in tab menu.

I'd even suggest we can go one step further, and in the Home tab show the Readme above the files (and maybe change the order/highlight some other UI elements too).

Tue, Apr 2, 10:01
bekay updated the diff for D25538: Separate repository home and browse view in tab menu.
  • Moves readme to the top in home view
Tue, Apr 2, 09:58
bekay added a comment to Q108: Phorge and Mermaid Js (Answer 139).

Well, my idea was to use the already implemented logic of the diagram extension and just extend it with another diagram renderer. But @mturdus is not responding 😁

Tue, Apr 2, 09:17
bekay added a comment to T15744: Render html color codes in remarkup.

Well, you know what would be next level for a dev? If (s)he clicks on it, the color is copied to the clipboard. We can't use this behavior, because behaviors loose their state in the remarkup cache...

Tue, Apr 2, 09:12 · Remarkup

Mar 15 2024

bekay added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

Updated Pygments with pip to 2.17.2 und cut the time in half. So yeah, that's already an improvement.

Mar 15 2024, 09:08 · Remarkup
bekay added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

Well, good to know that it is not something in the phorge codebase. Our server has pygmentize 2.14.0 - but the server itself is really not the best, so that could be an explanation. Maybe we could make some remarks about performance and keeping the versions fresh on the diviner page...

Mar 15 2024, 08:14 · Remarkup

Mar 14 2024

avivey awarded T15756: Rendering remarkup with many embedded code blocks is very slow a Manufacturing Defect? token.
Mar 14 2024, 16:45 · Remarkup
bekay created T15756: Rendering remarkup with many embedded code blocks is very slow.
Mar 14 2024, 14:46 · Remarkup

Feb 23 2024

avivey awarded Q112: Deprecation Notice from PhrictionRemarkupRule.php:194 a Like token.
Feb 23 2024, 10:51 · Deprecation Notice
bekay asked Q112: Deprecation Notice from PhrictionRemarkupRule.php:194.
Feb 23 2024, 10:11 · Deprecation Notice

Feb 21 2024

bekay added a comment to T15741: Diffusion pattern search not working as expected.

The word solution would solve it from the expecting side, you are right. Here in my company the search is used frequently and only as a plain text search. So we have to escape the special regex signs time and again. Just would be interested if this is seen as an issue by others who uses the feature.

Feb 21 2024, 12:48 · Diffusion
bekay added a comment to T15741: Diffusion pattern search not working as expected.

Thanks for the clarification. I still think we should tackle the exception.

Feb 21 2024, 12:41 · Diffusion
bekay updated the task description for T15741: Diffusion pattern search not working as expected.
Feb 21 2024, 10:52 · Diffusion
bekay created T15741: Diffusion pattern search not working as expected.
Feb 21 2024, 10:51 · Diffusion
bekay created T15740: Crumb menu wrapping is deficient.
Feb 21 2024, 10:35 · UX
bekay added a comment to T15728: Repo home view and browse view share the same menu tab.

I tried to understand the situation. Thanks.

In your opinion: on the repo view (with clone buttons) is it really important to link to the other similar "reduced" view (without clone buttons)?

Feb 21 2024, 10:15 · Discussion Needed, Diffusion

Feb 16 2024

bekay added a comment to T15048: Allow awarding Tokens to individual Comments.

Just asking for a friend: Is there some progress on this?

Feb 16 2024, 12:43 · Comments
bekay updated subscribers of Q108: Phorge and Mermaid Js (Answer 139).

Maybe this could be integrated in the Diagrams extension...? I mean: the entire infrastructure is there - you just have to decide, what lib you wanne use when creating a new diagram. @mturdus What do you think about this?

Feb 16 2024, 12:35

Feb 15 2024

bekay attached a referenced file: F1360344: image.png.
Feb 15 2024, 19:01
bekay attached a referenced file: F1368592: image.png.
Feb 15 2024, 19:01
bekay added a comment to T15673: Phorge participation at FOSDEM 2024.

TRUST ME - YOU DON'T WANT TO LISTEN MY ENGLISH :D :D

Btw now the video is here :D :D AGAIN SORRY PHORGE FOR MY MISTAKES <3 <3

https://video.fosdem.org/2024/h2215/fosdem-2024-3610-unpack-phabricator-welcome-phorge-forking-the-opinionated-open-source-project-manager.av1.webm

Feb 15 2024, 18:59 · Blessed Communicators, Phorge
bekay closed D25536: Implements copy button in clone repo modal.
Feb 15 2024, 18:38
bekay committed rP89a5d3132c94: Implements copy button in clone repo modal.
Implements copy button in clone repo modal
Feb 15 2024, 18:38
bekay updated the diff for D25536: Implements copy button in clone repo modal.
Feb 15 2024, 18:35
bekay added a comment to D25536: Implements copy button in clone repo modal.

I really have struggled to find any device in our company that can't do await/async. I strongly bevlieve it is a non issue. Let us land this thing now and see if we get any feedback of an error.

Feb 15 2024, 16:29
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • Changes the order of the variables and function calls
Feb 15 2024, 16:29
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • Extends select behavior and only select content on first click
Feb 15 2024, 16:23
bekay added a comment to D25536: Implements copy button in clone repo modal.

Again, non-blocking opinion:

Are we aware that the "async" keyword (that was never used in Phorge) may just cause a crash by syntax error (almost-immediately even without clicking?) by that kind of browsers, so, breaking the page, just because we want to provide a copy function and we want to avoid .then()?

I think we can introduce breaking changes, but it's strange to do that, now, with this minor feature.

If we are aware of this minor risk, indeed let's land.

Feb 15 2024, 10:08
bekay added a comment to D25536: Implements copy button in clone repo modal.

Additional non-blocking thing:

Maybe should be copy(text) with var data defined outside

Bonus point: copy() not defined during every call of JX.Stratcom.listen, but outside (?)

Feb 15 2024, 09:23
valerio.bozzolan awarded D25536: Implements copy button in clone repo modal a Like token.
Feb 15 2024, 09:08
bekay added a comment to D25536: Implements copy button in clone repo modal.

Yes, we can avoid async.

So, this is just a tip, to avoid async and also to have everything a little more modular for no reason:

  1. remove async from copy()
  2. rename copy() to copyWithoutFeedback() and have the function that always return a Promise
    • so copyWithoutFeedback() has return navigator.clipboard.writeText(text); to always return a Promise
    • so copyWithoutFeedback() can use copyWithFeedback() but after that it return Promise.resolve(true) to always return a Promise
    • so copyWithoutFeedback() can fail with just return Promise.reject() to always return a Promise
  3. so we can create the function with feedback, copyWithFeedback(), that just calls the previous one, so, copyWithoutFeedback().then(function() { show_success_message() } ); with also a chained .fail( function() { show_error_message(); } ) or something similar
Feb 15 2024, 08:52
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • Updates map
Feb 15 2024, 08:36
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • Ignores async jshint
Feb 15 2024, 08:35

Feb 14 2024

bekay edited the content of Organizations Using Phorge.
Feb 14 2024, 17:36
bekay requested review of D25538: Separate repository home and browse view in tab menu.
Feb 14 2024, 17:27
bekay added a revision to T15728: Repo home view and browse view share the same menu tab: D25538: Separate repository home and browse view in tab menu.
Feb 14 2024, 17:27 · Discussion Needed, Diffusion
bekay added a comment to D25536: Implements copy button in clone repo modal.

I'll try to see if there's config for the jshint to allow async.

Feb 14 2024, 16:36
bekay added a comment to D25536: Implements copy button in clone repo modal.

Well, now I have tried to satisfy every wish.

Feb 14 2024, 16:05
bekay updated the diff for D25536: Implements copy button in clone repo modal.
  • use async/await for copy promise hell
  • make the io button to just a type icon
  • select entire text when clicking inside the input field
  • patch JsShrink to shrink await/async syntax
Feb 14 2024, 16:01
bekay updated the summary of D25536: Implements copy button in clone repo modal.
Feb 14 2024, 15:49
bekay added a comment to D25536: Implements copy button in clone repo modal.

(This Quickfix would help: https://github.com/vrana/JsShrink/pull/6/commits/5b2dd500d25b29ace2fbd76fc95b4518ef22abfc 😆 )

Feb 14 2024, 12:39
bekay added a comment to D25536: Implements copy button in clone repo modal.

await/async won't go through the shrink process without destroying the entire syntax. And if it will go through this jsxmin binary, who can know? Note for the future: Maybe replace the entire shrink process with a new and used php shrinker like JShrink.

Feb 14 2024, 12:13
bekay added a comment to D25536: Implements copy button in clone repo modal.

@avivey worst case is a syntax error because the operators are not known. Even that could be wrapped inside a try/catch.
@valerio.bozzolan could be done with the current behavior but this kind of implicit actions seems not the phorge way...?

Feb 14 2024, 10:10
bekay added a comment to D25536: Implements copy button in clone repo modal.

Yes, I insist on using the absolute required minimum of Promise-style coding.

Feb 14 2024, 08:56

Feb 13 2024

bekay added a comment to D25536: Implements copy button in clone repo modal.

I have to wait for the success or failure of the copy action, so I think this ui example makes no sense for my case. The notification should not be triggered by a button click.

Feb 13 2024, 09:42
bekay added a comment to D25536: Implements copy button in clone repo modal.
Feb 13 2024, 09:35

Feb 12 2024

bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

Well, I see a tremendous critism and scepticism concerning modern client side techniques here. The world of frontend tooling has changed tremendously in the last 5 years. And I understand concerns, but nobody has to write JavaScript for certain browsers anymore. Javelin for example tries to solve so many problems that Babel solves with one config entry. But that's okay and I like the architecture here and know we can't change everything at once.

Feb 12 2024, 21:05 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

The overwriting of variables with media queries could be configured inside the theming class. So possible breakpoints can be part of a theming API.

Feb 12 2024, 20:16 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

And my general approach is: when the client can do something (and that even better), why should the server do it?

Feb 12 2024, 20:04 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

@avivey CSS vars are a vital part of modern modularized theming. They are versatile, can be overwritten with media queries or per class/element basis. They are editable in browser dev tools. If you would ask me: this step is pretty important.

Feb 12 2024, 20:01 · Discussion Needed
bekay added a comment to T15736: JavaScript modernization (umbrella task).

to have a working dev server when developing js - at the moment I have to ./bin/celerity map after every change to js and css to see my changes...

Are you sure about that? I thought celerity map was only needed when adding a file (in dev mode).

Feb 12 2024, 19:47 · UX, Discussion Needed
bekay updated the task description for T15739: Replace celerity postprocessors with real css variables.
Feb 12 2024, 17:27 · Discussion Needed
bekay added a comment to T15039: Add a button to copy key information.
In T15039#1358, @bekay wrote:

The clone repo modal could really use some copy buttons.

image.png (282×854 px, 20 KB)

Preferably replacing the Read / Write Button.

Feb 12 2024, 16:50 · Differential
bekay updated the task description for T15735: Fix the various inconsistencies of phui tags.
Feb 12 2024, 16:49
bekay renamed T15735: Fix the various inconsistencies of phui tags from Fix the various inconsistenies of phui tags to Fix the various inconsistencies of phui tags.
Feb 12 2024, 16:49