Page MenuHomePhorge
Differential D25475

Drag & Drop Task Cover Image: also attach
Changes PlannedPublic
Actions

Authored by valerio.bozzolan on Mon, Nov 20, 09:06.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 30, 00:02
Unknown Object (File)
Tue, Nov 28, 16:03
Unknown Object (File)
Thu, Nov 23, 13:53
Subscribers
Cigaryno
Matthew
tobiaswiese

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15163: Auto-Attach a File when dropping it as Task cover image
Summary

Sometime (always?), when you Drag & Drop an Image from your computer to
a Workboard Task, the File is not visible to other people.

I sincerely don't remember from what moment this happened, but I'm quite
sure that this is not a new thing from Phorge.

There is an "attach" system. So we can attach the File to the Task.
So, the File inherits the visibility permissions of the Task.
So, the File is visible to persons who can see the Task.

Closes T15163

Test Plan

Visit a Workboard with a Column and a Task. Then:

  1. Drag & Drop GNU.png from your computer to that Task
  2. Drag & Drop GNU.png again there
  3. Drag & Drop Linux.png to that Task
  4. Drag & Drop Linux.png again
  5. No nuclear implosion.
  6. In all cases Task participants can see your Cover Image.

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 948
Build 948: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Mon, Nov 20, 09:06
Owners added a reviewer: O1: Blessed Committers.Mon, Nov 20, 09:06
Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptMon, Nov 20, 09:06
Harbormaster completed remote builds in B948: Diff 1531.Mon, Nov 20, 09:06
valerio.bozzolan requested review of this revision.Mon, Nov 20, 09:06
valerio.bozzolan planned changes to this revision.EditedWed, Nov 22, 12:10

This partially fixes the problem:

  • the file is now visible to Task participants, but
  • the file file transform is still not visible as Cover Image for some interesting reasons
valerio.bozzolan mentioned this in T15674: Image Transforms should reflect policy of parent Image.Wed, Nov 22, 13:04

Revision Contents
Changeset List

PathSizePackages
src/
applications/
project/
controller/
32 linesO1: Blessed Committers

Diff 1531

View Options

src/applications/project/controller/PhabricatorProjectCoverController.php

Loading...