Page MenuHomePhorge
Differential D25575

Make sure `offset` is an integer
ClosedPublic
Actions

Authored by avivey on Fri, Apr 12, 08:32.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 14:47
Unknown Object (File)
Thu, May 2, 14:47
Unknown Object (File)
Thu, May 2, 14:47
Unknown Object (File)
Wed, May 1, 19:22
Unknown Object (File)
Mon, Apr 22, 09:09
Unknown Object (File)
Mon, Apr 22, 09:09
Unknown Object (File)
Mon, Apr 22, 09:01
Unknown Object (File)
Mon, Apr 22, 08:54
View All 24 Files
Subscribers
aklapper
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP0d9ca2589f7c: Make sure `offset` is an integer
Summary

Older git versions allowed the --skip to get empty string as value and interpreted that to an int.
We were sending null in some places where we wanted a 0, so it all worked out.

Since https://git.kernel.org/pub/scm/git/git.git/commit/revision.c?id=71a1e94821666909b7b2bd62a36244c601f8430e git fails when provided empty string for an integer.

See Q124 and T15783.

Test Plan

Have recent git version (that fails with --skip '', navigate to /diffusion/1/history/master/) - see history.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey created this revision.Fri, Apr 12, 08:32
Owners added a reviewer: O1: Blessed Committers.Fri, Apr 12, 08:32
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, Apr 12, 08:32
avivey requested review of this revision.Fri, Apr 12, 08:32
Harbormaster completed remote builds in B1164: Diff 1839.Fri, Apr 12, 08:32
avivey mentioned this in Q124: [bug] Diffusion Commit History CommandException on git 2.42 (Answer 156).Fri, Apr 12, 08:33
valerio.bozzolan added a comment.Fri, Apr 12, 11:06

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

avivey added a comment.Fri, Apr 12, 13:47
In D25575#16550, @valerio.bozzolan wrote:

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

??

What for?

valerio.bozzolan accepted this revision.Fri, Apr 12, 13:56

(Stupid question :D sorry - clear now)

sgtm

This revision is now accepted and ready to land.Fri, Apr 12, 13:56
aklapper edited the summary of this revision. (Show Details)Fri, Apr 12, 15:52
aklapper subscribed.

(I took the liberty to link the specific change in Git in the commit message)

Closed by commit rP0d9ca2589f7c: Make sure `offset` is an integer. · Explain WhyFri, Apr 12, 16:28
This revision was automatically updated to reflect the committed changes.
avivey added a commit: rP0d9ca2589f7c: Make sure `offset` is an integer.

Revision Contents
Changeset List

PathSizePackages
src/
applications/
conduit/
protocol/
7 linesO1: Blessed Committers
diffusion/
conduit/
4 linesO1: Blessed Committers

Diff 1840

View Options

src/applications/conduit/protocol/ConduitAPIRequest.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0