Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:25.
Tags
None
Referenced Files
F3298961: D25581.1743013462.diff
Tue, Mar 25, 18:24
F3296885: D25581.1742978969.diff
Tue, Mar 25, 08:49
F3249435: D25581.1742286102.diff
Mon, Mar 17, 08:21
F3222126: D25581.1741903961.diff
Wed, Mar 12, 22:12
F3220971: D25581.1741813279.diff
Tue, Mar 11, 21:01
F3220970: D25581.1741813278.diff
Tue, Mar 11, 21:01
F3148505: D25581.1741217892.diff
Tue, Mar 4, 23:38
F3079522: D25581.1741064078.diff
Mon, Mar 3, 04:54

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/nuance/management/NuanceManagementWorkflow.php:69]
Test Plan

Run ../phorge/bin/nuance update: Get no strlen() error anymore but only expected output Usage Exception: Specify a item with --item.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable