Paths

Table of Contentst

Differential D25581

Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter
ClosedPublic
Actions

Authored by aklapper on Tue, Apr 16, 08:25.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 27, 21:51

	Unknown Object (File)
	Sat, Apr 27, 07:26

	Unknown Object (File)
	Mon, Apr 22, 23:59

	Unknown Object (File)
	Mon, Apr 22, 23:59

	Unknown Object (File)
	Mon, Apr 22, 19:09

	Unknown Object (File)
	Mon, Apr 22, 18:33

	Unknown Object (File)
	Fri, Apr 19, 17:45

	Unknown Object (File)
	Fri, Apr 19, 16:34

View All 10 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP9101c0b63df4: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/nuance/management/NuanceManagementWorkflow.php:69]

Test Plan

Run ../phorge/bin/nuance update: Get no strlen() error anymore but only expected output Usage Exception: Specify a item with --item.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Tue, Apr 16, 08:25

Owners added a reviewer: O1: Blessed Committers.Tue, Apr 16, 08:25

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Apr 16, 08:25

Harbormaster completed remote builds in B1173: Diff 1853.Tue, Apr 16, 08:25

aklapper requested review of this revision.Tue, Apr 16, 08:25

yesyes

This revision is now accepted and ready to land.Tue, Apr 16, 16:55

Closed by commit rP9101c0b63df4: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter. · Explain WhyTue, Apr 16, 22:35

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP9101c0b63df4: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

nuance/

management/

NuanceManagementWorkflow.php

2 lines

O1: Blessed Committers

Diff 1868

src/applications/nuance/management/NuanceManagementWorkflow.php

Loading...