We can also ship this feature in two phases, so, first, adding the option files.maximum-file-size, and then the second one when it's ready or requested lol

last change promise lol

arc unit

harden

\o/

also tried to fix PhutilRemarkupEngineTestCase

but fails in link-edge-cases.txt now (thus it's likely not complete):

Double slam-accept

Uh, that would be so good. So you can say "When the moon is full".

I like your option names. I like to specify PHIDs and not numeric IDs so it's more portable against import/exports 👍 Let's add Discussion Needed to attract some +1 or nice suggestions.

What happens to already-existing URLs? Maybe nice to mention in the test plan

Thanks. I see, from this page is not possible:

Double slam-accept

...like line 105 :)

Thaaanks - If I'm not wrong we can = idx($card, 'objectPHID');

We should maybe rewrite a bit the proposed solution, since ideally it's possible to use upstream.phorge.dev but it should be at least reachable to pass some anti-spam checkers I guess. At the moment it isn't:

git rebase origin/master

lol @taavi I've stolen some of your "ä" for the example file test_accents.mbox, I hope you won't send me a lawyer

I tried to prepare a unit test but it's not working. But yes it seems to work thanks

(Sorry I cannot test now) Does the test plan work with just this?

Nice question avivey. We could always disable this but maybe "newcomer admins" may not try to click it, so with more confusion from the other (Dark) Side.

(I still need to understand the old intentions on the old regex, and the new one, but it seems much magically readable, thanks)

Double slam accept

BTW I think the page is reached by a crawler that is visiting a branch root on a specific commit:

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

sgtm. Thanks :) just that comment

Maybe relevant but PhabricatorObjectHandleData seems to do some magic about filling PhabricatorObjectHandle with stuff like the name.

Thanks for the comment

Thanks :)

Thanks :)

Double-accept

In D25823#22340, @keithzg wrote:

... Conversely, arc browse . works for what I expected a pathless invocation to do, and funny enough that doesn't work on Git repos! So we have feature parity ;)

Thanks. Can you reproduce with "Upload file" button too? If yes, maybe sub-task of: T15106: "Upload file" in remarkup text fields should attach by default

@avivey Thanks for the tip about arguments allow-list in getArguments() https://we.phorge.it/source/arcanist/browse/master/src/workflow/ArcanistLintWorkflow.php$67 but I was not able to use that since here it's using getWorkflowArguments() 🤔 So I've just added a warning. It works lol. Check "BRANCH OPTION NOT AVAILABLE"

found a corner case, fixed

I think that, after the hidden comment is loaded in its bulk, "some more comments" are loaded as context for the hidden comment 🤔 So I guess that extra loading is probably a feature and not a bug.

Wikimedia Foundation has this in production since years. I think it doesn't hurt.

Hi @keithzg (and any SVN hacker) do you like the new added Subversion support?

Probably not enough consensus for a mass edit. Best we can do is case-by-case fixes reading warn reports.