Maybe better to expand the test plan to check user creation as well

Ah, probably after WMF disabled some applications, some crawlers started visiting these. Understood.

@avivey: still red flag?

How have you discovered this problem?

Probably we need some help to understand the semantic difference between these two:

I'm on latest master, and I'm still not able to try this 🤔 No errors. Just plaintext remarkup. Test case:

I see "Unknown object" if the Diff repository is unset. Is that known?

Tested before and after, I love this! Thanks!

• Run arc liberate from my clean working copy that has not ManiphestDefaultPriorityEditCapability (?)
• Minor fix indentation of a comment in PhabricatorDashboardQueryPanelType.php:81

Can reproduce. Tested. Thanks :)

You are now in the family of Trusted Contributors :) Patch welcome.

(From Task description)

In diffusion repositories, Description and tags are hard to find or never shown (only show in Manage page).

In T15526#16806, @aklapper wrote:

Which exact page(s) is this ticket about?

Probably something here should be expanded to check if the form contains at least a visible input without read-only

You are now in the family of Trusted Contributors 🎇

Thanks again avivey. I liked the idea of using applyExternalEffects(). I have not found a way to do it efficiently, without introducing another static method.

(Credit to bekay indeed)

Nice :) Thanks

Bonus point: maybe instead of "#123" we can use "#L123" since both GitLab and GitHub uses that (and that's not a stupid specification). Just because we can.

If we find 10 minutes, let's test this on every provider, as last time it gave us a little surprise on one of them

Thanks! It worked now! As mentioned in the chat, I'm quite sure that point n.3 and n.4 should be swapped in the README

Premising I've already seen this syntax in Java but not in PHP, I'm happy that now your IDE says something useful. Maybe a better title is "Improve PHPDoc of id()".

I think the purpose is to tell the IDE that the function receives a type and returns that exact type.

(Stupid question :D sorry - clear now)

In D25080#16549, @aklapper wrote:

I still think that the two Subscriber Rule value should be a list strings should for consistency be Add subscriber rule value should be a list respectively Remove subscriber rule value should be a list.

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

fix red color for removal (like in PhabricatorProjectTriggerRemoveProjectsRule)

follow code review - thanks

Ouch I see that receiving the engine was very complicated.

A weird but... expandable, fast, easy possibility is:

Thanks. Tested this in a correct situation and also causing a crash putting an unset($nodes[$current_node]) in ../arcanist/src/utils/AbstractDirectedGraph.php to see the nice exception message

...or Pharkdown :D

I do not understand why it does not work to me.

Go MoreMimeMailParserPeouw

Ah, also adding a smalll meta "noindex" HTML tag on legacy file.php$123 pages and similar ones, would maybe help a little bit.

Agree with last comment

add minor comment - ready again - tested

introduce a nice applyExternalEffect() to change external things (the orginal file)

All of this should maybe go under "applyExternalEffects()"

In this way, do we skip that column creating a column shift?

Whops, typo "Seperate" in the title - sorry for not noticing

Congratulations to both bekay and avivey. Minimum change, maximum result.

beautified even more - all logic inside the Transaction itself