Page MenuHomePhorge

valerio.bozzolan (Valerio Bozz.)
ʕ•ᴥ•ʔ

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 6 2021, 12:36 (154 w, 3 d)
Availability
Available
Timezone
UTC+2

I'm a pasta pizza volunteer Phabrilover. I would like to do it all day long.

I use Phorge in:

  • my personal installation to handle my stuff (about 80 users)
  • in the company I work for (about 30 employees)
  • in the Wikimedia Phabricator (as simple user)

Please don't contact me in private for troubleshooting. Use the chat or ping me from Ponder.

Other links:

Recent Activity

Yesterday

valerio.bozzolan updated the summary of D25691: Fix arc diff in Subversion for non-English languages.
Fri, Jun 21, 14:49
valerio.bozzolan updated the task description for T15855: Fix "arc diff" in Subversion for non-English languages.
Fri, Jun 21, 14:46 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan added a comment to D25691: Fix arc diff in Subversion for non-English languages.

Any chance to share the related stacktrace?

Fri, Jun 21, 14:35
valerio.bozzolan added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

What if $cdn has some evil characters? Do we have some escaping

Fri, Jun 21, 00:12

Thu, Jun 20

valerio.bozzolan added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
Thu, Jun 20, 23:39 · Files
valerio.bozzolan added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
Thu, Jun 20, 23:37 · Files
valerio.bozzolan updated the diff for D25051: Destroy file attachments when file is deleted, or object is deleted.

git rebase master

Thu, Jun 20, 23:30 · Files
valerio.bozzolan assigned T15110: File reference not removed when file is deleted to Dylsss.
Thu, Jun 20, 20:36 · Files, Bug Reports
valerio.bozzolan updated the name of F2236006: Phorge error Unknown objects.png from "image.png" to "Phorge error Unknown objects.png".
Thu, Jun 20, 20:20

Tue, Jun 18

valerio.bozzolan triaged T15859: Set "preconnect" HTTP header when "security.alternate-file-domain" is set as Wishlist priority.
Tue, Jun 18, 15:20 · Feature Requests

Tue, Jun 11

valerio.bozzolan updated the summary of D25691: Fix arc diff in Subversion for non-English languages.
Tue, Jun 11, 16:11
valerio.bozzolan updated the summary of D25691: Fix arc diff in Subversion for non-English languages.
Tue, Jun 11, 16:10
valerio.bozzolan requested review of D25691: Fix arc diff in Subversion for non-English languages.
Tue, Jun 11, 16:09
valerio.bozzolan added a revision to T15855: Fix "arc diff" in Subversion for non-English languages: D25691: Fix arc diff in Subversion for non-English languages.
Tue, Jun 11, 16:09 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan triaged T15855: Fix "arc diff" in Subversion for non-English languages as Normal priority.
Tue, Jun 11, 16:06 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan accepted D25642: Initialize $cache_key variable in CelerityResourceController.php.

Thanks. Moreover, looking at PhutilKeyValueCache it seems that setKey(null) has no sense. So thanks also for that extra care you already set.

Tue, Jun 11, 10:58

Mon, Jun 10

valerio.bozzolan accepted D25686: Fix PHP 8.1 exceptions importing ICS file without attendee names.

I will then need a rebase for D25363

Mon, Jun 10, 22:20
valerio.bozzolan added inline comments to D25668: Add Open Graph protocol meta tags to Maniphest task pages.
Mon, Jun 10, 14:59

Sun, Jun 9

valerio.bozzolan added a comment to D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

To me it makes sense thanks. Maybe just add a comment somewhere to say that the menu should be automatically generated - T15224

Sun, Jun 9, 09:18

Fri, Jun 7

valerio.bozzolan added a comment to D25622: Transformed Pictures: make them non-orphan.

Test plan: I finished my ideas. It seems it just work 🤔

Fri, Jun 7, 20:34
valerio.bozzolan added a comment to D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

Fri, Jun 7, 20:13
valerio.bozzolan accepted D25685: Allow admins to access "Manage" page from user profile page menu on mobile.
Fri, Jun 7, 19:33
valerio.bozzolan added a comment to D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

Better than before.

Fri, Jun 7, 19:33
valerio.bozzolan accepted D25683: Only display "Calendar" entry in user profile page menu on mobile when Calendar application is installed.

all those tears shed by devastated users after clicking the Calendar menu item

Fri, Jun 7, 19:31
valerio.bozzolan added inline comments to D25618: Avoid search exception for calendar events when using localized time formats.
Fri, Jun 7, 15:43
valerio.bozzolan added inline comments to D25618: Avoid search exception for calendar events when using localized time formats.
Fri, Jun 7, 15:42
valerio.bozzolan accepted D25644: Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment.
Fri, Jun 7, 15:10
valerio.bozzolan added a comment to D25644: Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment.

Maybe a good moment for minimal PHPDoc with

Fri, Jun 7, 15:10
valerio.bozzolan awarded Q138: SAML 2.0 support a Yellow Medal token.
Fri, Jun 7, 14:45 · Feature Requests
valerio.bozzolan added a comment to D25675: Drydock and Almanac: add welcome pages.

I will update the screenshots. Let's wait another +1 on strings.

Fri, Jun 7, 12:23
valerio.bozzolan updated the diff for D25675: Drydock and Almanac: add welcome pages.

Tried to re-phrase a bit, thanks to feedback from Italian coworkers and Andrè. lol

Fri, Jun 7, 12:18
valerio.bozzolan accepted D25653: Fix call to non-existing getDisplayName() in DiffusionRepositoryClusterEngine.php.

sgtm

Fri, Jun 7, 11:03
valerio.bozzolan accepted D25596: Fix PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.

sgtm

Fri, Jun 7, 09:13
valerio.bozzolan awarded D25655: Fix call to non-existing newWorkCommands() in NuanceItemType a Like token.
Fri, Jun 7, 08:11
valerio.bozzolan accepted D25655: Fix call to non-existing newWorkCommands() in NuanceItemType.

sgtm

Fri, Jun 7, 08:11

Wed, Jun 5

valerio.bozzolan awarded D25643: Fix call to non-existing newError() in PhabricatorEditorExtension a Evil Spooky Haunted Tree token.
Wed, Jun 5, 15:00
valerio.bozzolan added a comment to D25643: Fix call to non-existing newError() in PhabricatorEditorExtension.

Also fix the typo in the function name

Wed, Jun 5, 14:59
valerio.bozzolan accepted D25647: Fix call to non-existing newIcons() in PhabricatorIconSet.
$ grep -FR 'extends PhabricatorIconSet' .
./src/applications/people/icon/PhabricatorPeopleIconSet.php:  extends PhabricatorIconSet {
./src/applications/calendar/icon/PhabricatorCalendarIconSet.php:  extends PhabricatorIconSet {
./src/applications/project/icon/PhabricatorProjectIconSet.php:  extends PhabricatorIconSet {
./src/applications/badges/icon/PhabricatorBadgesIconSet.php:  extends PhabricatorIconSet {
./src/applications/search/menuitem/PhabricatorProfileMenuItemIconSet.php:  extends PhabricatorIconSet {
./src/applications/dashboard/icon/PhabricatorDashboardIconSet.php:  extends PhabricatorIconSet {
Wed, Jun 5, 14:45
valerio.bozzolan added a comment to D25655: Fix call to non-existing newWorkCommands() in NuanceItemType.

Thanks. Your edit effectively reflects what already happens, but interestingly, it still may crash 🤔

Wed, Jun 5, 14:42
valerio.bozzolan accepted D25654: Correct PHPDoc return value for loadObject() in PhabricatorObjectMailReceiver.

sgtm

Wed, Jun 5, 14:31
valerio.bozzolan accepted D25681: Fix PHP 8.1 "strlen(null)" exception creating a Portal.

sgtm

Wed, Jun 5, 14:30
valerio.bozzolan accepted D25051: Destroy file attachments when file is deleted, or object is deleted.
Wed, Jun 5, 08:31 · Files
valerio.bozzolan triaged T15110: File reference not removed when file is deleted as High priority.

A bit more than Normal, since it reflects on a database with orphan elements that creates "ghosts in the UI".

Wed, Jun 5, 07:59 · Files, Bug Reports
valerio.bozzolan accepted D25671: Reword joke password reset email message.

Wow. With my proposal is not funny anymore. OK I will refrain myself from contributing here. But I personally like the new proposal from Andrè and @pppery. Personally approving.

Wed, Jun 5, 07:44
valerio.bozzolan added a comment to D25671: Reword joke password reset email message.

I understand the points. Third round, starting with useful tips (good idea), and shorter:

Wed, Jun 5, 07:41

Tue, Jun 4

valerio.bozzolan closed D25621: Show login page if a search token requires a valid viewer.
Tue, Jun 4, 14:11
valerio.bozzolan closed T15704: Cryptic exception when listing tasks "Closed By: Current Viewer" while logged out as Resolved by committing rP5a40739451c1: Show login page if a search token requires a valid viewer.
Tue, Jun 4, 14:10 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan committed rP5a40739451c1: Show login page if a search token requires a valid viewer.
Show login page if a search token requires a valid viewer
Tue, Jun 4, 14:10
valerio.bozzolan edited the content of Next Up.
Tue, Jun 4, 14:10
valerio.bozzolan updated the task description for T15704: Cryptic exception when listing tasks "Closed By: Current Viewer" while logged out.
Tue, Jun 4, 14:09 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan added a project to T15704: Cryptic exception when listing tasks "Closed By: Current Viewer" while logged out: Bug Reports.
Tue, Jun 4, 14:07 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan accepted D25679: Remove unused variable from HeraldEngine.

No results.

Tue, Jun 4, 10:24
valerio.bozzolan added a comment to D25679: Remove unused variable from HeraldEngine.

Is anything extending HeraldEngine trying direct access to that?

Tue, Jun 4, 10:24
valerio.bozzolan updated the test plan for D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings).
Tue, Jun 4, 01:30
valerio.bozzolan accepted D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings).

The linter now screams nonsense things because of my little new unit test, taken from the proposed tar.gz file. Probably better than nothing. Tested A/B and it makes sense. Also the addition makes sense to me, compared to the other ones.

Tue, Jun 4, 01:29
valerio.bozzolan updated the diff for D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings).

add unit test

Tue, Jun 4, 01:25

Mon, Jun 3

valerio.bozzolan closed T15844: Dashboard Panel list: missing welcome page as Resolved by committing rP89dcbe125c6c: Panels list: fix missing welcome page.
Mon, Jun 3, 23:45 · Dashboards, Bug Reports
valerio.bozzolan closed D25674: Panels list: fix missing welcome page.
Mon, Jun 3, 23:45
valerio.bozzolan committed rP89dcbe125c6c: Panels list: fix missing welcome page.
Panels list: fix missing welcome page
Mon, Jun 3, 23:45
valerio.bozzolan updated the diff for D25675: Drydock and Almanac: add welcome pages.
  • AlmanacDeviceSearchEngine: add comma, but maybe keeping 'networks' in plural since the button is See Networks
  • AlmanacServiceSearchEngine: -of your devices +provided by your devices
Mon, Jun 3, 23:43
valerio.bozzolan added inline comments to D25675: Drydock and Almanac: add welcome pages.
Mon, Jun 3, 23:43
valerio.bozzolan added a member for Blessed Communicators: aklapper.
Mon, Jun 3, 23:24

Fri, May 31

valerio.bozzolan updated the summary of D25675: Drydock and Almanac: add welcome pages.
Fri, May 31, 16:12
valerio.bozzolan requested review of D25675: Drydock and Almanac: add welcome pages.
Fri, May 31, 16:10
valerio.bozzolan added a revision to T15018: Make Harbormaster more generally usable and extendable: D25675: Drydock and Almanac: add welcome pages.
Fri, May 31, 16:10 · Almanac/Drydock/Harbormaster
valerio.bozzolan added a comment to T15018: Make Harbormaster more generally usable and extendable.

Also adding some on-platform documentation would be nice.

Fri, May 31, 16:10 · Almanac/Drydock/Harbormaster
valerio.bozzolan added a comment to F2212243: Phorge Services.png.

Screenshot taken at 702 x 495

Fri, May 31, 15:14
valerio.bozzolan changed the visibility for F2212243: Phorge Services.png.
Fri, May 31, 15:14
valerio.bozzolan changed the visibility for F2212244: Phorge Devices.png.
Fri, May 31, 15:14
valerio.bozzolan changed the visibility for F2212245: Phorge Blueprints.png.
Fri, May 31, 15:14
valerio.bozzolan changed the visibility for F2212246: Phorge Networks.png.
Fri, May 31, 15:13
valerio.bozzolan added a comment to D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

I guess I should abandon this patch?

Fri, May 31, 12:33
valerio.bozzolan awarded D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController a Evil Spooky Haunted Tree token.
Fri, May 31, 12:27
valerio.bozzolan requested review of D25674: Panels list: fix missing welcome page.
Fri, May 31, 12:24
valerio.bozzolan added a revision to T15844: Dashboard Panel list: missing welcome page: D25674: Panels list: fix missing welcome page.
Fri, May 31, 12:24 · Dashboards, Bug Reports
valerio.bozzolan added a comment to D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

Sorry again for the confusion, I don't want to create extra work. I will create another patch as clarification. Unfortunate legacy situation.

Fri, May 31, 11:40
valerio.bozzolan added a comment to D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

Yup. I noticed that probably the method getNewUserBody() should be just moved from PhabricatorDashboardPanelListController to PhabricatorDashboardPanelSearchEngine. Additional details in T15844.

Fri, May 31, 10:10
valerio.bozzolan added a project to T15844: Dashboard Panel list: missing welcome page: Dashboards.
Fri, May 31, 09:13 · Dashboards, Bug Reports
valerio.bozzolan added a comment to D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

The test plan should be:

Fri, May 31, 08:55
valerio.bozzolan requested changes to D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

Just try to move the method in PhabricatorDashboardPanelSearchEngine as-is

Fri, May 31, 08:50
valerio.bozzolan added a revision to T15844: Dashboard Panel list: missing welcome page: D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.
Fri, May 31, 08:49 · Dashboards, Bug Reports
valerio.bozzolan updated the summary of D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.
Fri, May 31, 08:49
valerio.bozzolan added a comment to D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.

Wow, this was super-interesting

Fri, May 31, 08:48
valerio.bozzolan created T15844: Dashboard Panel list: missing welcome page.
Fri, May 31, 08:48 · Dashboards, Bug Reports

Thu, May 30

valerio.bozzolan accepted D25641: Correct call to non-existing PhutilFileLockException in support/unit/lock.php.

Nice!

Thu, May 30, 10:46
valerio.bozzolan updated the test plan for D25641: Correct call to non-existing PhutilFileLockException in support/unit/lock.php.
Thu, May 30, 10:46
valerio.bozzolan accepted D25660: PHPMailer: Set defaults for required parameters followed by optional parameters in Authorise() method signature.
Thu, May 30, 10:39
valerio.bozzolan updated the diff for D25660: PHPMailer: Set defaults for required parameters followed by optional parameters in Authorise() method signature.

restore newline

Thu, May 30, 10:39
valerio.bozzolan accepted D25660: PHPMailer: Set defaults for required parameters followed by optional parameters in Authorise() method signature.

Thanks for the upstream link

Thu, May 30, 10:38
valerio.bozzolan accepted D25673: Fix error in Mercurial when no offset is specified.

sgtm

Thu, May 30, 10:33

Tue, May 28

valerio.bozzolan accepted D25665: PHPMailer: Remove unused variable.

https://www.reddit.com/r/ProgrammerHumor/comments/9xat04/the_ancient_code/

Tue, May 28, 01:53

Sat, May 25

valerio.bozzolan added a comment to D25671: Reword joke password reset email message.

Well, I understand why this patch completely removes that joke.

Sat, May 25, 07:40

May 19 2024

valerio.bozzolan accepted D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.

Thanks asd

May 19 2024, 05:11

May 18 2024

valerio.bozzolan awarded D25662: MimeMailParser: Remove an unused variable a Love token.
May 18 2024, 19:50
valerio.bozzolan created E39: Valerio available (vacation).
May 18 2024, 19:32
valerio.bozzolan updated the summary of D25651: Fix typo creating QRbitstream().
May 18 2024, 19:30
valerio.bozzolan updated the diff for D25651: Fix typo creating QRbitstream().

shot at line 1162

May 18 2024, 19:29
valerio.bozzolan accepted D25651: Fix typo creating QRbitstream().

Thanks :3 Hoping to be useful I will amend with a minimal sed -i 's/QRbitrtream/QRbitstream/' externals/phpqrcode/phpqrcode.php

May 18 2024, 19:26
valerio.bozzolan edited the content of Next Up.
May 18 2024, 18:55
valerio.bozzolan accepted D25656: Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants.

I tested this with the following snippet:

May 18 2024, 18:51