User Details
- User Since
- Jul 6 2021, 12:36 (89 w, 4 d)
- Availability
- Available
Today
Green light @20after4 - you can land - thank you
I agree. Having said that I'm not bold enough to propose a "default: open in same tab" since at the moment we have the exact contrary. That is why I proposed this compromise based on the destination.
remote: This push was rejected by Herald push rule H8. remote: Change: commit/ remote: Rule: Guard Arcanist Repo with Blessed Committers remote: Reason: Commit is not approved by Blessed Committers remote: Transcript: https://we.phorge.it/herald/transcript/4967/
Thank you for your review
simplified inline comment
make the damn linter happy
Yesterday
@Matthew thank you in the other Diff
Hi @Matthew please undo your -1 so the author can land
Hi @Cigaryno - I will offer you an authentic Phorge doublon for your review here
Do you want an hand to land this nice feature?
try to make a review even more simple
Damn Arcanist.
Interestingly, this modification also brings a performance improvement on calculating the length of multiple strings.
By the way, Rector.php was able to do this replacement automatically:
adopt mb_strlen() that is optimized to do exactly this if you tell that you want an UTF-8
simplification
fix inline comment
add inline comment
Hi @ollehar, if you want, join next meeting: