Details
- Reviewers
aklapper - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15133: Differential List View should show Repository
T15512: Make Flags more useful
T15750: Integrate CustomField into more interfaces
Look at Repository List and Task lists that have flags.
Diff Detail
- Repository
- rP Phorge
- Branch
- customfield-list
- Lint
Lint Passed Severity Location Code Message Advice src/applications/search/engine/PhabricatorApplicationSearchEngine.php:1647 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 1088 Build 1088: arc lint + arc unit
Event Timeline
| src/applications/maniphest/query/ManiphestTaskSearchEngine.php | ||
|---|---|---|
| 396–412 | Moving this here is a small improvement, but in reality the "$handles" array used Before this change, we'd actually load all the labels twice using the old, uncached mechanism. | |
IIUC this adds Flags in Differential, Maniphest, etc list views, and adds the repository in Differential list view?
Functionality wise this looks great and works as expected for me:
Use Results > Export Data > CSV in both Differential and Maniphest query result lists does not include a repository column (that is fine) and is still valid CSV.
Wondering if rendered flags should be links to http://phorge.localhost/flag/ but that would be a separate request anyway.
Giving a +1 on personal capacity; I don't really feel knowledgeable enough to give a +1 as O1 (yet).
(Flags only show up in Maniphest on this one; I'll add them to more apps in a layer diff)
I'm shocked to see the flag on the revisions list. Turns out it's already a thing (on master!). Did not know about it, I'll have to look for it in the code.
Thanks!
Traced the Flags in Revision back to its origin in https://secure.phabricator.com/T1557. I knew about this one - but I was 100% sure that the feature was lost when the SearchEngine classes were introduced.
I see "Unknown object" if the Diff repository is unset. Is that known?
To reproduce, go to a Diff, and manually unset the repo.
| src/applications/differential/customfield/DifferentialRepositoryField.php | ||
|---|---|---|
| 72 | Probably this should be wrapped in if ($this->getValue()) { | |