Page MenuHomePhorge

avivey (Aviv Eyal)
UserAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 10 2021, 05:36 (149 w, 1 d)
Roles
Administrator
Availability
Available
Timezone
UTC+2

Recent Activity

Tue, Apr 16

avivey retitled D25577: Makes extension usable with configured alternative file domain from [WIP] Makes extension usable with configured alternative file domain
Tue, Apr 16, 06:28 · Diagrams (Extension)

Mon, Apr 15

avivey added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

done...

Mon, Apr 15, 16:36 · Auth, Bug Reports
avivey committed rPd519f75dfdee: (stable) Fix config transaction rendering error on auth page by allowing… (authored by doommius).
(stable) Fix config transaction rendering error on auth page by allowing…
Mon, Apr 15, 16:36
avivey added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

Yeah, probably. I'll try to do it tonight.

Mon, Apr 15, 08:31 · Auth, Bug Reports

Sun, Apr 14

avivey added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

Maybe put the warning above the box, so it catches all actions, not just comments?

Sun, Apr 14, 08:22 · Feature Requests
avivey added a comment to D25576: Improve PHPDoc of id().

Unless we can come up with a better/more common notation to show this information, I'm +1 on this - I like static type information, and this one looks fine to me.
I'm not familiar with many PHP tools - is there another notation somewhere?

Sun, Apr 14, 07:01

Fri, Apr 12

avivey closed D25575: Make sure `offset` is an integer.
Fri, Apr 12, 16:28
avivey committed rP0d9ca2589f7c: Make sure `offset` is an integer.
Make sure `offset` is an integer
Fri, Apr 12, 16:28
avivey added a comment to D25575: Make sure `offset` is an integer.

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

Fri, Apr 12, 13:47
avivey added a comment to Q124: [bug] Diffusion Commit History CommandException on git 2.42 (Answer 156).

I've created D25575 for this case, and filed T15783 for the broader issue.

Fri, Apr 12, 08:33
avivey requested review of D25575: Make sure `offset` is an integer.
Fri, Apr 12, 08:32
avivey triaged T15783: Conduit doesn't validate missing params as Normal priority.
Fri, Apr 12, 08:20 · Conduit

Thu, Apr 11

avivey raised the priority of T15106: "Upload file" in remarkup text fields should attach by default from Normal to High.
Thu, Apr 11, 10:41 · Files, Remarkup

Wed, Apr 10

avivey closed T15773: Community Project: Gantt Diagrams as Resolved.

Done:

Wed, Apr 10, 04:52 · Phactory: Community Projects
avivey removed a hashtag from Gantt Charts (Extension): #gantt_diagrams_extension.
Wed, Apr 10, 04:50
avivey renamed Gantt Charts (Extension) from Gantt Diagrams (Extension) to Gantt Charts (Extension).
Wed, Apr 10, 04:50
avivey edited Description on Gantt Charts (Extension).
Wed, Apr 10, 04:47
avivey created Gantt Charts (Extension).
Wed, Apr 10, 04:46
avivey claimed T15773: Community Project: Gantt Diagrams.
Wed, Apr 10, 04:45 · Phactory: Community Projects

Tue, Apr 9

avivey added Q125: "Not In" query operator and searching for project milestones (Answer 157).
Tue, Apr 9, 12:33

Fri, Apr 5

avivey placed T15030: Support a Phorge Extensions ecosystem up for grabs.

Did that Phactory: Hosting Projects Here

Fri, Apr 5, 16:36 · Extension Development, Phactory: Community Projects, Phorge
avivey created an object: Phactory: Hosting Projects Here.
Fri, Apr 5, 16:34 · Phactory: Community Projects
avivey closed T15760: Community Repo: DeepClone as Resolved.
Fri, Apr 5, 16:20 · Phactory: Community Projects
avivey closed D25570: Show rest of task page when graph errors out.
Fri, Apr 5, 10:26
avivey committed rPecbef3fdf4b6: Show rest of task page when graph errors out.
Show rest of task page when graph errors out
Fri, Apr 5, 10:26
avivey added a comment to T15772: Task with graph issue won't show.

This script can be used to download the entire graph:

Fri, Apr 5, 10:05
avivey requested review of D25570: Show rest of task page when graph errors out.
Fri, Apr 5, 07:33
avivey triaged T15772: Task with graph issue won't show as Normal priority.
Fri, Apr 5, 07:28
avivey added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

It's something to do with the priority - it works if the priority is smaller.
Probably one of the other similar rules is interrupting (icon? Object? Maybe it thinks this is a mention of a project?)

Fri, Apr 5, 07:15
avivey added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

Doesn't actually work for me either after arc patch:

image.png (317×429 px, 19 KB)

Fri, Apr 5, 06:58

Thu, Apr 4

avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

We don't create the links to page$line in most places as hrefs, so this shouldn't be an issue.

  • Don't exist in Diffusion
  • Do exist in Paste
  • Don't exist in Differential
Thu, Apr 4, 21:34 · Discussion Needed
avivey added a comment to V5: Should we remove the code-generated documents from this instance?.

There's no easy way to do that...
The diviner flow loads code from a repository, creates "cache" files, and then loads them directly to DB. I'm not sure it's even reasonable to try to run it on a different workspace copy.

Thu, Apr 4, 18:47 · Diviner
avivey accepted D25558: Initial work.

You should be able to just arc land this now...

Thu, Apr 4, 08:00 · DeepClone (Extension)
avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

I'm guessing $ is used instead of # because (1) a user-agent might not send the # part to the server, and (2) the natural behavior of # ("scroll to this anchor") isn't what the intended behavior ("highlight these lines and scroll to the first one").

Thu, Apr 4, 07:10 · Discussion Needed

Wed, Apr 3

avivey added a comment to Q124: [bug] Diffusion Commit History CommandException on git 2.42 (Answer 156).

As a work-around, you can probably add ?offset=0 to the URL.

Wed, Apr 3, 11:09
avivey added Q124: [bug] Diffusion Commit History CommandException on git 2.42 (Answer 156).
Wed, Apr 3, 11:07
avivey awarded Q124: [bug] Diffusion Commit History CommandException on git 2.42 a Yellow Medal token.
Wed, Apr 3, 10:59 · Diffusion
avivey added a comment to D25558: Initial work.

(The images aren't public/attached, so I can't see them)

Wed, Apr 3, 10:56 · DeepClone (Extension)
avivey created V5: Should we remove the code-generated documents from this instance?.
Wed, Apr 3, 07:04 · Diviner
avivey added a comment to D25475: Drag & Drop Task Cover Image: also attach.

All of this should maybe go under "applyExternalEffects()", but I can't find any doc that explains what should go there. Looks like external runs after all the internal and the object being saved, and before final. 🤷‍♂️

Wed, Apr 3, 06:51
avivey added a comment to T15768: Better tracking tools for Files.

See also note in https://we.phorge.it/D25475#inline-3542 - looks like "creating a transformation" is done in many places.

Wed, Apr 3, 06:41 · Files
avivey added a comment to D25568: Fix PHP 8.1 "addcslashes(null)" exception exporting task list to tab-separated text.

In this way, do we skip that column creating a column shift?

Wed, Apr 3, 05:40

Tue, Apr 2

avivey added a comment to D25566: Fix setup check for gzip request mangling being sent as GET.

@kat: I've added you to the Trusted Contributors project, so you can now land this change!

Tue, Apr 2, 18:34
avivey added a member for Trusted Contributors: kat.
Tue, Apr 2, 18:33
avivey added a comment to D25548: Add (Advanced) Custom Fields to Item List.

Traced the Flags in Revision back to its origin in https://secure.phabricator.com/T1557. I knew about this one - but I was 100% sure that the feature was lost when the SearchEngine classes were introduced.

Tue, Apr 2, 18:28
avivey accepted D25538: Separate repository home and browse view in tab menu.
Tue, Apr 2, 13:18
avivey added a comment to Q108: Phorge and Mermaid Js (Answer 139).

The Github syntax for this is bad. That's the code block syntax. It makes it impossible to have code-block with mermaid syntax.

Tue, Apr 2, 09:10
avivey accepted D25566: Fix setup check for gzip request mangling being sent as GET.
Tue, Apr 2, 07:44
avivey added Q123: [Feature] Phorge integrates with Keycloak (Answer 155).
Tue, Apr 2, 06:25

Mon, Apr 1

avivey accepted D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

looks good to me - couple of small inlines....

Mon, Apr 1, 19:41
avivey added a comment to D25548: Add (Advanced) Custom Fields to Item List.

(Flags only show up in Maniphest on this one; I'll add them to more apps in a layer diff)

Mon, Apr 1, 19:30

Sun, Mar 31

avivey created T15768: Better tracking tools for Files.
Sun, Mar 31, 20:43 · Files
avivey accepted D25564: Fix PHP 8.1 "strlen(null)" exception when received email lacks From header.
Sun, Mar 31, 12:17
avivey accepted D25563: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser.

:-)

Sun, Mar 31, 12:17
avivey added a comment to D25563: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser.

Is that really as trivial as in my last revision?

Sun, Mar 31, 08:46

Sat, Mar 30

avivey requested changes to D25029: Co-Author support in arc land T15044.

house-keeping...

Sat, Mar 30, 12:28
avivey requested changes to D25028: Co-Author support in arc land T15044.

Changing status for house-keeping.

Sat, Mar 30, 12:28
avivey accepted D25538: Separate repository home and browse view in tab menu.

I'd even suggest we can go one step further, and in the Home tab show the Readme above the files (and maybe change the order/highlight some other UI elements too).

Sat, Mar 30, 12:25

Fri, Mar 29

avivey added a comment to D25563: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser.

Can we just define the used properties instead? Doesn't look like there's too many of them.

Fri, Mar 29, 12:07
avivey added a comment to D25558: Initial work.

IITC, The save() command won't generate any Feed item, so the unified feed entry would be either "xxx triaged this task" or "xxx added a comment". Also, for each comment added, a new Feed item will be generated, which is probably not what you'd like.

Fri, Mar 29, 09:27 · DeepClone (Extension)

Tue, Mar 26

avivey closed T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description as Resolved by committing rP216d308507ed: Fix Project Hovercard rendering @mention.
Tue, Mar 26, 18:07 · Affects-Wikimedia, Bug Reports
avivey closed D25562: Fix Project Hovercard rendering @mention.
Tue, Mar 26, 18:07
avivey committed rP216d308507ed: Fix Project Hovercard rendering @mention.
Fix Project Hovercard rendering @mention
Tue, Mar 26, 18:07
avivey requested review of D25562: Fix Project Hovercard rendering @mention.
Tue, Mar 26, 15:40
avivey added a revision to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description: D25562: Fix Project Hovercard rendering @mention.
Tue, Mar 26, 15:40 · Affects-Wikimedia, Bug Reports
avivey added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

It might not happen on any other card, because we might not be rendering Remarkup on any other card. Interesting....

Tue, Mar 26, 10:46 · Affects-Wikimedia, Bug Reports
avivey added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

So this is quite an edge-case:

  • PhabricatorMentionRemarkupRule wants to give the mention a different color, depending on if the user can view the "context object", in this case the Project.
  • There's an automatic rule, saying a member of a project can always view the project
  • When loading the project for the hovercard, we don't bother loading all the member list
  • When loading the user for the mention, we don't bother loading all its projects
  • so data is not available at the rendering point.
Tue, Mar 26, 10:39 · Affects-Wikimedia, Bug Reports
avivey claimed T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Tue, Mar 26, 10:23 · Affects-Wikimedia, Bug Reports
avivey accepted D25560: Remarkup code blocks: guess language from "name=".
Tue, Mar 26, 10:19

Mon, Mar 25

avivey added a comment to Q122: [Bug] Can't setup Admin account.

I can't immediately reproduce with that version either. I'll try again later.
In the meanwhile:

  • Try clearing your browser's cache
  • Try updating Phorge to the latest commit
  • Try disabling this extension: assets/DisableUsernameEditEventListener.php
Mon, Mar 25, 08:41 · Bug Reports
avivey added a comment to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..

I can reproduce this on master with basically any string search.

Mon, Mar 25, 08:30 · Phorge, Bug Reports
avivey accepted D25559: Update unit test of InterpreterBlockRule for "a {{{a}}}".
Mon, Mar 25, 08:27
avivey added inline comments to D25560: Remarkup code blocks: guess language from "name=".
Mon, Mar 25, 07:54
avivey added a comment to Q122: [Bug] Can't setup Admin account.

I can't reproduce this.
Which version of phorge/arc do you have (git log -1)?
How did you install the new Instance?

Mon, Mar 25, 07:44 · Bug Reports

Fri, Mar 22

avivey added Q120: What is the intended effect on a revision if the plan 1 fails? (Answer 152).
Fri, Mar 22, 12:11

Mar 20 2024

avivey moved T15525: Create repository for Diagrams, a DrawIO integration from Backlog to Pending Projects on the Phactory: Community Projects board.
Mar 20 2024, 12:08 · Phactory: Community Projects
avivey moved T15558: community repo: Semi Structured from Backlog to Pending Projects on the Phactory: Community Projects board.
Mar 20 2024, 12:08 · Semi Structured (Extension), Phactory: Community Projects
avivey moved T15576: Community Repo: QR Code Extension from Backlog to Pending Projects on the Phactory: Community Projects board.
Mar 20 2024, 12:08 · Phactory: Community Projects
avivey claimed T15030: Support a Phorge Extensions ecosystem.

@avivey to do now:

Mar 20 2024, 08:05 · Extension Development, Phactory: Community Projects, Phorge
avivey moved T15567: Phorge extension to print QR stickers from Backlog to Pending Projects on the Phactory: Community Projects board.
Mar 20 2024, 08:03 · Phactory: Community Projects
avivey moved T15760: Community Repo: DeepClone from Backlog to Pending Projects on the Phactory: Community Projects board.
Mar 20 2024, 08:03 · Phactory: Community Projects
avivey added a comment to T15760: Community Repo: DeepClone.

The repo is set to "host" right now, but it can also be set to "observe from" or "mirror to" another repo.

Mar 20 2024, 08:01 · Phactory: Community Projects
avivey changed the edit policy for DeepClone (Extension).
Mar 20 2024, 07:56
avivey added a member for DeepClone (Extension): tsc.
Mar 20 2024, 07:54
avivey created DeepClone (Extension).
Mar 20 2024, 07:54

Mar 19 2024

avivey added a comment to T15759: MySQL edge table error log: 'INSERT... ON DUPLICATE KEY UPDATE on a table with more than one UNIQUE KEY is unsafe'.

Interesting, and a little troubling if I understand it correctly; It means that the query ... WHERE dst = $a and type = $b and src = $c will be a full-table-read, but the equivalent query src = $c and type = $b and dst = $a will use the index to resolve quickly?

Mar 19 2024, 22:17
avivey accepted D25555: isSelfURI: fix anchors and relative URIs (that are "self" indeed).
Mar 19 2024, 11:27
avivey added a comment to T15759: MySQL edge table error log: 'INSERT... ON DUPLICATE KEY UPDATE on a table with more than one UNIQUE KEY is unsafe'.

Are the keys actually different? Looks like they have the same fields in different order. Does this makes a difference in the implementation?

Mar 19 2024, 09:02

Mar 17 2024

avivey updated the task description for T15758: Monitor PHPMailer security.
Mar 17 2024, 08:56 · Security

Mar 16 2024

avivey added a comment to D25502: Make PhabricatorSearchIntField validate its input.

I'm pretty sure getValueForQuery() should return some value?

Mar 16 2024, 14:13
avivey added a comment to T15121: Contributor Agreement.

I have a problem with this statement:

Mar 16 2024, 08:12 · Phorge

Mar 15 2024

avivey updated the task description for T15758: Monitor PHPMailer security.
Mar 15 2024, 19:30 · Security
avivey added a comment to T15758: Monitor PHPMailer security.

CVE-2017-5223, CVE-2018-19296 and CVE-2020-36326:

Mar 15 2024, 19:30 · Security
avivey added a comment to T15758: Monitor PHPMailer security.

CVE-2021-34551:
This one requires passing user-provided input as a filename to the "setLanguage" method; We don't call that method.

Mar 15 2024, 19:15 · Security
avivey updated the task description for T15758: Monitor PHPMailer security.
Mar 15 2024, 19:00 · Security
avivey edited the content of Dependencies.
Mar 15 2024, 18:57
avivey added a comment to T15758: Monitor PHPMailer security.

First pass, these one do not apply to us (and some of them do not apply to anyone at all):

Mar 15 2024, 18:56 · Security
avivey triaged T15758: Monitor PHPMailer security as Normal priority.
Mar 15 2024, 18:44 · Security
avivey added a comment to T15756: Rendering remarkup with many embedded code blocks is very slow.

(I've put a note in Dependencies for now)

Mar 15 2024, 18:23 · Remarkup
avivey created an object: Dependencies.
Mar 15 2024, 18:22