1b. Did you restart FastCGI after updating the code?

1. Yes, you should have D25387 - which makes it very strange that you're getting an exception.
2. That's the trace, yes.
3. I've added you to Trusted Contributors, so you can file bugs in maniphest, etc.

Unless something broke, this task is now complete.

• add PHP version
• rebase

add PHP version information to the view.

I'm just glossing over this - is ArcanistPhpunitTestResultParser now learning to parse generic "junit style xml" format?

If you can hop on IRC/Conpherence in about 4 hours (around 20:00 UTC), I can try debugging this interactively.

maybe use an PhabricatorSearchIntField with a default provided in the buildCustomSearchFields() ?

mmm, ok.

What kind of operation are you doing that involves loading all tasks in a browser?

If this is the only place where we have a "limit"/"page size" field, maybe just remove it?

Is this the only place where we have a "Page size" exposed in the search?

Let the Purge begin!

• rm commented out code

In D25388#13843, @Matthew wrote:

I like renaming the function!

We should probably have a timeline for removing the old function. Do we have a task for that?

The feature was removed for performance and private concerns. I thought Gravatar was alread dead.

I aslo don't see the point of this feature, but that's another issue.

I don't see the point in having this feature. What is it for?

• update some copy

• cleanup

From a product POV, I agree with @valerio.bozzolan - there is (sometimes) some information on commits that would be nice to index in a search engine - comments, mostly.

I don't have much of an attention span these days, sorry.

Yeah, the first run of arc lint creates the file, and subsequent runs do not update it.

I've taken the habit of updating to "latest RC" whenever I make an RC cut (every 3-4 months?), and then leaving it there until I feel like updating to master.
"I feel like updating to master" ususally means "there's something interesting there", and unless it's only interesting to this install, I tend to also cut the RC while I'm at it (or wait for when I do that).

Just for reference, see related T15449 and Q56.

great - see D25446

@fgaz can you try this and see if it it works for you?

I'm looking at PhutilLibraryMapBuilder:analyzeLibrary(), and it kinda looks like:

• if $this->fileSymbolMap is null, we call analyzeLibrary()`
• We load the data from the file if it's there
• We update the data
• We store it in $this->fileSymbolMap
• and we always save it to disk

There's no return in analyzeLibrary`, so if we got there, we'll save to disk. And there's no other write to fileSymbolMap, so we'll always get there.

So would the latter option mean doing $html_details = array($head, $more, implode(' ', $exceptions)); here? I kind of find this approach cleaner than appending a space to each item in the $exceptions array.

I don't think we have a specific task for "general UI text improvements" - there's the UX project, but "improve UX" is an ongoing process, so I don't think a single parent task is a good match.

Interestingly: https://secure.phabricator.com/T10574 argues for removal of the additional data from edges.

... whereas the $html_details is constructed as merely array($head, $more, $exceptions); ...

Without a reproduction, this is speculative.

Why would a branch name be an integer and not a string?

Yeah, I generally agree with "let the user set the width of the page"...

Can you add a couple of tests to https://we.phorge.it/source/arcanist/browse/master/src/utils/__tests__/cowsay/ ?

Did some digging, and it looks like Segoe is not something we can use: