Page MenuHomePhorge

avivey (Aviv Eyal)
UserAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 10 2021, 05:36 (55 w, 4 d)
Roles
Administrator
Availability
Available

Recent Activity

Fri, Jul 1

avivey created T15103: Status Checker.
Fri, Jul 1, 07:39 · Systems
avivey added a comment to D25040: merge phab/master -> phorge/master.

@speck I think we're sort of good to go here? maybe update?

Fri, Jul 1, 07:30

Tue, Jun 14

avivey edited the content of 2022-06-14.
Tue, Jun 14, 18:41

Fri, Jun 10

avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Allowing a user to make quick simple changes with nothing but a web browser is IMO the single best way to encourage new contributors.

Fri, Jun 10, 06:21 · Phorge General/Unknown, Arcanist

Wed, Jun 8

dtf awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Wed, Jun 8, 18:34 · Tokens

Mon, Jun 6

avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I'd point out that Gerrit was originally intended to work with a client-side tool called repo (Which also manages multi-repo code trees).
The git push ... <magic ref> is kind of a workaround for users that found having a client-side tool annoying to use :)

Mon, Jun 6, 14:47 · Phorge General/Unknown, Arcanist

May 3 2022

avivey edited the content of 2022-05-03.
May 3 2022, 19:21

Apr 18 2022

avivey added a comment to T15090: CVE-2022-24765 - Multi-user Git Privilege Escalation.
Apr 18 2022, 19:00 · Phorge General/Unknown, Restricted Project

Apr 13 2022

avivey shifted T15090: CVE-2022-24765 - Multi-user Git Privilege Escalation from the Restricted Space space to the S1 Public space.
Apr 13 2022, 18:10 · Phorge General/Unknown, Restricted Project
avivey changed the visibility for T15090: CVE-2022-24765 - Multi-user Git Privilege Escalation.
Apr 13 2022, 18:10 · Phorge General/Unknown, Restricted Project
avivey added a comment to T15090: CVE-2022-24765 - Multi-user Git Privilege Escalation.

err, I was trying to put it out as a Security PSA, so I clicked "Create security task" which I guess is the opposite of a PSA...

Apr 13 2022, 18:09 · Phorge General/Unknown, Restricted Project
avivey created T15090: CVE-2022-24765 - Multi-user Git Privilege Escalation.
Apr 13 2022, 18:07 · Phorge General/Unknown, Restricted Project

Apr 6 2022

20after4 awarded April 5, 2022 a Mountain of Wealth token.
Apr 6 2022, 16:59 · Governance

Apr 5 2022

avivey changed the join policy for Trusted Contributors.
Apr 5 2022, 19:45

Mar 24 2022

avivey accepted D25035: Hide the blurb of a user when that user is disabled.

lgtm.

Mar 24 2022, 18:03
avivey added a comment to T15078: Support for hardware keys as second factor.

The upstream discussion is at https://secure.phabricator.com/T8787

Mar 24 2022, 18:00 · Auth

Mar 21 2022

avivey triaged T15077: Rebrand: Tracking task as High priority.
Mar 21 2022, 20:17 · Phorge

Mar 19 2022

avivey awarded T15073: /status should be always allowed in anonymous mode a Like token.
Mar 19 2022, 07:48 · Phorge General/Unknown

Mar 14 2022

avivey updated the task description for T15071: Setup recurring Core meeting.
Mar 14 2022, 21:26 · Governance
avivey triaged T15071: Setup recurring Core meeting as Unbreak Now! priority.

4pm-8pm GMT (6-10pm GMT+2) sounds good to me - I can even go up to ~midnight and looks like I'm the east-most.

Mar 14 2022, 21:25 · Governance
avivey added a comment to T15072: Update Python-related linters for modern workflows.

Modern(ish) linters support a separate "interpreter" config - if that's set, they run $interpreter $binary $args rather then just $binary $args. Can this be utilized?

Mar 14 2022, 21:17 · Arcanist

Mar 11 2022

avivey updated subscribers of T15071: Setup recurring Core meeting.
Mar 11 2022, 14:53 · Governance
avivey created T15071: Setup recurring Core meeting.
Mar 11 2022, 14:50 · Governance

Feb 4 2022

avivey added a comment to D25033: Packages: Load'em from .cache.

This is my primary jab at Packages - think of it maybe as an RFC.

Feb 4 2022, 11:15
avivey added a revision to T15068: Distribution mechanism for arc extensions: D25033: Packages: Load'em from .cache.
Feb 4 2022, 11:10 · Arcanist
avivey added a task to D25033: Packages: Load'em from .cache: T15068: Distribution mechanism for arc extensions.
Feb 4 2022, 11:10
avivey created T15068: Distribution mechanism for arc extensions.
Feb 4 2022, 11:10 · Arcanist
avivey retitled D25033: Packages: Load'em from .cache from start: read packages info from config to Packages: Load'em from .cache.
Feb 4 2022, 11:07
avivey requested review of D25033: Packages: Load'em from .cache.
Feb 4 2022, 11:05

Jan 25 2022

avivey added a comment to T15064: Make phorge compatible with PHP 8.1.

oh, wow. 8.1 breakage are massive - and I'm guessing more such breaking changes would creep in in next versions?

Jan 25 2022, 18:54 · Phorge

Dec 18 2021

avivey added a comment to T15044: Co-Author support in arc land.

I've left a comment on the server-side diff.

Dec 18 2021, 07:37 · Arcanist
avivey added inline comments to D25029: Co-Author support in arc land T15044.
Dec 18 2021, 07:34
avivey updated the summary of D25029: Co-Author support in arc land T15044.
Dec 18 2021, 07:32
avivey updated the summary of D25028: Co-Author support in arc land T15044.
Dec 18 2021, 07:32
avivey added inline comments to D25028: Co-Author support in arc land T15044.
Dec 18 2021, 07:25

Nov 18 2021

ian awarded T15048: Allow awarding Tokens to individual Comments a Cup of Joe token.
Nov 18 2021, 07:33 · Tokens

Oct 24 2021

Labricator awarded T15048: Allow awarding Tokens to individual Comments a Like token.
Oct 24 2021, 19:38 · Tokens

Oct 22 2021

MacFan4000 awarded T15048: Allow awarding Tokens to individual Comments a Like token.
Oct 22 2021, 01:02 · Tokens

Oct 21 2021

lens0021 awarded T15048: Allow awarding Tokens to individual Comments a Like token.
Oct 21 2021, 17:01 · Tokens

Oct 17 2021

avivey added a comment to T15006: Re-brand Phorge.
In T15006#1429, @speck wrote:

I can provide more information later this weekend but I think it would help if we set up a virtual meeting with anyone interested in helping to get this done.

Oct 17 2021, 06:39 · Phorge

Sep 30 2021

20after4 awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Sep 30 2021, 13:55 · Tokens

Sep 24 2021

avivey added a comment to T15049: Segoe UI Symbol provides bad user experience.

Sague font family is probably important on Windows.

Sep 24 2021, 08:31

Sep 22 2021

G awarded T15048: Allow awarding Tokens to individual Comments a Mountain of Wealth token.
Sep 22 2021, 21:13 · Tokens
Leon95 awarded T15048: Allow awarding Tokens to individual Comments a The World Burns token.
Sep 22 2021, 20:21 · Tokens
avivey added a comment to T15047: Officially raise minimum required PHP version to 7.2.

Also, https://secure.phabricator.com/T7413 for the phone-home feature.

Sep 22 2021, 19:02 · Phorge
avivey added a comment to T15047: Officially raise minimum required PHP version to 7.2.

The kind of teams that use Centos/Redhat are very conservative - they're exactly the teams that would not install PHP from an "alternative" source (or from source code). They also tend to keep to older OS versions, as long as they are supported, and would not be happy with a single machine being different from the rest.
All that to say, it would make these teams sad to require an upgrade.

Sep 22 2021, 19:02 · Phorge
chris awarded T15048: Allow awarding Tokens to individual Comments a Mountain of Wealth token.
Sep 22 2021, 18:53 · Tokens
Ekubischta awarded T15048: Allow awarding Tokens to individual Comments a Mountain of Wealth token.
Sep 22 2021, 18:22 · Tokens
avivey created T15048: Allow awarding Tokens to individual Comments.
Sep 22 2021, 16:15 · Tokens
avivey added a comment to T15047: Officially raise minimum required PHP version to 7.2.

+1 for CentOS 7.

Sep 22 2021, 16:04 · Phorge

Sep 20 2021

avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I may be late for the party, but can't the translated verbiage be provided to the dialog in the $form_attributes in AphrontDialogView.php:337, and read using form.getAttribute(key) in the js?

Sep 20 2021, 15:04 · Maniphest

Sep 6 2021

avivey awarded T15046: Add GitHub mirrors for repos a Like token.
Sep 6 2021, 05:22 · Nuance, Phorge Upstream, Diffusion

Aug 26 2021

avivey added a comment to T15039: Add a button to copy key information.

Turns out there is Javelin support for "copy text" already implemented - I think it's used when copying from 2-up display, or when white-space is visible.
Anyway, I have an example code at https://secure.phabricator.com/P2080 for a button that copies arbitrary text.

Aug 26 2021, 17:41 · Differential
avivey awarded T15039: Add a button to copy key information a Like token.
Aug 26 2021, 17:38 · Differential
avivey added a comment to T15038: Offer a custom neutral timezone.

I think I just set that via "Global Default": https://we.phorge.it/settings/builtin/global/

Aug 26 2021, 17:32 · Phorge General/Unknown, Governance

Aug 24 2021

avivey added a comment to T15016: Update default storage namespace.

I like the idea of having an easily greppeable token...

Aug 24 2021, 17:05 · Phorge General/Unknown

Aug 20 2021

avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

What are the implications of making changes to the javelinjs.com https://github.com/phacility/javelin/ library?

Aug 20 2021, 06:58 · Maniphest

Aug 11 2021

avivey updated the task description for T15010: Vision Statement.
Aug 11 2021, 20:04 · Phorge, Governance
avivey added a comment to T15010: Vision Statement.

I agree with the doc, and would like to sign too.

Aug 11 2021, 20:03 · Phorge, Governance

Jul 28 2021

avivey added a subtask for T15000: Ad hoc setup tasks: T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses.
Jul 28 2021, 16:49 · Upstream General/Unknown
avivey added a parent task for T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses: T15000: Ad hoc setup tasks.
Jul 28 2021, 16:49 · Phorge Upstream
avivey awarded T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses a Like token.
Jul 28 2021, 16:49 · Phorge Upstream
avivey added a comment to T15035: Discuss communications channels (IRC, etc).

I just want everything "important" to be happening here, where the search and cross-references works and async communication is easy.

Jul 28 2021, 16:48 · Phorge Upstream
avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

The translated text can be a property of the dialogue itself, if we're worried about having extra objects laying around - the confirmation feels like it's a feature of the dialogue anyway.

Jul 28 2021, 07:20 · Maniphest
avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

There's no way to invoke pht from JS (because it's really complicated in the general case). The general practice is to provide the translated value from PHP when building the relevant objects. There should be an example in the UIExamples app - there's a page with buttons built in JS.

Jul 28 2021, 07:11 · Maniphest
avivey added a comment to T15014: Develop a Phorge Release Process.

There already are a bunch of worthwhile changes in Phabricator we should pick up; @Matthew - want to load them to check out the procedure? I can do that otherwise.

Jul 28 2021, 07:08 · Phorge

Jul 17 2021

avivey added a comment to T15030: Support a Phorge Extensions ecosystem.

Here's the terms I've been thinking of for accepting a project to Phactory:

  1. Directly related to Phorge in a significant way:

Good: Module for integration with some other system; New Phorge app that does something reasonable; scripts for administration work.
Bad: A space-zombie game that can report high-scores to IRC, Slack and Phorge.

Jul 17 2021, 07:23 · Phorge
avivey updated the task description for T15022: Legal stuff.
Jul 17 2021, 06:50 · Phorge

Jul 13 2021

avivey added a comment to T15030: Support a Phorge Extensions ecosystem.
In T15030#916, @dcog wrote:
In T15030#914, @avivey wrote:

We are planning on hosting community-driven extensions/projects (temp codename "Phactory"), either here or in a different domain; the idea is to have each project maintain their own repositories.

That sounds awesome! Cool name :) Curious, did this come up in Zulip? I need to log back in there.

Jul 13 2021, 16:48 · Phorge
avivey added a comment to T15014: Develop a Phorge Release Process.

nit-pick: maybe name them phabricator/master and phabricator/stable.

Jul 13 2021, 16:21 · Phorge
avivey added a comment to T15030: Support a Phorge Extensions ecosystem.

(I should stop reading stuff before coffee. You'd think I'd know that by now...)

Jul 13 2021, 08:34 · Phorge
avivey added a comment to T15030: Support a Phorge Extensions ecosystem.

I'm thinking of hosting them here, giving each project to manage their own repositories, but having a more tight control over the creation of the repo (for technical reasons) and projects.
I'd like to only have projects that are clearly related to Phorge in the install, because we're not GitHub.

Jul 13 2021, 06:34 · Phorge
avivey added a comment to T15030: Support a Phorge Extensions ecosystem.

We are planning on hosting community-driven extensions/projects (temp codename "Phactory"), either here or in a different domain; the idea is to have each project maintain their own repositories.

Jul 13 2021, 06:26 · Phorge

Jul 10 2021

avivey added a comment to T15010: Vision Statement.

I would like to officially submit myself as a Core Team member.

Jul 10 2021, 17:24 · Phorge, Governance

Jul 7 2021

avivey added a comment to T15006: Re-brand Phorge.

TBH, I'm a little confused about the way forward here, and I think this our biggest blocker?
I have some time I can put towards this, but I'm not sure what I should be doing.

Jul 7 2021, 18:02 · Phorge

Jul 3 2021

avivey added a comment to T15025: Simple Production Docker Stack.

Caddy looks interesting - if you get it going, can you make a small instructions writeup?

Jul 3 2021, 06:33 · Phorge General/Unknown
avivey awarded T15025: Simple Production Docker Stack a Like token.
Jul 3 2021, 06:20 · Phorge General/Unknown

Jul 1 2021

avivey added a comment to T15010: Vision Statement.

I like the current version :)

Jul 1 2021, 19:26 · Phorge, Governance

Jun 27 2021

avivey added a comment to T15010: Vision Statement.

Are we reasonably ok with what we have in the google doc?

Jun 27 2021, 19:32 · Phorge, Governance

Jun 26 2021

avivey added a comment to T15024: Landbot discussion(s), and generally ensuring that what is landed is what was reviewed.

The plan upstream was to (eventually) have arc land trigger T182, and do the whole thing server-side.

Jun 26 2021, 17:55 · Phorge General/Unknown
avivey added inline comments to D25002: T15006: Replacing external-facing trademarks/assets.
Jun 26 2021, 13:06
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

If you can break it to one diff with the new method/css stuff and one or two string changes, and several with only string change, we can just review it and land them one at a time.

Jun 26 2021, 06:38

Jun 25 2021

avivey added a comment to T15021: Exclude the Aphlict package-lock.json from linting rule.

ahh, there's a global setting for revisions - differential.generated-paths.

Jun 25 2021, 18:56 · Aphlict
avivey added a comment to T15021: Exclude the Aphlict package-lock.json from linting rule.

I was thinking of ArcanistGeneratedLinter.php, but it looks like the only way to mark a file is by adding @generated in it, and I think we can't do that?
I thought there was another way, because this also applies to revisions (it folds the file by default).

Jun 25 2021, 18:55 · Aphlict
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

Could we...

  1. Create a new Translation which specifically translates the token : e.g. %PHAB or {{Phabricator}} or {{PhabricatorWordmark}} or whatever
Jun 25 2021, 16:15
avivey added a comment to P2 Output from avivey script.

https://we.phorge.it/source/phorge/browse/master/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php has a few more instances of Phabricator (not in pht()).

Jun 25 2021, 15:42
avivey added a comment to T15014: Develop a Phorge Release Process.

(I'm 100% with @speck on requiring tasks)

Jun 25 2021, 15:11 · Phorge
avivey added a comment to T15016: Update default storage namespace.

@deadalnix's I like option 3 from a UX perspective - and it also lets us hold on this issue for a little while, without making things worse.

Jun 25 2021, 15:09 · Phorge General/Unknown
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

I had a thought, that adding a %xx argument to pht without matching argument is probably not a really good idea, so I went exploring.

Jun 25 2021, 08:27

Jun 24 2021

avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

I didn't talk with him in a while. Maybe opening a ticket in secure.phabricator.com is the quickest way?

Jun 24 2021, 17:22
avivey added a comment to T15014: Develop a Phorge Release Process.

Now, can we get a setup with CircleCI going so that we can test things?

Jun 24 2021, 15:08 · Phorge
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

I like the {Phabricator} idea! For technical compatibility with the rest of pht, it should probably be something like %PH.

Jun 24 2021, 05:41

Jun 23 2021

avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

Running ./bin/i18n extract . and then this scripts, shows 455 strings with the words Phabricator or Phacility (1 for Phacility), plus 19 in arcanist.

Jun 23 2021, 20:15
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.
In D25002#144, @speck wrote:

Still need to search for instances of Phabricator appearing anywhere within quotes. Testing all this will be fun.

Jun 23 2021, 19:39
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

How can I help?
Are we down to just grepping, or is there still some design left to do?

Jun 23 2021, 19:38
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

It says "Lint/Unit were skipped" for this diff - did you actually "skip" them, or is this some setup/usage artifact?

Jun 23 2021, 18:31
avivey triaged T15000: Ad hoc setup tasks as High priority.
Jun 23 2021, 18:27 · Upstream General/Unknown
avivey triaged T15005: Create Logo / Brand Assets as High priority.
Jun 23 2021, 18:27 · Phorge
avivey triaged T15008: Build Welcome Site as High priority.
Jun 23 2021, 18:27 · Upstream General/Unknown
avivey triaged T15009: Foundation as High priority.
Jun 23 2021, 18:27 · Phorge, Governance