Page MenuHomePhorge

avivey (Aviv Eyal)
UserAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 10 2021, 05:36 (162 w, 23 h)
Roles
Administrator
Availability
Available
Timezone
UTC+2

Recent Activity

Mon, Jul 15

avivey accepted D25672: Allow collapsing/expanding workboard column content by clicking its header.

👍👍

Mon, Jul 15, 09:06

Thu, Jul 11

avivey removed a project from T15705: Lower the search ranking of disabled user accounts: Discussion Needed.

I think we're all aligned here...

Thu, Jul 11, 07:35 · UX

Wed, Jul 10

avivey added a comment to Q143: Upgrading from Phabricator (Answer 179).

The best way is probably to make an Extension:

Wed, Jul 10, 14:01
avivey accepted D25729: Remove unreachable return statement in AphrontFormDateControlValue.
Wed, Jul 10, 13:53

Tue, Jul 9

avivey added Q143: Upgrading from Phabricator (Answer 179).
Tue, Jul 9, 14:44

Mon, Jul 8

avivey added a comment to T15879: Documentation: Macro image rendered instead of keyword when names match.

these pages should have Macro disabled, probably. A user on the install can add more macros that would break the page in some other ways. Probably.

Mon, Jul 8, 16:38
avivey accepted D25691: Fix arc diff in Subversion for non-English languages.
Mon, Jul 8, 07:45

Wed, Jul 3

avivey added a comment to T15875: Maniphest: Tasks can be closed as duplicate onto another task multiple times.

Once we remove this, we'll need to handle this edge-case:

  • I've closed a ticket as "duplicate of T1", but I was wrong and want to mark it as "duplicate of T2" instead (and say it's not a dup of T1).
Wed, Jul 3, 07:54 · Maniphest, Bug Reports

Tue, Jul 2

avivey added Q141: LotusLinkManiphestCustomField.php:258, occurrences: 1 (Answer 175).
Tue, Jul 2, 12:26

Mon, Jul 1

avivey added a comment to D25709: Fix missing file attachment in Conpherence.

OK.

@avivey what do you think about a new silly commodity method PhabricatorTransactions::findOneByType(array, string) ?

Mon, Jul 1, 18:39
avivey added a comment to D25607: Add docs for color code formatting.

(BTW, in D25698 we started deprecating remarkup.diviner for RemarkupReferenceController)

Mon, Jul 1, 06:53

Sun, Jun 30

avivey added a comment to D25706: Remove workaround for IE8 to avoid mixed content warning.

what will this do?

Sun, Jun 30, 06:20

Fri, Jun 28

avivey edited the content of Next Up.
Fri, Jun 28, 08:10
avivey added a comment to Q140: Drag and drop: view policies.

I'm assuming you're talking about dropping a file in the text area when editing the page, right? Not just dropping it when viewing a wiki page?

Fri, Jun 28, 08:04
avivey accepted rP90f9da643d16: Add and use new RemarkupMetadata class.

Presumably resolved by D25134.

Fri, Jun 28, 08:00
avivey added Q140: Drag and drop: view policies (Answer 174).
Fri, Jun 28, 08:00

Thu, Jun 27

avivey added inline comments to D25703: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field.
Thu, Jun 27, 10:39
avivey added a comment to D25703: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field.

maybe just add if ($value === null) { continue; } somewhere before the this?

Thu, Jun 27, 10:36
avivey created T15869: Herald rule referring to a disabled rule silently fails.
Thu, Jun 27, 10:26 · Herald
avivey added a comment to D25658: Fix call to non-existing renderChangesetLink() in PHUIDiffTableOfContentsItemView.

grep for PHUIDiffTableOfContentsItemView in the codebase to see where we might be using this class.

Thu, Jun 27, 08:44
avivey added a comment to D25658: Fix call to non-existing renderChangesetLink() in PHUIDiffTableOfContentsItemView.

If we can't find the problem, that probably means we have some dead code here that should be removed.

Thu, Jun 27, 08:40
avivey added a comment to D25658: Fix call to non-existing renderChangesetLink() in PHUIDiffTableOfContentsItemView.

Is there something that's not working here?

Thu, Jun 27, 07:52
avivey accepted D25667: Redirect back to object after clicking "Log In to Comment" and login.
Thu, Jun 27, 07:51
avivey accepted D25646: Correct rendering of workboard column move feed stories when a single transaction performs moves on multiple boards.

:shrug:

Thu, Jun 27, 07:50
avivey reopened T15401: Make the Remarkup Help Page Extensible as "Open".

(re-opening, there's more work left here)

Thu, Jun 27, 06:27 · Documentation, Remarkup

Wed, Jun 26

avivey accepted D25698: Make the Remarkup Help Page Extensible.

bwahaha

Wed, Jun 26, 18:51
avivey added inline comments to D25698: Make the Remarkup Help Page Extensible.
Wed, Jun 26, 08:55
avivey added inline comments to D25698: Make the Remarkup Help Page Extensible.
Wed, Jun 26, 07:56
avivey added a comment to T15285: It's damn difficult to type a "Thumb Up" emojii.

Do we still need the auto-complete feature? In modern times, the OS has the "insert emoji" feature built-in (at least, Windows and Android and KDE do).

Wed, Jun 26, 07:54

Mon, Jun 24

avivey added a comment to D25698: Make the Remarkup Help Page Extensible.

Ok, this looks much better then what we have today, so yay.

Mon, Jun 24, 20:17
avivey added a comment to D25698: Make the Remarkup Help Page Extensible.

Looks good! I want to play with it locally before accepting.

Mon, Jun 24, 08:41
avivey awarded D25698: Make the Remarkup Help Page Extensible a Yellow Medal token.
Mon, Jun 24, 08:34

Sun, Jun 23

avivey added a comment to D25698: Make the Remarkup Help Page Extensible.

It also collected lots of commits, since May 2023.

Sun, Jun 23, 20:28
avivey accepted D25652: Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in ArcanistAliasEngine.
Sun, Jun 23, 07:31
avivey added a comment to D25697: Run celerity map after rP1fa8c79b1ef86a9edda575b582b18fa24d60ea1f.

I obviously failed to run ./bin/celerity map one more time before running arc diff.

There should really be some way to detect and prevent that mistake. It's one I've made probably 100 times before.

Sun, Jun 23, 06:21

Sat, Jun 22

avivey added inline comments to D25388: PhutilErrorHandler: support multiple error listeners.
Sat, Jun 22, 15:44

Fri, Jun 21

avivey updated the task description for T15750: Integrate CustomField into more interfaces.
Fri, Jun 21, 19:09
avivey updated the task description for T15750: Integrate CustomField into more interfaces.
Fri, Jun 21, 19:09
avivey edited the content of Next Up.
Fri, Jun 21, 09:48
avivey closed D25549: Add Standard Custom Fields to Item List.
Fri, Jun 21, 09:45
avivey committed rP587530a9bf7b: Add Standard Custom Fields to Item List.
Add Standard Custom Fields to Item List
Fri, Jun 21, 09:45
avivey added inline comments to D25549: Add Standard Custom Fields to Item List.
Fri, Jun 21, 09:39
avivey accepted D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Fri, Jun 21, 09:25
avivey accepted D25695: Add fallback languages for locale files.
Fri, Jun 21, 09:23
avivey renamed Blog Post: 2024 "Not Officially Summer" release blog post from 2024 "Not officially summer" release to 2024 "Not Officially Summer" release.
Fri, Jun 21, 09:11
avivey created Blog Post: 2024 "Not Officially Summer" release.
Fri, Jun 21, 09:11
avivey edited the content of Change Log.
Fri, Jun 21, 09:06
avivey edited the content of 2024 week 19.
Fri, Jun 21, 09:05
avivey committed rARC1eee3da56e2c: Promote 2024.19 to stable.
Promote 2024.19 to stable
Fri, Jun 21, 09:03
avivey committed rP63f86bee27c4: Promote 2024.19 to stable.
Promote 2024.19 to stable
Fri, Jun 21, 09:00

Thu, Jun 20

avivey added a comment to D25695: Add fallback languages for locale files.

What's the current behavior for fallback from cs_CZ? Would it make sense to set the default to en_US in the base class?

Thu, Jun 20, 06:42

Wed, Jun 19

avivey added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

What if $cdn has some evil characters? Do we have some escaping, or can it cause anything bad, or do we not care? Looks like we're including a bunch of other config as-is here, so maybe it's ok.

Wed, Jun 19, 08:11
avivey accepted D25546: Warn in comment field if task is closed as duplicate.

Looks good to me.

Wed, Jun 19, 07:33

Jun 16 2024

avivey updated the question details for Q139: Add remarkup syntax help for custom remarkup rule tokens.
Jun 16 2024, 15:49 · Extension Development
avivey added Q139: Add remarkup syntax help for custom remarkup rule tokens (Answer 171).
Jun 16 2024, 15:44
avivey added Q138: SAML 2.0 support (Answer 170).
Jun 16 2024, 15:33
avivey added a comment to D25546: Warn in comment field if task is closed as duplicate.

I still don't like the solution of using place-holder text for that; But this implementation also adds another DB access which I think is redundant.

Jun 16 2024, 09:16
avivey added a comment to D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.

Instead of this diff, can you add a modern endpoint that uses the EditEngine/transactions? e.g. maniphest.edit, badge.edit, etc.
That will need a different name (phriction.document.edit?), but will allow full editing capability.

Jun 16 2024, 07:53

Jun 9 2024

avivey added a comment to T15724: PHP 8.3: ldap_connect() call signature deprecated.

So PHP, very wow

Jun 9 2024, 06:54 · PHP 8 support

Jun 7 2024

avivey added a comment to D25685: Allow admins to access "Manage" page from user profile page menu on mobile.

As T15224 suggest, this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

Jun 7 2024, 19:58

Jun 6 2024

avivey accepted D25682: Fix a leftover misspelled "Phabricator" reference.

There may be some room for extra clarity for users in complex organization setups, but this is a rare enough operation (outside of dev) that it's probably not worth worrying about.

Jun 6 2024, 06:52

Jun 4 2024

avivey added a comment to D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings).

Please add some negative tests - things that could trigger this thing, but shouldn't.

Jun 4 2024, 06:58
avivey added a revision to T15774: Celerity: javascript minification issue with template literals (backticked strings): D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings).
Jun 4 2024, 06:51
avivey added a task to D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings): T15774: Celerity: javascript minification issue with template literals (backticked strings).
Jun 4 2024, 06:51

Jun 3 2024

avivey accepted D25678: Expose initially set values of Maniphest custom date field and point values when removing them.
Jun 3 2024, 12:37
avivey accepted D25677: Remove unused method shouldCopyWhenCreatingSimilarTask().
Jun 3 2024, 10:55

Jun 2 2024

avivey added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

I think the EditEngine is what's used to create the actions form, and it has some sense of the object's status (see for example the available actions on Revisions - these change based on the revision's state).
Maybe it can get an additional "field" for this warning, and display it based on task status.

Jun 2 2024, 06:51 · Feature Requests

May 29 2024

avivey awarded T15843: Allow collapse and expand of workboard columns in mobile view a Hungry Hippo token.
May 29 2024, 07:12 · Workboard
avivey added a comment to D25672: Allow collapsing/expanding workboard column content by clicking its header.

Very cool!

May 29 2024, 07:12
avivey accepted D25669: Improve error passing task IDs as URL parameter in invalid format.

Don't we have something like phutil_is_integer method somewhere?

May 29 2024, 07:00

May 26 2024

avivey closed T15840: Don't give bad password advice when resetting password as Spite.
May 26 2024, 19:21

May 25 2024

avivey accepted D25670: Fix spelling of etc. in messages per Translatewiki request.

This is spelling, not formatting.

May 25 2024, 07:15
avivey added a comment to T15840: Don't give bad password advice when resetting password.

Using a password in 2024 is a bad advice in general.

May 25 2024, 07:09

May 21 2024

avivey accepted D25666: PHPMailer: Remove duplicate array keys.
May 21 2024, 08:31
avivey added a comment to D25668: Add Open Graph protocol meta tags to Maniphest task pages.

need to also test the result of renderPhabricatorLogo() when no logo set, when a custom logo is set, and when a custom logo is set but hidden (maybe. Maybe the logo file should be Attached to something public, so this situation can't really happen?)

May 21 2024, 07:31
avivey added a comment to T15121: Contributor Agreement.

That "don't sign a CLA" article should be titled "don't sign away your copyrights", to be more accurate and less click-bait-y. A CLA may ask you to sign away copyrights (which I feel makes the project non-open-source) ; It doesn't have to.

May 21 2024, 06:28 · Phorge

May 19 2024

aklapper awarded T15048: Allow awarding Tokens to individual Comments a Love token.
May 19 2024, 19:46 · Comments
avivey added a project to T15835: Misc "Return type is not covariant" errors for method Iterator::key(): PHP 8 support.
May 19 2024, 06:12 · PHP 8 support
avivey updated the task description for T15835: Misc "Return type is not covariant" errors for method Iterator::key().
May 19 2024, 06:11 · PHP 8 support
avivey accepted D25663: PHPMailer: Remove check for non-existing get_magic_quotes().
May 19 2024, 06:06

May 14 2024

avivey added a comment to D25035: Hide the blurb of a user when that user is disabled.

(It's about spam, but it doesn't have anything explicitly sensitive. I've made it public now)

May 14 2024, 16:02
avivey changed the visibility for T15074: Hide profile pictures and descriptions of disabled users.
May 14 2024, 16:00 · Security

May 12 2024

avivey added a comment to T15176: Evaluate a global Herald Maniphest action: "Block Task creation with message" (to allow custom Task constraints).

On a more meta level, Maniphest isn't well-suited to be an entry-form to be filled by a non-expert user; Nuance is/was intended for this use-case.

May 12 2024, 14:05 · Herald, Maniphest, User-valerio.bozzolan
avivey added a comment to T15176: Evaluate a global Herald Maniphest action: "Block Task creation with message" (to allow custom Task constraints).

on the technical level, Herald can't block object creation - it runs after the fact, by the Daemons.

May 12 2024, 14:03 · Herald, Maniphest, User-valerio.bozzolan
avivey added a comment to D25636: Fix exception awarding empty badge to user.

I think the 404 is possibly better then "silently fail without error".

May 12 2024, 09:09
avivey added a comment to D25635: Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php.

How can we end up with null here?

May 12 2024, 07:20

May 11 2024

avivey accepted D25634: Remove deprecated buildStandardPage* method calls.
May 11 2024, 14:48
avivey updated the diff for D25549: Add Standard Custom Fields to Item List.

Rebase

May 11 2024, 10:48
avivey closed T15133: Differential List View should show Repository as Resolved by committing rPea554af47649: Add (Advanced) Custom Fields to Item List.
May 11 2024, 10:25 · Differential
avivey closed D25548: Add (Advanced) Custom Fields to Item List.
May 11 2024, 10:25
avivey committed rPea554af47649: Add (Advanced) Custom Fields to Item List.
Add (Advanced) Custom Fields to Item List
May 11 2024, 10:25
avivey edited the content of Change Log.
May 11 2024, 04:39
avivey attached a referenced file: F1360344: image.png.
May 11 2024, 04:38
avivey attached a referenced file: F1368592: image.png.
May 11 2024, 04:37
avivey renamed 2024 week 19 from Next Up to 2024 week 19.
May 11 2024, 04:37

May 9 2024

avivey edited the content of Next Up.
May 9 2024, 06:16

May 8 2024

avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Another problem dramatically frequent for newcomers (at least in my office).

It's relatively too much easy to start with a similar commit message:
...

May 8 2024, 08:25 · Discussion Needed, Arcanist
avivey added a member for Trusted Contributors: pppery.
May 8 2024, 07:29
avivey accepted D25624: Make i18n string extraction ignore strings in test case files.

(run the full tests, and then count it as my + O1 Accept).

May 8 2024, 07:29
avivey added a comment to T15815: Make i18n string extraction ignore strings in test cases.

I think the costs of the extra translations are low, but the cost of "the tests are not being translated for developers" are even lower.

May 8 2024, 07:26 · Localization