Page MenuHomePhorge

avivey (Aviv Eyal)
UserAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 10 2021, 05:36 (130 w, 4 d)
Roles
Administrator
Availability
Available
Timezone
UTC+2

Recent Activity

Yesterday

avivey added a comment to Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 122).

1b. Did you restart FastCGI after updating the code?

Sun, Dec 10, 14:56
avivey closed Q99: permission to report a bug as resolved.
Sun, Dec 10, 14:47
avivey added Q99: permission to report a bug (Answer 125).
Sun, Dec 10, 14:46
avivey added a comment to Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 122).
  1. Yes, you should have D25387 - which makes it very strange that you're getting an exception.
  2. That's the trace, yes.
  3. I've added you to Trusted Contributors, so you can file bugs in maniphest, etc.
Sun, Dec 10, 14:46
avivey added a member for Trusted Contributors: adrelanos.
Sun, Dec 10, 14:46

Sat, Dec 9

avivey marked Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 123) as hidden.
Sat, Dec 9, 08:46
avivey accepted D25424: Curtain: add Hovercard support.
Sat, Dec 9, 08:44

Fri, Dec 8

avivey renamed 2023 week 49 RC from 2023.49 RC to 2023 week 49 RC.
Fri, Dec 8, 17:38
avivey edited the content of Change Log.
Fri, Dec 8, 17:38
avivey closed T15554: Handling PHP deprecations: convert to Setup Issues as Resolved.

Unless something broke, this task is now complete.

Fri, Dec 8, 17:37 · Phorge
avivey renamed 2023 week 49 RC from Next Up to 2023.49 RC.
Fri, Dec 8, 17:36
avivey added inline comments to D25388: PhutilErrorHandler: support multiple error listeners.
Fri, Dec 8, 16:05
avivey created T15690: PhutilErrorHandler - add try/catch around `call_user_func`.
Fri, Dec 8, 16:04
avivey closed D25440: Show Deprecation Warnings as Setup Warnings.
Fri, Dec 8, 15:56
avivey committed rP2ba2cbaf9bbf: Show Deprecation Warnings as Setup Warnings.
Show Deprecation Warnings as Setup Warnings
Fri, Dec 8, 15:56
avivey created T15689: built in exception display is missing top line.
Fri, Dec 8, 15:54 · Phorge Development Tools
avivey edited the content of Report Warnings.
Fri, Dec 8, 15:42
avivey updated the diff for D25440: Show Deprecation Warnings as Setup Warnings.
  • add PHP version
  • rebase
Fri, Dec 8, 15:41
avivey added Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 123).
Fri, Dec 8, 08:36

Wed, Dec 6

avivey updated the answer details for Q96: Support for FIDO2-backed SSH keys (Answer 120).
Wed, Dec 6, 16:10
avivey added Q96: Support for FIDO2-backed SSH keys (Answer 120).
Wed, Dec 6, 16:01
avivey awarded Q96: Support for FIDO2-backed SSH keys a Orange Medal token.
Wed, Dec 6, 15:55
avivey added Q97: Unable to submit patch via arc diff (Answer 119).
Wed, Dec 6, 15:50
avivey added Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 118).
Wed, Dec 6, 08:21

Tue, Dec 5

avivey added a member for Trusted Contributors: kuba-orlik.
Tue, Dec 5, 21:42
avivey added Q92: Cannot submit a revision - mysql problems? (Answer 116).
Tue, Dec 5, 21:42
avivey added Q93: The latest changes aren't reflected in the Setup Guide (Answer 115).
Tue, Dec 5, 21:36

Sun, Dec 3

avivey planned changes to D25440: Show Deprecation Warnings as Setup Warnings.

add PHP version information to the view.

Sun, Dec 3, 07:31

Fri, Dec 1

avivey added a comment to D25472: Update PhpunitTestEngine.php and ArcanistPhpunitTestResultParser.php to use junit output rather than json..

I'm just glossing over this - is ArcanistPhpunitTestResultParser now learning to parse generic "junit style xml" format?

Fri, Dec 1, 20:57
avivey added Q91: How can I tell phorge to use a different local.json file at runtime? (Answer 114).
Fri, Dec 1, 09:34
avivey added inline comments to D25388: PhutilErrorHandler: support multiple error listeners.
Fri, Dec 1, 09:05
fgaz awarded T15535: Using Differential with plain Git, without requiring Arc a Love token.
Fri, Dec 1, 08:09 · Feature Requests

Thu, Nov 30

avivey removed a reviewer for D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider: Matthew.
Thu, Nov 30, 07:39

Wed, Nov 29

avivey added a comment to Q90: Phorge storage upgrade error coming from Phabricator.

If you can hop on IRC/Conpherence in about 4 hours (around 20:00 UTC), I can try debugging this interactively.

Wed, Nov 29, 16:17 · Phorge
avivey updated the question details for Q90: Phorge storage upgrade error coming from Phabricator.
Wed, Nov 29, 16:09 · Phorge
avivey added a comment to D25479: Display default "Page Size" value in Maniphest Advanced Search form.

maybe use an PhabricatorSearchIntField with a default provided in the buildCustomSearchFields() ?

Wed, Nov 29, 16:06
avivey added a comment to T15676: Empty "Page Size" field in Maniphest Advanced Search should display "100" by default.

mmm, ok.

Wed, Nov 29, 16:03
avivey added a comment to T15676: Empty "Page Size" field in Maniphest Advanced Search should display "100" by default.

What kind of operation are you doing that involves loading all tasks in a browser?

Wed, Nov 29, 14:19
avivey added a comment to T15676: Empty "Page Size" field in Maniphest Advanced Search should display "100" by default.

If this is the only place where we have a "limit"/"page size" field, maybe just remove it?

Wed, Nov 29, 08:50

Mon, Nov 27

avivey added a comment to D25479: Display default "Page Size" value in Maniphest Advanced Search form.

Is this the only place where we have a "Page size" exposed in the search?

Mon, Nov 27, 18:40
avivey accepted D25480: Remove Chatlog entirely.

Let the Purge begin!

Mon, Nov 27, 18:34
avivey added inline comments to D25440: Show Deprecation Warnings as Setup Warnings.
Mon, Nov 27, 18:32
avivey closed D25388: PhutilErrorHandler: support multiple error listeners.
Mon, Nov 27, 18:32
avivey committed rARC25611ba24add: PhutilErrorHandler: support multiple error listeners.
PhutilErrorHandler: support multiple error listeners
Mon, Nov 27, 18:32
avivey updated the diff for D25440: Show Deprecation Warnings as Setup Warnings.
  • rm commented out code
Mon, Nov 27, 18:16
avivey added a comment to D25388: PhutilErrorHandler: support multiple error listeners.

I like renaming the function!

We should probably have a timeline for removing the old function. Do we have a task for that?

Mon, Nov 27, 18:06
avivey created T15677: Probably delete Log Write Check code.
Mon, Nov 27, 18:04

Sat, Nov 25

avivey added a comment to T15671: Allow to import Picture from Gravatar.

The feature was removed for performance and private concerns. I thought Gravatar was alread dead.

Sat, Nov 25, 14:49 · User-valerio.bozzolan, People
avivey requested changes to D25477: Visually indicate new user accounts.

I aslo don't see the point of this feature, but that's another issue.

Sat, Nov 25, 14:24
avivey added a comment to T15675: Visually indicate new user accounts.

I don't see the point in having this feature. What is it for?

Sat, Nov 25, 14:21 · Feature Requests

Fri, Nov 24

avivey renamed Report Warnings from Report-warnings to Report Warnings.
Fri, Nov 24, 18:27
avivey created Deprecation Notice.
Fri, Nov 24, 18:16
avivey updated the diff for D25440: Show Deprecation Warnings as Setup Warnings.
  • update some copy
Fri, Nov 24, 17:46
avivey updated the diff for D25388: PhutilErrorHandler: support multiple error listeners.
  • cleanup
Fri, Nov 24, 17:12
avivey updated the test plan for D25388: PhutilErrorHandler: support multiple error listeners.
Fri, Nov 24, 17:10
avivey updated the title for P26 test-logs-multilistener.php from Command-Line Input to test-logs-multilistener.php.
Fri, Nov 24, 17:09
avivey created P26 test-logs-multilistener.php.
Fri, Nov 24, 17:09

Sun, Nov 19

avivey reopened T15670: Disallow webcrawlers to index Diffusion repository commits as "Open".
Sun, Nov 19, 09:14 · Discussion Needed
avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

From a product POV, I agree with @valerio.bozzolan - there is (sometimes) some information on commits that would be nice to index in a search engine - comments, mostly.

Sun, Nov 19, 09:01 · Discussion Needed

Nov 5 2023

avivey awarded Q81: Documentation for "Restarting Phabricator" is missing a Grey Medal token.
Nov 5 2023, 07:42 · Phorge

Nov 2 2023

avivey added Q79: Is arc.land.onto.default configuration deprecated? (Answer 107).
Nov 2 2023, 19:49

Oct 27 2023

avivey accepted D25451: Remove unused variable $info in DiffusionCloneController.php.
Oct 27 2023, 08:12

Oct 26 2023

avivey resigned from D25118: Remarkup: make less internal links open in new tabs.

I don't have much of an attention span these days, sorry.

Oct 26 2023, 11:32

Oct 16 2023

avivey accepted D25447: Dashboard Panel: fix first tab sometime not opened anymore.
Oct 16 2023, 06:19

Oct 12 2023

avivey closed D25446: only update cache file if something changed.
Oct 12 2023, 16:22
avivey committed rARC98d16d27cf3e: only update cache file if something changed.
only update cache file if something changed
Oct 12 2023, 16:22
avivey added a comment to D25446: only update cache file if something changed.

Yeah, the first run of arc lint creates the file, and subsequent runs do not update it.

Oct 12 2023, 16:19

Oct 6 2023

avivey added a comment to T15092: Automatic deploy onto we.phorge.it.

I've taken the habit of updating to "latest RC" whenever I make an RC cut (every 3-4 months?), and then leaving it there until I feel like updating to master.
"I feel like updating to master" ususally means "there's something interesting there", and unless it's only interesting to this install, I tend to also cut the RC while I'm at it (or wait for when I do that).

Oct 6 2023, 06:34 · Phorge.it Systems
avivey added a comment to Q78: How to trigger build plan on GIT branch update?.

Just for reference, see related T15449 and Q56.

Oct 6 2023, 06:21 · Phorge
avivey added a project to T15024: Landbot discussion(s), and generally ensuring that what is landed is what was reviewed: Discussion Needed.
Oct 6 2023, 06:20 · Discussion Needed

Oct 5 2023

avivey added a comment to Q77: Arcanist writes cache files to its source directory, and this prevents packaging (Answer 106).

great - see D25446

Oct 5 2023, 12:27
avivey requested review of D25446: only update cache file if something changed.
Oct 5 2023, 12:27
avivey added a comment to Q77: Arcanist writes cache files to its source directory, and this prevents packaging (Answer 106).

@fgaz can you try this and see if it it works for you?

Oct 5 2023, 11:37
avivey added a comment to Q77: Arcanist writes cache files to its source directory, and this prevents packaging (Answer 106).

I'm looking at PhutilLibraryMapBuilder:analyzeLibrary(), and it kinda looks like:

  • if $this->fileSymbolMap is null, we call analyzeLibrary()`
  • We load the data from the file if it's there
  • We update the data
  • We store it in $this->fileSymbolMap
  • and we always save it to disk

There's no return in analyzeLibrary`, so if we got there, we'll save to disk. And there's no other write to fileSymbolMap, so we'll always get there.

Oct 5 2023, 11:31

Oct 3 2023

avivey added Q77: Arcanist writes cache files to its source directory, and this prevents packaging (Answer 106).
Oct 3 2023, 20:19

Sep 30 2023

waldyrious awarded T15535: Using Differential with plain Git, without requiring Arc a Love token.
Sep 30 2023, 14:12 · Feature Requests

Sep 27 2023

avivey accepted D25442: Update ArcanistComposerLinter.php to check content-hash instead of hash.
Sep 27 2023, 20:21
avivey accepted D25443: Correct Transaction text when changing Diffusion URI I/O type.
Sep 27 2023, 20:12

Sep 23 2023

revi awarded D25440: Show Deprecation Warnings as Setup Warnings a Party Time token.
Sep 23 2023, 21:03
avivey added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

So would the latter option mean doing $html_details = array($head, $more, implode(' ', $exceptions)); here? I kind of find this approach cleaner than appending a space to each item in the $exceptions array.

Sep 23 2023, 14:55
avivey added inline comments to D25363: Match yourself from Imported Events Invitees.
Sep 23 2023, 09:05
avivey added a project to T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land": UX.

I don't think we have a specific task for "general UI text improvements" - there's the UX project, but "improve UX" is an ongoing process, so I don't think a single parent task is a good match.

Sep 23 2023, 06:11 · UX, Differential
avivey updated the task description for T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".
Sep 23 2023, 05:53 · UX, Differential
avivey added a comment to T15512: Reimplement "Flags" to be based on Edges.

Interestingly: https://secure.phabricator.com/T10574 argues for removal of the additional data from edges.

Sep 23 2023, 05:36
avivey added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

... whereas the $html_details is constructed as merely array($head, $more, $exceptions); ...

Sep 23 2023, 05:07

Sep 22 2023

avivey requested review of D25440: Show Deprecation Warnings as Setup Warnings.
Sep 22 2023, 19:41
avivey added a revision to T15554: Handling PHP deprecations: convert to Setup Issues: D25440: Show Deprecation Warnings as Setup Warnings.
Sep 22 2023, 19:41 · Phorge
avivey created an object: Report Warnings.
Sep 22 2023, 19:02
avivey created an object: Docs.
Sep 22 2023, 19:02

Sep 18 2023

avivey added inline comments to D25051: Destroy file attachments when file is deleted.
Sep 18 2023, 07:47 · Files

Sep 17 2023

avivey added a comment to T15639: Exception: Value passed to "phutil_string_cast()" is an array in PhabricatorApplicationSearchEngine.php.

Without a reproduction, this is speculative.

Sep 17 2023, 07:38
avivey requested changes to D25438: Allow branch names to be integer values to avoid an InvalidArgumentException.

Why would a branch name be an integer and not a string?

Sep 17 2023, 07:35

Sep 15 2023

avivey added a comment to Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 104).

Yeah, I generally agree with "let the user set the width of the page"...

Sep 15 2023, 08:28
avivey added Q75: wiki (phriction) page doesn't utilize full screen width like most other pages do (Answer 104).
Sep 15 2023, 08:08

Sep 13 2023

revi awarded T15554: Handling PHP deprecations: convert to Setup Issues a The World Burns token.
Sep 13 2023, 16:40 · Phorge

Sep 11 2023

avivey accepted D25435: Fix rendering of cowsay sheep.cow.
Sep 11 2023, 19:04
avivey added a comment to D25435: Fix rendering of cowsay sheep.cow.

Can you add a couple of tests to https://we.phorge.it/source/arcanist/browse/master/src/utils/__tests__/cowsay/ ?

Sep 11 2023, 10:32

Sep 8 2023

avivey committed R6:ef927d616f71: Add quick-access buttons to lists.
Add quick-access buttons to lists
Sep 8 2023, 08:09

Sep 5 2023

avivey accepted D25367: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.
Sep 5 2023, 14:29
avivey added a comment to T15630: Fix Fonts.

Did some digging, and it looks like Segoe is not something we can use:

Sep 5 2023, 06:14