Page MenuHomePhorge

avivey (Aviv Eyal)
UserAdministrator

User Details

User Since
Jun 10 2021, 05:36 (18 w, 6 d)
Roles
Administrator

Recent Activity

Sun, Oct 17

avivey added a comment to T15006: Re-brand Phorge.
In T15006#1429, @speck wrote:

I can provide more information later this weekend but I think it would help if we set up a virtual meeting with anyone interested in helping to get this done.

Sun, Oct 17, 06:39 · Phorge

Thu, Sep 30

20after4 awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Thu, Sep 30, 13:55

Fri, Sep 24

avivey added a comment to T15049: Segoe UI Symbol provides bad user experience.

Sague font family is probably important on Windows.

Fri, Sep 24, 08:31

Wed, Sep 22

G awarded T15048: Allow awarding Tokens to individual Comments a Mountain of Wealth token.
Wed, Sep 22, 21:13
Leon95 awarded T15048: Allow awarding Tokens to individual Comments a The World Burns token.
Wed, Sep 22, 20:21
avivey added a comment to T15047: Officially raise minimum required PHP version to 7.2.

Also, https://secure.phabricator.com/T7413 for the phone-home feature.

Wed, Sep 22, 19:02 · Phorge
avivey added a comment to T15047: Officially raise minimum required PHP version to 7.2.

The kind of teams that use Centos/Redhat are very conservative - they're exactly the teams that would not install PHP from an "alternative" source (or from source code). They also tend to keep to older OS versions, as long as they are supported, and would not be happy with a single machine being different from the rest.
All that to say, it would make these teams sad to require an upgrade.

Wed, Sep 22, 19:02 · Phorge
chris awarded T15048: Allow awarding Tokens to individual Comments a Mountain of Wealth token.
Wed, Sep 22, 18:53
Ekubischta awarded T15048: Allow awarding Tokens to individual Comments a Mountain of Wealth token.
Wed, Sep 22, 18:22
avivey created T15048: Allow awarding Tokens to individual Comments.
Wed, Sep 22, 16:15
avivey added a comment to T15047: Officially raise minimum required PHP version to 7.2.

+1 for CentOS 7.

Wed, Sep 22, 16:04 · Phorge

Sep 20 2021

avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I may be late for the party, but can't the translated verbiage be provided to the dialog in the $form_attributes in AphrontDialogView.php:337, and read using form.getAttribute(key) in the js?

Sep 20 2021, 15:04 · Maniphest

Sep 6 2021

avivey awarded T15046: Add GitHub mirrors for repos a Like token.
Sep 6 2021, 05:22 · Nuance, Phorge Upstream, Diffusion

Aug 26 2021

avivey added a comment to T15039: Add a button to copy key information.

Turns out there is Javelin support for "copy text" already implemented - I think it's used when copying from 2-up display, or when white-space is visible.
Anyway, I have an example code at https://secure.phabricator.com/P2080 for a button that copies arbitrary text.

Aug 26 2021, 17:41 · Differential
avivey awarded T15039: Add a button to copy key information a Like token.
Aug 26 2021, 17:38 · Differential
avivey added a comment to T15038: Offer a custom neutral timezone.

I think I just set that via "Global Default": https://we.phorge.it/settings/builtin/global/

Aug 26 2021, 17:32 · Phorge General/Unknown, Governance

Aug 24 2021

avivey added a comment to T15016: Update default storage namespace.

I like the idea of having an easily greppeable token...

Aug 24 2021, 17:05 · Phorge General/Unknown

Aug 20 2021

avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

What are the implications of making changes to the javelinjs.com https://github.com/phacility/javelin/ library?

Aug 20 2021, 06:58 · Maniphest

Aug 11 2021

avivey updated the task description for T15010: Vision Statement.
Aug 11 2021, 20:04 · Phorge, Governance
avivey added a comment to T15010: Vision Statement.

I agree with the doc, and would like to sign too.

Aug 11 2021, 20:03 · Phorge, Governance

Jul 28 2021

avivey added a subtask for T15000: Ad hoc setup tasks: T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses.
Jul 28 2021, 16:49 · Upstream General/Unknown
avivey added a parent task for T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses: T15000: Ad hoc setup tasks.
Jul 28 2021, 16:49 · Phorge Upstream
avivey awarded T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses a Like token.
Jul 28 2021, 16:49 · Phorge Upstream
avivey added a comment to T15035: Discuss communications channels (IRC, etc).

I just want everything "important" to be happening here, where the search and cross-references works and async communication is easy.

Jul 28 2021, 16:48 · Phorge Upstream
avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

The translated text can be a property of the dialogue itself, if we're worried about having extra objects laying around - the confirmation feels like it's a feature of the dialogue anyway.

Jul 28 2021, 07:20 · Maniphest
avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

There's no way to invoke pht from JS (because it's really complicated in the general case). The general practice is to provide the translated value from PHP when building the relevant objects. There should be an example in the UIExamples app - there's a page with buttons built in JS.

Jul 28 2021, 07:11 · Maniphest
avivey added a comment to T15014: Develop a Phorge Release Process.

There already are a bunch of worthwhile changes in Phabricator we should pick up; @Matthew - want to load them to check out the procedure? I can do that otherwise.

Jul 28 2021, 07:08 · Phorge

Jul 17 2021

avivey added a comment to T15030: Support a Phorge Extensions ecosystem.

Here's the terms I've been thinking of for accepting a project to Phactory:

  1. Directly related to Phorge in a significant way:

Good: Module for integration with some other system; New Phorge app that does something reasonable; scripts for administration work.
Bad: A space-zombie game that can report high-scores to IRC, Slack and Phorge.

Jul 17 2021, 07:23 · Phorge
avivey updated the task description for T15022: Legal stuff.
Jul 17 2021, 06:50 · Phorge

Jul 13 2021

avivey added a comment to T15030: Support a Phorge Extensions ecosystem.
In T15030#916, @dcog wrote:
In T15030#914, @avivey wrote:

We are planning on hosting community-driven extensions/projects (temp codename "Phactory"), either here or in a different domain; the idea is to have each project maintain their own repositories.

That sounds awesome! Cool name :) Curious, did this come up in Zulip? I need to log back in there.

Jul 13 2021, 16:48 · Phorge
avivey added a comment to T15014: Develop a Phorge Release Process.

nit-pick: maybe name them phabricator/master and phabricator/stable.

Jul 13 2021, 16:21 · Phorge
avivey added a comment to T15030: Support a Phorge Extensions ecosystem.

(I should stop reading stuff before coffee. You'd think I'd know that by now...)

Jul 13 2021, 08:34 · Phorge
avivey added a comment to T15030: Support a Phorge Extensions ecosystem.

I'm thinking of hosting them here, giving each project to manage their own repositories, but having a more tight control over the creation of the repo (for technical reasons) and projects.
I'd like to only have projects that are clearly related to Phorge in the install, because we're not GitHub.

Jul 13 2021, 06:34 · Phorge
avivey added a comment to T15030: Support a Phorge Extensions ecosystem.

We are planning on hosting community-driven extensions/projects (temp codename "Phactory"), either here or in a different domain; the idea is to have each project maintain their own repositories.

Jul 13 2021, 06:26 · Phorge

Jul 10 2021

avivey added a comment to T15010: Vision Statement.

I would like to officially submit myself as a Core Team member.

Jul 10 2021, 17:24 · Phorge, Governance

Jul 7 2021

avivey added a comment to T15006: Re-brand Phorge.

TBH, I'm a little confused about the way forward here, and I think this our biggest blocker?
I have some time I can put towards this, but I'm not sure what I should be doing.

Jul 7 2021, 18:02 · Phorge

Jul 3 2021

avivey added a comment to T15025: Simple Production Docker Stack.

Caddy looks interesting - if you get it going, can you make a small instructions writeup?

Jul 3 2021, 06:33 · Phorge General/Unknown
avivey awarded T15025: Simple Production Docker Stack a Like token.
Jul 3 2021, 06:20 · Phorge General/Unknown

Jul 1 2021

avivey added a comment to T15010: Vision Statement.

I like the current version :)

Jul 1 2021, 19:26 · Phorge, Governance

Jun 27 2021

avivey added a comment to T15010: Vision Statement.

Are we reasonably ok with what we have in the google doc?

Jun 27 2021, 19:32 · Phorge, Governance

Jun 26 2021

avivey added a comment to T15024: Landbot discussion(s), and generally ensuring that what is landed is what was reviewed.

The plan upstream was to (eventually) have arc land trigger T182, and do the whole thing server-side.

Jun 26 2021, 17:55 · Phorge General/Unknown
avivey added inline comments to D25002: T15006: Replacing external-facing trademarks/assets.
Jun 26 2021, 13:06
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

If you can break it to one diff with the new method/css stuff and one or two string changes, and several with only string change, we can just review it and land them one at a time.

Jun 26 2021, 06:38

Jun 25 2021

avivey added a comment to T15021: Exclude the Aphlict package-lock.json from linting rule.

ahh, there's a global setting for revisions - differential.generated-paths.

Jun 25 2021, 18:56 · Aphlict
avivey added a comment to T15021: Exclude the Aphlict package-lock.json from linting rule.

I was thinking of ArcanistGeneratedLinter.php, but it looks like the only way to mark a file is by adding @generated in it, and I think we can't do that?
I thought there was another way, because this also applies to revisions (it folds the file by default).

Jun 25 2021, 18:55 · Aphlict
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

Could we...

  1. Create a new Translation which specifically translates the token : e.g. %PHAB or {{Phabricator}} or {{PhabricatorWordmark}} or whatever
Jun 25 2021, 16:15
avivey added a comment to P2 Output from avivey script.

https://we.phorge.it/source/phorge/browse/master/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php has a few more instances of Phabricator (not in pht()).

Jun 25 2021, 15:42
avivey added a comment to T15014: Develop a Phorge Release Process.

(I'm 100% with @speck on requiring tasks)

Jun 25 2021, 15:11 · Phorge
avivey added a comment to T15016: Update default storage namespace.

@deadalnix's I like option 3 from a UX perspective - and it also lets us hold on this issue for a little while, without making things worse.

Jun 25 2021, 15:09 · Phorge General/Unknown
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

I had a thought, that adding a %xx argument to pht without matching argument is probably not a really good idea, so I went exploring.

Jun 25 2021, 08:27

Jun 24 2021

avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

I didn't talk with him in a while. Maybe opening a ticket in secure.phabricator.com is the quickest way?

Jun 24 2021, 17:22
avivey added a comment to T15014: Develop a Phorge Release Process.

Now, can we get a setup with CircleCI going so that we can test things?

Jun 24 2021, 15:08 · Phorge
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

I like the {Phabricator} idea! For technical compatibility with the rest of pht, it should probably be something like %PH.

Jun 24 2021, 05:41

Jun 23 2021

avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

Running ./bin/i18n extract . and then this scripts, shows 455 strings with the words Phabricator or Phacility (1 for Phacility), plus 19 in arcanist.

Jun 23 2021, 20:15
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.
In D25002#144, @speck wrote:

Still need to search for instances of Phabricator appearing anywhere within quotes. Testing all this will be fun.

Jun 23 2021, 19:39
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

How can I help?
Are we down to just grepping, or is there still some design left to do?

Jun 23 2021, 19:38
avivey added a comment to D25002: T15006: Replacing external-facing trademarks/assets.

It says "Lint/Unit were skipped" for this diff - did you actually "skip" them, or is this some setup/usage artifact?

Jun 23 2021, 18:31
avivey triaged T15000: Ad hoc setup tasks as High priority.
Jun 23 2021, 18:27 · Upstream General/Unknown
avivey triaged T15005: Create Logo / Brand Assets as High priority.
Jun 23 2021, 18:27 · Phorge
avivey triaged T15008: Build Welcome Site as High priority.
Jun 23 2021, 18:27 · Upstream General/Unknown
avivey triaged T15009: Foundation as High priority.
Jun 23 2021, 18:27 · Phorge, Governance
avivey triaged T15022: Legal stuff as High priority.
Jun 23 2021, 18:27 · Phorge
avivey triaged T15004: Decide who has admin/commit/security access as Unbreak Now! priority.
Jun 23 2021, 18:27 · Phorge, Governance
avivey triaged T15006: Re-brand Phorge as Unbreak Now! priority.
Jun 23 2021, 18:26 · Phorge
avivey triaged T15010: Vision Statement as Unbreak Now! priority.
Jun 23 2021, 18:26 · Phorge, Governance
avivey added a comment to D25011: Remove CircleCI specific code from all over the place.

@deadalnix: want to move the bigger discussion to a ny task? I'm on a mobile right now.

Jun 23 2021, 15:27
avivey added a comment to D25011: Remove CircleCI specific code from all over the place.

One point that you raised and I disagree with: we do have lots of users right now. We (I) consider all the installs of Phabricator to be Phorge installs in-waiting; we want to keep compatibility there, for a while yet - to ease their transition.

Jun 23 2021, 14:07
avivey added a comment to D25011: Remove CircleCI specific code from all over the place.

+1 for holding any product change until we're officially "up".

Jun 23 2021, 05:54

Jun 22 2021

avivey created T15022: Legal stuff.
Jun 22 2021, 15:00 · Phorge

Jun 21 2021

avivey added a comment to T15014: Develop a Phorge Release Process.

I think that for the time-being, we should just continue the stable/master approach, because we have a lot of other things to do.
We can always open this later if we feel a need.

Jun 21 2021, 19:43 · Phorge
avivey added a comment to T15021: Exclude the Aphlict package-lock.json from linting rule.

There might be a way to explicitly define it as generated, which (used to) exclude it from lint.

Jun 21 2021, 17:33 · Aphlict
avivey added a comment to T15014: Develop a Phorge Release Process.

Can I please have access to Release Process ?

Jun 21 2021, 17:32 · Phorge

Jun 19 2021

avivey accepted D25003: Arcanist Update .arcconfig to point to we.phorge.it.
Jun 19 2021, 16:47
avivey added inline comments to D25002: T15006: Replacing external-facing trademarks/assets.
Jun 19 2021, 13:56
avivey added inline comments to D25002: T15006: Replacing external-facing trademarks/assets.
Jun 19 2021, 13:24

Jun 18 2021

avivey added a comment to T15011: Build a Phorge Developer Environment.

I have a plan for a single docker container for developing extensions.
It's really a question of "what will people like", so maybe throw everything at the wall and see what sticks.

Jun 18 2021, 15:37 · Phorge General/Unknown
avivey added a comment to T15000: Ad hoc setup tasks.
  • we.phorge.it works fine in Chrome, but arc has some issues w.r.t. CURLE_SSL_CACERT; I expect it might solve itself after a restart/update of my local machine.
  • git fetch from the new uri shows no errors
  • the push dragon still thinks rP51cb7a3db9 to 2abd75c162 is not fast-forward.
Jun 18 2021, 05:43 · Upstream General/Unknown
avivey accepted D25002: T15006: Replacing external-facing trademarks/assets.
Jun 18 2021, 05:25
avivey accepted D25001: T15006: Update .arcconfig to point to we.phorge.it.
Jun 18 2021, 05:22

Jun 17 2021

avivey added a comment to T15005: Create Logo / Brand Assets.

BTW, it's intentional that the place of the logo is currently a blank space, right?

image.png (96×133 px, 1 KB)

Jun 17 2021, 21:24 · Phorge
avivey updated the task description for T15000: Ad hoc setup tasks.
Jun 17 2021, 21:20 · Upstream General/Unknown
avivey updated the task description for T15000: Ad hoc setup tasks.
Jun 17 2021, 21:10 · Upstream General/Unknown
avivey updated the diff for D25000: Update Readme.

Squash and rebase change

Jun 17 2021, 21:06
avivey added a comment to T15000: Ad hoc setup tasks.

Maybe create ssh.log file and chown it to git? and hope that's the only file it needs to write to?
I'm guessing from the name that it's only used by the SSH flow.

Jun 17 2021, 20:57 · Upstream General/Unknown
avivey added a comment to T15000: Ad hoc setup tasks.

The release strategy of Phabricator was:

  • everything goes into master asap, unless it's dangerous
  • once a week, master gets merged into stable
    • after that, all the "dangerous" stuff lands to master
  • important stuff that comes up during the week gets cherry-picked to stable.
Jun 17 2021, 20:46 · Upstream General/Unknown
avivey added a comment to T15000: Ad hoc setup tasks.

I think /var/repo should be owned by git:

Jun 17 2021, 20:43 · Upstream General/Unknown
avivey added a comment to T15000: Ad hoc setup tasks.

I think secure. had instructions about file ownership - looking...

Jun 17 2021, 20:42 · Upstream General/Unknown
avivey added a comment to T15000: Ad hoc setup tasks.

That one is totally my fault - 4042d24d74 is a local commit I have (updates .arcconfig). But I was trying the push from a different commit, which has 51cb7a3db9 as its (only) parent.

Jun 17 2021, 20:35 · Upstream General/Unknown
avivey added a comment to T15000: Ad hoc setup tasks.

git version 2.32.0.rc3 locally; 2.25.1 on the server. Both reasonably recent...

Jun 17 2021, 19:59 · Upstream General/Unknown
avivey added a comment to T15006: Re-brand Phorge.
  • Emails have a bunch of X-Phabricator-* headers, for configuring rules in mail clients.
Jun 17 2021, 16:11 · Phorge
avivey added a comment to T15008: Build Welcome Site.

I think we want an Application in an Extension...

Jun 17 2021, 15:49 · Upstream General/Unknown
avivey added a comment to T15000: Ad hoc setup tasks.

Also won't let me push, because something thinks it's a non-fast-forward (it is, unless I'm drunk):

$ git push phorge 2abd75c162:master
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 817 bytes | 408.00 KiB/s, done.
Total 3 (delta 1), reused 0 (delta 0), pack-reused 0
remote: +---------------------------------------------------------------+
remote: |      * * * PUSH REJECTED BY EVIL DRAGON BUREAUCRATS * * *     |
remote: +---------------------------------------------------------------+
remote:              \
remote:               \                    ^    /^
remote:                \                  / \  // \
remote:                 \   |\___/|      /   \//  .\
remote:                  \  /V  V  \__  /    //  | \ \           *----*
remote:                    /     /  \/_/    //   |  \  \          \   |
remote:                    @___@`    \/_   //    |   \   \         \/\ \
remote:                   0/0/|       \/_ //     |    \    \         \  \
remote:               0/0/0/0/|        \///      |     \     \       |  |
remote:            0/0/0/0/0/_|_ /   (  //       |      \     _\     |  /
remote:         0/0/0/0/0/0/`/,_ _ _/  ) ; -.    |    _ _\.-~       /   /
remote:                     ,-}        _      *-.|.-~-.           .~    ~
remote:   *     \__/         `/\      /                 ~-. _ .-~      /
remote:    \____(Oo)            *.   }            {                   /
remote:    (    (..)           .----~-.\        \-`                 .~
remote:    //___\\  \ DENIED!  ///.----..<        \             _ -~
remote:   //     \\                ///-._ _ _ _ _ _ _{^ - - - - ~
remote:
remote:
remote: DANGEROUS CHANGE: The change you're attempting to push updates the branch 'master' from '51cb7a3db9e8' to '2abd75c16237', but this is not a fast-forward. Pushes which rewrite published branch history are dangerous.
remote: Dangerous change protection is enabled for this repository.
remote: Edit the repository configuration before making dangerous changes.
remote:
[2021-06-17 15:41:20] EXCEPTION: (Exception) Unable to write to logfile "/var/log/phorge/ssh.log"! at [<arcanist>/src/filesystem/PhutilDeferredLog.php:193]
arcanist(head=master, ref.master=246e604a070f), phabricator(head=master, ref.master=5e3f4e418f5c)
  #0 <#2> PhutilDeferredLog::__destruct()
  #1 phlog(Exception) called at [<arcanist>/src/filesystem/PhutilDeferredLog.php:201]
  #2 PhutilDeferredLog::write() called at [<arcanist>/src/filesystem/PhutilDeferredLog.php:155]
  #3 PhutilDeferredLog::__destruct()
[2021-06-17 15:41:20] EXCEPTION: (Exception) Unable to write to logfile "/var/log/phorge/ssh.log"! at [<arcanist>/src/filesystem/PhutilDeferredLog.php:193]
To ssh://secure.phorge.it:2222/source/phorge.git
 ! [remote rejected]       2abd75c162 -> master (pre-receive hook declined)
error: failed to push some refs to 'ssh://secure.phorge.it:2222/source/phorge.git'
Jun 17 2021, 15:43 · Upstream General/Unknown
avivey added a comment to T15000: Ad hoc setup tasks.

There's some issue with the SSH settings here - probably file permissions?

Jun 17 2021, 15:39 · Upstream General/Unknown

Jun 16 2021

avivey updated the diff for D25000: Update Readme.
  • stray phabricator
Jun 16 2021, 19:43
avivey added inline comments to D25000: Update Readme.
Jun 16 2021, 19:32
avivey added a comment to D25000: Update Readme.

This is basically the pre-deprecation README from Phabricator, with some names changed.

Jun 16 2021, 18:11
avivey added a comment to T15006: Re-brand Phorge.

./NOTICE has some legal text we might need help with.

Jun 16 2021, 18:08 · Phorge
avivey added a revision to T15006: Re-brand Phorge: D25000: Update Readme.
Jun 16 2021, 18:07 · Phorge
avivey retitled D25000: Update Readme from Update Readme Ref T15006 to Update Readme.
Jun 16 2021, 18:07
avivey requested review of D25000: Update Readme.
Jun 16 2021, 18:04