Page MenuHomePhorge

aklapper (Andre Klapper)
Bot

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2023, 20:44 (51 w, 12 h)
Availability
Available

Recent Activity

Tue, Feb 13

aklapper closed T15720: Improve messages when no image formats are supported (due to GD not installed) as Resolved by committing rPe2bec4c1f58b: Improve messages when no image formats are supported (due to GD not installed).
Tue, Feb 13, 16:07
aklapper closed D25525: Improve messages when no image formats are supported (due to GD not installed).
Tue, Feb 13, 16:07
aklapper committed rPe2bec4c1f58b: Improve messages when no image formats are supported (due to GD not installed).
Improve messages when no image formats are supported (due to GD not installed)
Tue, Feb 13, 16:07
aklapper updated the diff for D25502: Make PhabricatorSearchIntField validate its input.

Remove unreached return call as pointed out by speck

Tue, Feb 13, 15:58
aklapper added a comment to D25502: Make PhabricatorSearchIntField validate its input.
In D25502#15384, @speck wrote:

Is it possible to check if anything is relying on this not working with negative numbers?

Tue, Feb 13, 15:56

Mon, Feb 12

aklapper added a comment to D25491: Improve contrast of Links in Dark Mode.

@deric: Hi, would you like to arc land your patch, or do you need any help? Thanks in advance!

Mon, Feb 12, 12:29
aklapper added a comment to D25502: Make PhabricatorSearchIntField validate its input.

For the records, adding public function getValueForQuery($value) is needed because otherwise Expected a numeric scalar or null for %d conversion. Query: project.projectDepth >= %d

Mon, Feb 12, 12:28
aklapper added a comment to D25502: Make PhabricatorSearchIntField validate its input.

Would anyone fancy reviewing this? :)

Mon, Feb 12, 12:27
aklapper closed T15685: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Mon, Feb 12, 12:26 · PHP 8 support
aklapper closed T15685: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured as Resolved by committing rP052b5f41c705: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest….
Mon, Feb 12, 12:26 · PHP 8 support
aklapper closed D25489: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.
Mon, Feb 12, 12:26
aklapper committed rP052b5f41c705: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest….
Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest…
Mon, Feb 12, 12:26
aklapper closed T15129: Unmark Audit as a required application as Resolved by committing rP821708414eec: Allow to uninstall (hide) Audit application.
Mon, Feb 12, 11:10 · Diffusion, User-Cigaryno
aklapper closed D25503: Allow to uninstall (hide) Audit application.
Mon, Feb 12, 11:10
aklapper committed rP821708414eec: Allow to uninstall (hide) Audit application.
Allow to uninstall (hide) Audit application
Mon, Feb 12, 11:10
aklapper updated the diff for D25525: Improve messages when no image formats are supported (due to GD not installed).

Make code more readable

Mon, Feb 12, 11:01
aklapper added a comment to D25525: Improve messages when no image formats are supported (due to GD not installed).

Maybe simplify if (empty($v)) { to just if ($v) { and swapping the case

Mon, Feb 12, 11:00

Sat, Feb 10

aklapper added a comment to T15630: Fix Fonts.

For consideration of the bigger picture, I'd like to mention https://collinmbarrett.com/block-web-fonts (performance etc) and for example Firefox 118+ blocking font fingerprinting in private windows (yes, private only, but I can vaguely imagine expansion).

Sat, Feb 10, 14:42

Thu, Feb 8

aklapper added a comment to T15630: Fix Fonts.

I am honestly happy that you have the privilege to afford getting bigger screens. Unfortunately not everyone has. The point I'm trying to make is: There may be valid + good reasons to increase font sizes, absolutely. However, "go with the time" and "times have changed" phrases are neither valid reasons nor argumentations. :)

Thu, Feb 8, 16:03
aklapper added a comment to T15630: Fix Fonts.
In T15630#15561, @bekay wrote:

Times have changed and we all have very big screens.

Thu, Feb 8, 12:09

Tue, Feb 6

aklapper accepted D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.
Tue, Feb 6, 12:31
aklapper foisted D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries upon avivey.

Testing if "Foist Upon" does what I hope it does

Tue, Feb 6, 12:31
aklapper added a comment to D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.

@avivey Much cleaner and also works as expected (just tested). Thanks for finding that better approach! Now how can I approve your patch as I'm still set as original author, sigh?

Tue, Feb 6, 12:30
aklapper added inline comments to D25526: Avoid exception in revision timeline when left diff does not exist.
Tue, Feb 6, 10:45
avivey awarded D25533: Deprecate Fund and Phortune prototype applications a Yellow Medal token.
Tue, Feb 6, 09:18
aklapper closed D25533: Deprecate Fund and Phortune prototype applications.
Tue, Feb 6, 08:16
aklapper committed rP01b5bf9ea102: Deprecate Fund and Phortune prototype applications.
Deprecate Fund and Phortune prototype applications
Tue, Feb 6, 08:16

Mon, Feb 5

aklapper closed T15714: Validate PhabricatorSearchTextField value as Resolved by committing rPe3714c86a7d5: Validate PhabricatorSearchTextField value not to be an array.
Mon, Feb 5, 21:42
aklapper closed D25519: Validate PhabricatorSearchTextField value not to be an array.
Mon, Feb 5, 21:42
aklapper committed rPe3714c86a7d5: Validate PhabricatorSearchTextField value not to be an array.
Validate PhabricatorSearchTextField value not to be an array
Mon, Feb 5, 21:42
aklapper requested review of D25533: Deprecate Fund and Phortune prototype applications.
Mon, Feb 5, 21:39
aklapper added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

I'm not sure from the description if it's only broken on php 8. We also have PayPal integration)

Mon, Feb 5, 21:28
aklapper accepted D25532: unbreak celerity/map.

Also my fault for obviously not testing /all/ steps in D25530

Mon, Feb 5, 17:58
aklapper closed T15602: PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Mon, Feb 5, 15:09 · PHP 8 support
aklapper closed T15602: PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists as Resolved by committing rPbb23e86dafc6: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of….
Mon, Feb 5, 15:09 · PHP 8 support
aklapper closed D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
Mon, Feb 5, 15:09
aklapper committed rPbb23e86dafc6: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of….
Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of…
Mon, Feb 5, 15:09
aklapper closed D25524: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string.
Mon, Feb 5, 13:11
aklapper committed rP25aebab655fd: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of….
Make misc get*ApplicationClass[Name]() calls return ::class constant instead of…
Mon, Feb 5, 13:11

Sun, Feb 4

aklapper added a comment to T15630: Fix Fonts.

cf a very similar discussion about default fonts in GNOME at https://gitlab.gnome.org/GNOME/gsettings-desktop-schemas/-/issues/52 regarding aspects to take into consideration

Sun, Feb 4, 11:37

Thu, Feb 1

aklapper added a revision to T15158: "Modernize" codebase to features available since PHP 5.5 (that is the actual announced minimum): D25524: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string.
Thu, Feb 1, 14:12 · Phorge, Arcanist, User-valerio.bozzolan
aklapper updated the summary of D25524: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string.
Thu, Feb 1, 14:12

Sun, Jan 28

aklapper added a comment to D25524: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string.

@valerio.bozzolan Thanks. I guess I owe you a drink next weekend :)

Sun, Jan 28, 18:17
aklapper closed D25500: Add getQueryApplicationClass() to *TransactionQuery.php classes.
Sun, Jan 28, 16:10
aklapper committed rP064424c1b755: Add getQueryApplicationClass() to *TransactionQuery.php classes.
Add getQueryApplicationClass() to *TransactionQuery.php classes
Sun, Jan 28, 16:10
aklapper requested review of D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
Sun, Jan 28, 15:59
aklapper accepted D25530: Revert "Added cross-platform default fonts".
Sun, Jan 28, 15:56
aklapper added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

@valerio.bozzolan: Which problem would that solve? :)

Sun, Jan 28, 15:53

Sat, Jan 27

aklapper planned changes to D25531: Remove dysfunctional Fund and Phortune prototype applications.

Test Plan still to be fully executed thus setting "Plan Changes"

Sat, Jan 27, 13:30
aklapper requested review of D25531: Remove dysfunctional Fund and Phortune prototype applications.
Sat, Jan 27, 13:29
aklapper added a revision to T15726: Remove dysfunctional Fund and Phortune prototype applications: D25531: Remove dysfunctional Fund and Phortune prototype applications.
Sat, Jan 27, 13:29
aklapper renamed T15726: Remove dysfunctional Fund and Phortune prototype applications from Phortune: Stripe Payments Account API changes to Remove dysfunctional Fund and Phortune prototype applications.
Sat, Jan 27, 13:28
aklapper closed T15727: Update external timezone information file from 2016 as Resolved by committing rP6a30dc039ea5: Update external timezone information.
Sat, Jan 27, 12:29
aklapper closed D25529: Update external timezone information.
Sat, Jan 27, 12:29
aklapper committed rP6a30dc039ea5: Update external timezone information.
Update external timezone information
Sat, Jan 27, 12:29
aklapper added a comment to D25529: Update external timezone information.

I admit I did not test what happens when setting a (deprecated) timezone in Phorge to be removed by this patch, and then applying this patch.

Sat, Jan 27, 12:28
aklapper updated the test plan for D25529: Update external timezone information.
Sat, Jan 27, 12:20
aklapper added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

Makes sense.
Fund: Going to http://phorge.localhost/fund/create/ and creating a New Initiative anyway yields

EXCEPTION: (RuntimeException) Undefined array key "totalAsCurrency" at [<arcanist>/src/error/PhutilErrorHandler.php:273]
arcanist(head=master, ref.master=6c7caf3572f4), phorge(head=master, ref.master=c0191a039293)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:345]
Sat, Jan 27, 12:12
aklapper added a comment to D25529: Update external timezone information.

I admit I did not test what happens when setting a (deprecated) timezone in Phorge to be removed by this patch, and then applying this patch.

Sat, Jan 27, 08:35
aklapper requested review of D25529: Update external timezone information.
Sat, Jan 27, 08:33
aklapper added a revision to T15727: Update external timezone information file from 2016: D25529: Update external timezone information.
Sat, Jan 27, 08:33
aklapper closed D25528: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Sat, Jan 27, 08:20
aklapper closed T15725: PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Sat, Jan 27, 08:20 · PHP 8 support
aklapper closed T15725: PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune as Resolved by committing rPc0191a039293: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Sat, Jan 27, 08:20 · PHP 8 support
aklapper committed rPc0191a039293: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune
Sat, Jan 27, 08:20
aklapper created T15727: Update external timezone information file from 2016.
Sat, Jan 27, 08:19
aklapper updated the test plan for D25528: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Sat, Jan 27, 07:23

Fri, Jan 26

aklapper created T15726: Remove dysfunctional Fund and Phortune prototype applications.
Fri, Jan 26, 18:24
aklapper requested review of D25528: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Fri, Jan 26, 18:13
aklapper added a revision to T15725: PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune: D25528: Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Fri, Jan 26, 18:13 · PHP 8 support
aklapper created T15725: PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune.
Fri, Jan 26, 18:12 · PHP 8 support
aklapper created T15724: PHP 8.3: ldap_connect() call signature deprecated.
Fri, Jan 26, 17:52
aklapper added a comment to D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.

In an ideal world 1030-1313 could become just:

Fri, Jan 26, 11:14
aklapper requested review of D25527: Convert "Page Size" field in Maniphest Advanced Search to PhabricatorSearchIntField.
Fri, Jan 26, 11:01
aklapper added a revision to T15723: Convert "Page Size" field in ManiphestTaskSearchEngine.php to PhabricatorSearchIntField: D25527: Convert "Page Size" field in Maniphest Advanced Search to PhabricatorSearchIntField.
Fri, Jan 26, 11:01
aklapper created T15723: Convert "Page Size" field in ManiphestTaskSearchEngine.php to PhabricatorSearchIntField.
Fri, Jan 26, 10:55
aklapper requested review of D25526: Avoid exception in revision timeline when left diff does not exist.
Fri, Jan 26, 10:42
aklapper added a revision to T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php: D25526: Avoid exception in revision timeline when left diff does not exist.
Fri, Jan 26, 10:42

Wed, Jan 24

aklapper added a comment to D25517: Mark manually created Diffs as new objects to fix empty Feed transaction entries.

// TODO: Once everything is on EditEngine, just use getIsNewObject()

So maybe this? but I'm not bold enough:

Wed, Jan 24, 10:35
aklapper added a comment to T15720: Improve messages when no image formats are supported (due to GD not installed).

Before and after applying D25525:

Wed, Jan 24, 10:16
aklapper requested review of D25525: Improve messages when no image formats are supported (due to GD not installed).
Wed, Jan 24, 10:15
aklapper added a revision to T15720: Improve messages when no image formats are supported (due to GD not installed): D25525: Improve messages when no image formats are supported (due to GD not installed).
Wed, Jan 24, 10:15
aklapper created T15720: Improve messages when no image formats are supported (due to GD not installed).
Wed, Jan 24, 10:07
aklapper added inline comments to D25518: Allow setting default value for SearchFields; set Maniphest Page Size to 100.
Wed, Jan 24, 09:08

Tue, Jan 23

aklapper closed D25515: Avoid exception setting project profile image when GD not installed.
Tue, Jan 23, 14:11
aklapper closed T15326: PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring() as Resolved by committing rP7a86040f8a46: Avoid exception setting project profile image when GD not installed.
Tue, Jan 23, 14:11 · Files, PHP 8 support
aklapper committed rP7a86040f8a46: Avoid exception setting project profile image when GD not installed.
Avoid exception setting project profile image when GD not installed
Tue, Jan 23, 14:11
aklapper added inline comments to D25518: Allow setting default value for SearchFields; set Maniphest Page Size to 100.
Tue, Jan 23, 14:03
aklapper updated the diff for D25500: Add getQueryApplicationClass() to *TransactionQuery.php classes.

and thus remove the only newly added call which returned null in src/applications/meta/query/PhabricatorApplicationApplicationTransactionQuery.php)

Tue, Jan 23, 13:42
aklapper added a comment to D25500: Add getQueryApplicationClass() to *TransactionQuery.php classes.

Maybe we can return ClassName::class - that is supported since PHP 5.5

there's a lot more code to update in random *Query.php classes defining getQueryApplicationClass() functions, in a separate future patch

Tue, Jan 23, 13:37
aklapper requested review of D25524: Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string.
Tue, Jan 23, 13:36
aklapper added a comment to D25501: Feed: Do not query and display data of uninstalled applications.

Right. Sorry, my previous comment was very misleading!

Tue, Jan 23, 07:40

Mon, Jan 22

aklapper added a comment to D25500: Add getQueryApplicationClass() to *TransactionQuery.php classes.

Maybe we can return ClassName::class - that is supported since PHP 5.5

Note to myself: Makes sense; there's a lot more code to update in random *Query.php classes defining getQueryApplicationClass() functions, in a separate future patch

Mon, Jan 22, 23:17
aklapper updated the diff for D25500: Add getQueryApplicationClass() to *TransactionQuery.php classes.

Revert turning getQueryApplicationClass() abstract in the parent class src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php and make it return null again (and thus remove the only newly added call which returned null in src/applications/meta/query/PhabricatorApplicationApplicationTransactionQuery.php); also return ::class as proposed by Valerio

Mon, Jan 22, 23:14
aklapper updated the diff for D25501: Feed: Do not query and display data of uninstalled applications.

Fix D25501#14443: Do not show an "Query overheated" error when the user is anonymous and the application has been uninstalled

Mon, Jan 22, 22:01
aklapper added a comment to D25501: Feed: Do not query and display data of uninstalled applications.

Are there any feed transactions that are visible to logged out users?

Mon, Jan 22, 21:34
aklapper updated the diff for D25489: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.

Play it safe by using phutil_nonempty_scalar() and do not assume that integers are actually integers (because "1" and such)

Mon, Jan 22, 18:43
aklapper added a comment to D25515: Avoid exception setting project profile image when GD not installed.

I was able to trigger the "missing gd" warning (By uninstalling php*gd), so we're good there.
A bit puzzled about how you got the error if you already have it installed?

Mon, Jan 22, 14:14
aklapper added a comment to D25515: Avoid exception setting project profile image when GD not installed.

I wonder if it then, upon deletion of the profile image, it attempts to delete the builtin image

Mon, Jan 22, 14:13
aklapper retitled D25522: Remove bottom margin from embedded remarkup images from Removes margin from embedded remarkup images
Mon, Jan 22, 10:24