Page MenuHomePhorge
People aklapper

aklapper (Andre Klapper)
User

Projects

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2023, 20:44 (12 w, 6 d)
Availability
Available

Recent Activity
View All

Today

aklapper requested review of D25265: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch.
Tue, May 30, 18:16
aklapper added a revision to T15434: PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch: D25265: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch.
Tue, May 30, 18:16 · PHP 8 support
aklapper created T15434: PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch.
Tue, May 30, 18:15 · PHP 8 support
aklapper updated the summary of D25240: Fix PHP 8.1 "strlen(null)" exception which blocks rendering errors on Create Blueprint page.
Tue, May 30, 14:59
aklapper updated the summary of D25248: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Browse Herald Rules" dialog.
Tue, May 30, 14:58
aklapper updated the summary of D25258: Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed.
Tue, May 30, 14:57
aklapper updated the summary of D25259: Fix PHP 8.1 "trim(null)" exception which blocks rendering Conduit's harbormaster.sendmessage page.
Tue, May 30, 14:57
valerio.bozzolan awarded D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding a Mountain of Wealth token.
Tue, May 30, 13:28
aklapper updated the diff for D25250: Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards.

Make check in getUpcomingInput() also cover string "0" (as requested by valerio.bozzolan)

Tue, May 30, 11:27
aklapper updated the diff for D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.

Use strict mode

Tue, May 30, 11:24
aklapper updated the diff for D25240: Fix PHP 8.1 "strlen(null)" exception which blocks rendering errors on Create Blueprint page.

Uh neat. Thanks for that testing!

Tue, May 30, 11:16
aklapper requested review of D25264: Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page.
Tue, May 30, 11:05
aklapper added a revision to T15432: PHP 8.1 "strlen(null)" exceptions block rendering Differential Revision page: D25264: Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page.
Tue, May 30, 11:05 · PHP 8 support
aklapper created T15432: PHP 8.1 "strlen(null)" exceptions block rendering Differential Revision page.
Tue, May 30, 10:59 · PHP 8 support
aklapper requested review of D25263: Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in Differential when not entering data.
Tue, May 30, 10:35
aklapper added a revision to T15431: PHP 8.1 "preg_match(null)" exception blocks rendering "Create Revision" page in Differential: D25263: Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in Differential when not entering data.
Tue, May 30, 10:35 · PHP 8 support
aklapper created T15431: PHP 8.1 "preg_match(null)" exception blocks rendering "Create Revision" page in Differential.
Tue, May 30, 10:34 · PHP 8 support
aklapper requested review of D25262: Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface.
Tue, May 30, 10:22
aklapper added a revision to T15430: PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface: D25262: Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface.
Tue, May 30, 10:22 · PHP 8 support
aklapper created T15430: PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface.
Tue, May 30, 10:21 · PHP 8 support
aklapper closed T15429: Typo in English string "A merchant's members an always view and edit it." as Resolved by committing rPe11c5486c92b: Fix typo in PhortuneMerchant.php.
Tue, May 30, 10:01 · Good Starter Task
aklapper closed D25261: Fix typo in PhortuneMerchant.php.
Tue, May 30, 10:01
aklapper committed rPe11c5486c92b: Fix typo in PhortuneMerchant.php (authored by aklapper).
Fix typo in PhortuneMerchant.php
Tue, May 30, 10:00
aklapper requested review of D25261: Fix typo in PhortuneMerchant.php.
Tue, May 30, 09:50
aklapper added a revision to T15429: Typo in English string "A merchant's members an always view and edit it.": D25261: Fix typo in PhortuneMerchant.php.
Tue, May 30, 09:50 · Good Starter Task
aklapper created T15429: Typo in English string "A merchant's members an always view and edit it.".
Tue, May 30, 09:47 · Good Starter Task
aklapper closed T15428: PHP 8.1 "strlen(null)" exception blocks rendering Config's Database Status page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Tue, May 30, 08:59 · PHP 8 support
aklapper closed T15428: PHP 8.1 "strlen(null)" exception blocks rendering Config's Database Status page as Resolved by committing rP7cf210b76385: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Database….
Tue, May 30, 08:59 · PHP 8 support
aklapper closed D25260: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Database Status page.
Tue, May 30, 08:59
aklapper committed rP7cf210b76385: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Database… (authored by aklapper).
Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Database…
Tue, May 30, 08:59
aklapper closed T15425: PHP 8.1 "strlen(null)" exception blocks rendering Conduit's dashboard.panel.edit page as Resolved by committing rP72fdf232b4ab: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard..
Tue, May 30, 08:57 · PHP 8 support
aklapper closed T15425: PHP 8.1 "strlen(null)" exception blocks rendering Conduit's dashboard.panel.edit page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Tue, May 30, 08:57 · PHP 8 support
aklapper closed D25257: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard.panel.edit page.
Tue, May 30, 08:57
aklapper committed rP72fdf232b4ab: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard. (authored by aklapper).
Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard.
Tue, May 30, 08:57
aklapper closed T15421: PHP 8.1 "strlen(null)" exception blocks rendering a Diffusion repository page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Tue, May 30, 08:54 · PHP 8 support
aklapper closed T15421: PHP 8.1 "strlen(null)" exception blocks rendering a Diffusion repository page as Resolved by committing rP2a9eca696f09: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a Diffusion….
Tue, May 30, 08:54 · PHP 8 support
aklapper closed D25247: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a Diffusion repository page.
Tue, May 30, 08:54
aklapper committed rP2a9eca696f09: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a Diffusion… (authored by aklapper).
Fix PHP 8.1 "strlen(null)" exception which blocks rendering a Diffusion…
Tue, May 30, 08:54
aklapper closed T15269: Typos in English Differential strings: "Hold revision as as draft."; "You can not plan changes to this this revision" as Resolved by committing rPf2329f816504: Correct two spelling mistakes in Differential.
Tue, May 30, 08:46 · Good Starter Task, Differential
aklapper closed D25252: Correct two spelling mistakes in Differential.
Tue, May 30, 08:46
aklapper committed rPf2329f816504: Correct two spelling mistakes in Differential (authored by aklapper).
Correct two spelling mistakes in Differential
Tue, May 30, 08:46
aklapper closed D25251: Correct spelling mistake in PhabricatorAuditEditor.
Tue, May 30, 08:43
aklapper closed T15267: Typo in English string "A commit has a concerned raised against it." as Resolved by committing rPea43519c6bb1: Correct spelling mistake in PhabricatorAuditEditor.
Tue, May 30, 08:43 · Good Starter Task
aklapper committed rPea43519c6bb1: Correct spelling mistake in PhabricatorAuditEditor (authored by aklapper).
Correct spelling mistake in PhabricatorAuditEditor
Tue, May 30, 08:43

Yesterday

aklapper requested review of D25260: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Database Status page.
Mon, May 29, 17:46
aklapper added a revision to T15428: PHP 8.1 "strlen(null)" exception blocks rendering Config's Database Status page: D25260: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Database Status page.
Mon, May 29, 17:46 · PHP 8 support
aklapper created T15428: PHP 8.1 "strlen(null)" exception blocks rendering Config's Database Status page.
Mon, May 29, 17:44 · PHP 8 support
aklapper requested review of D25259: Fix PHP 8.1 "trim(null)" exception which blocks rendering Conduit's harbormaster.sendmessage page.
Mon, May 29, 14:54
aklapper added a revision to T15427: PHP 8.1 "trim(null)" exception blocks rendering Conduit's harbormaster.sendmessage page: D25259: Fix PHP 8.1 "trim(null)" exception which blocks rendering Conduit's harbormaster.sendmessage page.
Mon, May 29, 14:54 · PHP 8 support
aklapper created T15427: PHP 8.1 "trim(null)" exception blocks rendering Conduit's harbormaster.sendmessage page.
Mon, May 29, 14:50 · PHP 8 support
aklapper added a comment to T15425: PHP 8.1 "strlen(null)" exception blocks rendering Conduit's dashboard.panel.edit page.

The same exception also happens for user.edit, project.edit, portal.edit, phurls.edit, paste.edit, phame.blog.edit, phame.post.edit, owners.edit, macro.edit, maniphest.edit, harbormaster.step.edit.

Mon, May 29, 14:43 · PHP 8 support
aklapper requested review of D25258: Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed.
Mon, May 29, 11:31
aklapper added a revision to T15426: PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed: D25258: Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed.
Mon, May 29, 11:31 · PHP 8 support
aklapper created T15426: PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed.
Mon, May 29, 11:30 · PHP 8 support
aklapper requested review of D25257: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard.panel.edit page.
Mon, May 29, 11:18
aklapper added a revision to T15425: PHP 8.1 "strlen(null)" exception blocks rendering Conduit's dashboard.panel.edit page: D25257: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Conduit's dashboard.panel.edit page.
Mon, May 29, 11:18 · PHP 8 support
aklapper created T15425: PHP 8.1 "strlen(null)" exception blocks rendering Conduit's dashboard.panel.edit page.
Mon, May 29, 11:17 · PHP 8 support
aklapper closed T15361: PHP 8.1 "explode(null)" exception blocks rendering the Multimeter page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Mon, May 29, 10:36 · PHP 8 support
aklapper closed T15361: PHP 8.1 "explode(null)" exception blocks rendering the Multimeter page as Resolved by committing rP0d81da590923: Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page.
Mon, May 29, 10:36 · PHP 8 support
aklapper closed D25254: Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page.
Mon, May 29, 10:36
aklapper committed rP0d81da590923: Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page (authored by aklapper).
Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page
Mon, May 29, 10:36
aklapper updated the diff for D25254: Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page.

Indeed, getStr() can do that, right...

Mon, May 29, 08:43
aklapper closed T15268: Typo in English string "Lock '%s is not locked by this process!" as Resolved by committing rARC18554ea76ceb: Correct spelling mistake in PhutilLock.
Mon, May 29, 08:29 · Good Starter Task, Arcanist
aklapper closed D25253: Correct spelling mistake in PhutilLock.
Mon, May 29, 08:29
aklapper committed rARC18554ea76ceb: Correct spelling mistake in PhutilLock (authored by aklapper).
Correct spelling mistake in PhutilLock
Mon, May 29, 08:29

Sun, May 28

aklapper added a comment to T15164: Resolving without Claiming causes error "Action with no effect".

@valerio.bozzolan F267558 in the task description is not attached, thus it cannot be seen by others.

Sun, May 28, 15:13 · Maniphest, User-valerio.bozzolan
aklapper added a comment to D25255: Correct Phorge icon on Auth Provider page.

I have no idea how to create the hash value in resources/sprite/manifest/login.json. Probably there's some magic commands to do all of this. While I created the CSS etc manually.

Sun, May 28, 14:53
aklapper requested review of D25255: Correct Phorge icon on Auth Provider page.
Sun, May 28, 14:51
aklapper added a revision to T15403: Fix "Amazon" icon on Phorge OAuth: D25255: Correct Phorge icon on Auth Provider page.
Sun, May 28, 14:51 · Phorge
aklapper added a comment to T15403: Fix "Amazon" icon on Phorge OAuth.

getLoginIcon() { return PlatformSymbols::getPlatformServerName(); } returns Phorge.
Thus no corresponding icon is found as Phorge.png does not exist and code falls back to first icon.

Sun, May 28, 14:51 · Phorge
aklapper requested review of D25254: Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page.
Sun, May 28, 13:48
aklapper added a revision to T15361: PHP 8.1 "explode(null)" exception blocks rendering the Multimeter page: D25254: Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page.
Sun, May 28, 13:48 · PHP 8 support
aklapper requested review of D25253: Correct spelling mistake in PhutilLock.
Sun, May 28, 13:32
aklapper added a revision to T15268: Typo in English string "Lock '%s is not locked by this process!": D25253: Correct spelling mistake in PhutilLock.
Sun, May 28, 13:32 · Good Starter Task, Arcanist
aklapper requested review of D25252: Correct two spelling mistakes in Differential.
Sun, May 28, 13:31
aklapper added a revision to T15269: Typos in English Differential strings: "Hold revision as as draft."; "You can not plan changes to this this revision": D25252: Correct two spelling mistakes in Differential.
Sun, May 28, 13:31 · Good Starter Task, Differential
aklapper requested review of D25251: Correct spelling mistake in PhabricatorAuditEditor.
Sun, May 28, 13:23
aklapper added a revision to T15267: Typo in English string "A commit has a concerned raised against it.": D25251: Correct spelling mistake in PhabricatorAuditEditor.
Sun, May 28, 13:23 · Good Starter Task
aklapper requested review of D25250: Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards.
Sun, May 28, 13:02
aklapper added a revision to T15346: PHP 8.1 exceptions in JsonLint block rendering Tab Panels in Dashboards: D25250: Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards.
Sun, May 28, 13:02 · Arcanist, PHP 8 support
aklapper updated the task description for T15346: PHP 8.1 exceptions in JsonLint block rendering Tab Panels in Dashboards.
Sun, May 28, 12:45 · Arcanist, PHP 8 support

Sat, May 27

aklapper created T15424: Owners: Unhandled Exception: No repository PHID for path "0"!.
Sat, May 27, 12:06

Fri, May 26

aklapper updated the diff for D25246: Work around exception in Herald transcript of old tasks: Call to a member function getAppliedTransactionPHIDs() on bool.

This programming langauge clearly outsmarts me

Fri, May 26, 22:08
aklapper requested review of D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.
Fri, May 26, 21:44
aklapper added a revision to T15423: PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding: D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.
Fri, May 26, 21:44 · PHP 8 support
aklapper created T15423: PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.
Fri, May 26, 21:43 · PHP 8 support
aklapper updated the diff for D25248: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Browse Herald Rules" dialog.

Shorten 87 char line to pass linter

Fri, May 26, 21:36
aklapper requested review of D25248: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Browse Herald Rules" dialog.
Fri, May 26, 21:34
aklapper added a revision to T15422: PHP 8.1 "strlen(null)" exception blocks rendering the "Browse Herald Rules" dialog: D25248: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Browse Herald Rules" dialog.
Fri, May 26, 21:34 · PHP 8 support
aklapper created T15422: PHP 8.1 "strlen(null)" exception blocks rendering the "Browse Herald Rules" dialog.
Fri, May 26, 21:33 · PHP 8 support
aklapper requested review of D25247: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a Diffusion repository page.
Fri, May 26, 21:22
aklapper added a revision to T15421: PHP 8.1 "strlen(null)" exception blocks rendering a Diffusion repository page: D25247: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a Diffusion repository page.
Fri, May 26, 21:22 · PHP 8 support
aklapper created T15421: PHP 8.1 "strlen(null)" exception blocks rendering a Diffusion repository page.
Fri, May 26, 21:21 · PHP 8 support
aklapper updated the test plan for D25246: Work around exception in Herald transcript of old tasks: Call to a member function getAppliedTransactionPHIDs() on bool.
Fri, May 26, 14:29
aklapper requested review of D25246: Work around exception in Herald transcript of old tasks: Call to a member function getAppliedTransactionPHIDs() on bool.
Fri, May 26, 14:28
aklapper added a revision to T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool: D25246: Work around exception in Herald transcript of old tasks: Call to a member function getAppliedTransactionPHIDs() on bool.
Fri, May 26, 14:28 · Affects-Wikimedia, Herald
aklapper added a comment to T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool.

I could reproduce this locally:

  1. As an admin, go to http://phorge.localhost/herald/create/
  2. Select "Maniphest Tasks"
  3. On http://phorge.localhost/herald/create/?adapter=HeraldManiphestTaskAdapter , select "Global Rule"
  4. Under "Conditions", select any of and set the three conditions Description | contains | Internet Archive, Description | contains | archive.org, Description | contains | Wayback Machine.
  5. Under "Action", select Add projects | someProject
  6. Select "Save Rule"
  7. Trigger the rule by creating a new task.
  8. Wait, wait, and wait, then look at the Herald Transcript linked from the task.
Fri, May 26, 14:26 · Affects-Wikimedia, Herald

Wed, May 24

aklapper closed T15420: PHP 8.1 "strlen(null)" exceptions block rendering Browse Repositories overlay dialog, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Wed, May 24, 16:10 · PHP 8 support
aklapper closed T15420: PHP 8.1 "strlen(null)" exceptions block rendering Browse Repositories overlay dialog as Resolved by committing rP6d57904330bc: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Browse Repositories….
Wed, May 24, 16:10 · PHP 8 support
aklapper closed D25244: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Browse Repositories overlay dialog.
Wed, May 24, 16:10