Page MenuHomePhorge

aklapper (Andre Klapper)
Bot

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2023, 20:44 (71 w, 5 d)
Availability
Available

Recent Activity

Today

aklapper closed D25718: Removed unused loadGitLocalRefs() from PhabricatorRepositoryPullEngine.
Mon, Jul 15, 06:28
aklapper committed rP03092ca42202: Removed unused loadGitLocalRefs() from PhabricatorRepositoryPullEngine.
Removed unused loadGitLocalRefs() from PhabricatorRepositoryPullEngine
Mon, Jul 15, 06:28

Yesterday

aklapper closed T15865: [Regression] Incorrect mail subject header [Updated] instead of [Created] as Resolved by committing rP5a454cef8a98: Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE.
Sun, Jul 14, 22:45
aklapper closed D25732: Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE.
Sun, Jul 14, 22:45
aklapper committed rP5a454cef8a98: Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE.
Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE
Sun, Jul 14, 22:45
aklapper added a comment to D25732: Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE.
Sun, Jul 14, 22:44

Sat, Jul 13

aklapper requested review of D25732: Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE.
Sat, Jul 13, 15:47
aklapper added a revision to T15865: [Regression] Incorrect mail subject header [Updated] instead of [Created]: D25732: Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE.
Sat, Jul 13, 15:47
aklapper added a comment to T15865: [Regression] Incorrect mail subject header [Updated] instead of [Created].

Applying the debug patch in P45, output when creating a new task shows that Updated (defined in https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/storage/PhabricatorApplicationTransaction.php;877ac8a873f979f418064eb2f36f1148c9838694$1611-1612) wins over Created (defined in https://we.phorge.it/source/phorge/browse/master/src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php;877ac8a873f979f418064eb2f36f1148c9838694$24) as ActionName:

[0]
PHLOG: 'PATE: TransactionType: core:create' at [/var/www/html/phorge/phorge/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1625]
PHLOG: 'PAT: TA Type: core:create' at [/var/www/html/phorge/phorge/src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1601]
PHLOG: 'PATE: ActionName:      Updated' at [/var/www/html/phorge/phorge/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1626]
PHLOG: 'PATE: ActionStrength:  140' at [/var/www/html/phorge/phorge/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1627]
Sat, Jul 13, 15:41
aklapper created P45 T15865 debug.
Sat, Jul 13, 15:41

Fri, Jul 12

aklapper closed D25715: Fix property name typo in PhabricatorPDFIterator.
Fri, Jul 12, 10:20
aklapper committed rP877ac8a873f9: Fix property name typo in PhabricatorPDFIterator.
Fix property name typo in PhabricatorPDFIterator
Fri, Jul 12, 10:20

Thu, Jul 11

aklapper updated the task description for T15882: When archiving a project, reset its default menu item to Profile.
Thu, Jul 11, 23:12 · Feature Requests, Projects
aklapper requested review of D25731: Set default menu item to Project Details when archiving a project.
Thu, Jul 11, 23:07
aklapper added a revision to T15882: When archiving a project, reset its default menu item to Profile: D25731: Set default menu item to Project Details when archiving a project.
Thu, Jul 11, 23:07 · Feature Requests, Projects
aklapper created T15882: When archiving a project, reset its default menu item to Profile.
Thu, Jul 11, 22:49 · Feature Requests, Projects
aklapper requested review of D25730: Avoid PhabricatorApplicationTransactionStructureException on editors not supporting Mute Notifications.
Thu, Jul 11, 10:08
aklapper added a revision to T15378: PhabricatorApplicationTransactionStructureException trying to mute File notifications: "Attempting to apply a transaction which has not been constructed correctly": D25730: Avoid PhabricatorApplicationTransactionStructureException on editors not supporting Mute Notifications.
Thu, Jul 11, 10:08
aklapper closed T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Thu, Jul 11, 05:25 · PHP 8 support
aklapper closed T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView as Resolved by committing rP59428f64ca2c: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Thu, Jul 11, 05:25 · PHP 8 support
aklapper closed D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Thu, Jul 11, 05:25
aklapper committed rP59428f64ca2c: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView
Thu, Jul 11, 05:25
aklapper retitled D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView from Fix PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView
Thu, Jul 11, 05:21

Wed, Jul 10

aklapper updated the diff for D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.

Eh, the PHP pitfalls that I'll never learn by heart... Thanks! :)
Let's try if ($file !== null && $file !== '') instead of if ($file) then?

Wed, Jul 10, 19:53
aklapper closed D25729: Remove unreachable return statement in AphrontFormDateControlValue.
Wed, Jul 10, 13:56
aklapper committed rPc4246cf871a7: Remove unreachable return statement in AphrontFormDateControlValue.
Remove unreachable return statement in AphrontFormDateControlValue
Wed, Jul 10, 13:56
aklapper requested review of D25729: Remove unreachable return statement in AphrontFormDateControlValue.
Wed, Jul 10, 13:25
aklapper closed D25716: Declare missing class property in PhabricatorTimelineEngine.
Wed, Jul 10, 12:54
aklapper committed rP941b769abae6: Declare missing class property in PhabricatorTimelineEngine.
Declare missing class property in PhabricatorTimelineEngine
Wed, Jul 10, 12:54
aklapper edited the content of Next Up.
Wed, Jul 10, 11:34
aklapper closed T15876: Update external timezone information file to 2024a as Resolved by committing rP3fbb0309b53f: Update external timezone information to IANA TZDB 2024a.
Wed, Jul 10, 11:33
aklapper closed D25722: Update external timezone information to IANA TZDB 2024a.
Wed, Jul 10, 11:33
aklapper committed rP3fbb0309b53f: Update external timezone information to IANA TZDB 2024a.
Update external timezone information to IANA TZDB 2024a
Wed, Jul 10, 11:33
aklapper closed D25719: Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine.
Wed, Jul 10, 11:32
aklapper committed rPd9592e034812: Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine.
Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine
Wed, Jul 10, 11:32
aklapper closed D25713: Declare missing class properties in ArcanistDownloadWorkflow.
Wed, Jul 10, 08:06
aklapper committed rARC84210cedc6ce: Declare missing class properties in ArcanistDownloadWorkflow.
Declare missing class properties in ArcanistDownloadWorkflow
Wed, Jul 10, 08:06
aklapper closed D25720: Correct PHPDoc of dropSymbolCache().
Wed, Jul 10, 08:06
aklapper committed rARC76d22d70e429: Correct PHPDoc of dropSymbolCache().
Correct PHPDoc of dropSymbolCache()
Wed, Jul 10, 08:06
aklapper closed T15874: Invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest() as Resolved by committing rPff7be2cf1444: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Wed, Jul 10, 06:38
aklapper closed D25727: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Wed, Jul 10, 06:38
aklapper committed rPff7be2cf1444: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest()
Wed, Jul 10, 06:38
aklapper closed T15880: Timeline title for form creation mentions generic "object" instead of "form" as Resolved by committing rP290883b2a995: Set specific timeline title for form creation.
Wed, Jul 10, 06:18
aklapper closed D25726: Set specific timeline title for form creation.
Wed, Jul 10, 06:18
aklapper committed rP290883b2a995: Set specific timeline title for form creation.
Set specific timeline title for form creation
Wed, Jul 10, 06:18

Tue, Jul 9

aklapper updated the summary of D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Tue, Jul 9, 22:29
aklapper requested review of D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Tue, Jul 9, 22:23
aklapper added a revision to T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView: D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Tue, Jul 9, 22:23 · PHP 8 support
aklapper created T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView.
Tue, Jul 9, 22:10 · PHP 8 support
aklapper updated the diff for D25727: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().

Restore an empty line

Tue, Jul 9, 21:30
aklapper added a revision to T15874: Invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest(): D25727: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Tue, Jul 9, 21:26
aklapper requested review of D25727: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Tue, Jul 9, 21:26
aklapper added a comment to T15874: Invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().

This broken code is intended to find MailTags (means: each entry listed under http://phorge.localhost/settings/panel/emailpreferences/ , grep for const MAILTAG_ to get a list of them) defined more than once to display them in a Common section on top:

Screenshot from 2024-07-09 23-13-28.png (438×1 px, 90 KB)

However, as currently all MailTags are prefixed with their application (examples: phame-post-content, vote:responses, maniphest-owner) there is nothing to display anyway.

Tue, Jul 9, 21:19
aklapper added a comment to D25726: Set specific timeline title for form creation.

Before:

Screenshot from 2024-07-09 11-52-39.png (312×946 px, 35 KB)

Tue, Jul 9, 09:59
aklapper added a revision to T15880: Timeline title for form creation mentions generic "object" instead of "form": D25726: Set specific timeline title for form creation.
Tue, Jul 9, 09:58
aklapper requested review of D25726: Set specific timeline title for form creation.
Tue, Jul 9, 09:58
aklapper created T15880: Timeline title for form creation mentions generic "object" instead of "form".
Tue, Jul 9, 09:55

Mon, Jul 8

aklapper created T15879: Documentation: Macro image rendered instead of keyword when names match.
Mon, Jul 8, 15:36
aklapper requested review of D25725: Update phpqrcode from version 1.1.4 to 1.9.9.
Mon, Jul 8, 01:55
aklapper added a revision to T15878: Update embedded phpqrcode from version 1.1.4 to 1.9.9: D25725: Update phpqrcode from version 1.1.4 to 1.9.9.
Mon, Jul 8, 01:55
aklapper created T15878: Update embedded phpqrcode from version 1.1.4 to 1.9.9.
Mon, Jul 8, 01:52

Sun, Jul 7

aklapper closed D25714: Fix property name typo in DrydockResource.
Sun, Jul 7, 13:52
aklapper committed rP1b5d2f83c3aa: Fix property name typo in DrydockResource.
Fix property name typo in DrydockResource
Sun, Jul 7, 13:52

Thu, Jul 4

aklapper updated the diff for D25723: PHPMailer: Merge class.phpmailer-lite.php into class.phpmailer.php.

Fix $Mailer default value in docs

Thu, Jul 4, 12:42
aklapper updated the test plan for D25723: PHPMailer: Merge class.phpmailer-lite.php into class.phpmailer.php.
Thu, Jul 4, 12:18
aklapper added a comment to D25723: PHPMailer: Merge class.phpmailer-lite.php into class.phpmailer.php.
  • Between class.phpmailer-lite.php and class.phpmailer.php there were two differences in default values of variables, for $Mailer and $SingleTo:
    • I kept Lite's public $SingleTo = true as src/applications/metamta/adapter/PhabricatorMailSMTPAdapter.php (using non-Lite) already explicitly sets $smtp->SingleTo = false.
    • I kept Lite's public $Mailer = 'mail' instead of non-Lite's public $Mailer = 'sendmail' as SMTP in non-Lite already explicitly sets $Mailer = 'smtp' via calling $smtp->IsSMTP(), same for Sendmail via $mailer->IsSendmail(), and custom AmazonSES's code already explicitly sets $mailer->Mailer = 'amazon-ses' in src/applications/metamta/adapter/PhabricatorMailAmazonSESAdapter.php - so our default value sendmail does not really matter here anyway.
  • The other PhabricatorMail*Adapter subclasses of PhabricatorMailAdapter do not seem to utilize PHPMailer.
  • No documentation to update as https://we.phorge.it/book/phorge/article/configuring_outbound_email/ does not mention any PHPMailer.
Thu, Jul 4, 12:17
aklapper requested review of D25723: PHPMailer: Merge class.phpmailer-lite.php into class.phpmailer.php.
Thu, Jul 4, 12:16
aklapper added a revision to T15877: PHPMailer: Merge class.phpmailer-lite.php into class.phpmailer.php: D25723: PHPMailer: Merge class.phpmailer-lite.php into class.phpmailer.php.
Thu, Jul 4, 12:16
aklapper created T15877: PHPMailer: Merge class.phpmailer-lite.php into class.phpmailer.php.
Thu, Jul 4, 09:59

Wed, Jul 3

aklapper added a comment to T15865: [Regression] Incorrect mail subject header [Updated] instead of [Created].

In https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php ,
getMailAction() does return $this->getStrongestAction($object, $xactions)->getActionName()
and
getStrongestAction() does return head(msortv($xactions, 'newActionStrengthSortVector'))
and
newActionStrengthSortVector() does return id(new PhutilSortVector())->addInt(-$this->getActionStrength()) (note the minus)
so I'm wondering if rPf4d9d6920bcdcafedd6a05f34c28642589b3c285 broke something while it was supposed to do the opposite (cannot remember another recent commit that feels related to this area).

Wed, Jul 3, 10:42
aklapper added a revision to T15876: Update external timezone information file to 2024a: D25722: Update external timezone information to IANA TZDB 2024a.
Wed, Jul 3, 10:01
aklapper requested review of D25722: Update external timezone information to IANA TZDB 2024a.
Wed, Jul 3, 10:01
aklapper created T15876: Update external timezone information file to 2024a.
Wed, Jul 3, 10:01
aklapper edited the content of 2024 week 19.
Wed, Jul 3, 09:50
aklapper edited the content of 2024 week 19.
Wed, Jul 3, 09:40
aklapper edited the content of 2024 week 19.
Wed, Jul 3, 09:18
aklapper closed D25712: Declare missing class properties.
Wed, Jul 3, 07:05
aklapper committed rARC331b255b1508: Declare missing class properties.
Declare missing class properties
Wed, Jul 3, 07:05
aklapper requested review of D25721: Remove call to non-existing AphrontTypeaheadTemplateView::renderToken().
Wed, Jul 3, 06:39
aklapper requested review of D25720: Correct PHPDoc of dropSymbolCache().
Wed, Jul 3, 06:29

Tue, Jul 2

aklapper created T15874: Invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Tue, Jul 2, 21:18
aklapper requested review of D25719: Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine.
Tue, Jul 2, 20:53
aklapper requested review of D25718: Removed unused loadGitLocalRefs() from PhabricatorRepositoryPullEngine.
Tue, Jul 2, 20:44
aklapper requested review of D25717: Removed unused renderStatus() from PhabricatorProjectSubprojectsController.
Tue, Jul 2, 20:25
aklapper requested review of D25716: Declare missing class property in PhabricatorTimelineEngine.
Tue, Jul 2, 19:19
aklapper requested review of D25715: Fix property name typo in PhabricatorPDFIterator.
Tue, Jul 2, 19:11
aklapper requested review of D25714: Fix property name typo in DrydockResource.
Tue, Jul 2, 19:08
aklapper requested review of D25713: Declare missing class properties in ArcanistDownloadWorkflow.
Tue, Jul 2, 19:01
aklapper requested review of D25712: Declare missing class properties.
Tue, Jul 2, 18:53
aklapper closed D25643: Remove unused methods in PhabricatorEditorExtension.
Tue, Jul 2, 15:55
aklapper committed rPb0bba4d14235: Remove unused methods in PhabricatorEditorExtension.
Remove unused methods in PhabricatorEditorExtension
Tue, Jul 2, 15:55
aklapper retitled D25643: Remove unused methods in PhabricatorEditorExtension from Remove unused final protected methods in PhabricatorEditorExtension
Tue, Jul 2, 15:54
aklapper updated the answer details for Q142: Is it intentional that a Maniphest Task can be closed as a duplicate several times onto one task? (Answer 176).
Tue, Jul 2, 13:08
aklapper added Q142: Is it intentional that a Maniphest Task can be closed as a duplicate several times onto one task? (Answer 176).
Tue, Jul 2, 13:07
aklapper requested review of D25711: Suppress PHP 8.1 warnings "Return type mixed is not covariant with tentative return type mixed of method Iterator::key()".
Tue, Jul 2, 13:04
aklapper added a revision to T15835: Misc "Return type is not covariant" errors for method Iterator::key(): D25711: Suppress PHP 8.1 warnings "Return type mixed is not covariant with tentative return type mixed of method Iterator::key()".
Tue, Jul 2, 13:04 · PHP 8 support
aklapper retitled D25643: Remove unused methods in PhabricatorEditorExtension from Fix call to non-existing newError() in PhabricatorEditorExtension to Remove unused final protected methods in PhabricatorEditorExtension.
Tue, Jul 2, 12:42
aklapper updated the diff for D25643: Remove unused methods in PhabricatorEditorExtension.

Remove unused final protected methods in PhabricatorEditorExtension

Tue, Jul 2, 12:39
aklapper updated the diff for D25708: Fix invalid constructor call for ArcanistHardpointFutureList.

But it's designed to accept an array of futures, not a single one. Maybe just wrap in array($result).

Tue, Jul 2, 11:46
aklapper closed D25645: Remove unused save() method in PhabricatorUserCache.
Tue, Jul 2, 10:12