Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:15.
Tags
None
Referenced Files
F2982256: D25579.1739948772.diff
Tue, Feb 18, 07:06
F2976212: D25579.1739586727.diff
Fri, Feb 14, 02:32
F2976209: D25579.1739586723.diff
Fri, Feb 14, 02:32
F2976208: D25579.1739586720.diff
Fri, Feb 14, 02:32
F2976207: D25579.1739586717.diff
Fri, Feb 14, 02:31
F2964004: D25579.1739274386.diff
Mon, Feb 10, 11:46
F2946735: D25579.1738413599.diff
Fri, Jan 31, 12:39
F2937036: D25579.1737945498.diff
Sun, Jan 26, 02:38

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementGenerateKeyWorkflow.php:23]
Test Plan

Run ../phorge/bin/files generate-key: Get no strlen() error anymore but only expected output Usage Exception: Specify the type of key to generate with --type.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable