Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:15.
Tags
None
Referenced Files
F3149730: D25579.1741221149.diff
Wed, Mar 5, 00:32
F3149729: D25579.1741221148.diff
Wed, Mar 5, 00:32
F3149404: D25579.1741220013.diff
Wed, Mar 5, 00:13
F2996388: D25579.1740373834.diff
Sun, Feb 23, 05:10
F2995355: D25579.1740337760.diff
Sat, Feb 22, 19:09
F2995354: D25579.1740337673.diff
Sat, Feb 22, 19:07
F2995327: D25579.1740336190.diff
Sat, Feb 22, 18:43
F2982256: D25579.1739948772.diff
Tue, Feb 18, 07:06

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementGenerateKeyWorkflow.php:23]
Test Plan

Run ../phorge/bin/files generate-key: Get no strlen() error anymore but only expected output Usage Exception: Specify the type of key to generate with --type.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable