Page MenuHomePhorge
Feed Advanced Search

Today

valerio.bozzolan added a comment to T15645: Implement "Locate File" input in Browse view.

I wonder if under the hood this means "Add branch support to Locate File"

Fri, Dec 8, 20:01 · Diffusion
valerio.bozzolan updated the task description for T15577: Show existing Hovercards from more places.
Fri, Dec 8, 19:58 · UX, User-valerio.bozzolan

Yesterday

valerio.bozzolan added a comment to D25466: Improve command line prompts in setup issue pages.

We may want to expand the Test Plan to mention additional tips to help newcomers in breaking their installation.

Thu, Dec 7, 11:59 · Config, UX
valerio.bozzolan updated the test plan for D25466: Improve command line prompts in setup issue pages.
Thu, Dec 7, 11:55 · Config, UX
valerio.bozzolan accepted D25466: Improve command line prompts in setup issue pages.

I love it, thanks.

Thu, Dec 7, 11:54 · Config, UX
valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Thu, Dec 7, 10:33 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a parent task for T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested: T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Thu, Dec 7, 10:32
valerio.bozzolan added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested.
Thu, Dec 7, 10:32 · Discussion Needed, Affects-Wikimedia

Wed, Dec 6

valerio.bozzolan accepted D25491: Improve contrast of Links in Dark Mode.

Tested, thanks! no nuclear implosions and I like it. I also think that "accadf" is more readable than before :^) please wait some days before landing to eventually attract additional testers.

Wed, Dec 6, 19:36
valerio.bozzolan updated the diff for D25491: Improve contrast of Links in Dark Mode.

arc lint

Wed, Dec 6, 19:36
valerio.bozzolan added a revision to T15056: Improve Dark Mode: D25491: Improve contrast of Links in Dark Mode.
Wed, Dec 6, 19:33 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
valerio.bozzolan retitled D25491: Improve contrast of Links in Dark Mode from Links in dark theme have low contrast (T15056)
Wed, Dec 6, 19:33
valerio.bozzolan updated the name of F416077: Links After.png from "image.png" to "Links After.png".
Wed, Dec 6, 19:28
valerio.bozzolan updated the name of F416075: Links Before.png from "image.png" to "Links Before.png".
Wed, Dec 6, 19:27
valerio.bozzolan added inline comments to D25305: Workboard: have thin scrollbars.
Wed, Dec 6, 08:28
valerio.bozzolan updated the answer details for Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 117).
Wed, Dec 6, 08:21
valerio.bozzolan updated the answer details for Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 117).
Wed, Dec 6, 08:21
valerio.bozzolan added Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 117).
Wed, Dec 6, 08:02
valerio.bozzolan accepted D25485: CSS adjustments to Conpherence.

Thanks @waldyrious - I agree with both you and @speck since I was affected by the first issue and since I believe that T15225 is a good thing. Tested, nice!

Wed, Dec 6, 07:05 · Conpherence
valerio.bozzolan accepted D25488: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured.
Wed, Dec 6, 06:53
valerio.bozzolan added a comment to D25488: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured.

Hmm, I guess the patch should also change line 14 in the same way? I managed to reach that line with the same problem but do not remember the exact steps I performed...

Wed, Dec 6, 06:53
valerio.bozzolan updated the test plan for D25486: Use user's preferred font for inline code snippets too.
Wed, Dec 6, 06:39
valerio.bozzolan accepted D25486: Use user's preferred font for inline code snippets too.

Tested. No nuclear implosions :) Thanks!

Wed, Dec 6, 06:39
valerio.bozzolan awarded T15686: Include 'published' date in Phame atom feeds a Like token.
Wed, Dec 6, 06:28 · Affects-Wikimedia, Feature Requests
valerio.bozzolan added a project to T15686: Include 'published' date in Phame atom feeds: Affects-Wikimedia.
Wed, Dec 6, 06:28 · Affects-Wikimedia, Feature Requests
valerio.bozzolan updated the summary of D25490: Include 'published' date of posts in Phame Atom feeds.
Wed, Dec 6, 06:25
valerio.bozzolan accepted D25490: Include 'published' date of posts in Phame Atom feeds.

If the patch was written by 20after4 we can probably set git commit --amend --author="Mukunda Modell". Can I help in this?

Wed, Dec 6, 06:23
valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Wed, Dec 6, 06:21 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a parent task for T15686: Include 'published' date in Phame atom feeds: T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Wed, Dec 6, 06:21 · Affects-Wikimedia, Feature Requests
valerio.bozzolan added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15686: Include 'published' date in Phame atom feeds.
Wed, Dec 6, 06:21 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan moved T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge from Backlog to Discussion Needed on the Affects-Wikimedia board.
Wed, Dec 6, 06:20 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a comment to Q94: Email notifications are not being sent.

is the phd running? (./bin/phd start) anything in its log?

Wed, Dec 6, 05:59

Tue, Dec 5

valerio.bozzolan added a comment to D25489: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.

I think that the value may be an int, so, causing a nuclear implosion. Probably nice to check for a concrete populated example, and eventually do line 27 or similar ones.

Tue, Dec 5, 12:07
valerio.bozzolan accepted D25484: fix PHP 8 "strlen(null)" when moving paths with missing options.
Tue, Dec 5, 00:19
valerio.bozzolan added a comment to D25484: fix PHP 8 "strlen(null)" when moving paths with missing options.

In the future it may also be nice to have a getArgStr() that always return a string, never NULL. So, we can just if ( $to === '' )

Tue, Dec 5, 00:18

Mon, Dec 4

valerio.bozzolan edited the content of Next Up.
Mon, Dec 4, 22:52

Sat, Dec 2

valerio.bozzolan awarded D25485: CSS adjustments to Conpherence a Love token.
Sat, Dec 2, 10:27 · Conpherence

Tue, Nov 28

valerio.bozzolan edited the content of 2023 Week 32.
Tue, Nov 28, 15:27

Mon, Nov 27

valerio.bozzolan edited the content of Next Up.
Mon, Nov 27, 19:59
valerio.bozzolan added inline comments to D25440: Show Deprecation Warnings as Setup Warnings.
Mon, Nov 27, 15:10

Fri, Nov 24

valerio.bozzolan awarded T15164: Resolving without Claiming causes error "Action with no effect" a Yellow Medal token.
Fri, Nov 24, 23:22 · Maniphest, User-valerio.bozzolan

Thu, Nov 23

valerio.bozzolan accepted D25418: Catch RuntimeException: mb_convert_encoding(): Illegal character encoding specified at PhabricatorTextDocumentEngine.php:73.

Nobody seems interested in my concern, so, hard approve :) Thanks

Thu, Nov 23, 14:47
valerio.bozzolan added a comment to Q88: Phorge upgrade error PhutilURI::checkHrefType() (Answer 111).

Thanks for your help @valerio.bozzolan, It appears I had missed that part!..oops...I'll give that a try over the weekend.

Thu, Nov 23, 09:53
valerio.bozzolan marked Q88: Phorge upgrade error PhutilURI::checkHrefType() (Answer 112) as hidden.
Thu, Nov 23, 09:53
valerio.bozzolan updated the answer details for Q88: Phorge upgrade error PhutilURI::checkHrefType() (Answer 111).
Thu, Nov 23, 09:08
valerio.bozzolan added Q88: Phorge upgrade error PhutilURI::checkHrefType() (Answer 111).
Thu, Nov 23, 09:07
valerio.bozzolan updated the task description for T15055: Import translations from translatewiki.net.
Thu, Nov 23, 06:23 · Affects-Wikimedia, Phorge

Wed, Nov 22

valerio.bozzolan closed T15674: Image Transforms should reflect policy of parent Image, a subtask of T15163: Auto-Attach a File when dropping it as Task cover image, as Invalid.
Wed, Nov 22, 13:08 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard
valerio.bozzolan closed T15674: Image Transforms should reflect policy of parent Image as Invalid.

My steps to reproduce are wrong / unclear / not always happening.

Wed, Nov 22, 13:08 · Files, User-valerio.bozzolan
valerio.bozzolan triaged T15674: Image Transforms should reflect policy of parent Image as Normal priority.
Wed, Nov 22, 13:04 · Files, User-valerio.bozzolan
valerio.bozzolan planned changes to D25475: Drag & Drop Task Cover Image: also attach.

This partially fixes the problem:

Wed, Nov 22, 12:11
valerio.bozzolan added a comment to D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.

Please fix unit errors

Wed, Nov 22, 08:11

Tue, Nov 21

valerio.bozzolan updated the question details for Q87: Deleting a specific Phriction version.
Tue, Nov 21, 16:13
valerio.bozzolan asked Q87: Deleting a specific Phriction version.
Tue, Nov 21, 16:12
valerio.bozzolan added a comment to D25439: Fix strlen(null) errors for projects with integer fields under PHP 8.1.

Probably this happens while creating a new project and doing that thing again 🤔

Tue, Nov 21, 16:10
valerio.bozzolan added a project to T15673: Phorge participation at FOSDEM 2024 (Deadline: 10th December): Blessed Communicators.
Tue, Nov 21, 12:11 · Blessed Communicators, Phorge
valerio.bozzolan created T15673: Phorge participation at FOSDEM 2024 (Deadline: 10th December).
Tue, Nov 21, 12:10 · Blessed Communicators, Phorge
valerio.bozzolan renamed T15641: Creating or editing a project under PHP 8.1 causes strlen() null error with custom integer fields from Creating or editing a project under PHP 8.1 causes strlen() null error to Creating or editing a project under PHP 8.1 causes strlen() null error with custom integer fields.
Tue, Nov 21, 09:33 · PHP 8 support

Mon, Nov 20

valerio.bozzolan awarded Q86: Policy lifecycle of security tasks a Love token.
Mon, Nov 20, 22:15 · Discussion Needed
valerio.bozzolan added a project to Q86: Policy lifecycle of security tasks: Discussion Needed.
Mon, Nov 20, 22:15 · Discussion Needed
valerio.bozzolan moved T15672: Allow to tune "Invite Users" policy from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.
Mon, Nov 20, 18:53 · User-valerio.bozzolan, Policy, People
valerio.bozzolan updated the task description for T15672: Allow to tune "Invite Users" policy.
Mon, Nov 20, 18:50 · User-valerio.bozzolan, Policy, People
valerio.bozzolan triaged T15672: Allow to tune "Invite Users" policy as Low priority.
Mon, Nov 20, 18:48 · User-valerio.bozzolan, Policy, People
valerio.bozzolan updated the task description for T15671: Allow to import Picture from Gravatar.
Mon, Nov 20, 18:37 · User-valerio.bozzolan, People
valerio.bozzolan triaged T15671: Allow to import Picture from Gravatar as Wishlist priority.
Mon, Nov 20, 17:01 · User-valerio.bozzolan, People
valerio.bozzolan lowered the priority of T15407: People: uploaded thumbnails should be editable by their author (not by "No one") from High to Normal.
Mon, Nov 20, 16:58 · User-valerio.bozzolan, People
valerio.bozzolan accepted D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Nobody replied for months. I basically like the disclaimer and I basically trust your test in your production. Thanks.

Mon, Nov 20, 16:38
valerio.bozzolan added a comment to D25079: Trigger: Add Sound "Coin".

I suggest to accept with "whatcouldgowrong" \o/

Mon, Nov 20, 16:25
valerio.bozzolan accepted D25423: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.

Thanks bob. Just to say that I care about your code proposals and sorry if this needed extra time.

Mon, Nov 20, 16:21
valerio.bozzolan requested changes to D25439: Fix strlen(null) errors for projects with integer fields under PHP 8.1.
Mon, Nov 20, 16:05
valerio.bozzolan added a comment to D25439: Fix strlen(null) errors for projects with integer fields under PHP 8.1.

(Indeed I agree we cannot bulk edit things - PHP 8.1 is a nightmare - see T15190)

Mon, Nov 20, 16:04
valerio.bozzolan added a comment to D25418: Catch RuntimeException: mb_convert_encoding(): Illegal character encoding specified at PhabricatorTextDocumentEngine.php:73.

Interestingly, Gerrit does similar things, and does not mention the problematic URI value in case it's somehow already clear:

Mon, Nov 20, 14:42
valerio.bozzolan added a project to T15055: Import translations from translatewiki.net: Affects-Wikimedia.

Cool. Two things:

Mon, Nov 20, 11:12 · Affects-Wikimedia, Phorge
valerio.bozzolan added a comment to T15073: /status should be always allowed in anonymous mode.

(maybe this happens if you have just one provider and it's an OAuth)

Mon, Nov 20, 10:59
valerio.bozzolan added a comment to T15073: /status should be always allowed in anonymous mode.

Interestingly this cannot be reproduced in any public Phabricator:

Mon, Nov 20, 10:58
valerio.bozzolan added a comment to T15125: Unknown edge constant "26"! when deleting a file with old attachment edges.

Other edges have probably been eliminated in the past. For example this one:

Mon, Nov 20, 10:17 · Affects-Wikimedia, Files, Bug Reports
valerio.bozzolan edited the content of Code Differences between Phabricator and Phorge.
Mon, Nov 20, 10:10
valerio.bozzolan added a comment to T15450: Configure another Ponder Question status "Closed, Graduated".

I sincerely thought that "Obsolete" was the good one semantically.

Mon, Nov 20, 10:02 · phorge.it install
valerio.bozzolan added a comment to T15237: Conpherence: allow "announcement" style channel.

I think a dedicated policy for "Can send messages" would be better, to cover more cases. It would be strange to have an Announcement channel editable by everyone.

Mon, Nov 20, 09:53 · Feature Requests, Conpherence
valerio.bozzolan triaged T15504: If registration is disabled, show the button as disabled as Low priority.
Mon, Nov 20, 09:49 · Good Starter Task, UX
valerio.bozzolan added a comment to T15612: Missing subversion commit information.

Is this only related to the "Authored on ..." field, as far as you can see?

Mon, Nov 20, 09:47 · Bug Reports, Phorge
valerio.bozzolan closed T15627: Clicking on meme then cancel causes redirection to homepage and dialog does not disappear as Resolved.

I cannot reproduce anymore. This does not happen anymore in latest master.

Mon, Nov 20, 09:46 · UX, Bug Reports
valerio.bozzolan requested changes to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

Sorry if I've found two additional interesting things:

Mon, Nov 20, 09:24
valerio.bozzolan awarded T15660: Generate a Table of Content for Diffusion browse as Remarkup (?as=remarkup) a Love token.
Mon, Nov 20, 09:15 · Feature Requests
valerio.bozzolan renamed T15660: Generate a Table of Content for Diffusion browse as Remarkup (?as=remarkup) from No TOC generated for diffusion browse ?as=remarkup to Generate a Table of Content for Diffusion browse as Remarkup (?as=remarkup).
Mon, Nov 20, 09:15 · Feature Requests
valerio.bozzolan moved T15163: Auto-Attach a File when dropping it as Task cover image from Code Sprint Candidate to PingDeath 🌚 on the User-valerio.bozzolan board.
Mon, Nov 20, 09:09 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard
valerio.bozzolan requested review of D25475: Drag & Drop Task Cover Image: also attach.
Mon, Nov 20, 09:06
valerio.bozzolan added a revision to T15163: Auto-Attach a File when dropping it as Task cover image: D25475: Drag & Drop Task Cover Image: also attach.
Mon, Nov 20, 09:06 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard
valerio.bozzolan claimed T15163: Auto-Attach a File when dropping it as Task cover image.
Mon, Nov 20, 08:54 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard

Sat, Nov 18

valerio.bozzolan added a comment to D25474: Disallow webcrawlers to index Diffusion commits.

I'm not an important stakeholder, but I would like to share that in my installation https://gitpull.it I would like to have commits indexed as default as it happens in GitHub and GitLab. So I'm now sincerely understanding how to restore the old behavior without keeping my own fork of Phorge.

Sat, Nov 18, 16:50
valerio.bozzolan accepted D25473: Change some instances of "phabricator" to "phorge".

Thanks for the deep inspection! Tested and I agree

Sat, Nov 18, 16:41

Fri, Nov 17

valerio.bozzolan added inline comments to D25474: Disallow webcrawlers to index Diffusion commits.
Fri, Nov 17, 15:25

Thu, Nov 16

valerio.bozzolan accepted D25418: Catch RuntimeException: mb_convert_encoding(): Illegal character encoding specified at PhabricatorTextDocumentEngine.php:73.

Side note, we are introducing the possibility to share this kind of very creative and confusing URLs (that are safe from the point of view of XSS but) that could be an attracting point for lamers to generate confusing user messages inside Phorge itself, like:

Thu, Nov 16, 14:29
valerio.bozzolan added a comment to D25461: Disallow webcrawlers to follow Paste line number anchor links.

Thanks for landing!

Thu, Nov 16, 10:30
valerio.bozzolan awarded D25474: Disallow webcrawlers to index Diffusion commits a Evil Spooky Haunted Tree token.
Thu, Nov 16, 10:24
valerio.bozzolan added a project to T15670: Disallow webcrawlers to index Diffusion repository commits: Discussion Needed.

This is something that may be not appreciated by some people.

Thu, Nov 16, 10:23 · Discussion Needed
valerio.bozzolan added a comment to D25441: Fix possible array to string conversion renaming Pholio Mockup image.

Happy you fixed!

Thu, Nov 16, 09:47

Wed, Nov 15

valerio.bozzolan added a comment to D25457: Update diffusion browse to generate Table of Contents when viewed as remarkup.

JavaScript: ✅ I damn like your proposal and I think it is very OK, non-plus-ultra

Wed, Nov 15, 16:29
valerio.bozzolan updated the name of F399268: Before.png from "image.png" to "Before.png".
Wed, Nov 15, 15:44
valerio.bozzolan updated the name of F399270: After.png from "image.png" to "After.png".
Wed, Nov 15, 15:44