In D25546#15665, @valerio.bozzolan wrote:

I also don't get if in this part we have access to any thing related to Maniphest, ManiphestEditEngine or this kind of stuff, to just call $something->getCommentPanelPlaceholder() and have the business logic there in the specific application itself.

I fail to find anything in https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php which would allow us to know in which Phorge application this comment field is rendered :(

In D25546#15665, @valerio.bozzolan wrote:

I also don't get if in this part we have access to any thing related to Maniphest, ManiphestEditEngine or this kind of stuff, to just call $something->getCommentPanelPlaceholder() and have the business logic there in the specific application itself.

Yeah, let me refactor this. It'll be more lines of code but way cleaner and expandable.

I see quite some potential in our downstream instance where folks do not get exposed to hints in a Form Preamble when commenting on an existing task, and will not always find and read hints in a custom red box manually added to a task description either, while this comment field placeholder will be nice automated server-side logic.

Ouch I see that receiving the engine was very complicated.

I wonder how this was used. I mean. If we have something like this:

(new PhabricatorApplicationTransactionCommentView())
  ->render();

Maybe we can add our dependency:

(new PhabricatorApplicationTransactionCommentView())
  ->setEngine($engine)
  ->render();

But this is just a stupid idea - and I'm sorry that this is becoming so time expensive

I guess another question is whether to define an abstract public function getCommentFieldPlaceholderText() in parent PhabricatorEditEngine and then add to all and every child EditEngine a default public function getCommentFieldPlaceholderText($object_phid) { return '' };. Feels cleaner to me.

and I'm sorry that this is becoming so time expensive

Nah, I see some potential in this, so I wanted to have the code properly split between general functionality implementation and per-app conditions and behavior. :)

In D25546#16489, @valerio.bozzolan wrote:

Maybe we can add our dependency:

(new PhabricatorApplicationTransactionCommentView())
  ->setEngine($engine)
  ->render();

ManiphestEditEngine does not instantiate a PhabricatorApplicationTransactionCommentView directly, it goes via the parent class PhabricatorEditEngine...