Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:29.
Tags
None
Referenced Files
F2976232: D25582.1739586755.diff
Fri, Feb 14, 02:32
F2962752: D25582.1739181879.diff
Sun, Feb 9, 10:04
F2962751: D25582.1739181876.diff
Sun, Feb 9, 10:04
F2962750: D25582.1739181873.diff
Sun, Feb 9, 10:04
F2951643: D25582.1738905805.diff
Thu, Feb 6, 05:23
F2944598: D25582.1738273125.diff
Wed, Jan 29, 21:38
F2937039: D25582.1737945633.diff
Sun, Jan 26, 02:40
F2934549: D25582.1737793328.diff
Fri, Jan 24, 08:22

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/management/PhabricatorAuthManagementUnlimitWorkflow.php:30]
Test Plan

Run ../phorge/bin/auth unlimit: Get no strlen() error anymore but only expected output Usage Exception: Use --user to choose a user to reset actions for.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable