Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:29.
Tags
None
Referenced Files
F3852234: D25582.1746123278.diff
Wed, Apr 30, 18:14
F3847252: D25582.1746105969.diff
Wed, Apr 30, 13:26
F3847250: D25582.1746105968.diff
Wed, Apr 30, 13:26
F3847249: D25582.1746105967.diff
Wed, Apr 30, 13:26
F3766851: D25582.1745847361.diff
Sun, Apr 27, 13:36
F3761215: D25582.1745830747.diff
Sun, Apr 27, 08:59
F3761214: D25582.1745830746.diff
Sun, Apr 27, 08:59
F3761213: D25582.1745830745.diff
Sun, Apr 27, 08:59

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/management/PhabricatorAuthManagementUnlimitWorkflow.php:30]
Test Plan

Run ../phorge/bin/auth unlimit: Get no strlen() error anymore but only expected output Usage Exception: Use --user to choose a user to reset actions for.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable