Paths

Table of Contentst

Differential D25600

Mark created Pholio mockups as new objects to fix empty Feed transaction entries
Needs ReviewPublic
Actions

Authored by aklapper on Fri, Apr 19, 16:30.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 27, 08:03

	Unknown Object (File)
	Fri, Apr 26, 22:34

	Unknown Object (File)
	Fri, Apr 26, 02:19

	Unknown Object (File)
	Thu, Apr 25, 23:03

	Unknown Object (File)
	Thu, Apr 25, 23:03

	Unknown Object (File)
	Thu, Apr 25, 07:17

	Unknown Object (File)
	Thu, Apr 25, 04:22

	Unknown Object (File)
	Thu, Apr 25, 01:11

View All 18 Files

Subscribers

valerio.bozzolan

Tokens

"Love" token, awarded by valerio.bozzolan.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15679: Pholio image upload triggers Passing null is deprecated at PhabricatorPolicyQuery.php:314

Summary

When creating a Pholio mockup, setIsCreateTransaction(true) to avoid an empty Transaction field in the Feed and avoid strncmp() complaining about a null value being passed.

This is very similar to T15659 about Differential Diffs.

ERROR 8192: strncmp(): Passing null to parameter #1 ($string1) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/policy/query/PhabricatorPolicyQuery.php:314]

Closes T15679

Test Plan

Create a new Pholio mockup via /pholio/create/
Go to /feed/transactions/query/all/
Compare entries in the Transaction column before (empty ones) and after (no empty ones) applying the patch.

Diff Detail

Repository

Branch

T15679pholioStrncmp (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1192
Build 1192: arc lint + arc unit

Event Timeline

aklapper created this revision.Fri, Apr 19, 16:30

Owners added a reviewer: O1: Blessed Committers.Fri, Apr 19, 16:30

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, Apr 19, 16:30

aklapper requested review of this revision.Fri, Apr 19, 16:30

Harbormaster completed remote builds in B1192: Diff 1889.Fri, Apr 19, 16:30

Screenshot before (M17) and after (M18) applying D25600:

Screenshot from 2024-04-19 18-20-53.png (834×1 px, 162 KB)

Probably we need some help to understand the semantic difference between these two:

PholioTransaction#setIsCreateTransaction(bool)
PholioMockEditor#setIsCreate(bool)

In any case, whenever it's the first one or the second (or both??) I'm quite sure we should set this only if $id is set.

valerio.bozzolan awarded a token.Fri, Apr 26, 10:29

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

pholio/

controller/

PholioMockEditController.php

1 line

O1: Blessed Committers

Diff 1889

src/applications/pholio/controller/PholioMockEditController.php

Loading...