Page MenuHomePhorge

Why is there an `outline-style: none;` declaration for all links within Phorge/Phabricator?
OpenPublic

Asked by banaanihillo on Apr 24 2024, 18:14.

Details

The file webroot/rsrc/css/core/core.css has the following declaration:

a {
  outline-style: none;
}

This makes all links within the site have no focus indicators, which makes keyboard navigation pretty challenging.

Before I even try to figure out how to either open an issue for the above, or make a pull request for it myself, I'd like to just ask (since asking a question is the only place I could find),
Is there a reason why that declaration was put there in the first place?

Answer Summary

Huh? Am I supposed to answer the question myself?

Answers

valerio.bozzolan
Updated 210 Days Ago

Thanks for this question, I was not aware of this CSS rule, and this:

https://developer.mozilla.org/en-US/docs/Web/CSS/outline#accessibility_concerns

It seems it has the origin here:

e284d5b5dc7daee6d0a26dfba736cf203c712d35

And it has no explanation.

I would say: patch welcome!

aklapper
Updated 203 Days Ago

Not an answer (but this is in Ponder, sigh): Removing that one CSS line looks pretty bad in Chromium 124 with that outline being cropped in many places:

Screenshot from 2024-04-25 13-04-17.png (734×1 px, 140 KB)

(Note to myself: Above image showed as attached to Q132 on https://we.phorge.it/F2162682 but I had to explicitly change the View permissions from my user account only to "Public")

New Answer