Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter
ClosedPublic

Authored by aklapper on Tue, Apr 16, 08:36.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 12:38
Unknown Object (File)
Sat, Apr 27, 03:49
Unknown Object (File)
Sat, Apr 27, 02:04
Unknown Object (File)
Wed, Apr 24, 19:20
Unknown Object (File)
Tue, Apr 23, 00:00
Unknown Object (File)
Tue, Apr 23, 00:00
Unknown Object (File)
Mon, Apr 22, 19:09
Unknown Object (File)
Mon, Apr 22, 18:33

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/management/PhabricatorAuthManagementRefreshWorkflow.php:37]
Test Plan

Run ../phorge/bin/auth refresh: Get no strlen() error anymore but only expected output Found 3 account(s) to refresh. (or similar)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable