Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:36.
Tags
None
Referenced Files
F2976238: D25583.1739586767.diff
Fri, Feb 14, 02:32
F2976235: D25583.1739586763.diff
Fri, Feb 14, 02:32
F2962755: D25583.1739181885.diff
Sun, Feb 9, 10:04
F2962754: D25583.1739181882.diff
Sun, Feb 9, 10:04
F2944596: D25583.1738273119.diff
Wed, Jan 29, 21:38
F2937031: D25583.1737945446.diff
Sun, Jan 26, 02:37
F2932826: D25583.1737744657.diff
Thu, Jan 23, 18:50
F2932825: D25583.1737744649.diff
Thu, Jan 23, 18:50

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/management/PhabricatorAuthManagementRefreshWorkflow.php:37]
Test Plan

Run ../phorge/bin/auth refresh: Get no strlen() error anymore but only expected output Found 3 account(s) to refresh. (or similar)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable