Paths

Table of Contentst

Show rest of task page when graph errors out
ClosedPublic
Actions

Authored by avivey on Apr 5 2024, 07:33.

Tags

None

Referenced Files

	F2998549: D25570.1740413829.diff
	Sun, Feb 23, 16:17

	F2998245: D25570.1740410883.diff
	Sun, Feb 23, 15:28

	F2998243: D25570.1740410879.diff
	Sun, Feb 23, 15:27

	F2998226: D25570.1740410785.diff
	Sun, Feb 23, 15:26

	F2992934: D25570.1740261098.diff
	Fri, Feb 21, 21:51

	F2990718: D25570.1740180028.diff
	Thu, Feb 20, 23:20

	F2990717: D25570.1740179982.diff
	Thu, Feb 20, 23:19

	F2990387: D25570.1740177770.diff
	Thu, Feb 20, 22:42

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPecbef3fdf4b6: Show rest of task page when graph errors out

Summary

T15772.

Test Plan

Add a throw statement in graph calculation, load a task that has a graph, see message.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey created this revision.Apr 5 2024, 07:33

Owners added a reviewer: O1: Blessed Committers.Apr 5 2024, 07:33

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 5 2024, 07:33

avivey requested review of this revision.Apr 5 2024, 07:33

Harbormaster completed remote builds in B1154: Diff 1826.Apr 5 2024, 07:33

sgtm

Thanks. Tested this in a correct situation and also causing a crash putting an unset($nodes[$current_node]) in ../arcanist/src/utils/AbstractDirectedGraph.php to see the nice exception message

This revision is now accepted and ready to land.Apr 5 2024, 08:42

Closed by commit rPecbef3fdf4b6: Show rest of task page when graph errors out. · Explain WhyApr 5 2024, 10:26

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rPecbef3fdf4b6: Show rest of task page when graph errors out.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

maniphest/

controller/

ManiphestTaskDetailController.php

23 lines

O1: Blessed Committers

Diff 1827

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Show rest of task page when graph errors outClosedPublicActions