Page MenuHomePhorge
Differential D25570

Show rest of task page when graph errors out
ClosedPublic
Actions

Authored by avivey on Apr 5 2024, 07:33.
Tags
None
Referenced Files
F3372319: D25570.1744249508.diff
Wed, Apr 9, 01:45
F3370949: D25570.1744237621.diff
Tue, Apr 8, 22:27
F3369172: D25570.1744213349.diff
Tue, Apr 8, 15:42
F3368478: D25570.1744209343.diff
Tue, Apr 8, 14:35
F3342195: D25570.1743662524.diff
Wed, Apr 2, 06:42
F3333964: D25570.1743541968.diff
Mon, Mar 31, 21:12
F3329649: D25570.1743478046.diff
Mon, Mar 31, 03:27
F3328005: D25570.1743448143.diff
Sun, Mar 30, 19:09
View All 44 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rPecbef3fdf4b6: Show rest of task page when graph errors out
Summary

T15772.

Test Plan

Add a throw statement in graph calculation, load a task that has a graph, see message.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey created this revision.Apr 5 2024, 07:33
Owners added a reviewer: O1: Blessed Committers.Apr 5 2024, 07:33
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 5 2024, 07:33
avivey requested review of this revision.Apr 5 2024, 07:33
Harbormaster completed remote builds in B1154: Diff 1826.Apr 5 2024, 07:33
valerio.bozzolan accepted this revision.Apr 5 2024, 08:42

sgtm

Thanks. Tested this in a correct situation and also causing a crash putting an unset($nodes[$current_node]) in ../arcanist/src/utils/AbstractDirectedGraph.php to see the nice exception message

This revision is now accepted and ready to land.Apr 5 2024, 08:42
Closed by commit rPecbef3fdf4b6: Show rest of task page when graph errors out. · Explain WhyApr 5 2024, 10:26
This revision was automatically updated to reflect the committed changes.
avivey added a commit: rPecbef3fdf4b6: Show rest of task page when graph errors out.

Revision Contents
Changeset List

PathSizePackages
src/
applications/
maniphest/
controller/
23 linesO1: Blessed Committers

Diff 1827

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0