Page MenuHomePhorge

Show rest of task page when graph errors out
ClosedPublic

Authored by avivey on Apr 5 2024, 07:33.
Tags
None
Referenced Files
F3835406: D25570.1746085913.diff
Wed, Apr 30, 07:51
F3835405: D25570.1746085912.diff
Wed, Apr 30, 07:51
F3835404: D25570.1746085911.diff
Wed, Apr 30, 07:51
F3763007: D25570.1745838590.diff
Sun, Apr 27, 11:09
F3749084: D25570.1745790590.diff
Sat, Apr 26, 21:49
F3749083: D25570.1745790587.diff
Sat, Apr 26, 21:49
F3749082: D25570.1745790587.diff
Sat, Apr 26, 21:49
F3675334: D25570.1745507722.diff
Wed, Apr 23, 15:15

Details

Summary
Test Plan

Add a throw statement in graph calculation, load a task that has a graph, see message.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey requested review of this revision.Apr 5 2024, 07:33

sgtm

Thanks. Tested this in a correct situation and also causing a crash putting an unset($nodes[$current_node]) in ../arcanist/src/utils/AbstractDirectedGraph.php to see the nice exception message

This revision is now accepted and ready to land.Apr 5 2024, 08:42