Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 23:05.
Tags
None
Referenced Files
F3284760: D25595.1742784627.diff
Sun, Mar 23, 02:50
F3249452: D25595.1742286172.diff
Mon, Mar 17, 08:22
F3151946: D25595.1741226959.diff
Wed, Mar 5, 02:09
F3151945: D25595.1741226957.diff
Wed, Mar 5, 02:09
F3147905: D25595.1741216535.diff
Tue, Mar 4, 23:15
F3082829: D25595.1741072545.diff
Mon, Mar 3, 07:15
F3005273: D25595.1740516259.diff
Mon, Feb 24, 20:44
F2981852: D25595.1739940081.diff
Feb 18 2025, 04:41

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementEncodeWorkflow.php:45]
Test Plan

Run ../phorge/bin/files encode F1: Get no strlen() error anymore but only expected output Usage Exception: Use --as <format> to select a target encoding format. Available formats are: aes-256-cbc, rot13, raw.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable