Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 23:05.
Tags
None
Referenced Files
F3553383: D25595.1744931166.diff
Wed, Apr 16, 23:06
F3502370: D25595.1744796483.diff
Tue, Apr 15, 09:41
F3502369: D25595.1744796482.diff
Tue, Apr 15, 09:41
F3502368: D25595.1744796481.diff
Tue, Apr 15, 09:41
F3381514: D25595.1744373519.diff
Thu, Apr 10, 12:11
F3359536: D25595.1743948961.diff
Sat, Apr 5, 14:16
F3359069: D25595.1743934329.diff
Sat, Apr 5, 10:12
F3357440: D25595.1743910096.diff
Sat, Apr 5, 03:28

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementEncodeWorkflow.php:45]
Test Plan

Run ../phorge/bin/files encode F1: Get no strlen() error anymore but only expected output Usage Exception: Use --as <format> to select a target encoding format. Available formats are: aes-256-cbc, rot13, raw.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable