In T15056#3210, @golyalpha wrote:

Another example of broken dark theme

A while ago I looked at this in downstream https://phabricator.wikimedia.org/T259329#9354946 (long version).
In short, rPce953ea4479052c7e671c8c75af6833252ebefd4 and rP657f3c380608abc0fc59088d979457f1d8826f06 are the culprits.

Yeah, in this one special place it doesn't matter; But that page already have a special body, so we can save even the extra click by putting the message right there...

OK I see. Indeed we should not put any similar button anywhere else.

But in Diffusion, that button is hidden behind a "Actions -> Manage" button, inside a screen that also has dozens of other admin actions. The clutter cost there is minimized.

I see. Maybe the root problem is that I'm in love with that Diffusion popup 🤔

In that case, we don't even need another button - just add a line to the "deleted message" that says something like "To completely remove the history from the database, contact your admin".

Premising the user already have an Delete Document button.

I feel that adding such a button would clutter the UI.
Users should generally "know" that in order to really delete things, they need to go to the admin, because they don't have the permissions anyway; And adding that just for the once-in-a-while that the admin needs this...

I mean, we can maybe have a "Delete" button that just shows the related CLI command, like I've seen around (Diffusion maybe)

I don't think we actually allow "deleting" from the web ui, only hiding it (in the sense that the data is not removed from the database).

This feature request could also be expanded to:

Since Subversion allows to checkout just a sub-directory,

Perhaps a single new sound is enough to change the world.

https://we.phorge.it/D25079#15506

I've better triaged my root problem.

Note that at least for Phame, http://phorge.localhost/J1 seems to always redirect to http://phorge.localhost/phame/post/view/1/blogpost/ instead of keeping the monogram in the URI.
So the baseURI is already wrong (not being http://phorge.localhost/ only) before concatenating the $ref (monogram and anchor).
As an ugly workardound, could probably make "Quote Comment" work by calling getObjectNamePrefix() in PhamePostRemarkupRule and LegalpadDocumentRemarkupRule and then use them in a preg_match to remove the monogram from the $ref but function is protected and... still ugly.

In addition, it seems only the owner can see their stuff here.

I ended up running this

I totally agree with these additional considerations. Thanks.

Since I can, thanks to that revision, at work I've put this additional CSS rule for extra nonsense scary climax.

Partially related, a systemd unit for the SSH server. Proposal in D25497

Since we already show the full (public) key when editing, then I don't see a reason not to show it after it's revoked.

In T15225#13714, @waldyrious wrote:

It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message.

In T15671#14420, @avivey wrote:

The feature was removed for performance and private concerns. I thought Gravatar was alread dead.

Maybe this can be done as an extension:

• Abstract the "profile picture provider"
• Allow an extension to write a Gravatar one

There are currently 2-3 sources, so maybe there is some abstraction:

• pokemon-style silhouette
• Character with background (generated from username)
• Upload Picture

The feature was removed for performance and private concerns. I thought Gravatar was alread dead.

Obviously, any fixes should be in ManiphestTransactionEditor and not spill into generic parent PhabricatorApplicationTransactionEditor.

Historical references: rP69eab4196de462e42b07b60e2b52071631f4a3c8 and rP4041a7e0f66406dbaa31faa3807d50833b7c7efd (which didn't help much).

My steps to reproduce are wrong / unclear / not always happening.

Hoping to be useful we can self-document this joining this group:

Partially related to

Yeah feel free to review D25301

I still like this. Why is this not going forward? 😄

It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message. I was caught off-guard by this at least once. So perhaps the text entry box should be made single-line by default (as already happens if the screen is narrow enough) and expand as needed if line breaks are added.

Nuance has a "GitHub Repository: Import issues and pull requests from a GitHub repository" Source Type - it might already be doing something related?