Page MenuHomePhorge

Legalpad and Phame: "Quote Comment" destination is a "not found" page
Open, LowPublic

Description

Steps to reproduce:

  • edit a Lealpad
  • visit a comment
  • see the Quote Comment destination link

At the moment the destination URL is something like:

http://phorge.boz.local.reyboz.it/legalpad/view/3/L1#

This should be instead:

phorge.boz.local.reyboz.it/legalpad/view/3/#

Revisions and Commits

Event Timeline

valerio.bozzolan renamed this task from Legalpad: "Quote Comment" destination is a "not found" page to Legalpad and Phame: "Quote Comment" destination is a "not found" page.Aug 1 2023, 12:12
valerio.bozzolan added a project: Phame.

I'm 99% sure that this only affects Phame and Legalpad. I tested in Audit, Maniphest, Paste, Pholio and Files without issues.

Note that at least for Phame, http://phorge.localhost/J1 seems to always redirect to http://phorge.localhost/phame/post/view/1/blogpost/ instead of keeping the monogram in the URI.
So the baseURI is already wrong (not being http://phorge.localhost/ only) before concatenating the $ref (monogram and anchor).
As an ugly workardound, could probably make "Quote Comment" work by calling getObjectNamePrefix() in PhamePostRemarkupRule and LegalpadDocumentRemarkupRule and then use them in a preg_match to remove the monogram from the $ref but function is protected and... still ugly.