Page MenuHomePhorge

20after4 (Mukunda Modell)
ContributorAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2021, 22:11 (148 w, 3 d)
Roles
Administrator
Availability
Available
Timezone
US Central

Phabricator, Phorge.it & Me

I started working with Phabricator in 2012 and I've been a contributor to the open source project since 2014. I also maintained Wikimedia's Fork of Phabricator, along with several extensions until 2021. When Phacility announced the end of active maintenance for Phabricator, I was involved in organizing a group of interested parties to take over community support of the project. Ultimately that effort has evolved into this project that you are currently viewing.

See L1 Phorge Vision Statement for the project vision statement.

Employment

Previously:

  • Senior Engineer at play.co.
  • Release Engineer at the Wikimedia Foundation (2014 to 2022).
  • Back-end and DevOps Engineer at deviantArt.com (2009 to 2013)

Disclaimer & Disclosure

Any opinions that I express do not necessarily represent those of current or previous employers. My participation in the phorge community is in a personal capacity and not as part of my employment.

Recent Activity

Fri, Apr 5

20after4 added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

Also apologies for not testing this locally, I was far too confident in my TDD.

Fri, Apr 5, 19:52
20after4 added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

man I didn't even consider that you could actually have a valid project named #0dba11 ... maybe the syntax should be something different. #{00ffff} perhaps?

Fri, Apr 5, 19:51
20after4 added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

It's kind of a shame that remarkup wasn't named Pharkup.

Fri, Apr 5, 02:01
20after4 updated the diff for D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

Actually add the rule to the remarkup engine.

Fri, Apr 5, 02:01
20after4 added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

LOL I only ever tested the unit test case. I forgot to add the rule to PhabricatorMarkupEngine:

Fri, Apr 5, 02:00

Wed, Apr 3

20after4 added inline comments to D25565: Make incoming mail handling more robust / correct.
Wed, Apr 3, 17:12
20after4 added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

Anyway, I vote to revert the change - commit pages can have discussions in.

Wed, Apr 3, 17:03 · Discussion Needed
20after4 added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

If it's that easy, then I'm both impressed and surprised it remained this way for so long. I'm actually not quite sure I understand the reasoning for not using # to begin with.

Wed, Apr 3, 16:58 · Discussion Needed
20after4 awarded P35 Replace fragments a Mountain of Wealth token.
Wed, Apr 3, 16:57
20after4 added inline comments to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.
Wed, Apr 3, 01:21
20after4 added inline comments to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.
Wed, Apr 3, 01:18
20after4 updated the diff for D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

Address review feedback:

Wed, Apr 3, 01:18
20after4 accepted D25567: Fix PHP 8.1 "preg_match(null)" exception exporting task list to CSV.
Wed, Apr 3, 00:50
20after4 accepted D25568: Fix PHP 8.1 "addcslashes(null)" exception exporting task list to tab-separated text.
Wed, Apr 3, 00:49

Tue, Apr 2

20after4 added a comment to D25549: Add Standard Custom Fields to Item List.

I'll test this locally, I can't see any reason we shouldn't merge it.

Tue, Apr 2, 19:22
20after4 awarded D25475: Drag & Drop Task Cover Image: also attach a Mountain of Wealth token.
Tue, Apr 2, 19:21
20after4 awarded D25538: Separate repository home and browse view in tab menu a Orange Medal token.
Tue, Apr 2, 19:19
20after4 awarded D25566: Fix setup check for gzip request mangling being sent as GET a Mountain of Wealth token.
Tue, Apr 2, 19:15
20after4 updated 20after4.
Tue, Apr 2, 19:14

Mon, Apr 1

20after4 added a comment to T15744: Render html color codes in remarkup.

This should be ready to merge now, if someone wouldn't mind reviewing it.

Mon, Apr 1, 18:14 · Remarkup
20after4 accepted D25566: Fix setup check for gzip request mangling being sent as GET.

Discussed on IRC: it seems that this should have been POST all along.

Mon, Apr 1, 18:12
20after4 added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

About your Remarkup unit tests, try to rebase. Maybe related to D25559.

Mon, Apr 1, 18:11
20after4 retitled D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes from WIP: add PhutilRemarkupHexColorCodeRule
Mon, Apr 1, 18:10
20after4 updated the diff for D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.
  • Fixed a logic bug.
  • Added passing unit tests.
Mon, Apr 1, 18:04

Sat, Mar 30

20after4 awarded D25561: Fix important regression in search engine a Mountain of Wealth token.
Sat, Mar 30, 11:02
20after4 accepted D25554: Custom integer fields: fix search by array of possible values.
Sat, Mar 30, 11:01

Fri, Mar 22

20after4 added Q86: Policy lifecycle of security tasks (Answer 154).
Fri, Mar 22, 14:59
20after4 added Q115: How to analyze each member story points data (Answer 153).
Fri, Mar 22, 14:57
20after4 added a comment to T15048: Allow awarding Tokens to individual Comments.

So I got this mostly working locally, it's actually fairly trivial to reuse the existing token storage and infrastructure. Actually displaying the tokens might not be the most efficient of operations when there are a lot of comments on a given object. I still need to write an optimized query to fetch all of the token given in one query rather than many and then figure out how to display the tokens inline with the comments.

Fri, Mar 22, 14:42 · Comments

Mar 10 2024

20after4 added a comment to Q116: How to set fa-pie-chart value? (Answer 147).

@littleggghost I think you might just need to run celerity to update the icons.

Mar 10 2024, 00:56

Mar 2 2024

20after4 added Q116: How to set fa-pie-chart value? (Answer 147).
Mar 2 2024, 11:55
20after4 awarded T15750: Integrate CustomField into more interfaces a Love token.
Mar 2 2024, 11:37
20after4 awarded D25549: Add Standard Custom Fields to Item List a Mountain of Wealth token.
Mar 2 2024, 11:36
20after4 added a comment to D25549: Add Standard Custom Fields to Item List.

This is really cool!

Mar 2 2024, 11:36
20after4 closed D25547: Diviner: Improve documentation for remarkup code blocks.
Mar 2 2024, 11:32
20after4 committed rP32b5139d46dc: Diviner: Improve documentation for remarkup code blocks.
Diviner: Improve documentation for remarkup code blocks
Mar 2 2024, 11:32

Feb 29 2024

20after4 updated the summary of D25547: Diviner: Improve documentation for remarkup code blocks.
Feb 29 2024, 17:39
20after4 added a comment to T15747: Support short language specifier in code blocks: ```php instead of ```lang=php.

Added documentation in D25547: Diviner: Improve documentation for remarkup code blocks

Feb 29 2024, 17:36 · Remarkup
20after4 requested review of D25547: Diviner: Improve documentation for remarkup code blocks.
Feb 29 2024, 17:34
20after4 added a comment to Q114: Subtypes deadline switch to colored calendar icons (Answer 146).

Awesome! I'm glad it finally worked. If you want all of your tasks to have the 'deadline' subtype you can edit your task form to set the subtype (or create a separate form that sets the subtype) that way you don't have to manually change the type of each task after it's created.

Feb 29 2024, 16:46
20after4 added a comment to Q114: Subtypes deadline switch to colored calendar icons (Answer 146).

Did you manage to get the extension working?

Feb 29 2024, 16:38
20after4 accepted D25545: Make lipsum project generator also fill in project description.
Feb 29 2024, 16:38
20after4 changed the visibility for F1441547: 0001-Add-custom-task-deadline-display-on-workboard-cards.patch.
Feb 29 2024, 11:49
20after4 changed the visibility for F1469703: Screenshot from 2024-02-29 03-46-40.png.
Feb 29 2024, 11:49
20after4 changed the visibility for F1469699: Screenshot from 2024-02-29 03-45-51.png.
Feb 29 2024, 11:48
20after4 changed the visibility for F1469698: Screenshot from 2024-02-29 03-45-23.png.
Feb 29 2024, 11:48
20after4 added a comment to Q114: Subtypes deadline switch to colored calendar icons (Answer 146).

You still need the wikimedia extension at least for now. The screenshots just show how to change the subtype of a task and then shows the due date icon. I just changed the permissions on the attachments, maybe they work now?

Feb 29 2024, 11:45
20after4 added a comment to Q114: Subtypes deadline switch to colored calendar icons (Answer 146).

@littleggghost: Yes after applying the patch to phorge master branch I can see the icon.

Feb 29 2024, 09:48
20after4 accepted D25544: Comments: avoid confusing warning about "core:file".
Feb 29 2024, 06:37
20after4 added a comment to D25544: Comments: avoid confusing warning about "core:file".

confirmed, that warning makes no sense.

Feb 29 2024, 06:37
20after4 added a comment to D25544: Comments: avoid confusing warning about "core:file".
Feb 29 2024, 06:36
20after4 added a comment to D25544: Comments: avoid confusing warning about "core:file".
Feb 29 2024, 06:36
20after4 closed T15747: Support short language specifier in code blocks: ```php instead of ```lang=php as Invalid.
Feb 29 2024, 06:34 · Remarkup
20after4 added a comment to T15747: Support short language specifier in code blocks: ```php instead of ```lang=php.

Hahah I guess I could have tested it first.

Feb 29 2024, 06:33 · Remarkup

Feb 28 2024

20after4 created T15747: Support short language specifier in code blocks: ```php instead of ```lang=php.
Feb 28 2024, 18:35 · Remarkup
20after4 added a comment to Q114: Subtypes deadline switch to colored calendar icons (Answer 146).

This looks correct to me:

Feb 28 2024, 18:29
20after4 added a comment to T15675: Visually indicate new user accounts.

I agree, badges seems like the right way to go. They are an underutilized feature really, IMO.

Feb 28 2024, 08:37 · Feature Requests
20after4 updated the answer details for Q114: Subtypes deadline switch to colored calendar icons (Answer 146).
Feb 28 2024, 08:35
20after4 updated the answer details for Q114: Subtypes deadline switch to colored calendar icons (Answer 146).
Feb 28 2024, 08:33
20after4 added a comment to Q114: Subtypes deadline switch to colored calendar icons (Answer 146).

@littleggghost So it turns out that in order to enable this feature, there was a patch to Phabricator core. That patch isn't part of the wikimedia extension, and hasn't been merged into phorge.

Feb 28 2024, 08:31

Feb 27 2024

20after4 updated subscribers of Q114: Subtypes deadline switch to colored calendar icons (Answer 146).

@littleggghost one thing you might want to try is updating the celerity map. You may be missing the custom css rules to style the deadline appropriately. I’m not familiar enough with the phorge docker image to be able to tell you exactly how that is accomplished. With non-containerized phorge instances you would just run bin/celerity map from within the phorge root directory.

Feb 27 2024, 22:11
20after4 added Q114: Subtypes deadline switch to colored calendar icons (Answer 146).
Feb 27 2024, 21:53
20after4 added a comment to T15743: Support for math (LaTeX) in Remarkup.
Feb 27 2024, 01:21 · Remarkup

Feb 26 2024

20after4 added a comment to T15743: Support for math (LaTeX) in Remarkup.

Interestingly, I just discovered Wikimedia has a pretty cool project to render math on the server side, by transpiling some js into php:

Feb 26 2024, 19:18 · Remarkup
20after4 awarded T15718: Guide/demo on "How To Create Your First Extension" a Orange Medal token.
Feb 26 2024, 18:49 · Extension Development, Phactory: Community Projects
20after4 updated the answer details for Q113: How to create a bug report (Answer 145).
Feb 26 2024, 18:48
20after4 added Q113: How to create a bug report (Answer 145).
Feb 26 2024, 18:47
20after4 added a comment to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

I went down a rabbit hole while trying to add unit tests for this. Our core remarkup unit tests are pretty thorough but they only seem to cover the "core" remarkup engine and syntax. When I added a new test case for this it would pass but always caused a different test case to fail in weird ways. I haven't yet figured out what part of the unit test or engine is stateful such that my unit test alters the state in a way that breaks a later test. If I change the order that tests run in, it just causes another different test case to fail.

Feb 26 2024, 18:40
20after4 updated the diff for D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

Fix lint again

Feb 26 2024, 18:36
20after4 updated the diff for D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

fix lint.

Feb 26 2024, 18:35
20after4 updated the diff for D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

Added contrasting color calculation

Feb 26 2024, 18:33
20after4 added a comment to T15743: Support for math (LaTeX) in Remarkup.

There is also MathJax, a subset of LaTex that only covers the mathematical notation without the page layout functionality.

Feb 26 2024, 17:42 · Remarkup

Feb 25 2024

avivey awarded T15744: Render html color codes in remarkup a Grey Medal token.
Feb 25 2024, 08:59 · Remarkup
avivey awarded T15743: Support for math (LaTeX) in Remarkup a Yellow Medal token.
Feb 25 2024, 08:18 · Remarkup
20after4 claimed T15744: Render html color codes in remarkup.
Feb 25 2024, 04:14 · Remarkup
20after4 triaged T15744: Render html color codes in remarkup as Normal priority.
Feb 25 2024, 04:14 · Remarkup
20after4 planned changes to D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

This is not yet tested.

Feb 25 2024, 04:13
20after4 updated the diff for D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.

fix lint error.

Feb 25 2024, 04:12
20after4 requested review of D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.
Feb 25 2024, 04:10
20after4 added a revision to T15744: Render html color codes in remarkup: D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.
Feb 25 2024, 04:10 · Remarkup
20after4 added a comment to T15744: Render html color codes in remarkup.

This would be useful for discussions about design, specifically I wished for this feature while reviewing D25491: Improve contrast of Links in Dark Mode

Feb 25 2024, 00:53 · Remarkup
20after4 created T15744: Render html color codes in remarkup.
Feb 25 2024, 00:48 · Remarkup
20after4 created T15743: Support for math (LaTeX) in Remarkup.
Feb 25 2024, 00:40 · Remarkup

Feb 23 2024

20after4 added a comment to T15719: Phorge mail may not meet Google's email sender guidelines.
In T15719#15304, @Tgr wrote:

Given how it's displayed on the Gmail UI, IMO unsubscribing from all emails or at least all emails of the given type (e.g. all Maniphest emails if it's a Maniphest notification) is the only thing that makes sense. If I mark an email as spam, and then use the unsubscribe option instead, I would not expect to continue getting identical email from all the other tasks.
No idea how (or if) other email clients handle the header, though.

Feb 23 2024, 08:54 · Maniphest, Mail

Feb 22 2024

20after4 added a comment to D25491: Improve contrast of Links in Dark Mode.

Hello! Are you sure changing the links color is a good idea? Perhaps we should just make the background darker?

Feb 22 2024, 09:58
20after4 added a comment to T15048: Allow awarding Tokens to individual Comments.

The only progress I've made is to think through the implementation but I haven't actually started coding on it. It is sort of high on my wish list so I may get to it soon.

Feb 22 2024, 09:50 · Comments

Feb 17 2024

20after4 awarded R11:741e2946b93f: license a Like token.
Feb 17 2024, 12:52

Feb 13 2024

20after4 added a comment to T15705: Lower the search ranking of disabled user accounts.

I agree, disabled users should be hidden in the global search typeahead results.

Feb 13 2024, 23:22 · Discussion Needed, UX
20after4 added a comment to T15736: JavaScript modernization (umbrella task).
In T15736#15681, @bekay wrote:
  • Get rid of the JX namespace and the the require comments - use import and export like it is done in modern js
Feb 13 2024, 23:21 · UX, Discussion Needed

Feb 11 2024

20after4 triaged T15736: JavaScript modernization (umbrella task) as Wishlist priority.
Feb 11 2024, 22:32 · UX, Discussion Needed
20after4 added a subtask for T15736: JavaScript modernization (umbrella task): T15168: Improve JavaScript i18n.
Feb 11 2024, 22:32 · UX, Discussion Needed
20after4 added a parent task for T15168: Improve JavaScript i18n: T15736: JavaScript modernization (umbrella task).
Feb 11 2024, 22:32 · User-valerio.bozzolan, Localization
20after4 created T15736: JavaScript modernization (umbrella task).
Feb 11 2024, 22:31 · UX, Discussion Needed

Feb 9 2024

20after4 added a comment to T15673: Phorge participation at FOSDEM 2024.

TRUST ME - YOU DON'T WANT TO LISTEN MY ENGLISH :D :D

Btw now the video is here :D :D AGAIN SORRY PHORGE FOR MY MISTAKES <3 <3

Feb 9 2024, 17:10 · Blessed Communicators, Phorge
20after4 added a comment to T15673: Phorge participation at FOSDEM 2024.

Nice, you touched on most of the advantages of Phorge. It really does have some strong competitive advantages.

Feb 9 2024, 08:41 · Blessed Communicators, Phorge
20after4 added a comment to T15630: Fix Fonts.

From my perspective, on Linux, Phorge already supports configurable fonts - that is, none of the specific typefaces mentioned in the phorge css actually work, so it falls back to whatever I set as the default document font in Gnome.

Feb 9 2024, 08:25
20after4 added a comment to T15630: Fix Fonts.

CSS is rather flexible now; a larger font scale can be specified for displays above a certain horizontal resolution or display width/effective character width, nowadays.
Atkinson looks poor at the font size specified, you're right about that @bekay.
I feel like it might need to break out into another task item, but perhaps CSS modernization is imo a good step towards making Phorge more compatible and capable, on screens both small and large.

Feb 9 2024, 08:23

Feb 6 2024

20after4 added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

When I was at Wikimedia I remember a lot of issues from search robots endlessly indexing dynamic pages.

Feb 6 2024, 02:26 · Discussion Needed

Feb 4 2024

20after4 added a comment to T15630: Fix Fonts.

Interesting that gnome is considering Inter. Recursive looks really good too. I like that it has both monospace and proportional all in one.

Feb 4 2024, 13:40

Feb 2 2024

20after4 added a comment to D25501: Feed: Do not query and display data of uninstalled applications.

Maybe we can simplify things introducing a commodity "if viewer exists" method like:

Feb 2 2024, 14:57