Page MenuHomePhorge

20after4 (Mukunda Modell)
ContributorAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2021, 22:11 (118 w, 5 d)
Roles
Administrator
Availability
Available
Timezone
US Central

Phabricator, Phorge.it & Me

I started working with Phabricator in 2012 and I've been a contributor to the open source project since 2014. When Phacility announced the end of active maintenance for Phabricator, I was involved in organizing a group of interested parties to take over community support of the project. Ultimately that effort has evolved into this project that you are currently viewing.

See L1 Phorge Vision Statement for the project vision statement.

Employment

Previously:

  • Senior Engineer at play.co.
  • Release Engineer at the Wikimedia Foundation (2014 to 2022).
  • Back-end and DevOps Engineer at deviantArt.com (2009 to 2013)

Disclaimer & Disclosure

Any opinions that I express do not necessarily represent those of current or previous employers. My participation in the phorge community is in a personal capacity and not as part of my employment.

Recent Activity

Fri, Sep 15

20after4 updated subscribers of D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).
Fri, Sep 15, 10:43
20after4 added a comment to D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

Hi @20after4 :) Can I ask you if this could be useful in Wikimedia? I think yep

Fri, Sep 15, 10:42
20after4 accepted D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

I like it but I haven't tested locally.

Fri, Sep 15, 10:39

Mon, Aug 28

20after4 awarded T15583: Typeahead datasource query for repos should match substrings a Like token.
Mon, Aug 28, 17:32 · Feature Requests, Diffusion

Jul 6 2023

20after4 awarded T15535: Using Differential with plain Git, without requiring Arc a Love token.
Jul 6 2023, 15:07 · Feature Requests
20after4 added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Interesting.... Herald could probably start the flow, but there's still more parts needed (update vs create revision, extract summary and test plan)

Jul 6 2023, 13:14 · Discussion Needed, Arcanist

Jul 5 2023

20after4 added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I suspect there's also a problem of motivation: These things are lots of work, and the people who are capable of performing them - people who are comfortable with working with these tools - will not personally benefit from this stuff. The people who would benefit the most are people who are not involved in the project at all...

Jul 5 2023, 16:23 · Discussion Needed, Arcanist

Jul 1 2023

20after4 awarded rHP065aaa664276: Improve quality of logo.png and fix favicon.ico a Yellow Medal token.
Jul 1 2023, 21:48
20after4 added Q34: Configure display of search results (for tasks) (Answer 85).
Jul 1 2023, 21:47
20after4 added a project to Q49: File uploads - default permissions: Files.
Jul 1 2023, 21:42 · Files
20after4 added a project to Q62: Extension: how to use PhabricatorFile::newFromFileData(): Files.
Jul 1 2023, 21:41 · Files
20after4 awarded Q62: Extension: how to use PhabricatorFile::newFromFileData() a Yellow Medal token.
Jul 1 2023, 21:39 · Files
20after4 added a comment to Q64: File editor extension: updating PhabricatorFile content (Answer 83).

Cool extension! We still need to build a proper extension ecosystem for Phorge. Maybe we could start with a wiki page linking to known extensions, then you'll have a place to share your extension, should you decide to do so.

Jul 1 2023, 21:38

Jun 22 2023

20after4 awarded D25293: Diviner: add a minimal systemd example a Doubloon token.
Jun 22 2023, 23:49
20after4 accepted D25293: Diviner: add a minimal systemd example.

lgtm

Jun 22 2023, 23:48

Jun 20 2023

20after4 added a comment to T15483: EditEngine: allow to Duplicate a Form.

This is a feature that was invaluable on wikimedia's use of phabricator, however, proliferation of a lot of forms can be troublesome / difficult to manage. Ideally the forms system could use some improvements to make things more manageable.

Jun 20 2023, 22:25 · Affects-Wikimedia
20after4 awarded T15483: EditEngine: allow to Duplicate a Form a Like token.
Jun 20 2023, 22:23 · Affects-Wikimedia
20after4 awarded rP478012cd463d: Add serious business string for defrocking a user (remove admin rights) a Mountain of Wealth token.
Jun 20 2023, 22:17
20after4 updated 20after4.
Jun 20 2023, 22:12
20after4 updated 20after4.
Jun 20 2023, 22:11
20after4 updated 20after4.
Jun 20 2023, 22:09

Jun 14 2023

20after4 added a comment to T15410: Discussion: stacked diffs / dependent revisions.

More prior art: https://zuul-ci.org/docs/zuul/latest/gating.html#cross-project-testing

Jun 14 2023, 05:24 · Differential
20after4 awarded T15467: Document a systemd daemon a Like token.
Jun 14 2023, 05:03 · User-valerio.bozzolan, Documentation
20after4 added a comment to T15467: Document a systemd daemon.

This is a nice contribution and definitely would be a valuable addition to the docs, IMO.

Jun 14 2023, 04:55 · User-valerio.bozzolan, Documentation

May 22 2023

20after4 added a comment to T15364: arc land complaints summary by FreeBSD community.
In T15364#8952, @avivey wrote:

"tooling for chains of diffs" might need its own topic, with a design of the what the whole thing should look like in an ideal world, and how to get to it.
Even if not all of the stuff fits nicely into Phorge, there's probably a lot that can work, and some conduit methods can be added to implement the rest.

May 22 2023, 01:32 · Arcanist, Differential, Affects-FreeBSD
20after4 added a comment to T15410: Discussion: stacked diffs / dependent revisions.

Breaking this out from the discussion at T15364: arc land complaints summary by FreeBSD community

May 22 2023, 01:31 · Differential
20after4 created T15410: Discussion: stacked diffs / dependent revisions.
May 22 2023, 01:30 · Differential

May 8 2023

20after4 added a comment to T15364: arc land complaints summary by FreeBSD community.

FWIW I think the test plan is configurable (that requirement can be disabled in phabricator's config server side which should remove it from commit messages in arc)

May 8 2023, 18:21 · Arcanist, Differential, Affects-FreeBSD

Apr 23 2023

valerio.bozzolan awarded D25101: Countdown: add a capability to decide who can Create a Yellow Medal token.
Apr 23 2023, 20:55 · Policy (archived), Countdown (archived)
20after4 closed D25101: Countdown: add a capability to decide who can Create.
Apr 23 2023, 20:18 · Policy (archived), Countdown (archived)
20after4 closed T15208: Countdown: it's not possible to limit who can create a new Countdown, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Apr 23 2023, 20:18 · Affects-Wikimedia
20after4 closed T15208: Countdown: it's not possible to limit who can create a new Countdown as Resolved by committing rP7ed35123a347: Countdown: add a capability to decide who can Create.
Apr 23 2023, 20:18 · Policy, User-valerio.bozzolan, Affects-Wikimedia
20after4 committed rP7ed35123a347: Countdown: add a capability to decide who can Create (authored by 20after4).
Countdown: add a capability to decide who can Create
Apr 23 2023, 20:18
20after4 added a comment to T15011: Build a Phorge Developer Environment.

Relevant links:

Apr 23 2023, 20:00

Apr 18 2023

20after4 added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

I might be willing to take a stab at this but not sure when I'll have the time.

Apr 18 2023, 05:51 · Affects-FreeBSD, Differential
20after4 added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

Phabricator's codebase is mostly high quality and fairly easy to jump into but I probably wouldn't recommend it for someone new to PHP :D

Apr 18 2023, 05:49 · Affects-FreeBSD, Differential
20after4 added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

@ton welcome, glad to have your input here.

Apr 18 2023, 05:45 · Discussion Needed, Arcanist

Mar 18 2023

20after4 added a comment to T15127: Allow for reordering of milestones.

FWIW even in the case the milestones are strictly ordered, it's incredibly inconvenient to sort out a situation where you need to add one to the middle of the list - forcing the user to rename a bunch of them to get things straightened out.

Mar 18 2023, 21:28 · Workboard
20after4 added a comment to T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards.

epriestley was very much against this idea but wikimedia's users loved it.

Do we have epristley's reasoning as to why he was against this? Might help in deciding about including this patch in Phorge.

Mar 18 2023, 21:26 · Affects-Wikimedia, Workboard
20after4 awarded D25069: Fix middle-click, CTRL+click, right-click etc. on Typehead search results a Love token.
Mar 18 2023, 20:57

Mar 15 2023

valerio.bozzolan awarded T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues. a Mountain of Wealth token.
Mar 15 2023, 07:56 · Discussion Needed, Arcanist

Dec 20 2022

20after4 added a comment to T15048: Allow awarding Tokens to individual Comments.
In T15048#2234, @eax wrote:

IMHO if we are to do this it should be similar to "comment reactions" from github. Useful for e.g., +1 -1 but shouldn't generate visible transactions on the rest of the page.

Dec 20 2022, 02:25
20after4 added a comment to T15132: Support monospaced links in remarkup.

To me 2 seems like the safest / easiest solution, even if it is a bit limited.

Dec 20 2022, 02:16 · Remarkup
20after4 awarded T15137: Not able to edit a "Calendar Imported .ics URI" a Orange Medal token.
Dec 20 2022, 02:11 · User-valerio.bozzolan, Calendar
20after4 awarded D25061: Fix editing a Calendar import ICS URI a Mountain of Wealth token.
Dec 20 2022, 02:11

Nov 30 2022

20after4 accepted D25060: Fix NULL pointer exception in some circumstances from Calendar's homepage.
Nov 30 2022, 18:13 · Calendar
20after4 added a comment to D25060: Fix NULL pointer exception in some circumstances from Calendar's homepage.

This looks good to me. It seems like I may have actually ran into this before and just didn't manage to upstream the fix from Wikimedia's fork.

Nov 30 2022, 18:13 · Calendar

Sep 7 2022

20after4 closed T15114: Can I create tasks? as Invalid.
Sep 7 2022, 16:54
20after4 added a comment to T15084: Discussion: Maniphest vs Ponder for user support.

Well that didn't work: T15114: Can I create tasks?

Sep 7 2022, 16:50 · phorge.it install
20after4 created T15114: Can I create tasks?.
Sep 7 2022, 16:49
20after4 removed a member for Trusted Contributors: 20after4.
Sep 7 2022, 16:48
20after4 added a comment to T15084: Discussion: Maniphest vs Ponder for user support.

I'll remove myself from trusted contributors just to test.

Sep 7 2022, 16:48 · phorge.it install
20after4 added a comment to T15084: Discussion: Maniphest vs Ponder for user support.

The form ( https://we.phorge.it/transactions/editengine/maniphest.task/edit/2/ ) needed a security policy. I think that should fix the problem?

Sep 7 2022, 16:48 · phorge.it install
20after4 added a comment to T15101: Assigned to - Required Field.

https://secure.phabricator.com/book/phabricator/article/custom_fields/ custom fields allow you to set the required property in configuration. I'm not sure if you can use this to override a default built-in field but you could possibly replace the built in field with a custom field with same/similar name and type: users.

Sep 7 2022, 16:45 · Maniphest

Jul 26 2022

20after4 committed rPa0b91de535af: New MediaWiki logo for the icon that represents the MediaWiki oauth provider. (authored by 20after4).
New MediaWiki logo for the icon that represents the MediaWiki oauth provider.
Jul 26 2022, 15:03

May 14 2022

20after4 awarded T15098: Disabled required fields in subtypes should neither block creation of a task nor be displayed in the frontend a Like token.
May 14 2022, 16:26

May 1 2022

20after4 added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
In T15096#2233, @speck wrote:

Thank you for these write-ups, I'll need more time to review however I noticed Evan recently started a task in the upstream where it looks like he's investigating compiling PHP to a library for use with a custom native entrypoint which would allow distributing arcanist as a single binary (he estimates ~10mb in size).
https://secure.phabricator.com/T13675

May 1 2022, 21:38 · Discussion Needed, Arcanist
20after4 updated the task description for T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
May 1 2022, 21:28 · Discussion Needed, Arcanist

Apr 27 2022

20after4 added a comment to D25021: Added cross-platform default fonts.

This seems sensible to me, FWIW

Apr 27 2022, 15:59
20after4 added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

@micax: Good points and it's helpful to hear another perspective on this. From my past experience using Phabricator on a corporate team I definitely think that arcanist helped keep everyone's workflow consistent and simple.

Apr 27 2022, 15:54 · Discussion Needed, Arcanist

Apr 25 2022

20after4 edited the content of April 19, 2022.
Apr 25 2022, 07:42 · Governance
20after4 created T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
Apr 25 2022, 07:39 · Discussion Needed, Arcanist

Apr 24 2022

20after4 awarded D25034: support language highlighting for GFM-style code blocks a Mountain of Wealth token.
Apr 24 2022, 18:50
20after4 added Q11: upgrade phabricator to phorge (Answer 3).
Apr 24 2022, 18:45
20after4 added a task to D25037: Hide the "hidden" fields on custom form previews: T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Apr 24 2022, 18:39
20after4 added a task to D25038: Conduit column.search: add status, sequence and isDefault to API results: T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Apr 24 2022, 18:39
20after4 added revisions to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: D25038: Conduit column.search: add status, sequence and isDefault to API results, D25037: Hide the "hidden" fields on custom form previews.
Apr 24 2022, 18:39 · Affects-Wikimedia
20after4 updated the diff for D25038: Conduit column.search: add status, sequence and isDefault to API results.

Fix line length

Apr 24 2022, 18:36
20after4 retitled D25038: Conduit column.search: add status, sequence and isDefault to API results from Add column sequence to the conduit api results for column.search to Add Status, sequence and isDefault to the conduit api results for column.search.
Apr 24 2022, 18:34
20after4 updated the diff for D25038: Conduit column.search: add status, sequence and isDefault to API results.

celerity map

Apr 24 2022, 18:30
20after4 requested review of D25038: Conduit column.search: add status, sequence and isDefault to API results.
Apr 24 2022, 18:29
20after4 requested review of D25037: Hide the "hidden" fields on custom form previews.
Apr 24 2022, 18:19
20after4 added a comment to T15048: Allow awarding Tokens to individual Comments.

Does anyone else feel that this is not a good idea? Seems like the consensus here is that it's at least acceptable if not desirable to have.

Apr 24 2022, 17:58
20after4 added a comment to T15048: Allow awarding Tokens to individual Comments.

I did a bit of digging through the source code and it looks like tokens are implemented in an incredibly generic way, such that it wouldn't be at all difficult to add tokens to comments. I think the hardest part will be integrating it with the UI.

Apr 24 2022, 17:55
20after4 added a comment to T15090: CVE-2022-24765 - Multi-user Git Privilege Escalation.
In T15090#2141, @avivey wrote:

@avivey Would it make sense to add a public announcement to Diviner or Phiction? Or perhaps we use Phame for this use case (Create a "Security Incidents" blog)? I always think of a task as an actionable item, whereas we would want this to exist forever.

Yes, probably. "Announcements"-style thing

Apr 24 2022, 17:51 · Security
20after4 created T15095: Setup an announcements blog with Phame.
Apr 24 2022, 17:51 · phorge.it install

Apr 11 2022

20after4 added a comment to T15084: Discussion: Maniphest vs Ponder for user support.

I'm setting the "Moderate" policy on Ponder to Trusted Contributors and I'll add a link to Ponder from the default home page.

Apr 11 2022, 17:17 · phorge.it install
20after4 changed the Moderate Policy policy for application Ponder from Administrators to Trusted Contributors (Project).
Apr 11 2022, 17:16
20after4 awarded T15084: Discussion: Maniphest vs Ponder for user support a Mountain of Wealth token.
Apr 11 2022, 17:15 · phorge.it install

Apr 6 2022

20after4 awarded April 5, 2022 a Mountain of Wealth token.
Apr 6 2022, 16:59 · Governance

Mar 31 2022

20after4 added a comment to T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards.

epriestley was very much against this idea but wikimedia's users loved it.

Do we have epristley's reasoning as to why he was against this? Might help in deciding about including this patch in Phorge.

Mar 31 2022, 23:55 · Affects-Wikimedia, Workboard

Mar 25 2022

20after4 added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards.
Mar 25 2022, 13:18 · Affects-Wikimedia
20after4 added a parent task for T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards: T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Mar 25 2022, 13:18 · Affects-Wikimedia, Workboard
20after4 added a project to T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards: Projects (archived).
Mar 25 2022, 13:17 · Affects-Wikimedia, Workboard
20after4 created T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards.
Mar 25 2022, 13:17 · Affects-Wikimedia, Workboard
20after4 added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
  • e95157e39bf5 Show matching context from the document body in ferret search results
    • This is not perfect but it generally works - display a snippet from the matched document and highlight the matched words - kind standard and expected from any full-text search engine. Probably not my best work as far as code quality / it's a bit hacky and performance may not be stellar, however, it's been in use at wikimedia for quite some time without any major issues that I'm aware of.
  • bba62cf52435 Hide the "hidden" fields on custom form previews.
    • This is a single line change to css that makes things a lot cleaner when you have a lot of custom forms with a lot of custom fields.
    • submitted as D25037
  • 9191d4838278 Make "task type" and date-type custom fields work in herald.
  • 3d33d1cceac7 Implement Atom/RSS discovery on Phame blog pages
  • ebfe30890b52 Add column sequence to the conduit api results for column.search
    • This seems like an obvious omission from the conduit api for columns and the change is straightforward.
    • submitted as D25038
  • 893664bd44b8 EditEngine: 'Duplicate Form' action to create new forms from existing config.
    • This makes it much easier to clutter up your custom forms with 100 variations of your forms. It also makes it much easier to make a new form vs. starting from scratch every time. It's sort of a hack and the custom form management UI needs a lot of improvement generally, this was just the minimum change I could implement to make life slightly easier for myself and fellow Wikimedia phab admins. Not sure it's a good idea in the upstream without further changes to go with it.
  • 44a94dc04b3f Fix validation of "column" transaction type in "maniphest.edit"
Mar 25 2022, 08:20 · Affects-Wikimedia
20after4 created T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Mar 25 2022, 07:52 · Affects-Wikimedia
20after4 created P3 Wikimedia patches.
Mar 25 2022, 07:50
20after4 added a comment to D25035: Hide the blurb of a user when that user is disabled.

fwiw, this is how I handled it in the wikimedia fork:

Mar 25 2022, 04:45

Mar 15 2022

20after4 updated the task description for T15071: Setup recurring Core meeting.
Mar 15 2022, 22:23 · Governance

Mar 14 2022

20after4 added a comment to T15030: Support a Phorge Extensions ecosystem.

@MacFan4000 the mediawiki auth is in core afaik. There is some custom stuff for the wikimedia ldap setup but the oauth part was merged upstream ages ago.

Mar 14 2022, 05:02 · Phactory: Community Projects, Phorge
20after4 added a comment to T15069: Disable spammers.

Yeah admittedly what I did was just a hack because I didn't want to implement storage and UI for a new "hidden" boolean flag.

Mar 14 2022, 05:00 · Upstream General/Unknown

Mar 13 2022

20after4 added a comment to T15069: Disable spammers.

On Wikipedia’s phabricator instance I implemented a patch that hides the profile text on disabled accounts which helps (slightly) to disincentivize spammers.

Mar 13 2022, 00:13 · Upstream General/Unknown

Mar 12 2022

20after4 updated the task description for T15071: Setup recurring Core meeting.
Mar 12 2022, 05:09 · Governance

Feb 25 2022

20after4 updated 20after4.
Feb 25 2022, 21:07
20after4 updated 20after4.
Feb 25 2022, 21:06

Feb 1 2022

20after4 updated subscribers of T15055: Import translations from translatewiki.net.
Feb 1 2022, 20:20 · Phorge

Dec 5 2021

20after4 added a parent task for T15006: Re-brand Phorge: T15055: Import translations from translatewiki.net.
Dec 5 2021, 19:40 · Phorge
20after4 added a subtask for T15055: Import translations from translatewiki.net: T15006: Re-brand Phorge.
Dec 5 2021, 19:40 · Phorge
20after4 added a comment to T15055: Import translations from translatewiki.net.

Once the rebranding is complete we can send updated strings to translatewiki so that everything remains in sync.

Dec 5 2021, 19:39 · Phorge