Remove the reassign transaction from $results as we de-facto do not change the task owner: it was unset before and will be unset after, so there is no transaction to perform.
Closes T15164
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15164: Resolving without Claiming causes error "Action with no effect"
tbd - This is still WIP
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T15164 (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 951 Build 951: arc lint + arc unit
Event Timeline
Comment Actions
Thanks again for this proposed solution. I have now a big picture and I partially agree on the approach: the fix is there, in touching the manually-set claim action, but maybe we can just mute that "non-effective manual transaction" instead of dropping it. And anyway, we can maybe recycle some code about finding that transaction.
Edited: also it's maybe better to keep that $is_claim definition only in the inner case. That probably had sense for micro-optimization reasons.
I'm personally OK with this solution, premising that we can maybe review this instead that has the above suggestions (I was not able to express these using voice):
D25550: Avoid "Action with no effect" for auto-claim statuses after manually removing assignee