Page MenuHomePhorge

Improve contrast of Links in Dark Mode
AcceptedPublic

Authored by deric on Dec 6 2023, 16:30.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 19, 14:43
Unknown Object (File)
Mon, Feb 19, 04:28
Unknown Object (File)
Mon, Feb 19, 04:28
Unknown Object (File)
Mon, Feb 19, 04:28
Unknown Object (File)
Wed, Jan 31, 16:45
Unknown Object (File)
Wed, Jan 24, 10:20
Unknown Object (File)
Tue, Jan 23, 12:18
Unknown Object (File)
Jan 21 2024, 00:55

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15056: Improve Dark Mode
Summary

Use lighter color (higher contrast to dark background) in Links in Dark Mode.

BeforeAfter
Links Before.png (563×811 px, 103 KB)
Links After.png (563×811 px, 103 KB)

Explanation:

Screenshot_20231206_173817.png (492×627 px, 58 KB)

Ref T15056

Test Plan
  • Flush all Phorge caches
  • Sign in
  • Go to user's Settings > Display Preferences and select the Accessibility (user interface) "Dark Mode".
  • Check Dashboard links
  • Check People lists
  • Check Maniphest lists
  • Check Diffusion lists
  • Check Feeds, etc.

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25491
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 976
Build 976: arc lint + arc unit

Event Timeline

deric requested review of this revision.Dec 6 2023, 16:30
valerio.bozzolan retitled this revision from Links in dark theme have low contrast (T15056) to Improve contrast of Links in Dark Mode.Dec 6 2023, 19:33
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan edited the test plan for this revision. (Show Details)

Tested, thanks! no nuclear implosions and I like it. I also think that "accadf" is more readable than before :^) please wait some days before landing to eventually attract additional testers.

This revision is now accepted and ready to land.Dec 6 2023, 19:36

Hi deric,

To land this change, please try these:

arc patch D25491
arc land

Or use ../arcanist/bin/arc

Thanks

@deric: Hi, would you like to arc land your patch, or do you need any help? Thanks in advance!

@aklapper Yeah, that would be great. Sorry, I don't have a working dev instance right now.

Hello! Are you sure changing the links color is a good idea? Perhaps we should just make the background darker?