Page MenuHomePhorge

"arc browse <file>" does not support Subversion
Open, LowPublic

Description

It seems to me that arc browse does not support files in a Subversion repository.

Steps to reproduce:

Have a Subversion repository hosted in Phorge and have a file (example: README.md).

Have a similar .arcconfig:

.arcconfig
{
  "phabricator.uri" : "https://phorge.example.com/"
}

Run:

arc browse README.md

Your browser web will visit this HTTP 404 Page not found page:

https://phorge.example.com/browse/master/README.md

This should happen instead:

https://phorge.example.com/source/<repo>/browse/README.md

To me, we have two bugs:

  1. the repository is not recognized
  2. the branch should be omitted in a Subversion URL

About the point n. 2, this is a related TODO:

https://we.phorge.it/source/arcanist/browse/master/src/ref/ArcanistRepositoryRef.php;152ba1f02a31b7e48ed2923b611e66f951c9fdf0$95-96