"arc browse <file>" should support Subversion
Closed, ResolvedPublic
Actions

Description

It seems to me that arc browse does not support files in a Subversion repository.

Steps to reproduce:

Have a Subversion repository hosted in Phorge and have a file (example: README.md).

Have a similar .arcconfig:

.arcconfig

{
  "phabricator.uri" : "https://phorge.example.com/"
}

Run:

arc browse README.md

Your browser web will visit this HTTP 404 Page not found page:

https://phorge.example.com/browse/master/README.md

This should happen instead:

https://phorge.example.com/source/<repo>/browse/README.md

To me, we have two bugs:

the repository is not recognized
the branch should be omitted in a Subversion URL

About the point n. 2, this is a related TODO:

https://we.phorge.it/source/arcanist/browse/master/src/ref/ArcanistRepositoryRef.php;152ba1f02a31b7e48ed2923b611e66f951c9fdf0$95-96

Revisions and Commits

rARC Arcanist
	D25823	rARCc58c780b47ef arc browse: add support for Subversion repos

Related Objects

Mentioned In: Next Up
Wikimania Hackathon 2025 Istanbul
Z1: Phorge
D25339: Improve arc-browse for php 8.1

Event Timeline

valerio.bozzolan created this task.Jul 7 2023, 11:49

valerio.bozzolan triaged this task as Low priority.

valerio.bozzolan created this object in space S1 Public.

Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptJul 7 2023, 11:49

valerio.bozzolan updated the task description. (Show Details)Jul 7 2023, 11:49

valerio.bozzolan mentioned this in D25339: Improve arc-browse for php 8.1.

Hi @speck are you still a Mercurial user? Does arc browse <file> work for you? Just for my curiosity

valerio.bozzolan updated the task description. (Show Details)Jul 7 2023, 13:48

valerio.bozzolan mentioned this in Z1: Phorge.Nov 13 2023, 07:35

Since Subversion allows to checkout just a sub-directory,

Arcanist should probably query svn info to get that relative URL.

Example output, from one svn checkout ... from the /trunk sub-directory:

$ svn info
Path: .
Working Copy Root Path: /home/boz/example_repo
URL: svn+ssh://phorge@phorge.example.com/source/example_repo/trunk
Relative URL: ^/trunk
Repository Root: svn+ssh://phorge@phorge.example.com/source/example_repo
Repository UUID: stuff-stuff-stuff
Revision: 1854
Node Kind: directory
Schedule: normal
Last Changed Author: valerio.bozzolan
Last Changed Rev: 1854
Last Changed Date: 2024-02-27 19:01:57 +0100 (mar, 27 feb 2024)

Checking from the / directory instead:

$ svn info
Path: .
Working Copy Root Path: /home/boz/example_repo
URL: svn+ssh://phorge@phorge.example.com/source/example_repo
Relative URL: ^/
Repository Root: svn+ssh://phorge@phorge.example.com/source/example_repo
Repository UUID: stuff-stuff-stuff
Revision: 1854
Node Kind: directory
Schedule: normal
Last Changed Author: valerio.bozzolan
Last Changed Rev: 1854
Last Changed Date: 2024-02-27 19:01:57 +0100 (mar, 27 feb 2024)

So apparently we should parse the Relative URL and use that path to build the browse URI. Instead of just appending "master" that has no sense there.

valerio.bozzolan moved this task from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.May 2 2024, 18:31

valerio.bozzolan added a revision: D25823: arc browse: add support for Subversion repos.Sep 10 2024, 11:26

Uh!

valerio.bozzolan renamed this task from "arc browse <file>" does not support Subversion to "arc browse <file>" should support Subversion.Thu, May 1, 19:34

valerio.bozzolan added a project: Wikimedia Hackathon 2025.

valerio.bozzolan moved this task from Backlog to Plz Review 🥺 on the Wikimedia Hackathon 2025 board.

valerio.bozzolan added a project: Feature Requests.

valerio.bozzolan mentioned this in Wikimania Hackathon 2025 Istanbul.Sun, May 4, 11:49

valerio.bozzolan closed this task as Resolved by committing rARCc58c780b47ef: arc browse: add support for Subversion repos.Wed, May 14, 08:04

valerio.bozzolan added a commit: rARCc58c780b47ef: arc browse: add support for Subversion repos.

valerio.bozzolan mentioned this in Next Up.Wed, May 14, 08:08