Page MenuHomePhorge

Auth SSH Details: show Public Key (not just Type)
ClosedPublic

Authored by valerio.bozzolan on Dec 13 2023, 16:52.
Tags
None
Referenced Files
F2183644: D25495.id.diff
Wed, May 8, 11:42
F2182547: D25495.diff
Wed, May 8, 05:56
Unknown Object (File)
Thu, Apr 25, 22:19
Unknown Object (File)
Wed, Apr 24, 22:44
Unknown Object (File)
Wed, Apr 17, 18:18
Unknown Object (File)
Wed, Apr 17, 06:42
Unknown Object (File)
Tue, Apr 16, 21:50
Unknown Object (File)
Thu, Apr 11, 12:34

Details

Summary

At the moment the "SSH Key Details" page lists only two minimal information:

  • Key Type (Example: 'ssh-rsa')
  • Created (Example: 'Wed, Dec 13, 5:13 PM')

After this change it shows also the original Public Key. It becomes something like:

  • Public Key (Example: 'ssh-rsa AAAB3....... mariana@localhost')
  • Created (Example: 'Wed, Dec 13, 5:13 PM')

This is just a minimal UX change.
Note that you can already see the Public Key by clicking "Edit".
So, nothing new is shown.

Context:

Premising that Phorge encourages to Revoke your decommissioned / deprecated
/ compromised SSH keys with a very lovely "Revoke" Workflow...

Root problem:

If you Revoke one of your keys, and if you then want to double-check that
SSH Public Key again (if you want to see its original body), you then discover
that you cannot see it anymore. In fact, the only way is the Edit button, but
Editing is disabled for any Revoked Key. In this kind of situation, it's not
nice to have to involve your favorite database administrator, to inspect the
'phabricator_auth.auth_sshkey' database table, to just be able to see your SSH
Public Key again.

After this change, you can easily self-audit your Revoked SSH Public Keys,
and your beloved DBA has extra free time. Win-win situation.

Closes T15692

Test Plan
  • visit your SSH Keys, open one, and check the new Details with your big eyes
  • do the dame while juggling two ping pong balls (is anybody reading this?)
  • do the same on a Revoked key

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable