- User Since
- Aug 18 2023, 06:29 (5 w, 4 d)
Sun, Sep 24
Should I go ahead and submit a different patch? Or could I somehow contribute the edit to this patch?
Sat, Sep 23
Fri, Sep 22
For others reading this thread: there's some discussion going on in the thread of the patch linked above, D25419.
Note: the <ins> tag is typically rendered as underlined text, so this would be very similar to the <u> formatting that is produced with __foobar__ → foobar. In fact, it might be worth repurposing that rule to produce <ins> instead, since ~~foobar~~ actually creates a semantic <del> tag rather than the presentational equivalent <s> (strikethrough) tag.
Ugh. I added this to the UX project but forgot to remove the test content from the comment box, so my changes ended up coupled with a comment that said "- List Item". I tried to delete the comment but now it looks weird like some sort of redacted content :( anway, though I'd leave the note here in case anyone is confused with the deleted comment.
It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message. I was caught off-guard by this at least once. So perhaps the text entry box should be made single-line by default (as already happens if the screen is narrow enough) and expand as needed if line breaks are added.
@valerio.bozzolan I actually think the right place to look at the usage of getSpecialRules() might be here: https://we.phorge.it/source/phorge/browse/master/src/applications/policy/filter/PhabricatorPolicyFilter.php;4f845d8f8c77$693-719
By the way, is there a task or project about UI text improvements that this task could be made part of? I am looking e.g. at the button in this very comment box saying "Set Sail for Adventure", which, while amusing, is also prone to cause confusion.
How about something like "Endorse"? That might remove the connotations of speaking for the project position that something like "approve" or "accept" may imply.
Wed, Sep 20
Tested locally, works as advertised.
Thu, Aug 31
Wed, Aug 30
Yeah, that's nice! Though I'd replace the ! at the end with a :, and would remove the horizontal ruler (while keeping the new paragraph for the we.phorge.it link). This way it is clear that the last line is a continuation of the previous one; otherwise, it may not be immediately clear how one is supposed to "join the community".
I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions:
Tue, Aug 29
IMO the added text should be connected to the second sentence of the existing third paragraph, maybe as a separate paragraph. In fact I'd suggest re-grouping the paragraphs differently, to focus on a brief intro, info for users, and info for contributors. Perhaps something like this: