That's so weird! My instinct is of course to say that it should be completely unrelated to this patch since no CSS is touched in this one-line change... I have no idea how to debug this ☹️

Thanks for the note, Andre! I've went ahead and updated the revision as discussed above.

• Add spaces in HTML message builder instead of to each item text

Thanks both! I'll land this, then.

In D25485#14022, @speck wrote:

I was thinking we might want to better enable multi-line messages and remove the Enter = submit for both desktop and mobile (on mobile making a send button like most other chat apps).

In T15225#13714, @waldyrious wrote:

It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message.

• Remove extra <tt> in bulk job dialog

In D25473#13673, @valerio.bozzolan wrote:

So this is the only blocking Test that is failing:

Visit /maniphest/, shift+click on at least 1 Task, click on Bulk Edit Selected, Continue, see the popup

• Use dynamically generated platform path where possible

Btw, there are some similar commands in src/applications/config/check/PhabricatorManualActivitySetupCheck.php. Should I change them as well? How can I "break Phorge" to see this page rendered?

• Actually the path is not needed here.

• Fix missing arguments to hsprintf; re-add csprintf to string using the %R conversion

• Improve prompts: use hsprintf instead of cprintf, add missing <tt> markers, simplify syntax

For future reference, I went digging for the difference between csprintf() and hsprintf(), and found the following:

• Fix double prompt marker

Nice catches, @valerio.bozzolan — will fix.

• Wrap long line

• Rephrase Next Steps entry

I am not sure about all these changes. In particular, the changes in PhabricatorSetupIssueUIExample.php and PhabricatorSetupIssueView.php probably warrant extra scrutiny.

• Update the resources map

the prefix was added to have arcanist/phorge indication. So, if we use just $ it's better to remove it.

• Adjust message per code review suggestion

Revert indentation changes

Should I go ahead and submit a different patch? Or could I somehow contribute the edit to this patch?

In D25419#12602, @avivey wrote:

The value of moreInfo here is a list (array) of 3 things, (https://we.phorge.it/source/phorge/browse/master/src/applications/policy/filter/PhabricatorPolicyFilter.php;4f845d8f8c77$702) - $head, $more and $exceptions, and I'm guessing from context that the appendList() creates one <ul> for the list and one <li> for each item in the list - so $exceptions at this point is a single thing.

For others reading this thread: there's some discussion going on in the thread of the patch linked above, D25419.

Note: the <ins> tag is typically rendered as underlined text, so this would be very similar to the <u> formatting that is produced with __foobar__ → foobar. In fact, it might be worth repurposing that rule to produce <ins> instead, since ~~foobar~~ actually creates a semantic <del> tag rather than the presentational equivalent <s> (strikethrough) tag.

Ugh. I added this to the UX project but forgot to remove the test content from the comment box, so my changes ended up coupled with a comment that said "- List Item". I tried to delete the comment but now it looks weird like some sort of redacted content :( anway, though I'd leave the note here in case anyone is confused with the deleted comment.

It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message. I was caught off-guard by this at least once. So perhaps the text entry box should be made single-line by default (as already happens if the screen is narrow enough) and expand as needed if line breaks are added.

@valerio.bozzolan I actually think the right place to look at the usage of getSpecialRules() might be here: https://we.phorge.it/source/phorge/browse/master/src/applications/policy/filter/PhabricatorPolicyFilter.php;4f845d8f8c77$693-719

By the way, is there a task or project about UI text improvements that this task could be made part of? I am looking e.g. at the button in this very comment box saying "Set Sail for Adventure", which, while amusing, is also prone to cause confusion.

How about something like "Endorse"? That might remove the connotations of speaking for the project position that something like "approve" or "accept" may imply.

Tested locally, works as advertised.

LGTM! :D

Yeah, that's nice! Though I'd replace the ! at the end with a :, and would remove the horizontal ruler (while keeping the new paragraph for the we.phorge.it link). This way it is clear that the last line is a continuation of the previous one; otherwise, it may not be immediately clear how one is supposed to "join the community".

In D25425#12230, @valerio.bozzolan wrote:

maybe in the future we can have a CSS selector to be applied just to the "phorge/" pathname, in order to avoid mouse selection, and select just the command.

In D25426#12221, @avivey wrote:

See D25420 for a conflicting change...

I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions: