Page MenuHomePhorge

waldyrious (Waldir Pimenta)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 18 2023, 06:29 (5 w, 4 d)
Availability
Available

Recent Activity

Sun, Sep 24

waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

Should I go ahead and submit a different patch? Or could I somehow contribute the edit to this patch?

Sun, Sep 24, 09:14
waldyrious updated the title for P23 xhpast error from xhpast error (two commands and their output) to xhpast error.
Sun, Sep 24, 09:11
waldyrious created P23 xhpast error.
Sun, Sep 24, 09:08

Sat, Sep 23

waldyrious added inline comments to D25425: Remove mention of Phabricator in the Auth setup check.
Sat, Sep 23, 14:29
waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

The value of moreInfo here is a list (array) of 3 things, (https://we.phorge.it/source/phorge/browse/master/src/applications/policy/filter/PhabricatorPolicyFilter.php;4f845d8f8c77$702) - $head, $more and $exceptions, and I'm guessing from context that the appendList() creates one <ul> for the list and one <li> for each item in the list - so $exceptions at this point is a single thing.

Sat, Sep 23, 13:56

Fri, Sep 22

waldyrious added a comment to T15270: "Access Denied: Restricted File" strings concatenated without whitespace.

For others reading this thread: there's some discussion going on in the thread of the patch linked above, D25419.

Fri, Sep 22, 22:26 · Good Starter Task, Files
waldyrious updated the task description for T15644: Support backticks in inline and block code by wrapping with multiple backticks.
Fri, Sep 22, 22:22 · Feature Requests, Remarkup
waldyrious created T15644: Support backticks in inline and block code by wrapping with multiple backticks.
Fri, Sep 22, 22:17 · Feature Requests, Remarkup
waldyrious added a comment to T15643: Support marking text with <ins> in Remarkup.

Note: the <ins> tag is typically rendered as underlined text, so this would be very similar to the <u> formatting that is produced with __foobar__foobar. In fact, it might be worth repurposing that rule to produce <ins> instead, since ~~foobar~~ actually creates a semantic <del> tag rather than the presentational equivalent <s> (strikethrough) tag.

Fri, Sep 22, 21:58 · Feature Requests, Remarkup
waldyrious created T15643: Support marking text with <ins> in Remarkup.
Fri, Sep 22, 21:47 · Feature Requests, Remarkup
waldyrious added a comment to T15245: Continue bulleted/numbered list during new line.

Ugh. I added this to the UX project but forgot to remove the test content from the comment box, so my changes ended up coupled with a comment that said "- List Item". I tried to delete the comment but now it looks weird like some sort of redacted content :( anway, though I'd leave the note here in case anyone is confused with the deleted comment.

Fri, Sep 22, 21:36 · UX, Feature Requests, Remarkup
waldyrious added a project to T15245: Continue bulleted/numbered list during new line: UX.
Fri, Sep 22, 21:34 · UX, Feature Requests, Remarkup
waldyrious awarded T15245: Continue bulleted/numbered list during new line a Like token.
Fri, Sep 22, 21:33 · UX, Feature Requests, Remarkup
waldyrious added a comment to T15225: Conpherence: add a dedicated "Send" button (not just the Enter key).

It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message. I was caught off-guard by this at least once. So perhaps the text entry box should be made single-line by default (as already happens if the screen is narrow enough) and expand as needed if line breaks are added.

Fri, Sep 22, 21:29 · Conpherence, Mobile, User-valerio.bozzolan, UX
waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

@valerio.bozzolan I actually think the right place to look at the usage of getSpecialRules() might be here: https://we.phorge.it/source/phorge/browse/master/src/applications/policy/filter/PhabricatorPolicyFilter.php;4f845d8f8c77$693-719

Fri, Sep 22, 21:25
waldyrious awarded T15270: "Access Denied: Restricted File" strings concatenated without whitespace a Like token.
Fri, Sep 22, 20:38 · Good Starter Task, Files
waldyrious added a watcher for GitHub: waldyrious.
Fri, Sep 22, 20:37
waldyrious awarded T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge a Like token.
Fri, Sep 22, 20:35 · Affects-Wikimedia
waldyrious added a watcher for Affects-Wikimedia: waldyrious.
Fri, Sep 22, 20:34
waldyrious added a comment to T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".

By the way, is there a task or project about UI text improvements that this task could be made part of? I am looking e.g. at the button in this very comment box saying "Set Sail for Adventure", which, while amusing, is also prone to cause confusion.

Fri, Sep 22, 20:30 · UX, Differential
waldyrious added a comment to T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".

How about something like "Endorse"? That might remove the connotations of speaking for the project position that something like "approve" or "accept" may imply.

Fri, Sep 22, 20:28 · UX, Differential
waldyrious awarded T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land" a Like token.
Fri, Sep 22, 20:23 · UX, Differential

Wed, Sep 20

waldyrious accepted D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

Tested locally, works as advertised.

Wed, Sep 20, 11:32

Thu, Aug 31

waldyrious accepted D25413: Show a link to the Phorge homepage.

LGTM! :D

Thu, Aug 31, 20:32

Wed, Aug 30

waldyrious added a comment to D25413: Show a link to the Phorge homepage.

Yeah, that's nice! Though I'd replace the ! at the end with a :, and would remove the horizontal ruler (while keeping the new paragraph for the we.phorge.it link). This way it is clear that the last line is a continuation of the previous one; otherwise, it may not be immediately clear how one is supposed to "join the community".

Wed, Aug 30, 18:46
waldyrious added a comment to D25425: Remove mention of Phabricator in the Auth setup check.

maybe in the future we can have a CSS selector to be applied just to the "phorge/" pathname, in order to avoid mouse selection, and select just the command.

Wed, Aug 30, 18:38
waldyrious abandoned D25426: Fix label of submit button in timezone conflict dialog.

See D25420 for a conflicting change...

Wed, Aug 30, 18:32
waldyrious added a comment to D25420: Improving UX for ignoring timezone conflicts.

I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions:

Wed, Aug 30, 18:27

Tue, Aug 29

waldyrious removed a reviewer for D25425: Remove mention of Phabricator in the Auth setup check: Blessed Committers.
Tue, Aug 29, 21:33
waldyrious updated the summary of D25426: Fix label of submit button in timezone conflict dialog.
Tue, Aug 29, 21:32
waldyrious requested review of D25426: Fix label of submit button in timezone conflict dialog.
Tue, Aug 29, 21:32
waldyrious requested review of D25425: Remove mention of Phabricator in the Auth setup check.
Tue, Aug 29, 21:18
waldyrious added a comment to D25413: Show a link to the Phorge homepage.

IMO the added text should be connected to the second sentence of the existing third paragraph, maybe as a separate paragraph. In fact I'd suggest re-grouping the paragraphs differently, to focus on a brief intro, info for users, and info for contributors. Perhaps something like this:

Tue, Aug 29, 18:43

Aug 18 2023

waldyrious changed the visibility for F336320: Screenshot from 2023-08-18 16-05-43.png.
Aug 18 2023, 08:10
waldyrious closed T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2, as Resolved.
Aug 18 2023, 07:50 · PHP 8 support
waldyrious closed T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally as Resolved.

Oops, sorry, I was not on master. I was actually testing out D25079. This is already fixed on master, by @valerio.bozzolan.

Aug 18 2023, 07:50 · PHP 8 support
valerio.bozzolan awarded T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally a Cup of Joe token.
Aug 18 2023, 07:44 · PHP 8 support
waldyrious created T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally.
Aug 18 2023, 07:44 · PHP 8 support