Page MenuHomePhorge

Improve Dark Mode
Open, NormalPublic

Description

dark mode is rather... hard to see to say the least. Some things are out right impossible to see without 1000/100 vision.


Issues:

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Nice

Please put all the screenshots in the description with related checkboxes like

  • Fix this:

IMAGE

  • Fix that:

IMAGE

So that it's somehow possible to track changes here

Bukkit updated the task description. (Show Details)
Bukkit updated the task description. (Show Details)

Do you want to try to work on this?

If not, maybe in a couple of weeks I can find some spare time

I'll see if I could get to it. Pretty new to this project, so if you could point some fingers to where I can find the dark mode stuff, it would be greatly appreciated. :)

Not quite as bad (it's at least semi-readable) but still fails accessibility guidelines: F281242

I noticed that, when you pick the "Dark Mode" theme, the CSS class phui-theme-blindigo is added to the documents.

The usage seems in this file:

$ grep -R 'phui-theme-blindigo' --include="*.css"
webroot/rsrc/css/application/base/phui-theme.css

https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/application/base/phui-theme.css

At the moment it just contains 6 CSS rules so I see a wide margin of contribution!

Keep us updated if you make attempts

To be honest you can just try to use the Firefox console and patch the stylesheet on the fly, and then share your rules here (with a description for each rule please). Kind of:

/* Dark Mode: wow bar was unreadable, now darker */
.phui-theme-blindigo .phabricator-main-menu-wow {
   background: 123;
}

etc.

Thanks, really helpful! I'll try to work on it

Here is pretty complete list of dark mode fails from the creator himself: https://secure.phabricator.com/T13540

(And I've added the images in the task description for real - just as a better reference)

Cigaryno raised the priority of this task from Low to Normal.Jun 29 2023, 07:15
Cigaryno added a project: Accessibility.

The evidence that there are unfinished areas in dark mode is in its option, the option reads: Dark Mode (Expirimental). Users may opt into this 'expirimental' dark mode without realizing that there are unreadable areas until they go depper in the sea.

"experimental" means "not really working yet"... When it's fully usable, the "Experimental" label can be removed.

Yeah but I think the "Normal" priority is better than "Low" since we are hackers hating white screens and so that is quite important ihih

Does somebody want to work on this? Maybe in the next week-end I can try to hammer some CSS rules, thanks to the provided feedback :)

Also, I apologize for not completing this, hadn't had much spare time until recently. I will work on this soon.

Hi, I can also see this one that looks weird in big pannels available on dashboards

screenshot-phorge-bug-darkmode-pannel.png (90ร—842 px, 5 KB)

In workboard, empty column's drop zone is a little bit 'agressive' isn't it ?

screenshot-phorge-bug-darkmode-workboard.png (233ร—622 px, 12 KB)

Yeah bob, feel free to add your nice screenshots in the Task description for more visibility. You are a good minion!

Bukkit updated the task description. (Show Details)

I'll do it next time, I always do my best to serve my master !

In workboard, when maniphest's edit button style is broken on mouse over.

screenshot-phorge-bug-darkmode-workboard-maniphest-edit.png (135ร—314 px, 8 KB)

bob updated the task description. (Show Details)

In workboard, when a maniphest's is drag and dropped, available triggers information windows is broken.

screenshot-phorge-bug-darkmode-workboard-dnd-trigger-hint.png (103ร—325 px, 2 KB)

Concerning the dashbord's big pannel :

screenshot-phorge-bug-darkmode-pannel.png (90ร—842 px, 5 KB)

We can imagine several options as illustrated below :

screenshot-phorge-bug-darkmode-workboard-options.png (210ร—1 px, 17 KB)

  • Option 1 : Keep a gradient that looks like more/less what is currently implemented
--- a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+++ b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
@@ -723,7 +723,11 @@ ul.phui-oi-list-view .phui-oi-selectable
 .phui-oi-tail {
   text-align: center;
   padding: 8px 0;
-  background: linear-gradient({$lightbluebackground}, #fff 66%, #fff);
+  background: linear-gradient({$lightbluebackground}, transparent 66%, transparent);
 }
  • Option 2 : Invert the gradient
--- a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+++ b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
@@ -723,7 +723,11 @@ ul.phui-oi-list-view .phui-oi-selectable
 .phui-oi-tail {
   text-align: center;
   padding: 8px 0;
-  background: linear-gradient({$lightbluebackground}, #fff 66%, #fff);
+  background: linear-gradient(transparent, {$lightbluebackground});
 }
  • Option 3 : Remove the gradient
--- a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+++ b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
@@ -723,7 +723,11 @@ ul.phui-oi-list-view .phui-oi-selectable
 .phui-oi-tail {
   text-align: center;
   padding: 8px 0;
-  background: linear-gradient({$lightbluebackground}, #fff 66%, #fff);
 }

IMHO, this gradient is not bringing anything there in term of UX since the button is clearly visible whatever the case. That's why so I would vote for option 3 but what's your opinion about that ?

Another on when displaying a maniphest with a lot of comments :

screenshot-phorge-bug-darkmode-maniphest-comments-hidden.png (57ร—1 px, 6 KB)

Because there are more and more referenced issues and, because some of them may need further discussion in order to find the best solution, IMHO it may be a good idea to create a sub task for each issue reported isn't it ?

When an fatal exception is triggered :

screenshot-phorge-bug-darkmode-exception.png (172ร—1 px, 12 KB)