Interesting notes:

https://userstyles.org/styles/180475/phabricator-dark-mode-fixes

Here is pretty complete list of dark mode fails from the creator himself: https://secure.phabricator.com/T13540

(And I've added the images in the task description for real - just as a better reference)

"experimental" means "not really working yet"... When it's fully usable, the "Experimental" label can be removed.

Yeah but I think the "Normal" priority is better than "Low" since we are hackers hating white screens and so that is quite important ihih

Does somebody want to work on this? Maybe in the next week-end I can try to hammer some CSS rules, thanks to the provided feedback :)

I don't see file F281219

Hi @Bukkit can you please publish F281219? thanks :)

Done.

Also, I apologize for not completing this, hadn't had much spare time until recently. I will work on this soon.

Hi, I can also see this one that looks weird in big pannels available on dashboards

In workboard, empty column's drop zone is a little bit 'agressive' isn't it ?

Yeah bob, feel free to add your nice screenshots in the Task description for more visibility. You are a good minion!

I'll do it next time, I always do my best to serve my master !

In workboard, when maniphest's edit button style is broken on mouse over.

In workboard, when a maniphest's is drag and dropped, available triggers information windows is broken.

Concerning the dashbord's big pannel :

We can imagine several options as illustrated below :

• Option 1 : Keep a gradient that looks like more/less what is currently implemented

--- a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+++ b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
@@ -723,7 +723,11 @@ ul.phui-oi-list-view .phui-oi-selectable
 .phui-oi-tail {
   text-align: center;
   padding: 8px 0;
-  background: linear-gradient({$lightbluebackground}, #fff 66%, #fff);
+  background: linear-gradient({$lightbluebackground}, transparent 66%, transparent);
 }

• Option 2 : Invert the gradient

--- a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+++ b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
@@ -723,7 +723,11 @@ ul.phui-oi-list-view .phui-oi-selectable
 .phui-oi-tail {
   text-align: center;
   padding: 8px 0;
-  background: linear-gradient({$lightbluebackground}, #fff 66%, #fff);
+  background: linear-gradient(transparent, {$lightbluebackground});
 }

• Option 3 : Remove the gradient

--- a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+++ b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
@@ -723,7 +723,11 @@ ul.phui-oi-list-view .phui-oi-selectable
 .phui-oi-tail {
   text-align: center;
   padding: 8px 0;
-  background: linear-gradient({$lightbluebackground}, #fff 66%, #fff);
 }

IMHO, this gradient is not bringing anything there in term of UX since the button is clearly visible whatever the case. That's why so I would vote for option 3 but what's your opinion about that ?

Another on when displaying a maniphest with a lot of comments :

Because there are more and more referenced issues and, because some of them may need further discussion in order to find the best solution, IMHO it may be a good idea to create a sub task for each issue reported isn't it ?

When an fatal exception is triggered :

In T15056#3210, @golyalpha wrote:

Another example of broken dark theme

I can't reproduce it, it seems to be fixed.

T391929 In that task on Wikimedia Phabricator, I had put some issues

Steps to reproduce the bug:

• Enable the "Dark Mode (Experimental)" theme in Wikimedia Phabricator.
• Go to the Phabricator Workboard.
• Click on any button that has a dropdown menu.

And with these steps you can see the error like the images I have attached

In T15056#21737, @danielyepezgarces wrote:

@danielyepezgarces: Please always provide clear steps to reproduce something somewhere, in most recent Phorge itself.

In T15056#21750, @aklapper wrote:

In T15056#21737, @danielyepezgarces wrote:

@danielyepezgarces: Please always provide clear steps to reproduce something somewhere, in most recent Phorge itself.

Done, I've modified my comment

In T15056#21737, @danielyepezgarces wrote:

T391929 In that task on Wikimedia Phabricator, I had put some issues

Steps to reproduce the bug:

• Enable the "Dark Mode (Experimental)" theme in Wikimedia Phabricator.
• Go to the Phabricator Workboard.
• Click on any button that has a dropdown menu.

And with these steps you can see the error like the images I have attached

I just checked that the issue can be replicated in the Accessibility workboard, on the Affects-Wikimedia workboard it looks good

If there is an issue in Phorge then please provide steps to reproduce in Phorge. Please also strip unneeded full quotes which make comments hard to read. Thanks!

Ok, I'll improve it, because I still have a lot to learn about Phorge and its source code, otherwise I'll fix those issues myself