Page MenuHomePhorge

isSelfURI: fix anchors and relative URIs (that are "self" indeed)
ClosedPublic

Authored by valerio.bozzolan on Mar 9 2024, 22:30.
Tags
None
Referenced Files
F2199089: D25555.1716450314.diff
Wed, May 22, 07:45
Unknown Object (File)
Mon, May 20, 18:14
Unknown Object (File)
Mon, May 20, 17:27
Unknown Object (File)
Mon, May 20, 08:12
Unknown Object (File)
Mon, May 20, 05:52
Unknown Object (File)
Thu, May 9, 13:56
Unknown Object (File)
Sun, May 5, 23:30
Unknown Object (File)
Sun, May 5, 01:57

Details

Summary

Example cases that were wrongly considered external URLs:

  • "#foo"
  • "/foo"

Note that Phorge usually does not change stable things. In fact this thing
was not documented even inline, and was not even in the unit tests.

So this is a fix, and not a breaking change. Probably no one had ever tried it.

Closes T15182

Test Plan

The already existing unit tests still work.

The added ones make sense.

There are no problems doing other random things.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable