bin/celerity syntax
bin/celerity map
bin/cache purge --all
sign in
go to user's Settings > Display Preferences and select the Accessibility (user interface) "Dark Mode".
go to Phriction or Maniphest and add a codeblock.

Example:

<?php
final class Example extends PhabricatorApplication {
}

verify that codeblock content is readable
also check that with/without this, nothing changes in "normal" theme

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mturdus created this revision.Jan 9 2024, 21:56

Owners added a reviewer: O1: Blessed Committers.Jan 9 2024, 21:56

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJan 9 2024, 21:56

mturdus requested review of this revision.Jan 9 2024, 21:56

Harbormaster completed remote builds in B1007: Diff 1617.Jan 9 2024, 21:56

Can someone explain what these "Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'" messages mean ?
Are these automated unit tests run on we.phorge.it or on my system ?

Run arc diff from my computer that has Xdebug enabled

Harbormaster completed remote builds in B1008: Diff 1618.Jan 10 2024, 20:54

valerio.bozzolan awarded a token.Jan 10 2024, 20:54

I sincerely think this is lovely. Thanks. I do not understand how you figure it out all these keywords and in what order and associated to what, but hey, it works.

sgtm

This revision is now accepted and ready to land.Jan 12 2024, 09:55

I copy/pasted the keys of the getStyleMap() function dictionary into chatgpt with some remark that they were part of a syntax highlighting mechanism.
I asked it to translate them into something more readable.

I thought this was already in the repo, but I forgot to execute arc land... (sorry)
I bump into a 403 error when I execute it now.
I had one merge conflict in resources/celerity/map.php which I corrected manually.

These are the commands I executed and their output:

gj@blackbird:/var/www/htdocs/phorge/phorge$ ###################################################################################################
gj@blackbird:/var/www/htdocs/phorge/phorge$ git status
interactive rebase in progress; onto bf15a2d98c
Last command done (1 command done):
pick 8253e10648 Fix remarkup codeblock syntax highlighting when using Dark Mode
No commands remaining.
You are currently rebasing branch 'master' on 'bf15a2d98c'.
(all conflicts fixed: run "git rebase --continue")

Changes to be committed:
(use "git restore --staged <file>..." to unstage)
modified: resources/celerity/map.php
modified: src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php
modified: src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php
modified: src/infrastructure/syntax/PhabricatorDefaultSyntaxStyle.php
modified: webroot/rsrc/css/syntax/syntax-default.css

gj@blackbird:/var/www/htdocs/phorge/phorge$ ###################################################################################################
gj@blackbird:/var/www/htdocs/phorge/phorge$ git rebase --continue
[detached HEAD 5719d1e24b] Fix remarkup codeblock syntax highlighting when using Dark Mode
5 files changed, 350 insertions(+), 130 deletions(-)
Successfully rebased and updated refs/heads/master.
gj@blackbird:/var/www/htdocs/phorge/phorge$ git status
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
(use "git push" to publish your local commits)

nothing to commit, working tree clean
gj@blackbird:/var/www/htdocs/phorge/phorge$ ###################################################################################################
gj@blackbird:/var/www/htdocs/phorge/phorge$ ../arcanist/bin/arc land
STRATEGY Merging with "squash" strategy, the default strategy.
SOURCE Landing the current branch, "master".
ONTO REMOTE Remote "origin" was selected by following tracking branches upstream to the closest remote.
ONTO TARGET Landing onto target "master", selected by following tracking branches upstream to the closest remote branch.
INTO REMOTE Will merge into remote "origin" by default, because this is the remote the change is landing onto.
INTO TARGET Will merge into target "master" by default, because this is the "onto" target.
FETCH Fetching "master" from remote "origin"...

$ git fetch --no-tags --quiet -- origin master

INTO COMMIT Preparing merge into "master" from remote "origin", at commit "bf15a2d98ca3".
LANDING These changes will land:

* D25509 Improve remarkup codeblock syntax highlighting when using Dark Mode
5719d1e24bc1 Fix remarkup codeblock syntax highlighting when using Dark Mode

>>> Land these changes? [y/N/?] y
MERGING 5719d1e24bc1 Fix remarkup codeblock syntax highlighting when using Dark Mode
MERGE Attempting to rebase changes.
DONE Merge succeeded.
PUSHING Pushing changes to "origin".

$ git push -- origin 775e7fd2324d:refs/heads/master

fatal: unable to access 'https://we.phorge.it/source/phorge.git/': The requested URL returned error: 403

LOAD STATE Restoring local state (to ref "master" at commit "5719d1e24bc1").
USAGE EXCEPTION Push failed! Fix the error and run "arc land" again.
gj@blackbird:/var/www/htdocs/phorge/phorge$ git status
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
(use "git push" to publish your local commits)

nothing to commit, working tree clean

What should I do here ?

I suggest to visit here:

https://we.phorge.it/source/phorge/

Click on clone, and click on the Manage icon to set your HTTPs credentials.

(I originally cloned via SSH and I've uploaded my SSH hey, using the same menu nearby ssh://git)

Closed by commit rP892f527b9f63: Improve remarkup codeblock syntax highlighting when using Dark Mode. · Explain WhyMar 3 2024, 14:54

This revision was automatically updated to reflect the committed changes.

mturdus added a commit: rP892f527b9f63: Improve remarkup codeblock syntax highlighting when using Dark Mode.

Mission accomplished.
Thanks

valerio.bozzolan mentioned this in Next Up.Mar 18 2024, 07:19