Please rebase and resubmit, there is a merge conflict.

This does not land cleanly, please merge from master and re-submit.

In D25060#1987, @valerio.bozzolan wrote:

Hi @Matthew I think I cannot run arc land since I'm not in Blessed Committers

Well, I did ask for this to be converted into a revision, so I'm OK getting added as a reviewer. Sorry for the delay, I've been on vacation.

In T15105#3252, @tiguchi wrote:

In T15105#3239, @Matthew wrote:

In T15105#3233, @tiguchi wrote:

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

I just submitted a patch and ran into issues with running unit tests. It seems like the tests expect me to set up a MySQL database. I submitted the patch with arc diff --nounit if that's OK with you

In T15105#3233, @tiguchi wrote:

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

I think this should be done in two parts:

LGTM

I'm unable to reproduce this issue, after trying on multiple installs. I'm going to release this for someone else to take a try.

Looks good on my Mac. Screenshots attached.

release_process has been updated.

@Leon95 I encountered a merge conflict when attempting to land these changes. Could you please take a look and try to fix and land them yourself? If you need help, feel free to ping me.

Thank you for your work on this, Dan!

@golyalpha Are you still having this issue?

Boldly closing, as L1 exists and is available to sign.

Claiming this. Now that I've done this, I will take the time to document then I will close this task.

Follow-on task filed as T15120.

In T15117#2892, @jupe wrote:

Happy to create empty pages (I somehow feel that a wiki page with a fat TODO might be marginally better than a 404 :))

In T15026#2812, @jeremy.norris wrote:

FYI, the guide for migration doesn't seem to work quite smoothly for folks that were tracking the stable branch for Phabricator, because the new stable branch in Phorge does not have a linear changeset history to the old stable branch in Phabricator: if you follow the directions, you end up with a locally divergent stable branch that will contain a local merge commit.
Is there a reason the stable branch in Phorge wasn't created based upon the changeset history of the stable branch in Phabricator, in order to avoid this from happening?

Also, on a separate note, the changes from T15019 cause a conflict when issuing the git pull command:

error: The following untracked working tree files would be overwritten by merge:
	support/aphlict/server/package-lock.json
	support/aphlict/server/package.json
Please move or remove them before you merge.
Aborting

Should some notes be added to the migration guide on how to best deal with this as well?

In T15046#2762, @jeremy.norris wrote:

In T15046#2761, @jeremy.norris wrote:

It appears there are not any public repositories yet, is this intentional?

Actually, what is the correct Github organization? In the description for this task, the link is to (which is where I initially looked and saw no public repositories):

https://github.com/phorgelabs

But then in the comments above, the link is to (which does appear to have public repositories that are empty?):

https://github.com/phorgeit

In T15046#2788, @MacFan4000 wrote:

@avivey I see that the repos currently access GitHub anonymously. For auto mirror to work you need to configure a valid credential. By this I mean you need to create a username/password passphrase credential with creds for a GitHub account that has write access to the GitHub repos, and set it in the diffusion uris.

As @avivey mentioned, the GitHub organization is set up. Both Aviv and I have access, and I am willing to add other people in the core team.

If you view a book, then view source and search for PHID-BOOK then you should find a policy link. That's the PHID of the book you're viewing.

In T15012#2678, @avivey wrote:

I've re-generated the docs, and now we have two copies:

so:

1. need to delete the old ones, I didn't find a straight-forward way to do that
2. maybe do some http redirect from the old links to the new ones.

We do have a security task creation form and a separate space that roots have access to. See S2

For the record, I am against this change.

I'll see if I can reproduce this error.

LGTM

Per discussion during {E9}

New certificate issued.

https://we.phorge.it/phame/blog/view/3/ - Security Announcements
https://we.phorge.it/phame/blog/view/4/ - Release Announcements

@20after4 Hey, this does not appear to be working. T15101 was created by a user who was not a member of Trusted Contributors

Please do not triage tasks yourself, we will integrate it into the roadmap as we go.

@speck What is the status of this change?

@avivey has fixed this on the upstream install.