Page MenuHomePhorge

mturdus (Merula Turdus)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
May 28 2023, 17:44 (58 w, 5 d)
Availability
Available

Recent Activity

Today

mturdus committed R5:f1a92c669931: Remarkup documentation added.
Remarkup documentation added
Sat, Jul 13, 07:15
mturdus committed R5:41270a2e9664: Remarkup documentation added.
Remarkup documentation added
Sat, Jul 13, 07:08

Sat, Jul 6

mturdus updated the task description for T15056: Improve Dark Mode.
Sat, Jul 6, 15:28 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
mturdus requested review of D25724: Fix Dark Mode theme color issues in several places.
Sat, Jul 6, 15:26
mturdus added a revision to T15056: Improve Dark Mode: D25724: Fix Dark Mode theme color issues in several places.
Sat, Jul 6, 15:26 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit

Fri, Jul 5

mturdus closed D25709: Fix missing file attachment in Conpherence.
Fri, Jul 5, 16:20
mturdus committed rP136091ecd097: Fix missing file attachment in Conpherence.
Fix missing file attachment in Conpherence
Fri, Jul 5, 16:20
mturdus updated the diff for D25709: Fix missing file attachment in Conpherence.

Update after comments

Fri, Jul 5, 15:54

Mon, Jul 1

valerio.bozzolan awarded D25705: Fix missing file attachment in Phriction a Mountain of Wealth token.
Mon, Jul 1, 17:46
mturdus updated the diff for D25709: Fix missing file attachment in Conpherence.

Updates after comments

Mon, Jul 1, 17:28
mturdus updated the diff for D25709: Fix missing file attachment in Conpherence.

Updates after comments

Mon, Jul 1, 17:19
mturdus added a comment to D25705: Fix missing file attachment in Phriction.

Thanks

Mon, Jul 1, 16:43
mturdus closed D25705: Fix missing file attachment in Phriction.
Mon, Jul 1, 16:41
mturdus committed rP118f989366a0: Fix missing file attachment in Phriction (authored by valerio.bozzolan).
Fix missing file attachment in Phriction
Mon, Jul 1, 16:41
mturdus added a comment to D25709: Fix missing file attachment in Conpherence.

P.S. Why does Phriction have the field text_metadata? And why does Conpherence have content_metadata? 🤔

Mon, Jul 1, 16:37
mturdus added a comment to D25705: Fix missing file attachment in Phriction.

OK try this to restore your desired situation (so, two diffs)

git stash save

git checkout -b just_phriction
git reset --hard origin/master
arc patch --nobranch --diff 2173
arc diff --update D25705

git checkout -b just_conpherence
git reset --hard origin/master
arc patch --nobranch --diff 2178
arc diff --create

Then you have this benefit that you can repeat as many times you want:

git checkout just_phriction
LOL DO CHANGES
arc diff

git checkout just_conpherence
LOL DO CHANGES
arc diff

Or, get fresh master again:

git checkout master

Ideally, the default assumes that people do not touch master but work in branches, each branch a different feature

Mon, Jul 1, 16:27

Sun, Jun 30

mturdus added a comment to D25705: Fix missing file attachment in Phriction.

(Do you need a little help to split the changes in two diffs?)

Sun, Jun 30, 17:50
mturdus retitled D25705: Fix missing file attachment in Phriction from Fix file attachment in Phriction to Fix file attachment in Phriction and Conpherence.
Sun, Jun 30, 17:46
mturdus updated the diff for D25705: Fix missing file attachment in Phriction.

Updates after comments

Sun, Jun 30, 17:44
mturdus updated the diff for D25705: Fix missing file attachment in Phriction.

Fix file attachment in Conpherence

Sun, Jun 30, 17:07
mturdus updated the diff for D25705: Fix missing file attachment in Phriction.

Update after comments

Sun, Jun 30, 13:29
mturdus updated the diff for D25705: Fix missing file attachment in Phriction.

Updates after comments

Sun, Jun 30, 13:27
mturdus added inline comments to D25705: Fix missing file attachment in Phriction.
Sun, Jun 30, 12:43
mturdus updated the diff for D25705: Fix missing file attachment in Phriction.

Updates after comments

Sun, Jun 30, 12:38

Sat, Jun 29

mturdus closed Q140: Drag and drop: view policies as resolved.
Sat, Jun 29, 18:12
mturdus requested review of D25705: Fix missing file attachment in Phriction.
Sat, Jun 29, 18:11
mturdus added a revision to T15106: "Upload file" in remarkup text fields should attach by default : D25705: Fix missing file attachment in Phriction.
Sat, Jun 29, 18:11 · Files, Remarkup

Fri, Jun 28

mturdus added a comment to Q140: Drag and drop: view policies (Answer 174).

it works indeed for editing Maniphest tasks but not for Phriction documents.
I have been analyzing this "attach code" but it's too complex for me.
It seems that the content_metadata (with the attachedFilePHIDs) is correctly sent by the javascript, but it's not processed in the PHP, which makes it not attach the file object to the wiki page.

Fri, Jun 28, 19:14
mturdus asked Q140: Drag and drop: view policies.
Fri, Jun 28, 05:45

Wed, Jun 26

mturdus closed D25698: Make the Remarkup Help Page Extensible.
Wed, Jun 26, 20:11
mturdus closed T15401: Make the Remarkup Help Page Extensible as Resolved by committing rPf52bc073216e: Make the Remarkup Help Page Extensible.
Wed, Jun 26, 20:11 · Documentation, Remarkup
mturdus committed rPf52bc073216e: Make the Remarkup Help Page Extensible.
Make the Remarkup Help Page Extensible
Wed, Jun 26, 20:11
mturdus updated the diff for D25698: Make the Remarkup Help Page Extensible.

Make the Remarkup Help Page Extensible

Wed, Jun 26, 14:41
mturdus updated the diff for D25698: Make the Remarkup Help Page Extensible.

Make the Remarkup Help Page Extensible

Wed, Jun 26, 05:11

Tue, Jun 25

mturdus updated the diff for D25698: Make the Remarkup Help Page Extensible.

Make the Remarkup Help Page Extensible

Tue, Jun 25, 20:07
valerio.bozzolan awarded D25698: Make the Remarkup Help Page Extensible a Yellow Medal token.
Tue, Jun 25, 07:21

Mon, Jun 24

mturdus added a comment to D25698: Make the Remarkup Help Page Extensible.

I did not add a real index page.
The remarkup reference acts a bit as index page as cowsay and figlet references are referenced in here as hyperlinks.

Mon, Jun 24, 15:58
avivey awarded D25698: Make the Remarkup Help Page Extensible a Yellow Medal token.
Mon, Jun 24, 08:34

Sun, Jun 23

mturdus updated the diff for D25698: Make the Remarkup Help Page Extensible.

Make the Remarkup Help Page Extensible

Sun, Jun 23, 21:34
mturdus updated the diff for D25698: Make the Remarkup Help Page Extensible.

Make the Remarkup Help Page Extensible

Sun, Jun 23, 21:20
mturdus added a comment to D25698: Make the Remarkup Help Page Extensible.

I don't understand what happened here?
I only had these files changed/added:

  • src/applications/reference/src/application/ReferenceApplication.php
  • src/applications/reference/src/controller/CowayReferenceController.php
  • src/applications/reference/src/controller/FigletReferenceController.php
  • src/applications/reference/src/controller/ReferenceController.php
  • src/applications/reference/src/controller/RemarkupReferenceController.php
  • src/infrastructure/markup/interface/RemarkupSyntaxDocumentationProvider.php
  • src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php
  • src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php
  • src/view/form/control/PhabricatorRemarkupControl.php
Sun, Jun 23, 20:19
mturdus requested review of D25698: Make the Remarkup Help Page Extensible.
Sun, Jun 23, 20:10
mturdus added a revision to T15401: Make the Remarkup Help Page Extensible: D25698: Make the Remarkup Help Page Extensible.
Sun, Jun 23, 20:10 · Documentation, Remarkup

Fri, Jun 21

mturdus closed D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Fri, Jun 21, 16:10
mturdus closed T15858: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy as Resolved by committing rP1f5c54c35a1a: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Fri, Jun 21, 16:10 · Phriction, Feature Requests
mturdus committed rP1f5c54c35a1a: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Conduit API: allow phriction.edit to modify viewPolicy and editPolicy
Fri, Jun 21, 16:10

Thu, Jun 20

mturdus accepted D25612: Use more css and phorge standard elements for application view.
Thu, Jun 20, 16:06 · Diagrams (Extension)

Sun, Jun 16

mturdus closed Q139: Add remarkup syntax help for custom remarkup rule tokens as resolved.
Sun, Jun 16, 17:22 · Extension Development
mturdus added Q139: Add remarkup syntax help for custom remarkup rule tokens (Answer 172).
Sun, Jun 16, 17:22
mturdus updated the task description for T15858: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Sun, Jun 16, 15:24 · Phriction, Feature Requests
mturdus updated the diff for D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.

Updating D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy

Sun, Jun 16, 15:21

Sat, Jun 15

mturdus requested review of D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Sat, Jun 15, 15:03
mturdus added a revision to T15858: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy: D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Sat, Jun 15, 15:03 · Phriction, Feature Requests
mturdus created T15858: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Sat, Jun 15, 15:00 · Phriction, Feature Requests
mturdus closed T15857: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email as Resolved by committing rP000bccf8e4f7: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending….
Sat, Jun 15, 13:14
mturdus closed D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.
Sat, Jun 15, 13:14
mturdus committed rP000bccf8e4f7: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending….
Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending…
Sat, Jun 15, 13:14
mturdus retitled D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email from Fix PHP 8.1 "strlen(null)" exception in Diviner when sending email via SMTP
Sat, Jun 15, 12:43
mturdus requested review of D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.
Sat, Jun 15, 12:40
mturdus added a revision to T15857: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email: D25692: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.
Sat, Jun 15, 12:40
mturdus created T15857: Fix PHP 8.1 "strlen(null)" exception in PhabricatorMailSMTPAdapter when sending email.
Sat, Jun 15, 12:39

Thu, Jun 13

mturdus asked Q139: Add remarkup syntax help for custom remarkup rule tokens.
Thu, Jun 13, 19:15 · Extension Development

Jun 11 2024

mturdus closed D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings).
Jun 11 2024, 15:09
mturdus committed rP214988fafd75: T15774: Celerity: javascript minification issue with template literals….
T15774: Celerity: javascript minification issue with template literals…
Jun 11 2024, 15:09

Apr 15 2024

mturdus accepted D25577: Makes extension usable with configured alternative file domain.
Apr 15 2024, 20:41 · Diagrams (Extension)
mturdus added a comment to D25577: Makes extension usable with configured alternative file domain.

Now it's working!

Apr 15 2024, 16:58 · Diagrams (Extension)

Apr 14 2024

mturdus added a comment to D25577: Makes extension usable with configured alternative file domain.

This is the console log I got when running in Firefox:

Navigated to http://phorge.blackbird.turdus.local/diagram/
diagram-extension behavior called with config: 
Object { loadJsExtensionArgs: (4) […], toolbarCss: "http://phorge.blackbird.turdus.local/res/diagram-resources/35ad6f49/iframe-toolbtn.css", toolbarJs: "http://phorge.blackbird.turdus.local/res/diagram-resources/26d75a35/iframe-toolbtn.js" }
​
loadJsExtensionArgs: Array(4) [ "", "", "", … ]
​​
0: ""
​​
1: ""
​​
2: ""
​​
3: ""
​​
length: 4
​​
<prototype>: Array []
​
toolbarCss: "http://phorge.blackbird.turdus.local/res/diagram-resources/35ad6f49/iframe-toolbtn.css"
​
toolbarJs: "http://phorge.blackbird.turdus.local/res/diagram-resources/26d75a35/iframe-toolbtn.js"
​
<prototype>: Object { … }
phorge_extension.js:8:11
loadJsExtension called with args: <empty string> <empty string> <empty string> <empty string> phorge_extension.js:95:13
Apr 14 2024, 18:24 · Diagrams (Extension)
mturdus added a comment to D25577: Makes extension usable with configured alternative file domain.

I'm on branch arcpatch-D25577 now but I still have an empty screen.

Apr 14 2024, 06:43 · Diagrams (Extension)
mturdus updated the test plan for D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings).
Apr 14 2024, 05:39

Apr 13 2024

mturdus added a comment to D25577: Makes extension usable with configured alternative file domain.

I might be doing something wrong.
When I open Diagrams, I see an empty screen with only the application's title "Diagram" and its corresponding icon on top

Apr 13 2024, 18:28 · Diagrams (Extension)
mturdus added a comment to T15782: Diagrams Extension is not installable/usable in its current form.

The reason why I did not put all the draw.io js and css files in the repo is because

  1. draw.io is a very large repo

and 2) the draw.io people commit a lot (as in more than once a week).

Apr 13 2024, 15:43 · Diagrams (Extension)
mturdus committed R5:91dd43de7dee: T15781: arc liberate throws exception.
T15781: arc liberate throws exception
Apr 13 2024, 15:09

Apr 7 2024

mturdus retitled D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings) from Summary: T15774.
Apr 7 2024, 11:51
mturdus requested review of D25571: T15774: Celerity: javascript minification issue with template literals (backticked strings).
Apr 7 2024, 11:49
mturdus created T15774: Celerity: javascript minification issue with template literals (backticked strings).
Apr 7 2024, 11:41
mturdus added a comment to Q108: Phorge and Mermaid Js (Answer 139).

Sorry for the late reply.
The Diagrams extension (which just references the draw.io codebase) already has something like that in it.
You can use {DIAG1} in remarkup for showing Diagram 1 in e.g. a wiki document.
You can also import Mermaid diagrams in here.

Apr 7 2024, 10:45

Mar 3 2024

mturdus added a comment to D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.

Mission accomplished.
Thanks

Mar 3 2024, 14:55
mturdus closed D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.
Mar 3 2024, 14:54
mturdus committed rP892f527b9f63: Improve remarkup codeblock syntax highlighting when using Dark Mode.
Improve remarkup codeblock syntax highlighting when using Dark Mode
Mar 3 2024, 14:54
mturdus added a comment to D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.

I thought this was already in the repo, but I forgot to execute arc land... (sorry)
I bump into a 403 error when I execute it now.
I had one merge conflict in resources/celerity/map.php which I corrected manually.

Mar 3 2024, 14:15

Jan 12 2024

mturdus added a comment to D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.

I copy/pasted the keys of the getStyleMap() function dictionary into chatgpt with some remark that they were part of a syntax highlighting mechanism.
I asked it to translate them into something more readable.

Jan 12 2024, 16:25

Jan 10 2024

valerio.bozzolan awarded D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode a Love token.
Jan 10 2024, 20:54
mturdus added a comment to D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.

Can someone explain what these "Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'" messages mean ?
Are these automated unit tests run on we.phorge.it or on my system ?

Jan 10 2024, 17:57

Jan 9 2024

mturdus requested review of D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.
Jan 9 2024, 21:56
mturdus added a revision to T15056: Improve Dark Mode: D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.
Jan 9 2024, 21:56 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit

Aug 18 2023

mturdus accepted D25412: PHP 8 and Diviner Technical Documentation.
Aug 18 2023, 21:24
mturdus triaged T15621: PHP 8.2: Diviner's Phorge Technical Documentation not accessible as High priority.
Aug 18 2023, 18:46 · PHP 8 support

Jul 29 2023

mturdus created T15574: PHP8.1: strlen() null exception when creating a tab panel in a dashboard.
Jul 29 2023, 18:09 · PHP 8 support

Jul 24 2023

mturdus added a comment to D25267: Fix PHP 8.2 "trim(null)" exception which causes Conduit's user.whoami to fail.

I'm not sure if I understand your question.
I thought the fix was already implemented by aklapper?
What do you want me to do?

Jul 24 2023, 14:30

Jul 22 2023

mturdus committed R5:3b52564281f2: Content Security Policy issues fixed.
Content Security Policy issues fixed
Jul 22 2023, 18:01
mturdus committed R5:e6388ef5d785: DiagramUploadConduitAPIMethod.php: Important usage note added about base64….
DiagramUploadConduitAPIMethod.php: Important usage note added about base64…
Jul 22 2023, 18:01
mturdus committed R5:598dabbac05b: .phutil_module_cache removed from staging area.
.phutil_module_cache removed from staging area
Jul 22 2023, 18:01

Jul 16 2023

mturdus committed R5:840ea6b483a7: Subscription functionality added.
Subscription functionality added
Jul 16 2023, 11:56

Jul 15 2023

mturdus created T15555: PHP 8.2: "substr(null) exception" in People > Activity Logs.
Jul 15 2023, 12:36 · PHP 8 support

Jul 11 2023

mturdus added a comment to D25256: T15064: PHP8 related corrections.

The change in src/applications/people/mail/PhabricatorPeopleEmailLoginMailEngine.php also seems to be solved somehow.
I tried to simulate the issue with bin/mail send-test --to mturdus --subject "" and pressing CTRL-D.
I received an empty email (containing no subject and no body).

Jul 11 2023, 16:18
mturdus created T15548: PHP 8.2 "ltrim(null)" exception while executing ./bin/diviner generate.
Jul 11 2023, 05:32 · PHP 8 support

Jul 8 2023

mturdus committed R5:9031a4f716a0: Conduit API methods added.
Conduit API methods added
Jul 8 2023, 21:55

Jul 5 2023

mturdus committed R5:ebe69c77364e: README.md: spelling mistakes.
README.md: spelling mistakes
Jul 5 2023, 17:16
valerio.bozzolan awarded T15498: PHP 8.2 "strlen(null)" exception when viewing image details a Doubloon token.
Jul 5 2023, 12:42 · Files, PHP 8 support

Jul 4 2023

mturdus committed R5:ee422fb38773: Initial version.
Initial version
Jul 4 2023, 19:37