Update after comments

Updates after comments

Updates after comments

Thanks

In D25709#19616, @valerio.bozzolan wrote:

P.S. Why does Phriction have the field text_metadata? And why does Conpherence have content_metadata? 🤔

In D25705#19508, @valerio.bozzolan wrote:

OK try this to restore your desired situation (so, two diffs)

git stash save

git checkout -b just_phriction
git reset --hard origin/master
arc patch --nobranch --diff 2173
arc diff --update D25705

git checkout -b just_conpherence
git reset --hard origin/master
arc patch --nobranch --diff 2178
arc diff --create

Then you have this benefit that you can repeat as many times you want:

git checkout just_phriction
LOL DO CHANGES
arc diff

git checkout just_conpherence
LOL DO CHANGES
arc diff

Or, get fresh master again:

git checkout master

Ideally, the default assumes that people do not touch master but work in branches, each branch a different feature

In D25705#19485, @valerio.bozzolan wrote:

(Do you need a little help to split the changes in two diffs?)

Updates after comments

Fix file attachment in Conpherence

Update after comments

Updates after comments

Updates after comments

it works indeed for editing Maniphest tasks but not for Phriction documents.
I have been analyzing this "attach code" but it's too complex for me.
It seems that the content_metadata (with the attachedFilePHIDs) is correctly sent by the javascript, but it's not processed in the PHP, which makes it not attach the file object to the wiki page.

Make the Remarkup Help Page Extensible

Make the Remarkup Help Page Extensible

Make the Remarkup Help Page Extensible

I did not add a real index page.
The remarkup reference acts a bit as index page as cowsay and figlet references are referenced in here as hyperlinks.

Make the Remarkup Help Page Extensible

Make the Remarkup Help Page Extensible

I don't understand what happened here?
I only had these files changed/added:

• src/applications/reference/src/application/ReferenceApplication.php
• src/applications/reference/src/controller/CowayReferenceController.php
• src/applications/reference/src/controller/FigletReferenceController.php
• src/applications/reference/src/controller/ReferenceController.php
• src/applications/reference/src/controller/RemarkupReferenceController.php
• src/infrastructure/markup/interface/RemarkupSyntaxDocumentationProvider.php
• src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php
• src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php
• src/view/form/control/PhabricatorRemarkupControl.php

Updating D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy

Now it's working!

This is the console log I got when running in Firefox:

Navigated to http://phorge.blackbird.turdus.local/diagram/
diagram-extension behavior called with config: 
Object { loadJsExtensionArgs: (4) […], toolbarCss: "http://phorge.blackbird.turdus.local/res/diagram-resources/35ad6f49/iframe-toolbtn.css", toolbarJs: "http://phorge.blackbird.turdus.local/res/diagram-resources/26d75a35/iframe-toolbtn.js" }
​
loadJsExtensionArgs: Array(4) [ "", "", "", … ]
​​
0: ""
​​
1: ""
​​
2: ""
​​
3: ""
​​
length: 4
​​
<prototype>: Array []
​
toolbarCss: "http://phorge.blackbird.turdus.local/res/diagram-resources/35ad6f49/iframe-toolbtn.css"
​
toolbarJs: "http://phorge.blackbird.turdus.local/res/diagram-resources/26d75a35/iframe-toolbtn.js"
​
<prototype>: Object { … }
phorge_extension.js:8:11
loadJsExtension called with args: <empty string> <empty string> <empty string> <empty string> phorge_extension.js:95:13

I'm on branch arcpatch-D25577 now but I still have an empty screen.

I might be doing something wrong.
When I open Diagrams, I see an empty screen with only the application's title "Diagram" and its corresponding icon on top

The reason why I did not put all the draw.io js and css files in the repo is because

1. draw.io is a very large repo

and 2) the draw.io people commit a lot (as in more than once a week).

Sorry for the late reply.
The Diagrams extension (which just references the draw.io codebase) already has something like that in it.
You can use {DIAG1} in remarkup for showing Diagram 1 in e.g. a wiki document.
You can also import Mermaid diagrams in here.

Mission accomplished.
Thanks

I thought this was already in the repo, but I forgot to execute arc land... (sorry)
I bump into a 403 error when I execute it now.
I had one merge conflict in resources/celerity/map.php which I corrected manually.

I copy/pasted the keys of the getStyleMap() function dictionary into chatgpt with some remark that they were part of a syntax highlighting mechanism.
I asked it to translate them into something more readable.

Can someone explain what these "Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'" messages mean ?
Are these automated unit tests run on we.phorge.it or on my system ?

I'm not sure if I understand your question.
I thought the fix was already implemented by aklapper?
What do you want me to do?

The change in src/applications/people/mail/PhabricatorPeopleEmailLoginMailEngine.php also seems to be solved somehow.
I tried to simulate the issue with bin/mail send-test --to mturdus --subject "" and pressing CTRL-D.
I received an empty email (containing no subject and no body).