Root problem is the https://we.phorge.it/source/phorge/browse/master/src/view/layout/AphrontSideNavFilterView.php with its styles: https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/phui/phui-basic-nav-view.css

(From Task description)

In diffusion repositories, Description and tags are hard to find or never shown (only show in Manage page).

In T15526#16806, @aklapper wrote:

Which exact page(s) is this ticket about?

Which exact page(s) is this ticket about?

On the other hand, as the variable is called $html_details let's go for phutil_implode_html() to be super-safe? ping @roberto.urbani

See discussion and reasons in https://secure.phabricator.com/T11833

I agree, disabled users should be hidden in the global search typeahead results.

In T15736#15681, @bekay wrote:

• Get rid of the JX namespace and the the require comments - use import and export like it is done in modern js

In T15736#15726, @avivey wrote:

to have a working dev server when developing js - at the moment I have to ./bin/celerity map after every change to js and css to see my changes...

Are you sure about that? I thought celerity map was only needed when adding a file (in dev mode).

also, adding this file in src/extensions/ will let you have css/js files from src/extensions/rsrc/ loaded automatically:

to have a working dev server when developing js - at the moment I have to ./bin/celerity map after every change to js and css to see my changes...

I don't know if that is part of this task, but the global typeahead search should hide all disabled users, wikis and repos, shouldn't it? This is nothing you want as a fast suggestion...

Well, my idea would be:

I'm triaging as "wishlist" for now, but realistically - I don't believe will ever reach a point where we'll try to fix this -- see https://secure.phabricator.com/T13154 for discussion.

So apparently the ferret search engine doesn't really have any sort of dynamic ranking. The ranking is entirely based on how many ngrams match the query...with one singular exception - all user results are boosted above everything else.

I'll try to figure out a architecturally-appropriate way to do this. The users do get grayed out in the typeahead search, just not on the results pages.

Partially related, from the mentioned search it's easy to recognize closed Tasks, but Users are not greyed out when Disabled.

Old upstream WONTFIXed this in https://secure.phabricator.com/T13154

@aklapper @valerio.bozzolan See D25520.

BTW I like the proposed screenshot. So I also agree to: feel free to share the solution 👍

My fix would work with this css class

I did not realize you had a fix. Please share it. :)

In T15715#15174, @aklapper wrote:

I guess you could get the result that you're looking for by editing the file webroot/rsrc/css/aphront/typeahead.css and removing the line white-space: nowrap; from the definition of div.jx-typeahead-results a.jx-result. I just don't know which side effects this may have in other places...

I guess you could get the result that you're looking for by editing the file webroot/rsrc/css/aphront/typeahead.css and removing the line white-space: nowrap; from the definition of div.jx-typeahead-results a.jx-result. I just don't know which side effects this may have in other places...

In D25419#14821, @valerio.bozzolan wrote:

I'm just unsure between implode() or phutil_implode_html()

I'm just unsure between implode() or phutil_implode_html()

I believe I had some weird aggressive local browser cache pollution with rPaa8af1d79e8bfeb09e72d5e3b9330780e78b7aeb as I cannot reproduce the wordmark problem anymore, so: LGTM

+lots for removing the words "storage containers" - projects are very much not "storage".
A better metaphor is "labels" or "index" (like in a printed book? Is that something young people know about?).

Also for Archived Projects, and maybe some other objects.
I'm not sure if there's a generic way to do this, or if each search-engine needs to be updated manually.

I'd like to keep this boring:
Projects are hashtags are tags. You can use them for code bases, teams, or anything you need to group.

Completely agree on lowering their ranking as default

In addition, it seems only the owner can see their stuff here.

That's so weird! My instinct is of course to say that it should be completely unrelated to this patch since no CSS is touched in this one-line change... I have no idea how to debug this ☹️

I can confirm that this patch fixes the string problem. However, I am super super puzzled that after applying this patch, the CSS definition line-height: 22px for .phabricator-wordmark is suddenly missing in both Chromium 120 and Firefox 120, moving the wordmark a bit higher in the upper left corner (on my two screenshots, that is "Phoriorge").

I totally agree with these additional considerations. Thanks.

Since we already show the full (public) key when editing, then I don't see a reason not to show it after it's revoked.

We may want to expand the Test Plan to mention additional tips to help newcomers in breaking their installation.

I love it, thanks.

In T15225#13714, @waldyrious wrote:

It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message.

can't repro anymore, looks like the regression regressed

I cannot reproduce anymore. This does not happen anymore in latest master.

I don't think we have a specific task for "general UI text improvements" - there's the UX project, but "improve UX" is an ongoing process, so I don't think a single parent task is a good match.

Ugh. I added this to the UX project but forgot to remove the test content from the comment box, so my changes ended up coupled with a comment that said "- List Item". I tried to delete the comment but now it looks weird like some sort of redacted content :( anway, though I'd leave the note here in case anyone is confused with the deleted comment.

It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message. I was caught off-guard by this at least once. So perhaps the text entry box should be made single-line by default (as already happens if the screen is narrow enough) and expand as needed if line breaks are added.

This is very probably a recent regression since I cannot reproduce on Wikimedia Phabricator.