Page MenuHomePhorge

roberto.urbani (Roberto Urbani)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 19 2022, 14:15 (79 w, 2 d)
Availability
Available

Recent Activity

Nov 7 2023

roberto.urbani closed T15349: Explicitly cover in "Timezone settings" dialog how to ignore the browser vs profile conflict as Resolved by committing rP37ecdf233697: Improving UX for ignoring timezone conflicts.
Nov 7 2023, 08:29 · Good Starter Task
roberto.urbani closed D25420: Improving UX for ignoring timezone conflicts.
Nov 7 2023, 08:29
roberto.urbani committed rP37ecdf233697: Improving UX for ignoring timezone conflicts.
Improving UX for ignoring timezone conflicts
Nov 7 2023, 08:29

Aug 30 2023

roberto.urbani updated the test plan for D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.
Aug 30 2023, 12:45
roberto.urbani requested review of D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.
Aug 30 2023, 12:44
roberto.urbani added a revision to T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized: D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.
Aug 30 2023, 12:44 · Bug Reports

Aug 29 2023

roberto.urbani added a comment to T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized.

@valerio.bozzolan I found the js section where with the listener for open/close the persistent chat. From there I can get element somehow (by ID I don't think it would be good, because it seems to be auto-generated (UQ3_0)) and remove the class "core-menu-item" and the invisible gear icon will no longer be clickable. If the chat is not minimized, we add the class back so we can see it and click it.

Aug 29 2023, 15:44 · Bug Reports
roberto.urbani updated the summary of D25420: Improving UX for ignoring timezone conflicts.
Aug 29 2023, 12:33
roberto.urbani updated the diff for D25420: Improving UX for ignoring timezone conflicts.

Updating D25420:

Aug 29 2023, 12:27
roberto.urbani updated the summary of D25420: Improving UX for ignoring timezone conflicts.
Aug 29 2023, 07:07

Aug 28 2023

roberto.urbani updated the summary of D25420: Improving UX for ignoring timezone conflicts.
Aug 28 2023, 15:46
roberto.urbani updated the summary of D25420: Improving UX for ignoring timezone conflicts.
Aug 28 2023, 15:38
roberto.urbani updated the diff for D25420: Improving UX for ignoring timezone conflicts.

Updating D25420: Updating D25420: fixed tests error

Aug 28 2023, 15:37
roberto.urbani updated the diff for D25420: Improving UX for ignoring timezone conflicts.

Updating D25420: Added a checkbox to ignore timezone conflict in Adjust Timezone dialog window. Using the checkbox instead of a button because this way it's possible to reuse the existing form. Also, i still didn't find a way to capture the additional button click event. This way, if you check the checkbox, it will use the current setting timezone.

Aug 28 2023, 15:20
roberto.urbani added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

It seems your "master" branch has (many?) local unexpected commits.

In order to work on this feature, in Phorge, try these:

git status
# you should be on master - please eventually manually delete any local uncommitted change

Then, create another clean branch:

git branch   pippo_feature
git switch   pippo_feature
git reset --hard origin/master

So now you are on a custom branch pippo_feature that is super-clean. From there you can add fresh features and propose whatever patch.

(To switch between branches, just git switch master or git switch pippo_feature ecc.)

Aug 28 2023, 08:54 · UX
roberto.urbani updated the diff for D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

Updating D25419: Fix the whitespace issue in the message "Access Denied: Restricted File"

Aug 28 2023, 08:53 · UX

Aug 25 2023

roberto.urbani added a comment to T15349: Explicitly cover in "Timezone settings" dialog how to ignore the browser vs profile conflict.

I don't know how to add a third button in a modal, but I would agree on that approach.

Aug 25 2023, 13:45 · Good Starter Task
roberto.urbani added a comment to D25416: Replacing the deprecated -moz-outline-style with outline-style.

Tested, seems good to me

To land, please do this from your side:

arc patch D25416
arc land

Thank you!

Aug 25 2023, 08:37

Aug 24 2023

roberto.urbani added a comment to D25420: Improving UX for ignoring timezone conflicts.

Adding another notification will only make this more annoying.

Why not just improve the current dialog to make it easier to ignore the conflict?

Aug 24 2023, 15:45
roberto.urbani requested review of D25420: Improving UX for ignoring timezone conflicts.
Aug 24 2023, 15:37

Aug 23 2023

roberto.urbani updated the diff for D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

Updating D25419: Fix the whitespace issue in the message "Access Denied: Restricted File"

Aug 23 2023, 11:36 · UX
roberto.urbani updated the diff for D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

Updating D25419: Fix the whitespace issue in the message "Access Denied: Restricted File"

Aug 23 2023, 11:11 · UX
roberto.urbani abandoned D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".
Aug 23 2023, 07:56 · UX
roberto.urbani requested review of D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".
Aug 23 2023, 07:49 · UX

Aug 21 2023

roberto.urbani retitled D25416: Replacing the deprecated -moz-outline-style with outline-style from Task ref: T15585
Aug 21 2023, 14:10
roberto.urbani requested review of D25416: Replacing the deprecated -moz-outline-style with outline-style.
Aug 21 2023, 13:18