Page MenuHomePhorge

sirocyl (Tyler True)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 9 2024, 22:19 (15 w, 3 d)
Availability
Available

Recent Activity

Feb 14 2024

sirocyl edited the content of Organizations Using Phorge.
Feb 14 2024, 09:26
sirocyl added a comment to Organizations Using Phorge.

Should we add FreeBSD to this list? It uses Phorge now (as of June 2023) and has many users.
(Much of their documentation still refers to it as "Phabricator", despite this.)

Feb 14 2024, 00:52
sirocyl updated the answer details for Q18: Lowest and Highest supported PHP (Answer 141).
Feb 14 2024, 00:10
sirocyl added Q18: Lowest and Highest supported PHP (Answer 141).
Feb 14 2024, 00:09

Feb 13 2024

sirocyl added a comment to T15739: Replace celerity postprocessors with real css variables.

A big benefit of using client-side variables in CSS, is that one can use the browser's prefers-color-scheme media query to select light or dark mode based on the user's browser or system setting, automatically, and that the transition from light to dark mode, or to other accent/highlight color schemes, requires no reload.

Feb 13 2024, 04:02 · Discussion Needed
sirocyl closed T15737: Include information for installing required PHP version in Diviner docs as Wontfix.
Feb 13 2024, 03:34 · PHP 8 support, Good Starter Task, Documentation

Feb 12 2024

sirocyl added a comment to D25512: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.

@sirocyl Does this fix your issue? if yes, I can help in landing

Feb 12 2024, 10:52
sirocyl added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

Heck yeah, changing phutil_nonempty_string() to phutil_nonempty_stringlike() there fixed the issue I had mentioned in a comment in T15737: Include information for installing required PHP version in Diviner docs.

Feb 12 2024, 10:50 · Auth, Bug Reports
sirocyl added a comment to T15737: Include information for installing required PHP version in Diviner docs.

On it, thank you!

Feb 12 2024, 10:47 · PHP 8 support, Good Starter Task, Documentation
sirocyl added a comment to T15737: Include information for installing required PHP version in Diviner docs.

I'm on the latest pull, commit f81e821abf2b275d1778d02a018a4d0af7208be8.
A bit off topic here :) but I'll quickly sum up the issue I'm having (and am in the middle of trying things to fix):

  • Visiting https://[phorge instance]/auth/config/view/2/, where my Github auth item is, makes nginx dump a blank 502 page, no further info.
  • First instinct is to check the /var/log/nginx/error.log, where I get a PHP stack trace concatenated into one line, and an nginx header length error (reformatted for readability. the PHP error is truncated):
Feb 12 2024, 10:35 · PHP 8 support, Good Starter Task, Documentation
sirocyl added a comment to T15737: Include information for installing required PHP version in Diviner docs.

I'll take your word on it that it's supported, though the current installation guide says otherwise.
Further, I had a few roadbumps on a fresh install to a new server with PHP 8, that I suspect may relate to strlen(NULL) behavior, but I did need to set up PHP 7 to make sure that was or wasn't the case.
(I'm in the process of reproducing those and working out a possible cause or trace. Some manifested as warning banners, one as a 502 on my end in the GitHub auth provider.)

Feb 12 2024, 10:01 · PHP 8 support, Good Starter Task, Documentation
sirocyl updated the task description for T15737: Include information for installing required PHP version in Diviner docs.
Feb 12 2024, 07:38 · PHP 8 support, Good Starter Task, Documentation
sirocyl updated the task description for T15737: Include information for installing required PHP version in Diviner docs.
Feb 12 2024, 07:37 · PHP 8 support, Good Starter Task, Documentation
sirocyl created T15737: Include information for installing required PHP version in Diviner docs.
Feb 12 2024, 07:36 · PHP 8 support, Good Starter Task, Documentation

Feb 11 2024

sirocyl added a comment to T15630: Fix Fonts.

Agreed. We should not link fonts from outside our own assets (those hosted on an instance of Phorge.) I don't think I suggested that, but I don't disagree.

Feb 11 2024, 05:17

Feb 10 2024

sirocyl added a comment to T15630: Fix Fonts.

As far as bold/italic variants are concerned, for fonts that support it, you can preferentially serve the "variable" version and only fall back on specific font variants when that isn't supported, to save on bandwidth in most cases - since the e.g., Inter Variable font file "includes" the bold and italic, condensed and expanded versions, essentially "for free", as they're generated by the font engine/renderer on the fly from the base font.

Feb 10 2024, 15:16
sirocyl added a comment to T15630: Fix Fonts.

Inter and Noto look best to me (1080p laptop screen, Linux, Firefox, no scaling) given all default sizings in Phorge (as a drop-in replacement). Noto, I believe has a lot more Unicode symbol coverage, and a larger file size as a result; but Inter has variable font properties (e.g., more weights than "bold" and "regular", as well as condensed and expanded forms, letter variants for differentiating I/l O/0, etc).

Feb 10 2024, 14:44

Feb 9 2024

sirocyl added a comment to T15630: Fix Fonts.

CSS is rather flexible now; a larger font scale can be specified for displays above a certain horizontal resolution or display width/effective character width, nowadays.
Atkinson looks poor at the font size specified, you're right about that @bekay.
I feel like it might need to break out into another task item, but perhaps CSS modernization is imo a good step towards making Phorge more compatible and capable, on screens both small and large.

Feb 9 2024, 05:33

Feb 8 2024

sirocyl added a comment to T15630: Fix Fonts.

Of these, I like 1 and 3 (Noto and Inter) better. How does Atkinson look? (I haven't gotten around to changing the font on my end yet, heh)

Feb 8 2024, 00:07

Feb 7 2024

sirocyl added a comment to T15630: Fix Fonts.

Regardless of the choice made here; I'm likely going to maintain a patch on my instance that uses Inter for headings and UI elements, and Atkinson Hyperlegible for long-form text prose content.

Feb 7 2024, 13:28

Jan 28 2024

sirocyl added a comment to T15726: Remove dysfunctional Fund and Phortune prototype applications.

I never totally understood what the jobs of Fund and Phortune really were, and they weren't explained very well in the documentation, as if they were very Phacility-only tools that happened to be in Phabricator.

Jan 28 2024, 20:25

Jan 15 2024

valerio.bozzolan awarded T15711: Ponder: "New Answer" input box should be hidden for those without permissions. a Grey Medal token.
Jan 15 2024, 09:22 · Ponder, Bug Reports, UX
sirocyl added a comment to Q103: Ponder: "New Answer" input box should be hidden for those without permissions. (Answer 131).

Done; see T15711.

Jan 15 2024, 05:45
sirocyl closed Q103: Ponder: "New Answer" input box should be hidden for those without permissions. as resolved.
Jan 15 2024, 05:45 · UX
sirocyl created T15711: Ponder: "New Answer" input box should be hidden for those without permissions..
Jan 15 2024, 05:41 · Ponder, Bug Reports, UX

Jan 11 2024

sirocyl updated the question details for Q103: Ponder: "New Answer" input box should be hidden for those without permissions..
Jan 11 2024, 16:41 · UX
sirocyl asked Q103: Ponder: "New Answer" input box should be hidden for those without permissions..
Jan 11 2024, 16:38 · UX
sirocyl added a comment to T15006: Re-brand Phorge.

Noticed a few dangling phacility references in URLs in documentation, which could lead users to grabbing upstream Phabricator versions by mistake:

phorge/src/docs/user/field/xhprof.diviner:  $ git clone https://github.com/phacility/xhprof.git
phorge/src/docs/user/userguide/arcanist.diviner:  some_install_path/ $ git clone https://github.com/phacility/arcanist.git
phorge/src/docs/user/userguide/arcanist_quick_start.diviner:  somewhere/ $ git clone https://github.com/phacility/arcanist.git

corresponding to:
https://we.phorge.it/book/phorge/article/xhprof/#installing-xhprof
https://we.phorge.it/book/phorge/article/arcanist/#installing-arcanist
https://we.phorge.it/book/phorge/article/arcanist_quick_start/#installing-arcanist

Jan 11 2024, 15:36 · Phorge