Page MenuHomePhorge
People pppery

pppery (Perry)
User

Projects

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Nov 22 2023, 04:24 (35 w, 2 d)
Availability
Available

Recent Activity
View All

Thu, Jul 18

pppery added a comment to D25618: Avoid search exception for calendar events when using localized time formats.

I think the behavior of not setting the timezone is probably correct, actually. GetFormattedDateFromParts below already constructs a date object again with the timezone set. So I think the timezone offset is being applied twice here.

Thu, Jul 18, 18:28

Jun 21 2024

pppery added a project to T15854: "Undefined array key 1" exception when @task in PHPDoc is a single string: Diviner.
Jun 21 2024, 21:49 · Diviner
pppery added a project to T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)": Herald.
Jun 21 2024, 21:49 · Herald
pppery closed D25695: Add fallback languages for locale files.
Jun 21 2024, 17:10
pppery committed rARC0af89f7d323b: Add fallback languages for locale files.
Add fallback languages for locale files
Jun 21 2024, 17:10

Jun 20 2024

pppery added a comment to T15862: Some messages that support PLURAL are not detected as such by the i18n string extractor.

From an attempt I made to fix this before running out of motivation (this lists all parameters that vary on number in the US English translation but the i18n extractor thinks they don't)

WARNING  /applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php:269: missing PhutilNumber call?
WARNING  /applications/config/check/PhabricatorExtraConfigSetupCheck.php:72: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:58: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:73: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:316: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:321: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:347: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:390: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:397: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:524: missing PhutilNumber call?
WARNING  /applications/config/view/PhabricatorSetupIssueView.php:578: missing PhutilNumber call?
WARNING  /applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:74: missing PhutilNumber call?
WARNING  /applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:80: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:36: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:48: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:78: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:92: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:39: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:51: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:81: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:95: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php:46: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:18: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:30: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:61: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:75: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/differential/mail/DifferentialCreateMailReceiver.php:75: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:523: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:525: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:529: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:531: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:556: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:558: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:562: missing PhutilNumber call?
WARNING  /applications/differential/render/DifferentialChangesetHTMLRenderer.php:564: missing PhutilNumber call?
WARNING  /applications/differential/storage/DifferentialTransaction.php:593: missing PhutilNumber call?
WARNING  /applications/differential/storage/DifferentialTransaction.php:597: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php:46: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:64: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:78: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:25: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:37: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:67: missing PhutilNumber call?
WARNING  /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:81: missing PhutilNumber call?
WARNING  /applications/legalpad/edge/LegalpadObjectNeedsSignatureEdgeType.php:17: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:32: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:44: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:74: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:88: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:37: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:49: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:79: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:93: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php:21: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:45: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:76: missing PhutilNumber call?
WARNING  /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:90: missing PhutilNumber call?
WARNING  /applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php:54: missing PhutilNumber call?
WARNING  /applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php:60: missing PhutilNumber call?
WARNING  /applications/pholio/edge/PholioMockHasTaskEdgeType.php:21: missing PhutilNumber call?
WARNING  /applications/pholio/edge/PholioMockHasTaskEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/pholio/xaction/PholioImageFileTransaction.php:61: missing PhutilNumber call?
WARNING  /applications/pholio/xaction/PholioImageFileTransaction.php:67: missing PhutilNumber call?
WARNING  /applications/phortune/controller/account/PhortuneAccountOverviewController.php:116: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneAccountHasMemberEdgeType.php:17: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneAccountHasMemberEdgeType.php:29: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneMerchantHasMemberEdgeType.php:17: missing PhutilNumber call?
WARNING  /applications/phortune/edge/PhortuneMerchantHasMemberEdgeType.php:29: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectMemberOfProjectEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectMemberOfProjectEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:24: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:36: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:67: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:81: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:64: missing PhutilNumber call?
WARNING  /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:78: missing PhutilNumber call?
WARNING  /applications/project/storage/PhabricatorProjectTransaction.php:108: missing PhutilNumber call?
WARNING  /applications/project/storage/PhabricatorProjectTransaction.php:120: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:56: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:62: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:90: missing PhutilNumber call?
WARNING  /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:97: missing PhutilNumber call?
WARNING  /applications/repository/worker/PhabricatorRepositoryPushMailWorker.php:77: missing PhutilNumber call?
WARNING  /applications/repository/worker/PhabricatorRepositoryPushMailWorker.php:108: missing PhutilNumber call?
WARNING  /applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php:98: missing PhutilNumber call?
WARNING  /applications/subscriptions/view/SubscriptionListStringBuilder.php:67: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php:22: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php:34: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:21: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:33: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:63: missing PhutilNumber call?
WARNING  /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:77: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:38: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:39: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:44: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:55: missing PhutilNumber call?
WARNING  /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:56: missing PhutilNumber call?
WARNING  /applications/transactions/storage/PhabricatorApplicationTransaction.php:1042: missing PhutilNumber call?
WARNING  /applications/transactions/storage/PhabricatorApplicationTransaction.php:1053: missing PhutilNumber call?
WARNING  /infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php:140: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:66: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:78: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:109: missing PhutilNumber call?
WARNING  /infrastructure/edges/type/PhabricatorEdgeType.php:123: missing PhutilNumber call?

Not all of these should be fixed in the obvious way, or even can be.

Jun 20 2024, 18:42 · Localization
pppery created T15863: Phorge doesn't seem to properly support gramatical gender.
Jun 20 2024, 18:11 · Localization
pppery created T15862: Some messages that support PLURAL are not detected as such by the i18n string extractor.
Jun 20 2024, 18:03 · Localization
pppery updated the diff for D25695: Add fallback languages for locale files.

Fix a typo

Jun 20 2024, 15:07
pppery added a comment to D25695: Add fallback languages for locale files.

Done that. I left the technically-redundant methods where I have a lengthy comment explaining why I return en_US, since I think it's helpful to explain why that is.

Jun 20 2024, 15:06
pppery updated the diff for D25695: Add fallback languages for locale files.

Don't make unnecessary whitespace changes

Jun 20 2024, 15:04
pppery updated the diff for D25695: Add fallback languages for locale files.

Set fallback locale in base class

Jun 20 2024, 15:02
pppery added a comment to D25695: Add fallback languages for locale files.

The current behavior if a fallback locale is not specified is to fallback to the proto-English string (English without applying pluralization). It probably does make sense, now that you bring it up, to fall back to en_US instead by default instead of doing that in every locale.

Jun 20 2024, 14:56

Jun 19 2024

pppery updated the diff for D25695: Add fallback languages for locale files.

Ce a comment

Jun 19 2024, 21:36
pppery added inline comments to D25695: Add fallback languages for locale files.
Jun 19 2024, 20:29
pppery updated the diff for D25695: Add fallback languages for locale files.

Fix lint

Jun 19 2024, 20:16
pppery requested review of D25695: Add fallback languages for locale files.
Jun 19 2024, 20:12
pppery created T15861: Support bidirectional fallback locales.
Jun 19 2024, 19:43 · Arcanist, Localization

Jun 12 2024

pppery claimed T15840: Don't give bad password advice when resetting password.
Jun 12 2024, 04:01
pppery changed the status of T15840: Don't give bad password advice when resetting password from Spite to Resolved by committing rP1bb7422662ac: Reword joke password reset email message.
Jun 12 2024, 03:59
pppery closed D25671: Reword joke password reset email message.
Jun 12 2024, 03:59
pppery committed rP1bb7422662ac: Reword joke password reset email message.
Reword joke password reset email message
Jun 12 2024, 03:59

Jun 8 2024

pppery added a project to T15724: PHP 8.3: ldap_connect() call signature deprecated: PHP 8 support.
Jun 8 2024, 23:59 · PHP 8 support
pppery added a project to T15757: Arcanist Test Result Parser Updates: Arcanist.
Jun 8 2024, 23:58 · Arcanist
pppery added a project to T15772: Task with graph issue won't show: Maniphest.
Jun 8 2024, 23:58 · Maniphest
pppery added projects to T15790: Exception creating a "Diffusion Raw Commits" Dashboard query panel: Dashboards, Diffusion.
Jun 8 2024, 23:58 · Diffusion, Dashboards
pppery added a project to T15811: Search exception when AM/PM string is localized in Calendar application: Calendar.
Jun 8 2024, 23:57 · Calendar
pppery added a project to T15843: Allow collapse and expand of workboard columns in mobile view: Workboard.
Jun 8 2024, 23:56 · Workboard

Jun 7 2024

pppery closed D25684: Remove PhutilPhtTestCase::getDateTranslations().
Jun 7 2024, 19:10
pppery committed rARCf7fcf31c7e23: Remove PhutilPhtTestCase::getDateTranslations().
Remove PhutilPhtTestCase::getDateTranslations()
Jun 7 2024, 19:10
pppery added a comment to D25684: Remove PhutilPhtTestCase::getDateTranslations().

No, it never was called anywhere. Read the HTML comment this commit deletes.

Jun 7 2024, 18:56
pppery updated the summary of D25684: Remove PhutilPhtTestCase::getDateTranslations().
Jun 7 2024, 16:57
pppery requested review of D25684: Remove PhutilPhtTestCase::getDateTranslations().
Jun 7 2024, 16:55
pppery added a comment to T15815: Make i18n string extraction ignore strings in test cases.

... but it turns out by concidence most of the date elements that are worth translating are already translatable from other references in the code:

Jun 7 2024, 04:33 · Localization
pppery added a comment to T15815: Make i18n string extraction ignore strings in test cases.
// The only purpose of this function is to provide a static list of
// translations which can come from PhutilTranslator::translateDate() to
// allow translation extractor getting them.

I seem to have a bad habit of doing things and realizing they were stupid or I had missed something weeks to months later.

Jun 7 2024, 03:12 · Localization

Jun 6 2024

pppery closed T15850: Typo in auth message when unlinking accounts as Resolved by committing rPd8cd959622da: Fix a leftover misspelled "Phabricator" reference.
Jun 6 2024, 14:37
pppery closed D25682: Fix a leftover misspelled "Phabricator" reference.
Jun 6 2024, 14:37
pppery committed rPd8cd959622da: Fix a leftover misspelled "Phabricator" reference.
Fix a leftover misspelled "Phabricator" reference
Jun 6 2024, 14:37
pppery added a project to T15851: Support proper pluralization in mock task activity: Bug Reports.
Jun 6 2024, 05:39 · Bug Reports
pppery renamed T15851: Support proper pluralization in mock task activity from Support proper PLURAL syntax in mocks to Support proper pluralization in mock task activity.
Jun 6 2024, 05:39 · Bug Reports
pppery created T15851: Support proper pluralization in mock task activity.
Jun 6 2024, 05:37 · Bug Reports
pppery added a comment to D25682: Fix a leftover misspelled "Phabricator" reference.

I would be find with turning this into "your PlatformSymbols::getPlatformServerName() account" instead if that's seen as clearer but I'm not convinced the platform is necessary here at all. Opinions on that welcome.

Jun 6 2024, 02:34
pppery requested review of D25682: Fix a leftover misspelled "Phabricator" reference.
Jun 6 2024, 02:27
pppery added a revision to T15850: Typo in auth message when unlinking accounts: D25682: Fix a leftover misspelled "Phabricator" reference.
Jun 6 2024, 02:27
pppery claimed T15850: Typo in auth message when unlinking accounts.
Jun 6 2024, 01:39
pppery updated the task description for T15850: Typo in auth message when unlinking accounts.
Jun 6 2024, 01:24
pppery created T15850: Typo in auth message when unlinking accounts.
Jun 6 2024, 01:24

Jun 4 2024

pppery closed T15845: Remove leftover reference to PhutilHighIntensityIntervalDaemon as Resolved by committing rP8dd90edd3a76: Remove broken link to PhutilHighIntensityIntervalDaemon docs.
Jun 4 2024, 21:31
pppery closed D25680: Remove broken link to PhutilHighIntensityIntervalDaemon docs.
Jun 4 2024, 21:31
pppery committed rP8dd90edd3a76: Remove broken link to PhutilHighIntensityIntervalDaemon docs.
Remove broken link to PhutilHighIntensityIntervalDaemon docs
Jun 4 2024, 21:31
pppery updated the diff for D25671: Reword joke password reset email message.

Fix a double space after testing

Jun 4 2024, 19:14
pppery requested review of D25680: Remove broken link to PhutilHighIntensityIntervalDaemon docs.
Jun 4 2024, 17:22
pppery added a revision to T15845: Remove leftover reference to PhutilHighIntensityIntervalDaemon: D25680: Remove broken link to PhutilHighIntensityIntervalDaemon docs.
Jun 4 2024, 17:22
pppery updated the diff for D25671: Reword joke password reset email message.

Actually do that, since I screwed up before

Jun 4 2024, 17:17
pppery retitled D25671: Reword joke password reset email message from Remove joke password reset email message
Jun 4 2024, 17:12
pppery updated the diff for D25671: Reword joke password reset email message.

Update to Andre's suggestion

Jun 4 2024, 17:11

Jun 1 2024

pppery updated the task description for T15845: Remove leftover reference to PhutilHighIntensityIntervalDaemon.
Jun 1 2024, 23:01
pppery created T15845: Remove leftover reference to PhutilHighIntensityIntervalDaemon.
Jun 1 2024, 22:59

May 26 2024

pppery added a comment to D25671: Reword joke password reset email message.
In D25671#18362, @speck wrote:
In D25671#18360, @speck wrote:

Agree the current non-serious language needs updated.

Though, I’d guess Phab/Phorge will actually reject these short passwords.

May 26 2024, 16:58

May 25 2024

pppery added a project to T15836: ArcanistHardpointTask calls non-existent constructor for ArcanistHardpointFutureList: Arcanist.
May 25 2024, 20:17 · Arcanist
pppery updated the task description for T15842: Remove trailing whitespace in messages.
May 25 2024, 18:02 · Localization
pppery closed T15839: Fix formatting of "etc." in various messages as Resolved by committing rP3a6e835e364a: Fix spelling of etc. in messages per Translatewiki request.
May 25 2024, 15:52
pppery closed D25670: Fix spelling of etc. in messages per Translatewiki request.
May 25 2024, 15:52
pppery committed rP3a6e835e364a: Fix spelling of etc. in messages per Translatewiki request.
Fix spelling of etc. in messages per Translatewiki request
May 25 2024, 15:52
pppery retitled D25670: Fix spelling of etc. in messages per Translatewiki request from Fix formatting of etc. in messages per Translatewiki request
May 25 2024, 15:50
pppery updated the diff for D25670: Fix spelling of etc. in messages per Translatewiki request.

Change commit message to reference spelling

May 25 2024, 15:41
pppery updated subscribers of T15840: Don't give bad password advice when resetting password.

"And complained on WMF, where this feature is disabled?" is true but misleading IMO - there was nowhere better to complain than WMF's instance since this took place after Phabricator was abandoned but before Phorge's initial release, and WMF's instance has received numerous other reports of Phabricator translation problems that were later redirected here or to old upstream.

May 25 2024, 15:38
pppery added a comment to D25671: Reword joke password reset email message.

And yes, I did read https://we.phorge.it/book/phorge/article/tone/ before filing this patch. You are welcome to berate me (and by extension Verdy_p on translatewiki.net, although they've been blocked there so the chance of them seeing anything you say is low) anyway.

May 25 2024, 04:02
pppery created T15842: Remove trailing whitespace in messages.
May 25 2024, 02:04 · Localization
pppery requested review of D25671: Reword joke password reset email message.
May 25 2024, 01:14
pppery added a revision to T15840: Don't give bad password advice when resetting password: D25671: Reword joke password reset email message.
May 25 2024, 01:14
pppery closed T15841: Clarify "nav key on your keyboard" in DarkConsole as Invalid.

Sorry, this isn't an upstream problem. It's an instance of the general "Phabricator lacks message documentation" problem, since nav is a bit of remarkup that niether Verdy_p on the translatewiki side nor I am familiar with. But I can handle that on the translatewiki.net side and there's nothing for upstream to do.

May 25 2024, 01:09

May 24 2024

pppery added a comment to T15840: Don't give bad password advice when resetting password.

I upstreamed this as a largely procedural action (go through all requests for source message changes in translatewiki.net that haven't been resolved and move them up to Phorge so they can be evaluated properly rather than ignored).

May 24 2024, 20:16
pppery updated the diff for D25670: Fix spelling of etc. in messages per Translatewiki request.

Read the originally requested changes more carefully

May 24 2024, 19:23
pppery removed a task from D25670: Fix spelling of etc. in messages per Translatewiki request: T15841: Clarify "nav key on your keyboard" in DarkConsole.
May 24 2024, 19:20
pppery removed a revision from T15841: Clarify "nav key on your keyboard" in DarkConsole: D25670: Fix spelling of etc. in messages per Translatewiki request.
May 24 2024, 19:20
pppery updated the summary of D25670: Fix spelling of etc. in messages per Translatewiki request.
May 24 2024, 19:20
pppery added a revision to T15839: Fix formatting of "etc." in various messages: D25670: Fix spelling of etc. in messages per Translatewiki request.
May 24 2024, 19:20
pppery requested review of D25670: Fix spelling of etc. in messages per Translatewiki request.
May 24 2024, 19:19
pppery added a revision to T15841: Clarify "nav key on your keyboard" in DarkConsole: D25670: Fix spelling of etc. in messages per Translatewiki request.
May 24 2024, 19:19
pppery updated the task description for T15841: Clarify "nav key on your keyboard" in DarkConsole.
May 24 2024, 19:01
pppery created T15841: Clarify "nav key on your keyboard" in DarkConsole.
May 24 2024, 18:01
pppery created T15840: Don't give bad password advice when resetting password.
May 24 2024, 17:55
pppery created T15839: Fix formatting of "etc." in various messages.
May 24 2024, 17:50

May 15 2024

pppery added a project to T15815: Make i18n string extraction ignore strings in test cases: Localization.
May 15 2024, 05:13 · Localization
pppery added a project to T15055: Import translations from translatewiki.net: Localization.
May 15 2024, 05:12 · Localization, Affects-Wikimedia, Phorge
pppery merged T15079: Upstream translatewiki.net's changes into T15055: Import translations from translatewiki.net.
May 15 2024, 05:11 · Localization, Affects-Wikimedia, Phorge
pppery merged task T15079: Upstream translatewiki.net's changes into T15055: Import translations from translatewiki.net.
May 15 2024, 05:11 · Localization

May 8 2024

pppery added a comment to T15815: Make i18n string extraction ignore strings in test cases.
In T15815#17273, @valerio.bozzolan wrote:

I also don't think Phabricator ever documented how to change language in command line Arcanist. If ever possible, btw 🤔

May 8 2024, 23:57 · Localization
pppery added a comment to D25624: Make i18n string extraction ignore strings in test case files.

For the record: If I replace the entire file with just:

<?php
May 8 2024, 15:13
pppery claimed T15815: Make i18n string extraction ignore strings in test cases.

(that was me, I didn't have git author configured properly from on the system I landed from)

May 8 2024, 15:00 · Localization
pppery added a comment to D25624: Make i18n string extraction ignore strings in test case files.

(that was me, I didn't have git author configured properly from on the system I landed from)

May 8 2024, 15:00
pppery added a comment to D25624: Make i18n string extraction ignore strings in test case files.

arc unit --everything passed. But I don't think this file is covered by tests at all,

May 8 2024, 14:57
pppery added a comment to T15815: Make i18n string extraction ignore strings in test cases.
In T15815#17273, @valerio.bozzolan wrote:

Thanks. Completely agree.

I also don't think Phabricator ever documented how to change language in command line Arcanist. If ever possible, btw 🤔

May 8 2024, 12:49 · Localization

May 7 2024

pppery updated the diff for D25624: Make i18n string extraction ignore strings in test case files.

Re-diff with linting and tests working hopefully

May 7 2024, 22:41
pppery requested review of D25624: Make i18n string extraction ignore strings in test case files.
May 7 2024, 22:01
pppery added a revision to T15815: Make i18n string extraction ignore strings in test cases: D25624: Make i18n string extraction ignore strings in test case files.
May 7 2024, 22:01 · Localization

Jan 27 2024

pppery added a comment to T15722: Phorge is inaccessible while waiting for approval after registration.

Old upstream WONTFIXed this in https://secure.phabricator.com/T13154

Jan 27 2024, 22:20 · Bug Reports, UX

Dec 20 2023

pppery awarded T15697: When deleting the last Sub-project, restore its Root Project a Like token.
Dec 20 2023, 19:57 · User-valerio.bozzolan, Projects

Dec 8 2023

pppery added a comment to T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested.

Also related: https://phabricator.wikimedia.org/T266966

Dec 8 2023, 06:06
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0