Page MenuHomePhorge
Create Task
Maniphest T15270

"Access Denied: Restricted File" strings concatenated without whitespace
Closed, ResolvedPublic
Actions

Assigned To
valerio.bozzolan
Authored By
aklapper
Apr 25 2023, 09:51
Tags
Referenced Files
F2179147: image.png
May 5 2024, 11:07
F2179135: image.png
May 5 2024, 11:05
F2179138: image.png
May 5 2024, 11:05
Subscribers
aklapper
chris
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan
waldyrious
Tokens
"Like" token, awarded by waldyrious."Like" token, awarded by valerio.bozzolan.

Description

Strings get concatenated in the file src/applications/files/storage/PhabricatorFile.php in function describeAutomaticCapability($capability) resulting in a lack of whitespace between each of these strings.

See screenshot in https://phabricator.wikimedia.org/F34688615

CurrentProposed
image.png (322×359 px, 29 KB)
image.png (322×359 px, 30 KB)

Revisions and Commits

rP Phorge
D25419rPc8fb5046909c Fix the whitespace issue in the message "Access Denied: Restricted File"

Related Objects

Event Timeline

aklapper created this task.Apr 25 2023, 09:51
Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptApr 25 2023, 09:51
valerio.bozzolan awarded a token.May 3 2023, 13:06
valerio.bozzolan subscribed.
valerio.bozzolan triaged this task as Low priority.Jun 17 2023, 15:22
roberto.urbani mentioned this in D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".Aug 23 2023, 07:49
waldyrious awarded a token.Sep 22 2023, 20:37
waldyrious subscribed.
waldyrious added a comment.Sep 22 2023, 22:26

For others reading this thread: there's some discussion going on in the thread of the patch linked above, D25419.

waldyrious added a project: UX.Dec 15 2023, 08:49
valerio.bozzolan added a revision: D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".May 5 2024, 11:02
valerio.bozzolan closed this task as Resolved by committing rPc8fb5046909c: Fix the whitespace issue in the message "Access Denied: Restricted File".May 5 2024, 11:02
valerio.bozzolan claimed this task.
valerio.bozzolan added a commit: rPc8fb5046909c: Fix the whitespace issue in the message "Access Denied: Restricted File".
valerio.bozzolan updated the task description. (Show Details)May 5 2024, 11:05
waldyrious updated the task description. (Show Details)May 5 2024, 11:07
valerio.bozzolan attached a referenced file: F2179135: image.png. (Show Details)May 5 2024, 11:09
valerio.bozzolan attached a referenced file: F2179138: image.png. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0