Page MenuHomePhorge

Auto-subscription: little less verbose

Authored by valerio.bozzolan on May 4 2023, 20:39.
Referenced Files
Unknown Object (File)
Wed, May 15, 06:47
Unknown Object (File)
Tue, May 14, 08:43
Unknown Object (File)
Sat, May 11, 00:54
Unknown Object (File)
Fri, May 10, 13:15
Unknown Object (File)
Thu, May 9, 23:00
Unknown Object (File)
Wed, May 8, 14:50
Unknown Object (File)
Wed, May 8, 14:50
Unknown Object (File)
Wed, May 8, 14:46
"Cup of Joe" token, awarded by bfs.



When the user "Mrs. Kitten" adds or remove "Mrs. Kitten" as Subscriber,
usually these messages were generated:

Mrs. Kitten added a subscriber: Mrs. Kitten.
Mrs. Kitten removed a subscriber: Mrs. Kitten.

This was a bit like the Spiderman meme self-pointing Spiderman.

After this change, these beautiful messages are generated instead:

Mrs. Kitten subscribed.
Mrs. Kitten unsubscribed.
Subscriber messages - Before.png (365×652 px, 61 KB)
Subscriber messages - After.png (365×652 px, 45 KB)

Closes T15347

Test Plan
  • subscribe on something
  • unsubscribe from something
  • all other cases remain as-is

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable

Event Timeline

Yes, for wonderful, WONDERFUL reasons, there was already an isSelfSubscription() function! ✨

bfs subscribed.

Seems reasonable and simple enough. Can we get a Blessed Committer to accept this?

This revision is now accepted and ready to land.Jun 8 2023, 01:11