Page MenuHomePhorge
Differential D25191

Auto-subscription: little less verbose
ClosedPublic
Actions

Authored by valerio.bozzolan on May 4 2023, 20:39.
Tags
Referenced Files
F4045963: D25191.1746736920.diff
Wed, May 7, 20:42
F4045962: D25191.1746736919.diff
Wed, May 7, 20:41
F4045960: D25191.1746736918.diff
Wed, May 7, 20:41
F3970398: D25191.1746529127.diff
Mon, May 5, 10:58
F3970396: D25191.1746529091.diff
Mon, May 5, 10:58
F3970395: D25191.1746529052.diff
Mon, May 5, 10:57
F3956272: D25191.1746486268.diff
Sun, May 4, 23:04
F3945847: D25191.1746445625.diff
Sun, May 4, 11:47
View All 56 Files
Subscribers
bfs
Cigaryno
Matthew
speck
tobiaswiese
Tokens
"Cup of Joe" token, awarded by bfs.

Details

Reviewers
bfs
speck
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15347: Auto-subscription is a little bit too verbose: «Person added a subscriber: Person»
Commits
rP7fe622e5d366: Auto-subscription: little less verbose
Summary

When the user "Mrs. Kitten" adds or remove "Mrs. Kitten" as Subscriber,
usually these messages were generated:

Mrs. Kitten added a subscriber: Mrs. Kitten.
Mrs. Kitten removed a subscriber: Mrs. Kitten.

This was a bit like the Spiderman meme self-pointing Spiderman.

After this change, these beautiful messages are generated instead:

Mrs. Kitten subscribed.
Mrs. Kitten unsubscribed.
BeforeAfter
Subscriber messages - Before.png (365×652 px, 61 KB)
Subscriber messages - After.png (365×652 px, 45 KB)

Closes T15347

Test Plan
  • subscribe on something
  • unsubscribe from something
  • all other cases remain as-is

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.May 4 2023, 20:39
Owners added a reviewer: O1: Blessed Committers.May 4 2023, 20:39
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMay 4 2023, 20:39
valerio.bozzolan requested review of this revision.May 4 2023, 20:39
Harbormaster completed remote builds in B360: Diff 657.May 4 2023, 20:39
valerio.bozzolan mentioned this in Z1: Phorge.May 4 2023, 20:41

Yes, for wonderful, WONDERFUL reasons, there was already an isSelfSubscription() function! ✨

bfs awarded a token.May 5 2023, 20:04
valerio.bozzolan edited the test plan for this revision. (Show Details)May 9 2023, 16:59
bfs accepted this revision.May 10 2023, 17:21
bfs subscribed.

Seems reasonable and simple enough. Can we get a Blessed Committer to accept this?

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16
speck accepted this revision.Jun 8 2023, 01:11
This revision is now accepted and ready to land.Jun 8 2023, 01:11
Closed by commit rP7fe622e5d366: Auto-subscription: little less verbose. · Explain WhyJun 15 2023, 09:52
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rP7fe622e5d366: Auto-subscription: little less verbose.
valerio.bozzolan mentioned this in Next Up.Jun 15 2023, 10:00
avivey mentioned this in 2023 Week 32.Aug 11 2023, 16:31
waldyrious added a project: UX.Nov 29 2023, 11:54

Revision Contents
Changeset List

PathSizePackages
src/
applications/
transactions/
storage/
10 linesO1: Blessed Committers

Diff 967

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0