Page MenuHomePhorge
Differential D25191

Auto-subscription: little less verbose
Needs ReviewPublic
Actions

Authored by valerio.bozzolan on May 4 2023, 20:39.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 31, 06:37
Unknown Object (File)
Mon, May 22, 23:40
Unknown Object (File)
Mon, May 22, 09:26
Unknown Object (File)
Wed, May 17, 14:34
Unknown Object (File)
Mon, May 8, 15:38
F286216: Subscriber messages - After.png
May 4 2023, 20:39
F286215: Subscriber messages - Before.png
May 4 2023, 20:39
Subscribers
bfs
Cigaryno
Matthew
speck
tobiaswiese
Tokens
"Cup of Joe" token, awarded by bfs.

Details

Reviewers
bfs
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15347: Auto-subscription is a little bit too verbose: «Person added a subscriber: Person»
Summary

When the user "Mrs. Kitten" adds or remove "Mrs. Kitten" as Subscriber,
usually these messages were generated:

Mrs. Kitten added a subscriber: Mrs. Kitten.
Mrs. Kitten removed a subscriber: Mrs. Kitten.

This was a bit like the Spiderman meme self-pointing Spiderman.

After this change, these beautiful messages are generated instead:

Mrs. Kitten subscribed.
Mrs. Kitten unsubscribed.
BeforeAfter
Subscriber messages - Before.png (365×652 px, 61 KB)
Subscriber messages - After.png (365×652 px, 45 KB)

Closes T15347

Test Plan
  • subscribe on something
  • unsubscribe from something
  • all other cases remain as-is

Diff Detail

Repository
rP Phorge
Branch
subscriber-verbosity
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 360
Build 360: arc lint + arc unit

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
applications/
transactions/
storage/
10 lines0%
Loading...
O1: Blessed Committers

Diff 657

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...