Page MenuHomePhorge

Show title entirely and cut of secondary information gracefully in typeahead results of main search
ClosedPublic

Authored by bekay on Jan 18 2024, 13:24.
Tags
None
Referenced Files
F2304668: D25520.1721119358.diff
Mon, Jul 15, 08:42
F2304611: D25520.1721117508.diff
Mon, Jul 15, 08:11
Unknown Object (File)
Mon, Jul 15, 00:13
Unknown Object (File)
Mon, Jul 15, 00:13
Unknown Object (File)
Sun, Jul 14, 23:41
Unknown Object (File)
Tue, Jul 9, 06:44
Unknown Object (File)
Sun, Jun 30, 17:19
Unknown Object (File)
Sun, Jun 30, 17:19

Details

Summary

This revision increases the usability of the typeahead results of the main search (on the right in the top bar).
The result texts wont't overflow in a reasonable way.

BeforeAfter
image.png (340×366 px, 25 KB)
image.png (383×359 px, 25 KB)

The result title (red box) will now break so the user can read and understand it.
The result type (blue box) will be cut off inside the padding with an ellipsis.

See T15715

Test Plan

Check it out and use the main search in the top bar to create typeahead result with very long titles ;)

Nothing changes for short titles.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bekay requested review of this revision.Jan 18 2024, 13:24

Tested and I like it. Thanks :3

Please wait a couple of days at least before landing, to have more watchers

This revision is now accepted and ready to land.Jan 18 2024, 13:50
valerio.bozzolan edited the test plan for this revision. (Show Details)

please make the title more descriptive of the actual change (what it's doing) - "improve usability" is very vague.
maybe "don't hide title in search" or something like that.

bekay retitled this revision from Increases usability of typeahead results of main search to Show title completly and cut of secondary information grave in typeahead results of main search.Jan 18 2024, 13:58
bekay retitled this revision from Show title completly and cut of secondary information grave in typeahead results of main search to Show title entirely and cut of secondary information gracefully in typeahead results of main search.

Thanks
also - need to run bin/celerity map before landing?

Thanks
also - need to run bin/celerity map before landing?

The new map should be part of the revision. I will make a diff...