Fix use of ExecFuture to pass a scalar string as first argument instead of variable.

When I was at Wikimedia I remember a lot of issues from search robots endlessly indexing dynamic pages.

I managed to compile xhpast on windows using llvm installed via Scoop. I also have Visual Studio C++ 19 installed which may be required (I saw some suspicious output that indicated that some include files were being pulled from that install somehow).

I wonder how many Windows users we have. The xhpast linter does not work, and the unit test failures listed here are pre-existing and occur without these changes.

Almost seems a little too easy

In T15726#15440, @avivey wrote:

I'm not sure from the description if it's only broken on php 8. We also have PayPal integration)

Also my fault for obviously not testing /all/ steps in D25530

D25532 should fix this...

I broke it at D25530; Thanks @philj0st

Sorry, I just assumed arc land will catch it...

This seems to have generated and committed a merge conflict into resources/celerity/map.php
I get the following error when trying to open Phorge:

In case of what?

OK. Then we can add a Task about how to easily configure robot changes without forking, in case.

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

Interesting that gnome is considering Inter. Recursive looks really good too. I like that it has both monospace and proportional all in one.

cf a very similar discussion about default fonts in GNOME at https://gitlab.gnome.org/GNOME/gsettings-desktop-schemas/-/issues/52 regarding aspects to take into consideration

I'm triaging as "wishlist" for now, but realistically - I don't believe will ever reach a point where we'll try to fix this -- see https://secure.phabricator.com/T13154 for discussion.

Marking as "obsolete" because this has graduated to T15722

In D25501#15033, @valerio.bozzolan wrote:

Maybe we can simplify things introducing a commodity "if viewer exists" method like:

This seems reasonable.

Noto seems like a reasonable choice. I personally really like DejaVu Sans a lot.

Or what about Inter? It is open source and looks very readable: https://rsms.me/inter/

So apparently the ferret search engine doesn't really have any sort of dynamic ranking. The ranking is entirely based on how many ngrams match the query...with one singular exception - all user results are boosted above everything else.

I'll try to figure out a architecturally-appropriate way to do this. The users do get grayed out in the typeahead search, just not on the results pages.

can confirm, https://we.phorge.it/D25342?id=1111 does show an error for me in an incognito window.

Probably, something should "Attach" these files by default to that Diff, during the upload phase.

A workaround is to make all files as "Public". I fixed for example the diff D25079: Trigger: Add Sound "Coin" by setting the audio file F1271256 as public.

What a lovely day to run a git rebase master to shine

Partially related, from the mentioned search it's easy to recognize closed Tasks, but Users are not greyed out when Disabled.

I’m not sure about Permalink being a top-level button. Maybe under the View Options menu?

This basically works

In T15726#15436, @Matthew wrote:

My concern with removing the applications outright is that they may be in use. Something like ChatLog was deprecated for years before it was removed. I think it might be smart to leave it deprecated for a couple of months.

Another thing: deletion of transactions. If by some misfortune they're around, they mess up during certain things, like T15125.

In T15726#15431, @valerio.bozzolan wrote:

Should we deprecate these first, before complete removal? (if easy)

I never totally understood what the jobs of Fund and Phortune really were, and they weren't explained very well in the documentation, as if they were very Phacility-only tools that happened to be in Phabricator.

@valerio.bozzolan Thanks. I guess I owe you a drink next weekend :)

Believe me or not but I've spent 15 intense minutes to use my big eyes to check all 571 files to catch whatever line that had not the very same class name A/B.

@valerio.bozzolan: Which problem would that solve? :)

Should we deprecate these first, before complete removal? (if easy)

I have landed my solution.

Old upstream WONTFIXed this in https://secure.phabricator.com/T13154

Test Plan still to be fully executed thus setting "Plan Changes"