Details

Reviewers

Cigaryno
20after4
waldyrious

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15143: Allow to quick-edit a Milestone name from Workboard menu

Commits

rP903d71e67d84: Workboard: Milestone Name easily editable (instead of surfing 3 pages)

Summary

After this change, a new input field "Milestone Name" appears in the "Edit" menu of a Milestone:

Before	After

So you can quickly change the name of your Milestones, from a Workboard.

Before this change, from a Workboard, this was the way to rename a Milestone:

click on the Milestone name (yes, that is a link)
click on Manage
click on Edit Details
rename
Save
Manually visit again the Project's Workboard

After this change, from a Workboard, you just need to:

click on Milestone > Edit
click on Edit Column
rename
Save

Example usage:

This does not change the level of permissions needed: if you have not enough
permissions to see or edit a Milestone, you cannot access this feature indeed.

In short, this is just a frontend change, keeping current policies as-is.

Closes T15143

Test Plan

Create a Project or use an existing editable one.

Create a Milestone called "Test Milestone". You can create Milestones visiting the Project's menu Subprojects → Create next milestone

Visit the Project's Workboard. Find the column "Test Milestone". Click the Edit button on a Milestone, and:

try to save another name: it must work
try to save an empty name: nice error message shown
try to save both the score points and the name: it must work
try to save "FOO" as Points: you still see the error message

Also:

do the same for the Backlog column: it still works (name still allowed to be empty)
do the same for a "normal" Column (not the Backlog): it still work (name still not allowed to be empty)

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Feb 11 2023, 18:19

Owners added a reviewer: O1: Blessed Committers.Feb 11 2023, 18:19

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptFeb 11 2023, 18:19

valerio.bozzolan requested review of this revision.Feb 11 2023, 18:19

Harbormaster completed remote builds in B113: Diff 317.Feb 11 2023, 18:19

avoid same variable storing different things

Harbormaster completed remote builds in B114: Diff 318.Feb 11 2023, 18:29

Some explanations:

In short I tried to just add another text input, just to be more nice and don't use the same input field for two different purposes
I added the great_success flag just to be sure that, if the earlier Column-related stuff fails, it does not try to do other things with the Milestone

I'm not 100% sure that the $column->getProxy(), when set, always return a Milestone. If you can confirm this I'm more inclined to sleep tonight, without any possible "oh my god maybe.." resentment of the kind.

Here a stupid spoiler of this. Milestone before:

Phorge editing Milestone.png (206×830 px, 15 KB)

Milestone after:

Milestone editable from Workboard, test case.png (298×828 px, 22 KB)

But don't trust me. I'm a spy sent here to destroy Phorge. Try my test plan locally.

(Don't tell anyone that I tried to corrupt the blessed committers with a doubloon to try this lovely patch)

If you think this patch is too complicated to review, I can do a middleware patch to just propose a small refactor without introducing any feature, and than turn back on this one.

try to make a review even more simple

Harbormaster completed remote builds in B178: Diff 390.Mar 24 2023, 21:44

valerio.bozzolan added a child revision: D25093: Column Edit: minor refactor for future changes.Mar 26 2023, 17:02

valerio.bozzolan mentioned this in 2023-03-27.Mar 27 2023, 14:07

Cigaryno accepted this revision.Apr 2 2023, 10:12

valerio.bozzolan mentioned this in Z1: Phorge.Apr 2 2023, 19:51

valerio.bozzolan mentioned this in D25093: Column Edit: minor refactor for future changes.Apr 4 2023, 11:53

revert to the previous state (no split changes)

Harbormaster completed remote builds in B223: Diff 451.Apr 5 2023, 12:21

Cigaryno accepted this revision.Apr 5 2023, 16:00

valerio.bozzolan edited the summary of this revision. (Show Details)Apr 14 2023, 10:46

valerio.bozzolan edited the summary of this revision. (Show Details)Apr 14 2023, 10:49

If you want to test this somewhere,

Feel free to test in my personal Phorge where this patch is already online:

https://gitpull.it/project/board/252/

So, whatever is a Column or a Milestone, you can just try Edit Column and change the name and Save

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16

avoid an extra variable

Harbormaster completed remote builds in B437: Diff 779.May 22 2023, 07:55

valerio.bozzolan retitled this revision from Allow to quick-edit a Milestone name from Workboard Edit menu to Workboard UX: Milestone Name can be changed in less than 6 clicks.May 22 2023, 07:59

valerio.bozzolan edited the test plan for this revision. (Show Details)

valerio.bozzolan retitled this revision from Workboard UX: Milestone Name can be changed in less than 6 clicks to Workboard: Milestone Name can be changed in less than 6 clicks.May 22 2023, 08:06

valerio.bozzolan mentioned this in 2023-05-22.May 22 2023, 13:47

put some wax on the floor to sparkle

Harbormaster completed remote builds in B549: Diff 948.Jun 12 2023, 09:11

Hi @20after4 :) Can I ask you if this could be useful in Wikimedia? I think yep

valerio.bozzolan edited the summary of this revision. (Show Details)Jun 24 2023, 08:33

valerio.bozzolan edited the test plan for this revision. (Show Details)

move a variable in a nicer position

Harbormaster completed remote builds in B590: Diff 1007.Jun 24 2023, 08:34

valerio.bozzolan edited the summary of this revision. (Show Details)Jun 24 2023, 09:11

valerio.bozzolan edited the summary of this revision. (Show Details)Jun 26 2023, 14:45

Cigaryno accepted this revision.Jun 26 2023, 16:20

I know, the attached video is beautiful

Suggested meme: whatcouldgowrong

valerio.bozzolan retitled this revision from Workboard: Milestone Name can be changed in less than 6 clicks to Workboard: Milestone Name changable in 4 clicks instead of 6.Jul 20 2023, 13:41

Hi @20after4 what do you think about the attached video? Do you like this feature? :)

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 19 2023, 04:47

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 28 2023, 16:39

I'm not a virus but a dolphin.png (466×640 px, 510 KB)

comments more sexier for reviewers

Harbormaster completed remote builds in B836: Diff 1377.Sep 6 2023, 11:24

valerio.bozzolan retitled this revision from Workboard: Milestone Name changable in 4 clicks instead of 6 to Workboard: Milestone Name easily editable (instead of surfing 3 pages).Sep 13 2023, 08:40

I like it but I haven't tested locally.

This revision is now accepted and ready to land.Sep 15 2023, 10:39

In D25066#8893, @valerio.bozzolan wrote:

Hi @20after4 :) Can I ask you if this could be useful in Wikimedia? I think yep

I'm no longer employed by Wikimmedia, though I still intend to contribute there when I have a chance to volunteer. My full time employment mostly prevents me from having time to do so, currently.

cc @aklapper and @brennen

20after4 added subscribers: aklapper, brennen.Sep 15 2023, 10:43

valerio.bozzolan edited the test plan for this revision. (Show Details)Sep 19 2023, 09:50

Tested locally, works as advertised.

(Though as a newbie to milestones, I have to say the entire flow from creation to editing is HIGHLY unintuitive; this patch is does a great job at improving part of the experience, but there's a long way to go 😅)

Thanks!

So:

we have an approval from a core contributor
we tested by at lest 2 persons in real-world
we tested also in my production for 7 months, using this intensively, without any nuclear implosion
nobody cares, really, nobody uses Milestones, nobody knows what a Milestone is, people also don't like Workboards, Workboards are evil persons for much core contributors, so we will never receive more feedback here automagically, if we have not received these in 7 months
since this change is online since the 11st of February (!) :D and since I waited 2 weeks to be kind after approval, ...

I'm going to land this now 😎

THANKS FOLKS for making this happen! This changes my life! I love Phorge! Phorge is life! Phorge is gorgeous! Long life to Phorge! asd

Any follow-up suggestion is welcome indeed.

Closed by commit rP903d71e67d84: Workboard: Milestone Name easily editable (instead of surfing 3 pages). · Explain WhySep 25 2023, 06:18

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP903d71e67d84: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

valerio.bozzolan mentioned this in Next Up.Sep 25 2023, 06:20

avivey mentioned this in 2023 week 49 RC.Fri, Dec 8, 17:36

Workboard: Milestone Name easily editable (instead of surfing 3 pages)
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1395

src/applications/project/controller/PhabricatorProjectColumnEditController.php

Workboard: Milestone Name easily editable (instead of surfing 3 pages)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1395

src/applications/project/controller/PhabricatorProjectColumnEditController.php

Workboard: Milestone Name easily editable (instead of surfing 3 pages)
ClosedPublic
Actions

Revision Contents
Changeset List