Page MenuHomePhorge

Workboard: Milestone Name easily editable (instead of surfing 3 pages)
ClosedPublic

Authored by valerio.bozzolan on Feb 11 2023, 18:19.
Tags
None
Referenced Files
F2199068: D25066.1716445642.diff
Wed, May 22, 06:27
F2198804: D25066.1716401018.diff
Tue, May 21, 18:03
Unknown Object (File)
Tue, May 21, 02:18
Unknown Object (File)
Sat, May 18, 13:22
Unknown Object (File)
Fri, May 17, 06:10
Unknown Object (File)
Fri, May 17, 05:36
Unknown Object (File)
Fri, May 17, 05:25
Unknown Object (File)
Fri, May 17, 02:17
Tokens
"Love" token, awarded by 20after4."Doubloon" token, awarded by valerio.bozzolan.

Details

Summary

After this change, a new input field "Milestone Name" appears in the "Edit" menu of a Milestone:

BeforeAfter
Milestone menu before.png (199×822 px, 15 KB)
Milestone quick editable name.png (237×822 px, 20 KB)

So you can quickly change the name of your Milestones, from a Workboard.

Before this change, from a Workboard, this was the way to rename a Milestone:

  1. click on the Milestone name (yes, that is a link)
  2. click on Manage
  3. click on Edit Details
  4. rename
  5. Save
  6. Manually visit again the Project's Workboard

After this change, from a Workboard, you just need to:

  1. click on Milestone > Edit
  2. click on Edit Column
  3. rename
  4. Save

Example usage:

This does not change the level of permissions needed: if you have not enough
permissions to see or edit a Milestone, you cannot access this feature indeed.

In short, this is just a frontend change, keeping current policies as-is.

Closes T15143

Test Plan

Create a Project or use an existing editable one.

Create a Milestone called "Test Milestone". You can create Milestones visiting the Project's menu SubprojectsCreate next milestone

Visit the Project's Workboard. Find the column "Test Milestone". Click the Edit button on a Milestone, and:

  • try to save another name: it must work
  • try to save an empty name: nice error message shown
  • try to save both the score points and the name: it must work
  • try to save "FOO" as Points: you still see the error message

Also:

  • do the same for the Backlog column: it still works (name still allowed to be empty)
  • do the same for a "normal" Column (not the Backlog): it still work (name still not allowed to be empty)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avoid same variable storing different things

Some explanations:

  • In short I tried to just add another text input, just to be more nice and don't use the same input field for two different purposes
  • I added the great_success flag just to be sure that, if the earlier Column-related stuff fails, it does not try to do other things with the Milestone

I'm not 100% sure that the $column->getProxy(), when set, always return a Milestone. If you can confirm this I'm more inclined to sleep tonight, without any possible "oh my god maybe.." resentment of the kind.

Here a stupid spoiler of this. Milestone before:

Phorge editing Milestone.png (206×830 px, 15 KB)

Milestone after:

Milestone editable from Workboard, test case.png (298×828 px, 22 KB)

But don't trust me. I'm a spy sent here to destroy Phorge. Try my test plan locally.

(Don't tell anyone that I tried to corrupt the blessed committers with a doubloon to try this lovely patch)

If you think this patch is too complicated to review, I can do a middleware patch to just propose a small refactor without introducing any feature, and than turn back on this one.

try to make a review even more simple

revert to the previous state (no split changes)

If you want to test this somewhere,

Feel free to test in my personal Phorge where this patch is already online:

https://gitpull.it/project/board/252/

So, whatever is a Column or a Milestone, you can just try Edit Column and change the name and Save

valerio.bozzolan retitled this revision from Allow to quick-edit a Milestone name from Workboard Edit menu to Workboard UX: Milestone Name can be changed in less than 6 clicks.May 22 2023, 07:59
valerio.bozzolan edited the test plan for this revision. (Show Details)
valerio.bozzolan retitled this revision from Workboard UX: Milestone Name can be changed in less than 6 clicks to Workboard: Milestone Name can be changed in less than 6 clicks.May 22 2023, 08:06

put some wax on the floor to sparkle

Hi @20after4 :) Can I ask you if this could be useful in Wikimedia? I think yep

valerio.bozzolan edited the test plan for this revision. (Show Details)

move a variable in a nicer position

I know, the attached video is beautiful

valerio.bozzolan retitled this revision from Workboard: Milestone Name can be changed in less than 6 clicks to Workboard: Milestone Name changable in 4 clicks instead of 6.Jul 20 2023, 13:41

Hi @20after4 what do you think about the attached video? Do you like this feature? :)

comments more sexier for reviewers

valerio.bozzolan retitled this revision from Workboard: Milestone Name changable in 4 clicks instead of 6 to Workboard: Milestone Name easily editable (instead of surfing 3 pages).Sep 13 2023, 08:40

I like it but I haven't tested locally.

This revision is now accepted and ready to land.Sep 15 2023, 10:39

Hi @20after4 :) Can I ask you if this could be useful in Wikimedia? I think yep

I'm no longer employed by Wikimmedia, though I still intend to contribute there when I have a chance to volunteer. My full time employment mostly prevents me from having time to do so, currently.

cc @aklapper and @brennen

waldyrious subscribed.

Tested locally, works as advertised.

(Though as a newbie to milestones, I have to say the entire flow from creation to editing is HIGHLY unintuitive; this patch is does a great job at improving part of the experience, but there's a long way to go 😅)

Thanks!

So:

  • we have an approval from a core contributor
  • we tested by at lest 2 persons in real-world
  • we tested also in my production for 7 months, using this intensively, without any nuclear implosion
  • nobody cares, really, nobody uses Milestones, nobody knows what a Milestone is, people also don't like Workboards, Workboards are evil persons for much core contributors, so we will never receive more feedback here automagically, if we have not received these in 7 months
  • since this change is online since the 11st of February (!) :D and since I waited 2 weeks to be kind after approval, ...

I'm going to land this now 😎

THANKS FOLKS for making this happen! This changes my life! I love Phorge! Phorge is life! Phorge is gorgeous! Long life to Phorge! asd

Any follow-up suggestion is welcome indeed.