Closes T15143
Details
Details
- Reviewers
- None
- Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15143: Allow to quick-edit a Milestone name from Workboard menu
Visit a Workboard, click the Edit button on a
Milestone, and:
- try to save another name: it must work
- try to save an empty name: nice error message shown
- try to save both the score points and the name: it must work
Visit a Workboard, click the Edit button on a
Column, and:
- try to do everything as normal also there, it must work
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- arcpatch-D25066_workboard_refactor
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 178 Build 178: arc lint + arc unit
Event Timeline
Comment Actions
Some explanations:
- In short I tried to just add another text input, just to be more nice and don't use the same input field for two different purposes
- I added the great_success flag just to be sure that, if the earlier Column-related stuff fails, it does not try to do other things with the Milestone
I'm not 100% sure that the $column->getProxy(), when set, always return a Milestone. If you can confirm this I'm more inclined to sleep tonight, without any possible "oh my god maybe.." resentment of the kind.
Comment Actions
Here a stupid spoiler of this. Milestone before:
Milestone after:
But don't trust me. I'm a spy sent here to destroy Phorge. Try my test plan locally.
Comment Actions
(Don't tell anyone that I tried to corrupt the blessed committers with a doubloon to try this lovely patch)
Comment Actions
If you think this patch is too complicated to review, I can do a middleware patch to just propose a small refactor without introducing any feature, and than turn back on this one.