Page MenuHomePhorge

Revert "Added cross-platform default fonts"
ClosedPublic

Authored by avivey on Jan 27 2024, 10:28.
Tags
None
Referenced Files
F2199603: D25530.1716500950.diff
Wed, May 22, 21:49
Unknown Object (File)
Tue, May 21, 16:47
Unknown Object (File)
Mon, May 20, 18:22
Unknown Object (File)
Sat, May 18, 10:42
Unknown Object (File)
Sun, May 12, 21:58
Unknown Object (File)
Fri, May 10, 00:16
Unknown Object (File)
Wed, May 8, 04:57
Unknown Object (File)
Wed, May 8, 04:32

Details

Summary

Revert rPf8ffa393c4427f8b9026075e6dc490990a12df12 (D25021). This Commit caused more grief then fun.

Ref T15630

Test Plan

Site should still be readable on most platforms

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey requested review of this revision.Jan 27 2024, 10:28
This revision is now accepted and ready to land.Jan 28 2024, 15:56

This seems to have generated and committed a merge conflict into resources/celerity/map.php
I get the following error when trying to open Phorge:

NOTICE: PHP message: [2024-02-05 07:41:30] EXCEPTION: (ParseError) syntax error, unexpected '<<' (T_SL), expecting ')' at [<phorge>/resources/celerity/map.php:12]
NOTICE: PHP message: arcanist(head=master, ref.master=6c7caf3572f4), phorge(head=master, ref.master=bb23e86dafc6)
NOTICE: PHP message:   #0 phlog(ParseError) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
NOTICE: PHP message:   #1 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, ParseError) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
NOTICE: PHP message:   #2 AphrontApplicationConfiguration::handleThrowable(ParseError) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:337]
NOTICE: PHP message:   #3 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
NOTICE: PHP message:   #4 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]
10.4.222.10 -  05/Feb/2024:15:41:30 +0000 "GET /index.php" 500
NOTICE: PHP message: [2024-02-05 07:41:30] EXCEPTION: (ParseError) syntax error, unexpected '<<' (T_SL), expecting ')' at [<phorge>/resources/celerity/map.php:12]
NOTICE: PHP message: arcanist(head=master, ref.master=6c7caf3572f4), phorge(head=master, ref.master=bb23e86dafc6)
NOTICE: PHP message:   #0 phlog(ParseError) called at [<phorge>/src/aphront/response/AphrontUnhandledExceptionResponse.php:32]
NOTICE: PHP message:   #1 AphrontUnhandledExceptionResponse::setException(ParseError) called at [<phorge>/webroot/index.php:46]
10.4.222.10 -  05/Feb/2024:15:41:30 +0000 "GET /index.php" 302
10.4.222.10 -  05/Feb/2024:15:41:30 +0000 "GET /index.php" 200
NOTICE: PHP message: [2024-02-05 07:41:56] EXCEPTION: (ParseError) syntax error, unexpected '<<' (T_SL), expecting ')' at [<phorge>/resources/celerity/map.php:12]
NOTICE: PHP message: arcanist(head=master, ref.master=6c7caf3572f4), phorge(head=master, ref.master=bb23e86dafc6)
NOTICE: PHP message:   #0 phlog(ParseError) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
NOTICE: PHP message:   #1 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, ParseError) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
NOTICE: PHP message:   #2 AphrontApplicationConfiguration::handleThrowable(ParseError) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:337]
NOTICE: PHP message:   #3 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
NOTICE: PHP message:   #4 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]
NOTICE: PHP message: [2024-02-05 07:41:56] EXCEPTION: (ParseError) syntax error, unexpected '<<' (T_SL), expecting ')' at [<phorge>/resources/celerity/map.php:12]
NOTICE: PHP message: arcanist(head=master, ref.master=6c7caf3572f4), phorge(head=master, ref.master=bb23e86dafc6)
NOTICE: PHP message:   #0 phlog(ParseError) called at [<phorge>/src/aphront/response/AphrontUnhandledExceptionResponse.php:32]
NOTICE: PHP message:   #1 AphrontUnhandledExceptionResponse::setException(ParseError) called at [<phorge>/webroot/index.php:46]
10.4.222.10 -  05/Feb/2024:15:41:56 +0000 "GET /index.php" 500
10.4.222.10 -  05/Feb/2024:15:41:56 +0000 "GET /index.php" 302
10.4.222.10 -  05/Feb/2024:15:42:10 +0000 "GET /index.php" 302
NOTICE: PHP message: [2024-02-05 07:42:10] EXCEPTION: (ParseError) syntax error, unexpected '<<' (T_SL), expecting ')' at [<phorge>/resources/celerity/map.php:12]
NOTICE: PHP message: arcanist(head=master, ref.master=6c7caf3572f4), phorge(head=master, ref.master=bb23e86dafc6)
NOTICE: PHP message:   #0 phlog(ParseError) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
NOTICE: PHP message:   #1 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, ParseError) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
NOTICE: PHP message:   #2 AphrontApplicationConfiguration::handleThrowable(ParseError) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:337]
NOTICE: PHP message:   #3 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
NOTICE: PHP message:   #4 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]
NOTICE: PHP message: [2024-02-05 07:42:10] EXCEPTION: (ParseError) syntax error, unexpected '<<' (T_SL), expecting ')' at [<phorge>/resources/celerity/map.php:12]
NOTICE: PHP message: arcanist(head=master, ref.master=6c7caf3572f4), phorge(head=master, ref.master=bb23e86dafc6)
NOTICE: PHP message:   #0 phlog(ParseError) called at [<phorge>/src/aphront/response/AphrontUnhandledExceptionResponse.php:32]
NOTICE: PHP message:   #1 AphrontUnhandledExceptionResponse::setException(ParseError) called at [<phorge>/webroot/index.php:46]

Sorry, I just assumed arc land will catch it...